summaryrefslogtreecommitdiff
path: root/xmloff
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2023-04-10 10:38:32 +0100
committerAndras Timar <andras.timar@collabora.com>2023-05-13 20:01:54 +0200
commit2e315f6ad5d72ac591a6c9c34f3ff2395ab4da4e (patch)
treea213dabeabe9bde7b29c86fdc8ff0e321fa26a06 /xmloff
parent4d9787c0cb3215ec898efe931ce26862b9c65043 (diff)
crashreporting: getUsedFontList() crash
e.g. https://crashreport.libreoffice.org/stats/crash_details/3a3c07aa-0f96-4efa-b55b-c3fe4e4b6ed8 ... Crash Reason EXCEPTION_ACCESS_VIOLATION_READ Crash Address 0x0 ... XMLFontAutoStylePool::getUsedFontList() xmloff\source\style\XMLFontAutoStylePool.cxx:334 XMLFontAutoStylePool::exportXML() xmloff\source\style\XMLFontAutoStylePool.cxx:408 Change-Id: I5d057b8e639260f6d00e731c3af7bab7203a8814 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150152 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Diffstat (limited to 'xmloff')
-rw-r--r--xmloff/source/style/XMLFontAutoStylePool.cxx4
1 files changed, 2 insertions, 2 deletions
diff --git a/xmloff/source/style/XMLFontAutoStylePool.cxx b/xmloff/source/style/XMLFontAutoStylePool.cxx
index 0fbb57b78ec8..e86709b6cc3d 100644
--- a/xmloff/source/style/XMLFontAutoStylePool.cxx
+++ b/xmloff/source/style/XMLFontAutoStylePool.cxx
@@ -328,9 +328,9 @@ std::unordered_set<OUString> XMLFontAutoStylePool::getUsedFontList()
if (xStyle->isInUse())
{
uno::Reference<beans::XPropertySet> xPropertySet(xStyle, UNO_QUERY);
- if (xPropertySet.is())
+ uno::Reference<beans::XPropertySetInfo> xInfo(xPropertySet ? xPropertySet->getPropertySetInfo() : nullptr);
+ if (xInfo)
{
- uno::Reference<beans::XPropertySetInfo> xInfo(xPropertySet->getPropertySetInfo());
if (m_bEmbedLatinScript && xInfo->hasPropertyByName("CharFontName"))
{
OUString sCharFontName;