diff options
| author | Michael Stahl <mstahl@redhat.com> | 2014-04-16 12:11:39 +0200 |
|---|---|---|
| committer | Michael Stahl <mstahl@redhat.com> | 2014-04-16 12:47:43 +0200 |
| commit | 426077fbea57facf9907cff2431d8f669713d6da (patch) | |
| tree | 68f5ccef88706419f3dad75b8af16a92cd797b86 /xmloff | |
| parent | 5d53cabb52648507086a39e06803624949e4a301 (diff) | |
fdo#77027: add some comments to prevent such oversights
Change-Id: I381c9738bba3e422e01324fa0c781c857db3d360
Diffstat (limited to 'xmloff')
| -rw-r--r-- | xmloff/source/draw/XMLGraphicsDefaultStyle.cxx | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/xmloff/source/draw/XMLGraphicsDefaultStyle.cxx b/xmloff/source/draw/XMLGraphicsDefaultStyle.cxx index afbe5797bf7f..9753a3fe0b8a 100644 --- a/xmloff/source/draw/XMLGraphicsDefaultStyle.cxx +++ b/xmloff/source/draw/XMLGraphicsDefaultStyle.cxx @@ -125,6 +125,11 @@ void XMLGraphicsDefaultStyle::SetDefaults() xDefaults->setPropertyValue("IsFollowingTextFlow", uno::makeAny(true)); } + // NOTE: the only reason why it's legal to check "==" (not "<") against + // arbitrary versions here is that the default value of these attributes + // is not defined by ODF, therefore it is implementation-defined + // (and we of course must not override any attributes that are actually + // in the document, so check for that) bool const bIsAOO4( GetImport().getGeneratorVersion() >= SvXMLImport::AOO_40x && GetImport().getGeneratorVersion() <= SvXMLImport::AOO_4x); |