summaryrefslogtreecommitdiff
path: root/xmloff
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2017-12-27 12:39:11 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2017-12-27 15:39:29 +0100
commita967c8f6847cf9cbd6e0f4b9f58f2023e1f92ae5 (patch)
treea00a7d73a3aa5d6d972c8a66e9357637edf62f9b /xmloff
parent33bd6c3e3512bf96376534e116d6f9f60d157be9 (diff)
loplugin:passstuffbyref improved return in xmloff,sfx2
Change-Id: I7161dfca77f944027bd20614616e22d6acfa27cd Reviewed-on: https://gerrit.libreoffice.org/47081 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'xmloff')
-rw-r--r--xmloff/inc/SchXMLExport.hxx2
-rw-r--r--xmloff/source/chart/SchXMLExport.cxx2
-rw-r--r--xmloff/source/core/xmlexp.cxx8
-rw-r--r--xmloff/source/core/xmlimp.cxx6
-rw-r--r--xmloff/source/text/txtimp.cxx2
-rw-r--r--xmloff/source/text/txtparaimphint.hxx2
6 files changed, 11 insertions, 11 deletions
diff --git a/xmloff/inc/SchXMLExport.hxx b/xmloff/inc/SchXMLExport.hxx
index a2a36301a2f7..cc0835d400f7 100644
--- a/xmloff/inc/SchXMLExport.hxx
+++ b/xmloff/inc/SchXMLExport.hxx
@@ -54,7 +54,7 @@ public:
SvXMLExportFlags nExportFlags );
virtual ~SchXMLExport() override;
- rtl::Reference< XMLPropertySetMapper > GetPropertySetMapper() const;
+ rtl::Reference< XMLPropertySetMapper > const & GetPropertySetMapper() const;
};
#endif // INCLUDED_XMLOFF_INC_SCHXMLEXPORT_HXX
diff --git a/xmloff/source/chart/SchXMLExport.cxx b/xmloff/source/chart/SchXMLExport.cxx
index b28ec1b60ff0..3b51533cc14b 100644
--- a/xmloff/source/chart/SchXMLExport.cxx
+++ b/xmloff/source/chart/SchXMLExport.cxx
@@ -3613,7 +3613,7 @@ void SchXMLExport::ExportContent_()
}
}
-rtl::Reference< XMLPropertySetMapper > SchXMLExport::GetPropertySetMapper() const
+rtl::Reference< XMLPropertySetMapper > const & SchXMLExport::GetPropertySetMapper() const
{
return maExportHelper->m_pImpl->GetPropertySetMapper();
}
diff --git a/xmloff/source/core/xmlexp.cxx b/xmloff/source/core/xmlexp.cxx
index 85b7152ee566..2a0ecb11f25a 100644
--- a/xmloff/source/core/xmlexp.cxx
+++ b/xmloff/source/core/xmlexp.cxx
@@ -1455,12 +1455,12 @@ void SvXMLExport::ResetNamespaceMap()
delete mpNamespaceMap; mpNamespaceMap = new SvXMLNamespaceMap;
}
-OUString SvXMLExport::GetSourceShellID() const
+OUString const & SvXMLExport::GetSourceShellID() const
{
return mpImpl->maSrcShellID;
}
-OUString SvXMLExport::GetDestinationShellID() const
+OUString const & SvXMLExport::GetDestinationShellID() const
{
return mpImpl->maDestShellID;
}
@@ -2337,7 +2337,7 @@ bool SvXMLExport::writeOutlineStyleAsNormalListStyle() const
return mpImpl->mbOutlineStyleAsNormalListStyle;
}
-uno::Reference< embed::XStorage > SvXMLExport::GetTargetStorage()
+uno::Reference< embed::XStorage > const & SvXMLExport::GetTargetStorage()
{
return mpImpl->mxTargetStorage;
}
@@ -2466,7 +2466,7 @@ bool SvXMLExport::SetNullDateOnUnitConverter()
return mpImpl->mbNullDateInitialized;
}
-OUString SvXMLExport::GetImageFilterName() const
+OUString const & SvXMLExport::GetImageFilterName() const
{
return msImgFilterName;
}
diff --git a/xmloff/source/core/xmlimp.cxx b/xmloff/source/core/xmlimp.cxx
index a95ba7061983..0718e7af65e6 100644
--- a/xmloff/source/core/xmlimp.cxx
+++ b/xmloff/source/core/xmlimp.cxx
@@ -1421,7 +1421,7 @@ OUString SvXMLImport::ResolveEmbeddedObjectURL(
return sRet;
}
-Reference< embed::XStorage > SvXMLImport::GetSourceStorage()
+Reference< embed::XStorage > const & SvXMLImport::GetSourceStorage()
{
return mpImpl->mxSourceStorage;
}
@@ -1895,7 +1895,7 @@ void SvXMLImport::DisposingModel()
return mpImpl->maInterfaceToIdentifierMapper;
}
-uno::Reference< uno::XComponentContext >
+uno::Reference< uno::XComponentContext > const &
SvXMLImport::GetComponentContext() const
{
return mpImpl->mxComponentContext;
@@ -1966,7 +1966,7 @@ bool SvXMLImport::isGeneratorVersionOlderThan(
}
-OUString SvXMLImport::GetODFVersion() const
+OUString const & SvXMLImport::GetODFVersion() const
{
return mpImpl->aODFVersion;
}
diff --git a/xmloff/source/text/txtimp.cxx b/xmloff/source/text/txtimp.cxx
index 7ff3bec70784..53e8836c846b 100644
--- a/xmloff/source/text/txtimp.cxx
+++ b/xmloff/source/text/txtimp.cxx
@@ -2864,7 +2864,7 @@ void XMLTextImportHelper::SetChangesProtectionKey(const Sequence<sal_Int8> &)
}
-OUString XMLTextImportHelper::GetOpenRedlineId()
+OUString const & XMLTextImportHelper::GetOpenRedlineId()
{
return m_xImpl->m_sOpenRedlineIdentifier;
}
diff --git a/xmloff/source/text/txtparaimphint.hxx b/xmloff/source/text/txtparaimphint.hxx
index 2f5f231b6c2c..2214fea36b3f 100644
--- a/xmloff/source/text/txtparaimphint.hxx
+++ b/xmloff/source/text/txtparaimphint.hxx
@@ -230,7 +230,7 @@ public:
}
// Frame "to character": anchor moves from first to last char after saving (#i33242#)
- css::uno::Reference < css::drawing::XShape > GetShape() const
+ css::uno::Reference < css::drawing::XShape > const & GetShape() const
{
return static_cast<SvXMLShapeContext*>(xContext.get())->getShape();
}