summaryrefslogtreecommitdiff
path: root/xmloff
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2019-10-08 10:30:36 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2019-10-09 07:44:49 +0200
commit682fdbf1312cf6ca70fe209bf4d7051dad8f5008 (patch)
treed001d22a20752086c6aa0f56d6c83791406fae9b /xmloff
parentc71896debc7ef5f6d6e918f59fa44423eb5df480 (diff)
loplugin:redundantpointerops check other pointer types
as well as unique_ptr Change-Id: I54842bca161ee460fb96c46ca31b6f9c0a7dbbdf Reviewed-on: https://gerrit.libreoffice.org/80455 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'xmloff')
-rw-r--r--xmloff/source/core/xmlexp.cxx4
-rw-r--r--xmloff/source/core/xmlmultiimagehelper.cxx4
-rw-r--r--xmloff/source/text/XMLTextFrameContext.cxx4
3 files changed, 6 insertions, 6 deletions
diff --git a/xmloff/source/core/xmlexp.cxx b/xmloff/source/core/xmlexp.cxx
index 93ef19a46957..5d7d1910d98a 100644
--- a/xmloff/source/core/xmlexp.cxx
+++ b/xmloff/source/core/xmlexp.cxx
@@ -810,7 +810,7 @@ sal_Bool SAL_CALL SvXMLExport::filter( const uno::Sequence< beans::PropertyValue
OUString sMessage( ex.getValueTypeName() + ": \"" + e.Message + "\"");
if (e.Context.is())
{
- const char* pContext = typeid(*e.Context.get()).name();
+ const char* pContext = typeid(*e.Context).name();
sMessage += " (context: " + OUString::createFromAscii(pContext) + " )";
}
SetError( XMLERROR_FLAG_ERROR | XMLERROR_FLAG_SEVERE | XMLERROR_API,
@@ -1690,7 +1690,7 @@ void SvXMLExport::ExportStyles_( bool )
XMLTextParagraphExport* SvXMLExport::CreateTextParagraphExport()
{
- return new XMLTextParagraphExport( *this, *(GetAutoStylePool().get()) );
+ return new XMLTextParagraphExport( *this, *GetAutoStylePool() );
}
XMLShapeExport* SvXMLExport::CreateShapeExport()
diff --git a/xmloff/source/core/xmlmultiimagehelper.cxx b/xmloff/source/core/xmlmultiimagehelper.cxx
index 36b65fdd7449..af03e7bb1361 100644
--- a/xmloff/source/core/xmlmultiimagehelper.cxx
+++ b/xmloff/source/core/xmlmultiimagehelper.cxx
@@ -113,7 +113,7 @@ SvXMLImportContextRef MultiImageImportHelper::solveMultipleImages()
for(std::vector<SvXMLImportContextRef>::size_type a = 0; a < maImplContextVector.size(); a++)
{
- const SvXMLImportContext& rContext = *maImplContextVector[a].get();
+ const SvXMLImportContext& rContext = *maImplContextVector[a];
OUString sMimeType;
@@ -152,7 +152,7 @@ SvXMLImportContextRef MultiImageImportHelper::solveMultipleImages()
// remove the rest from parent
for(std::vector<SvXMLImportContextRef>::size_type a = 0; a < maImplContextVector.size(); a++)
{
- SvXMLImportContext& rCandidate = *maImplContextVector[a].get();
+ SvXMLImportContext& rCandidate = *maImplContextVector[a];
removeGraphicFromImportContext(rCandidate);
}
diff --git a/xmloff/source/text/XMLTextFrameContext.cxx b/xmloff/source/text/XMLTextFrameContext.cxx
index 7fb33155622b..0f33c760a6ac 100644
--- a/xmloff/source/text/XMLTextFrameContext.cxx
+++ b/xmloff/source/text/XMLTextFrameContext.cxx
@@ -1522,7 +1522,7 @@ SvXMLImportContextRef XMLTextFrameContext::CreateChildContext(
if(getSupportsMultipleContents() && XML_TEXT_FRAME_GRAPHIC == nFrameType)
{
- addContent(*m_xImplContext.get());
+ addContent(*m_xImplContext);
}
}
}
@@ -1535,7 +1535,7 @@ SvXMLImportContextRef XMLTextFrameContext::CreateChildContext(
m_eDefaultAnchorType, XML_TEXT_FRAME_GRAPHIC, m_xAttrList, true);
m_xImplContext = xContext;
- addContent(*m_xImplContext.get());
+ addContent(*m_xImplContext);
}
else if( m_bSupportsReplacement && !m_xReplImplContext.is() &&
XML_NAMESPACE_DRAW == p_nPrefix &&