summaryrefslogtreecommitdiff
path: root/xmloff
diff options
context:
space:
mode:
authorMike Kaganski <mike.kaganski@collabora.com>2020-05-09 11:11:13 +0300
committerMike Kaganski <mike.kaganski@collabora.com>2020-05-11 10:22:20 +0200
commit5814f08c01ab7973cc83e6721ef434f5acc63a1a (patch)
tree922e6c157aa3b876f03bfb6829d1f0d1c8575dd1 /xmloff
parentaa5dc0b48cd4db6883c9b52c68b16170c9c81d1f (diff)
Document relation between three lists that must be in sync
Change-Id: I9fc44b6878450d147d21f77ff4daa6939edfa0c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93837 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'xmloff')
-rw-r--r--xmloff/qa/unit/tokenmap-test.cxx2
-rw-r--r--xmloff/source/core/xmltoken.cxx3
2 files changed, 5 insertions, 0 deletions
diff --git a/xmloff/qa/unit/tokenmap-test.cxx b/xmloff/qa/unit/tokenmap-test.cxx
index fb6916444454..476416fc3933 100644
--- a/xmloff/qa/unit/tokenmap-test.cxx
+++ b/xmloff/qa/unit/tokenmap-test.cxx
@@ -62,6 +62,8 @@ void TokenmapTest::test_roundTrip()
void TokenmapTest::test_listEquality()
{
//make sure the two token lists stay in sync
+ // This depends on same order in three places: XMLTokenEnum in include/xmloff/xmltoken.hxx,
+ // aTokenList in xmloff/source/core/xmltoken.cxx, and xmloff/source/token/tokens.txt
for ( sal_Int32 nToken = 0; nToken < XML_TOKEN_COUNT; ++nToken )
{
Sequence< sal_Int8 > rUtf8Name = pTokenMap->getUtf8TokenName(nToken);
diff --git a/xmloff/source/core/xmltoken.cxx b/xmloff/source/core/xmltoken.cxx
index 4f7428dc431f..9c774c5ee46d 100644
--- a/xmloff/source/core/xmltoken.cxx
+++ b/xmloff/source/core/xmltoken.cxx
@@ -49,6 +49,9 @@ namespace xmloff::token {
#define TOKEN( s, e ) { sizeof(s)-1, s, std::nullopt }
#endif
+ // IMPORTANT! aTokenList order MUST be in synch with XMLTokenEnum in include/xmloff/xmltoken.hxx
+ // and with xmloff/source/token/tokens.txt.
+
struct XMLTokenEntry aTokenList[] =
{
#if OSL_DEBUG_LEVEL > 0