diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2014-01-23 18:43:53 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2014-01-23 18:43:53 +0100 |
| commit | e3133ae2371b6e2d4b47daa6a3487ea4f2753315 (patch) | |
| tree | f9a000ee6542fb470733bfed28199092a36c26c5 /xmloff | |
| parent | 14f4e2fa22a0a2576808bab08edaf2e12f761cd8 (diff) | |
Let C++ inline functions return bool instead of sal_Bool
...to improve diagnosing misuses of boolean expressions in client code (cf.
compilerplugins/clang/implicitboolconversion.cxx). This change should be
transparent to client code.
Missing overloads of insert() for bool have been added to OStringBuffer and
OUStringBuffer (which required dropping one !VALID_CONVERSION check that would
now pick that overload, but would be flagged by
compilerplugins/clang/pointertobool.cxx).
Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
Diffstat (limited to 'xmloff')
| -rw-r--r-- | xmloff/source/forms/elementimport.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/xmloff/source/forms/elementimport.cxx b/xmloff/source/forms/elementimport.cxx index 171070d53eab..8cbfeae9a445 100644 --- a/xmloff/source/forms/elementimport.cxx +++ b/xmloff/source/forms/elementimport.cxx @@ -948,8 +948,8 @@ namespace xmloff { // we have exactly 2 properties where this type class is allowed: OSL_ENSURE( - (0 == _rPropValue.Name.equals(PROPERTY_EFFECTIVE_VALUE)) - || (0 == _rPropValue.Name.equals(PROPERTY_EFFECTIVE_DEFAULT)), + !_rPropValue.Name.equals(PROPERTY_EFFECTIVE_VALUE) + || !_rPropValue.Name.equals(PROPERTY_EFFECTIVE_DEFAULT), "OControlImport::implTranslateValueProperty: invalid property type/name combination!"); // Both properties are allowed to have a double or a string value, |