diff options
author | Noel Grandin <noel@peralex.com> | 2016-04-11 16:05:03 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2016-04-12 08:33:32 +0200 |
commit | dc0d98590f07c7dae4504b7ed0c0127794f032d8 (patch) | |
tree | b3b926f947185f89f59788f8fc48e6305eac67ff /xmloff | |
parent | 03fd8d24c2e4603731e796b24e51289736c65621 (diff) |
clang-tidy performance-unnecessary-value-param in xmloff
Change-Id: I8e6d8e66cdab2e50ee10882e139be29c14ce50f6
Diffstat (limited to 'xmloff')
30 files changed, 58 insertions, 58 deletions
diff --git a/xmloff/inc/PropertySetMerger.hxx b/xmloff/inc/PropertySetMerger.hxx index 7a711d3ebe58..22ec387fa0b9 100644 --- a/xmloff/inc/PropertySetMerger.hxx +++ b/xmloff/inc/PropertySetMerger.hxx @@ -24,8 +24,8 @@ extern css::uno::Reference< css::beans::XPropertySet > PropertySetMerger_CreateInstance( - css::uno::Reference< css::beans::XPropertySet > rPropSet1, - css::uno::Reference< css::beans::XPropertySet > rPropSet2 ) throw(); + const css::uno::Reference< css::beans::XPropertySet >& rPropSet1, + const css::uno::Reference< css::beans::XPropertySet >& rPropSet2 ) throw(); #endif diff --git a/xmloff/inc/StyleMap.hxx b/xmloff/inc/StyleMap.hxx index 4d838abc2683..d11447d6ab0a 100644 --- a/xmloff/inc/StyleMap.hxx +++ b/xmloff/inc/StyleMap.hxx @@ -75,7 +75,7 @@ public: static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId() throw(); static StyleMap* getImplementation( - css::uno::Reference< css::uno::XInterface > ) throw(); + const css::uno::Reference< css::uno::XInterface >& ) throw(); // XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( diff --git a/xmloff/inc/XMLChartPropertySetMapper.hxx b/xmloff/inc/XMLChartPropertySetMapper.hxx index 819865b5bf85..cb8dcd5a9222 100644 --- a/xmloff/inc/XMLChartPropertySetMapper.hxx +++ b/xmloff/inc/XMLChartPropertySetMapper.hxx @@ -52,7 +52,7 @@ protected: virtual void ContextFilter( bool bEnableFoFontFamily, ::std::vector< XMLPropertyState >& rProperties, - css::uno::Reference<css::beans::XPropertySet > rPropSet ) const override; + const css::uno::Reference<css::beans::XPropertySet >& rPropSet ) const override; private: /// this method is called for every item that has the MID_FLAG_ELEMENT_EXPORT flag set @@ -74,7 +74,7 @@ public: SvXMLExport& rExport ); virtual ~XMLChartExportPropertyMapper(); - void setChartDoc( css::uno::Reference< css::chart2::XChartDocument > xChartDoc ); + void setChartDoc( const css::uno::Reference< css::chart2::XChartDocument >& xChartDoc ); }; class XMLChartImportPropertyMapper : public SvXMLImportPropertyMapper diff --git a/xmloff/source/chart/PropertyMaps.cxx b/xmloff/source/chart/PropertyMaps.cxx index 67011a5ccb6a..0e55b077f1b3 100644 --- a/xmloff/source/chart/PropertyMaps.cxx +++ b/xmloff/source/chart/PropertyMaps.cxx @@ -211,7 +211,7 @@ XMLChartExportPropertyMapper::~XMLChartExportPropertyMapper() void XMLChartExportPropertyMapper::ContextFilter( bool bEnableFoFontFamily, std::vector< XMLPropertyState >& rProperties, - uno::Reference< beans::XPropertySet > rPropSet ) const + const uno::Reference< beans::XPropertySet >& rPropSet ) const { OUString aAutoPropName; bool bCheckAuto = false; @@ -508,7 +508,7 @@ void XMLChartExportPropertyMapper::handleSpecialItem( } } -void XMLChartExportPropertyMapper::setChartDoc( uno::Reference< chart2::XChartDocument > xChartDoc ) +void XMLChartExportPropertyMapper::setChartDoc( const uno::Reference< chart2::XChartDocument >& xChartDoc ) { mxChartDoc = xChartDoc; } diff --git a/xmloff/source/chart/SchXMLExport.cxx b/xmloff/source/chart/SchXMLExport.cxx index 064f8d960cff..57abb9670b3b 100644 --- a/xmloff/source/chart/SchXMLExport.cxx +++ b/xmloff/source/chart/SchXMLExport.cxx @@ -184,8 +184,8 @@ public: bool bIncludeTable = false ); void exportTable(); void exportPlotArea( - css::uno::Reference< css::chart::XDiagram > xDiagram, - css::uno::Reference< css::chart2::XDiagram > xNewDiagram, + const css::uno::Reference< css::chart::XDiagram >& xDiagram, + const css::uno::Reference< css::chart2::XDiagram >& xNewDiagram, const css::awt::Size & rPageSize, bool bExportContent, bool bIncludeTable ); @@ -234,10 +234,10 @@ public: /// add svg position as attribute for current element void addPosition( const css::awt::Point & rPosition ); - void addPosition( css::uno::Reference< css::drawing::XShape > xShape ); + void addPosition( const css::uno::Reference< css::drawing::XShape >& xShape ); /// add svg size as attribute for current element void addSize( const css::awt::Size & rSize, bool bIsOOoNamespace = false ); - void addSize( css::uno::Reference< css::drawing::XShape > xShape ); + void addSize( const css::uno::Reference< css::drawing::XShape >& xShape ); /// exports a string as a paragraph element void exportText( const OUString& rText ); @@ -1818,8 +1818,8 @@ Reference< chart2::XAxis > lcl_getAxis( const Reference< chart2::XCoordinateSyst } void SchXMLExportHelper_Impl::exportPlotArea( - Reference< chart::XDiagram > xDiagram, - Reference< chart2::XDiagram > xNewDiagram, + const Reference< chart::XDiagram >& xDiagram, + const Reference< chart2::XDiagram >& xNewDiagram, const awt::Size & rPageSize, bool bExportContent, bool bIncludeTable ) @@ -3457,7 +3457,7 @@ void SchXMLExportHelper_Impl::addPosition( const awt::Point & rPosition ) mrExport.AddAttribute( XML_NAMESPACE_SVG, XML_Y, msString ); } -void SchXMLExportHelper_Impl::addPosition( Reference< drawing::XShape > xShape ) +void SchXMLExportHelper_Impl::addPosition( const Reference< drawing::XShape >& xShape ) { if( xShape.is()) addPosition( xShape->getPosition()); @@ -3476,7 +3476,7 @@ void SchXMLExportHelper_Impl::addSize( const awt::Size & rSize, bool bIsOOoNames mrExport.AddAttribute( bIsOOoNamespace ? XML_NAMESPACE_CHART_EXT : XML_NAMESPACE_SVG, XML_HEIGHT, msString ); } -void SchXMLExportHelper_Impl::addSize( Reference< drawing::XShape > xShape ) +void SchXMLExportHelper_Impl::addSize( const Reference< drawing::XShape >& xShape ) { if( xShape.is()) addSize( xShape->getSize() ); diff --git a/xmloff/source/chart/SchXMLPlotAreaContext.cxx b/xmloff/source/chart/SchXMLPlotAreaContext.cxx index 07e4db502694..af2e117564db 100644 --- a/xmloff/source/chart/SchXMLPlotAreaContext.cxx +++ b/xmloff/source/chart/SchXMLPlotAreaContext.cxx @@ -977,7 +977,7 @@ SchXMLStatisticsObjectContext::~SchXMLStatisticsObjectContext() namespace { -void SetErrorBarStyleProperties( const OUString& rStyleName, uno::Reference< beans::XPropertySet > xBarProp, +void SetErrorBarStyleProperties( const OUString& rStyleName, const uno::Reference< beans::XPropertySet >& xBarProp, SchXMLImportHelper& rImportHelper ) { const SvXMLStylesContext* pStylesCtxt = rImportHelper.GetAutoStylesContext(); @@ -990,7 +990,7 @@ void SetErrorBarStyleProperties( const OUString& rStyleName, uno::Reference< bea rSeriesStyleContext.FillPropertySet( xBarProp ); } -void SetErrorBarPropertiesFromStyleName( const OUString& aStyleName, uno::Reference< beans::XPropertySet> xBarProp, +void SetErrorBarPropertiesFromStyleName( const OUString& aStyleName, const uno::Reference< beans::XPropertySet>& xBarProp, SchXMLImportHelper& rImportHelper, OUString& aPosRange, OUString& aNegRange) { const SvXMLStylesContext* pStylesCtxt = rImportHelper.GetAutoStylesContext(); diff --git a/xmloff/source/chart/SchXMLTableContext.cxx b/xmloff/source/chart/SchXMLTableContext.cxx index 5bef1072a65e..d3403d35a7ee 100644 --- a/xmloff/source/chart/SchXMLTableContext.cxx +++ b/xmloff/source/chart/SchXMLTableContext.cxx @@ -741,7 +741,7 @@ static void lcl_ApplyCellToComplexLabel( const SchXMLCell& rCell, Sequence< uno: void SchXMLTableHelper::applyTableToInternalDataProvider( const SchXMLTable& rTable, - uno::Reference< chart2::XChartDocument > xChartDoc ) + const uno::Reference< chart2::XChartDocument >& xChartDoc ) { // apply all data read from the local table to the internal data provider if( !xChartDoc.is() || !xChartDoc->hasInternalDataProvider() ) @@ -835,7 +835,7 @@ void SchXMLTableHelper::applyTableToInternalDataProvider( void SchXMLTableHelper::switchRangesFromOuterToInternalIfNecessary( const SchXMLTable& rTable, const tSchXMLLSequencesPerIndex & rLSequencesPerIndex, - uno::Reference< chart2::XChartDocument > xChartDoc, + const uno::Reference< chart2::XChartDocument >& xChartDoc, chart::ChartDataRowSource eDataRowSource ) { if( ! (xChartDoc.is() && xChartDoc->hasInternalDataProvider())) diff --git a/xmloff/source/chart/SchXMLTableContext.hxx b/xmloff/source/chart/SchXMLTableContext.hxx index 21ba2fdf63a9..6523facb0a01 100644 --- a/xmloff/source/chart/SchXMLTableContext.hxx +++ b/xmloff/source/chart/SchXMLTableContext.hxx @@ -68,14 +68,14 @@ class SchXMLTableHelper { public: static void applyTableToInternalDataProvider( const SchXMLTable& rTable, - css::uno::Reference< css::chart2::XChartDocument > xChartDoc ); + const css::uno::Reference< css::chart2::XChartDocument >& xChartDoc ); /** This function reorders local data to fit the correct data structure. Call it after the data series got their styles set. */ static void switchRangesFromOuterToInternalIfNecessary( const SchXMLTable& rTable, const tSchXMLLSequencesPerIndex & rLSequencesPerIndex, - css::uno::Reference< css::chart2::XChartDocument > xChartDoc, + const css::uno::Reference< css::chart2::XChartDocument >& xChartDoc, css::chart::ChartDataRowSource eDataRowSource ); }; diff --git a/xmloff/source/chart/SchXMLTools.cxx b/xmloff/source/chart/SchXMLTools.cxx index bb5d011d214f..619758ff5d11 100644 --- a/xmloff/source/chart/SchXMLTools.cxx +++ b/xmloff/source/chart/SchXMLTools.cxx @@ -746,7 +746,7 @@ bool switchBackToDataProviderFromParent( const Reference< chart2::XChartDocument return true; } -void setBuildIDAtImportInfo( uno::Reference< frame::XModel > xModel, Reference< beans::XPropertySet > xImportInfo ) +void setBuildIDAtImportInfo( const uno::Reference< frame::XModel >& xModel, const Reference< beans::XPropertySet >& xImportInfo ) { OUString aGenerator( lcl_getGeneratorFromModelOrItsParent(xModel) ); if( !aGenerator.isEmpty() ) diff --git a/xmloff/source/chart/SchXMLTools.hxx b/xmloff/source/chart/SchXMLTools.hxx index 567fa3b5791b..456cf67e75f9 100644 --- a/xmloff/source/chart/SchXMLTools.hxx +++ b/xmloff/source/chart/SchXMLTools.hxx @@ -48,8 +48,8 @@ namespace SchXMLTools bool isDocumentGeneratedWithOpenOfficeOlderThan3_0( const css::uno::Reference< css::frame::XModel >& xChartModel); bool isDocumentGeneratedWithOpenOfficeOlderThan3_3( const css::uno::Reference< css::frame::XModel >& xChartModel); - void setBuildIDAtImportInfo( css::uno::Reference< css::frame::XModel > xModel - , css::uno::Reference< css::beans::XPropertySet > xImportInfo ); + void setBuildIDAtImportInfo( const css::uno::Reference< css::frame::XModel >& xModel + , const css::uno::Reference< css::beans::XPropertySet >& xImportInfo ); enum SchXMLChartTypeEnum { diff --git a/xmloff/source/core/DomBuilderContext.cxx b/xmloff/source/core/DomBuilderContext.cxx index d51d71e346ec..89bab48702cc 100644 --- a/xmloff/source/core/DomBuilderContext.cxx +++ b/xmloff/source/core/DomBuilderContext.cxx @@ -61,7 +61,7 @@ static Reference<XNode> lcl_createDomInstance(); static Reference<XNode> lcl_createElement( SvXMLImport& rImport, sal_uInt16 nPrefix, const OUString& rLocalName, - Reference<XNode> xParent); + const Reference<XNode>& xParent); DomBuilderContext::DomBuilderContext( SvXMLImport& rImport, @@ -195,7 +195,7 @@ static Reference<XNode> lcl_createDomInstance() static Reference<XNode> lcl_createElement( SvXMLImport& rImport, sal_uInt16 nPrefix, const OUString& rLocalName, - Reference<XNode> xParent) + const Reference<XNode>& xParent) { DBG_ASSERT( xParent.is(), "need parent node" ); diff --git a/xmloff/source/core/PropertySetMerger.cxx b/xmloff/source/core/PropertySetMerger.cxx index 2dc03ee591c9..62a6cd50ff8c 100644 --- a/xmloff/source/core/PropertySetMerger.cxx +++ b/xmloff/source/core/PropertySetMerger.cxx @@ -243,7 +243,7 @@ sal_Bool SAL_CALL PropertySetMergerImpl::hasPropertyByName( const OUString& Name return mxPropSet2Info->hasPropertyByName( Name ); } -Reference< XPropertySet > PropertySetMerger_CreateInstance( Reference< XPropertySet > rPropSet1, Reference< XPropertySet > rPropSet2 ) throw() +Reference< XPropertySet > PropertySetMerger_CreateInstance( const Reference< XPropertySet >& rPropSet1, const Reference< XPropertySet >& rPropSet2 ) throw() { return new PropertySetMergerImpl( rPropSet1, rPropSet2 ); } diff --git a/xmloff/source/core/attrlist.cxx b/xmloff/source/core/attrlist.cxx index c3a651c964b3..f01dc416da50 100644 --- a/xmloff/source/core/attrlist.cxx +++ b/xmloff/source/core/attrlist.cxx @@ -245,7 +245,7 @@ const uno::Sequence< sal_Int8 > & SvXMLAttributeList::getUnoTunnelId() throw() return theSvXMLAttributeListUnoTunnelId::get().getSeq(); } -SvXMLAttributeList* SvXMLAttributeList::getImplementation( uno::Reference< uno::XInterface > xInt ) throw() +SvXMLAttributeList* SvXMLAttributeList::getImplementation( const uno::Reference< uno::XInterface >& xInt ) throw() { uno::Reference< lang::XUnoTunnel > xUT( xInt, uno::UNO_QUERY ); if( xUT.is() ) diff --git a/xmloff/source/core/xmlexp.cxx b/xmloff/source/core/xmlexp.cxx index dacacdbb7251..6586867f0cbc 100644 --- a/xmloff/source/core/xmlexp.cxx +++ b/xmloff/source/core/xmlexp.cxx @@ -2068,7 +2068,7 @@ const uno::Sequence< sal_Int8 > & SvXMLExport::getUnoTunnelId() throw() return theSvXMLExportUnoTunnelId::get().getSeq(); } -SvXMLExport* SvXMLExport::getImplementation( uno::Reference< uno::XInterface > xInt ) throw() +SvXMLExport* SvXMLExport::getImplementation( const uno::Reference< uno::XInterface >& xInt ) throw() { uno::Reference< lang::XUnoTunnel > xUT( xInt, uno::UNO_QUERY ); if( xUT.is() ) diff --git a/xmloff/source/core/xmlimp.cxx b/xmloff/source/core/xmlimp.cxx index bf9e5de022e1..513f6100b8ef 100644 --- a/xmloff/source/core/xmlimp.cxx +++ b/xmloff/source/core/xmlimp.cxx @@ -1971,7 +1971,7 @@ SvXMLImport::GetRDFaImportHelper() } void -SvXMLImport::AddRDFa(uno::Reference<rdf::XMetadatable> i_xObject, +SvXMLImport::AddRDFa(const uno::Reference<rdf::XMetadatable>& i_xObject, OUString const & i_rAbout, OUString const & i_rProperty, OUString const & i_rContent, diff --git a/xmloff/source/draw/animationexport.cxx b/xmloff/source/draw/animationexport.cxx index 3140586c56e8..7bc5521e770d 100644 --- a/xmloff/source/draw/animationexport.cxx +++ b/xmloff/source/draw/animationexport.cxx @@ -1682,7 +1682,7 @@ AnimationsExporter::~AnimationsExporter() { } -void AnimationsExporter::prepare( Reference< XAnimationNode > xRootNode ) +void AnimationsExporter::prepare( const Reference< XAnimationNode >& xRootNode ) { try { @@ -1698,7 +1698,7 @@ void AnimationsExporter::prepare( Reference< XAnimationNode > xRootNode ) } } -void AnimationsExporter::exportAnimations( Reference< XAnimationNode > xRootNode ) +void AnimationsExporter::exportAnimations( const Reference< XAnimationNode >& xRootNode ) { try { diff --git a/xmloff/source/draw/animexp.cxx b/xmloff/source/draw/animexp.cxx index 0a14ef19b93b..638d6fd595f3 100644 --- a/xmloff/source/draw/animexp.cxx +++ b/xmloff/source/draw/animexp.cxx @@ -266,7 +266,7 @@ XMLAnimationsExporter::~XMLAnimationsExporter() { } -void XMLAnimationsExporter::prepare( Reference< XShape > xShape, SvXMLExport& ) +void XMLAnimationsExporter::prepare( const Reference< XShape >& xShape, SvXMLExport& ) { try { @@ -295,7 +295,7 @@ void XMLAnimationsExporter::prepare( Reference< XShape > xShape, SvXMLExport& ) } } -void XMLAnimationsExporter::collect( Reference< XShape > xShape, SvXMLExport& rExport ) +void XMLAnimationsExporter::collect( const Reference< XShape >& xShape, SvXMLExport& rExport ) { try { diff --git a/xmloff/source/draw/sdpropls.cxx b/xmloff/source/draw/sdpropls.cxx index da4366fe0396..872cee8fc9e4 100644 --- a/xmloff/source/draw/sdpropls.cxx +++ b/xmloff/source/draw/sdpropls.cxx @@ -1188,7 +1188,7 @@ XMLShapeExportPropertyMapper::~XMLShapeExportPropertyMapper() void XMLShapeExportPropertyMapper::ContextFilter( bool bEnableFoFontFamily, std::vector< XMLPropertyState >& rProperties, - uno::Reference< beans::XPropertySet > rPropSet ) const + const uno::Reference< beans::XPropertySet >& rPropSet ) const { XMLPropertyState* pRepeatOffsetX = nullptr; XMLPropertyState* pRepeatOffsetY = nullptr; @@ -1569,7 +1569,7 @@ XMLPageExportPropertyMapper::~XMLPageExportPropertyMapper() void XMLPageExportPropertyMapper::ContextFilter( bool bEnableFoFontFamily, std::vector< XMLPropertyState >& rProperties, - uno::Reference< beans::XPropertySet > rPropSet ) const + const uno::Reference< beans::XPropertySet >& rPropSet ) const { XMLPropertyState* pRepeatOffsetX = nullptr; XMLPropertyState* pRepeatOffsetY = nullptr; diff --git a/xmloff/source/draw/sdpropls.hxx b/xmloff/source/draw/sdpropls.hxx index 1b025704c381..22683e7aef32 100644 --- a/xmloff/source/draw/sdpropls.hxx +++ b/xmloff/source/draw/sdpropls.hxx @@ -83,7 +83,7 @@ protected: virtual void ContextFilter( bool bEnableFoFontFamily, ::std::vector< XMLPropertyState >& rProperties, - css::uno::Reference< css::beans::XPropertySet > rPropSet ) const override; + const css::uno::Reference< css::beans::XPropertySet >& rPropSet ) const override; public: XMLShapeExportPropertyMapper( const rtl::Reference< XMLPropertySetMapper >& rMapper, SvXMLExport& rExport ); virtual ~XMLShapeExportPropertyMapper(); @@ -116,7 +116,7 @@ protected: virtual void ContextFilter( bool bEnableFoFontFamily, ::std::vector< XMLPropertyState >& rProperties, - css::uno::Reference< css::beans::XPropertySet > rPropSet ) const override; + const css::uno::Reference< css::beans::XPropertySet >& rPropSet ) const override; public: XMLPageExportPropertyMapper( const rtl::Reference< XMLPropertySetMapper >& rMapper, SvXMLExport& rExport ); virtual ~XMLPageExportPropertyMapper(); diff --git a/xmloff/source/draw/sdxmlexp.cxx b/xmloff/source/draw/sdxmlexp.cxx index fdd11324766c..03586a0a73fb 100644 --- a/xmloff/source/draw/sdxmlexp.cxx +++ b/xmloff/source/draw/sdxmlexp.cxx @@ -623,7 +623,7 @@ void SAL_CALL SdXMLExport::setSourceDocument( const Reference< lang::XComponent } // #82003# helper function for recursive object count -sal_uInt32 SdXMLExport::ImpRecursiveObjectCount(Reference< drawing::XShapes > xShapes) +sal_uInt32 SdXMLExport::ImpRecursiveObjectCount(const Reference< drawing::XShapes >& xShapes) { sal_uInt32 nRetval(0L); @@ -1246,7 +1246,7 @@ void SdXMLExport::ImpWriteAutoLayoutPlaceholder(XmlPlaceholder ePl, const Rectan SvXMLElementExport aPPL(*this, XML_NAMESPACE_PRESENTATION, XML_PLACEHOLDER, true, true); } -ImpXMLEXPPageMasterInfo* SdXMLExport::ImpGetOrCreatePageMasterInfo( Reference< XDrawPage > xMasterPage ) +ImpXMLEXPPageMasterInfo* SdXMLExport::ImpGetOrCreatePageMasterInfo( const Reference< XDrawPage >& xMasterPage ) { bool bDoesExist = false; @@ -1614,7 +1614,7 @@ void SdXMLExport::ImplExportHeaderFooterDeclAttributes( const HeaderFooterPageSe AddAttribute( XML_NAMESPACE_PRESENTATION, XML_USE_DATE_TIME_NAME, aSettings.maStrDateTimeDeclName ); } -OUString SdXMLExport::ImpCreatePresPageStyleName( Reference<XDrawPage> xDrawPage, bool bExportBackground /* = true */ ) +OUString SdXMLExport::ImpCreatePresPageStyleName( const Reference<XDrawPage>& xDrawPage, bool bExportBackground /* = true */ ) { // create name OUString sStyleName; @@ -2485,7 +2485,7 @@ void SdXMLExport::ExportMasterStyles_() } } -void SdXMLExport::exportFormsElement( Reference< XDrawPage > xDrawPage ) +void SdXMLExport::exportFormsElement( const Reference< XDrawPage >& xDrawPage ) { if( xDrawPage.is() ) { diff --git a/xmloff/source/draw/sdxmlexp_impl.hxx b/xmloff/source/draw/sdxmlexp_impl.hxx index 49c3ebd7ace0..06be6229f9d4 100644 --- a/xmloff/source/draw/sdxmlexp_impl.hxx +++ b/xmloff/source/draw/sdxmlexp_impl.hxx @@ -124,7 +124,7 @@ class SdXMLExport : public SvXMLExport virtual void ExportContent_() override; virtual void ExportMeta_() override; - ImpXMLEXPPageMasterInfo* ImpGetOrCreatePageMasterInfo( css::uno::Reference< css::drawing::XDrawPage > xMasterPage ); + ImpXMLEXPPageMasterInfo* ImpGetOrCreatePageMasterInfo( const css::uno::Reference< css::drawing::XDrawPage >& xMasterPage ); void ImpPrepPageMasterInfos(); void ImpWritePageMasterInfos(); void ImpPrepAutoLayoutInfos(); @@ -134,7 +134,7 @@ class SdXMLExport : public SvXMLExport void ImpPrepDrawPageInfos(); void ImpPrepMasterPageInfos(); void ImpWritePresentationStyles(); - OUString ImpCreatePresPageStyleName( css::uno::Reference<css::drawing::XDrawPage> xDrawPage, bool bExportBackground = true ); + OUString ImpCreatePresPageStyleName( const css::uno::Reference<css::drawing::XDrawPage>& xDrawPage, bool bExportBackground = true ); bool ImpPrepAutoLayoutInfo(const css::uno::Reference< css::drawing::XDrawPage >& xPage, OUString& rName); void ImpWriteAutoLayoutInfos(); @@ -142,11 +142,11 @@ class SdXMLExport : public SvXMLExport void ImpWriteHeaderFooterDecls(); void ImplExportHeaderFooterDeclAttributes( const HeaderFooterPageSettingsImpl& aSettings ); - void exportFormsElement( css::uno::Reference< css::drawing::XDrawPage > xDrawPage ); + void exportFormsElement( const css::uno::Reference< css::drawing::XDrawPage >& xDrawPage ); void exportPresentationSettings(); // #82003# helper function for recursive object count - sal_uInt32 ImpRecursiveObjectCount( css::uno::Reference< css::drawing::XShapes > xShapes); + sal_uInt32 ImpRecursiveObjectCount( const css::uno::Reference< css::drawing::XShapes >& xShapes); OUString getNavigationOrder( const css::uno::Reference< css::drawing::XDrawPage >& xDrawPage ); diff --git a/xmloff/source/draw/shapeimport.cxx b/xmloff/source/draw/shapeimport.cxx index 1f98a132bb4b..73cb3f7521ea 100644 --- a/xmloff/source/draw/shapeimport.cxx +++ b/xmloff/source/draw/shapeimport.cxx @@ -65,8 +65,8 @@ struct ConnectionHint struct XShapeCompareHelper { - bool operator()(css::uno::Reference < css::drawing::XShape > x1, - css::uno::Reference < css::drawing::XShape > x2 ) const + bool operator()(const css::uno::Reference < css::drawing::XShape >& x1, + const css::uno::Reference < css::drawing::XShape >& x2 ) const { return x1.get() < x2.get(); } diff --git a/xmloff/source/style/PageMasterExportPropMapper.cxx b/xmloff/source/style/PageMasterExportPropMapper.cxx index 3aecf06b96d7..3bec5d6884c5 100644 --- a/xmloff/source/style/PageMasterExportPropMapper.cxx +++ b/xmloff/source/style/PageMasterExportPropMapper.cxx @@ -55,7 +55,7 @@ static void lcl_RemoveStateIfZero16( XMLPropertyState* pState ) lcl_RemoveState( pState ); } -static void lcl_AddState(::std::vector< XMLPropertyState >& rPropState, sal_Int32 nIndex, const OUString& rProperty, uno::Reference< beans::XPropertySet >& xProps) +static void lcl_AddState(::std::vector< XMLPropertyState >& rPropState, sal_Int32 nIndex, const OUString& rProperty, const uno::Reference< beans::XPropertySet >& xProps) { if(::cppu::any2bool(xProps->getPropertyValue(rProperty))) rPropState.push_back(XMLPropertyState (nIndex, css::uno::Any(true))); @@ -300,7 +300,7 @@ void XMLPageMasterExportPropMapper::handleSpecialItem( void XMLPageMasterExportPropMapper::ContextFilter( bool bEnableFoFontFamily, ::std::vector< XMLPropertyState >& rPropState, - Reference< XPropertySet > rPropSet ) const + const Reference< XPropertySet >& rPropSet ) const { XMLPropertyStateBuffer aPageBuffer; XMLPropertyStateBuffer aHeaderBuffer; diff --git a/xmloff/source/style/PageMasterExportPropMapper.hxx b/xmloff/source/style/PageMasterExportPropMapper.hxx index f3312493f63e..8ee27e53e6c1 100644 --- a/xmloff/source/style/PageMasterExportPropMapper.hxx +++ b/xmloff/source/style/PageMasterExportPropMapper.hxx @@ -35,7 +35,7 @@ protected: virtual void ContextFilter( bool bEnableFoFontFamily, ::std::vector< XMLPropertyState >& rProperties, - css::uno::Reference< css::beans::XPropertySet > rPropSet + const css::uno::Reference< css::beans::XPropertySet >& rPropSet ) const override; public: diff --git a/xmloff/source/style/StyleMap.cxx b/xmloff/source/style/StyleMap.cxx index 73ee7980d015..0ebcbc0985b3 100644 --- a/xmloff/source/style/StyleMap.cxx +++ b/xmloff/source/style/StyleMap.cxx @@ -50,7 +50,7 @@ const Sequence<sal_Int8>& StyleMap::getUnoTunnelId() throw() return theStyleMapUnoTunnelId::get().getSeq(); } -StyleMap* StyleMap::getImplementation(Reference<XInterface> xInterface) throw() +StyleMap* StyleMap::getImplementation(const Reference<XInterface>& xInterface) throw() { Reference<XUnoTunnel> xUnoTunnel(xInterface, UNO_QUERY); if (xUnoTunnel.is()) diff --git a/xmloff/source/style/xmlexppr.cxx b/xmloff/source/style/xmlexppr.cxx index 5c8f673f77a2..1201dbcaf2b9 100644 --- a/xmloff/source/style/xmlexppr.cxx +++ b/xmloff/source/style/xmlexppr.cxx @@ -667,7 +667,7 @@ vector<XMLPropertyState> SvXMLExportPropertyMapper::Filter_( void SvXMLExportPropertyMapper::ContextFilter( bool bEnableFoFontFamily, vector< XMLPropertyState >& rProperties, - Reference< XPropertySet > rPropSet ) const + const Reference< XPropertySet >& rPropSet ) const { // Derived class could implement this. if (mpImpl->mxNextMapper.is()) diff --git a/xmloff/source/style/xmlimppr.cxx b/xmloff/source/style/xmlimppr.cxx index 21cc05987bde..b841e599876d 100644 --- a/xmloff/source/style/xmlimppr.cxx +++ b/xmloff/source/style/xmlimppr.cxx @@ -104,8 +104,8 @@ void SvXMLImportPropertyMapper::ChainImportMapper( /** fills the given itemset with the attributes in the given list */ void SvXMLImportPropertyMapper::importXML( vector< XMLPropertyState >& rProperties, - Reference< XAttributeList > xAttrList, - const SvXMLUnitConverter& rUnitConverter, + const Reference< XAttributeList >& xAttrList, + const SvXMLUnitConverter& rUnitConverter, const SvXMLNamespaceMap& rNamespaceMap, sal_uInt32 nPropType, sal_Int32 nStartIdx, diff --git a/xmloff/source/text/txtexppr.cxx b/xmloff/source/text/txtexppr.cxx index 8b072c68d499..5bf94615fa0e 100644 --- a/xmloff/source/text/txtexppr.cxx +++ b/xmloff/source/text/txtexppr.cxx @@ -498,7 +498,7 @@ void lcl_FilterBorders( void XMLTextExportPropertySetMapper::ContextFilter( bool bEnableFoFontFamily, ::std::vector< XMLPropertyState >& rProperties, - Reference< XPropertySet > rPropSet ) const + const Reference< XPropertySet >& rPropSet ) const { // filter font XMLPropertyState *pFontNameState = nullptr; diff --git a/xmloff/source/text/txtexppr.hxx b/xmloff/source/text/txtexppr.hxx index f89dd022cb74..823db14079e4 100644 --- a/xmloff/source/text/txtexppr.hxx +++ b/xmloff/source/text/txtexppr.hxx @@ -59,7 +59,7 @@ protected: virtual void ContextFilter( bool bEnableFoFontFamily, ::std::vector< XMLPropertyState >& rProperties, - css::uno::Reference< css::beans::XPropertySet > rPropSet ) const override; + const css::uno::Reference< css::beans::XPropertySet >& rPropSet ) const override; const SvXMLExport& GetExport() const { return rExport; } public: diff --git a/xmloff/source/text/txtparae.cxx b/xmloff/source/text/txtparae.cxx index f094cff39cb5..c7e03bbbeae3 100644 --- a/xmloff/source/text/txtparae.cxx +++ b/xmloff/source/text/txtparae.cxx @@ -3740,7 +3740,7 @@ void XMLTextParagraphExport::exportMeta( void XMLTextParagraphExport::PreventExportOfControlsInMuteSections( const Reference<XIndexAccess> & rShapes, - rtl::Reference<xmloff::OFormLayerXMLExport> xFormExport ) + const rtl::Reference<xmloff::OFormLayerXMLExport>& xFormExport ) { // check parameters ad pre-conditions if( ( ! rShapes.is() ) || ( ! xFormExport.is() ) ) |