diff options
| author | Miklos Vajna <vmiklos@collabora.com> | 2020-09-24 21:06:46 +0200 |
|---|---|---|
| committer | Miklos Vajna <vmiklos@collabora.com> | 2020-09-25 09:02:57 +0200 |
| commit | 2dd3d03b5350e18cb5f39978022620b55d3d8c5b (patch) | |
| tree | 5c82e20fef4188cad18ed88be6b6a1a98613750c /xmlsecurity/qa | |
| parent | 6505f43b09fda83f26159746083b971bfab8054a (diff) | |
xmlsecurity: fold pdfio into pdfsignaturehelper
Most of the initial pdfio was moved to vcl as vcl::filter::PDFDocument.
A small part was left here, because it depended on NSS. Then later the
NSS bits were moved to svl::crypto::Signing. The rest is just a small
amount of code, keeping that separate from PDFSignatureHelper, which is
its only user makes little sense.
With this, vcl::filter::PDFDocument is an implementation detail of
PDFSignatureHelper during signature verification.
Change-Id: I6230f9e46deeff7159970f88dbb3bd2de0e9ce7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103350
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Diffstat (limited to 'xmlsecurity/qa')
| -rw-r--r-- | xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx b/xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx index 8b4a610fa56c..586ef54d3075 100644 --- a/xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx +++ b/xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx @@ -127,7 +127,7 @@ bool PDFSigningTest::sign(const OUString& rInURL, const OUString& rOutURL, // Only try certificates that are already active and not expired if ((now > aNotValidAfter) || (now < aNotValidBefore)) { - SAL_WARN("xmlsecurity.pdfio.test", + SAL_WARN("xmlsecurity.qa", "Skipping a certificate that is not yet valid or already not valid"); } else @@ -139,8 +139,7 @@ bool PDFSigningTest::sign(const OUString& rInURL, const OUString& rOutURL, DWORD dwErr = GetLastError(); if (HRESULT_FROM_WIN32(dwErr) == CRYPT_E_NO_KEY_PROPERTY) { - SAL_WARN("xmlsecurity.pdfio.test", - "Skipping a certificate without a private key"); + SAL_WARN("xmlsecurity.qa", "Skipping a certificate without a private key"); continue; // The certificate does not have a private key - not a valid certificate } } |