diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-08-14 11:14:08 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-08-16 09:04:51 +0200 |
| commit | 7d7a7862a7dccb6764f80258f28685a0da3cbbcb (patch) | |
| tree | b7281950f84b12c4868542f103a23c1460d22863 /xmlsecurity/source/helper | |
| parent | abeab40aeb2bf16c1438b5e5f0cd70b3e11f6b7a (diff) | |
new loplugin:sequenceloop
look for places we should be using std::as_const on for-range
loops over uno::Sequence, to avoid triggering a copy
Change-Id: I7efb641bf09d37c87946f03428ee4eec90298c8a
Reviewed-on: https://gerrit.libreoffice.org/77441
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'xmlsecurity/source/helper')
| -rw-r--r-- | xmlsecurity/source/helper/documentsignaturehelper.cxx | 4 | ||||
| -rw-r--r-- | xmlsecurity/source/helper/documentsignaturemanager.cxx | 4 | ||||
| -rw-r--r-- | xmlsecurity/source/helper/ooxmlsecexporter.cxx | 2 |
3 files changed, 5 insertions, 5 deletions
diff --git a/xmlsecurity/source/helper/documentsignaturehelper.cxx b/xmlsecurity/source/helper/documentsignaturehelper.cxx index ee5fb4989ec1..c097b14a2180 100644 --- a/xmlsecurity/source/helper/documentsignaturehelper.cxx +++ b/xmlsecurity/source/helper/documentsignaturehelper.cxx @@ -86,7 +86,7 @@ static void ImplFillElementList( const OUString& rRootStorageName, const bool bRecursive, const DocumentSignatureAlgorithm mode) { - Sequence< OUString > aElements = rxStore->getElementNames(); + const Sequence< OUString > aElements = rxStore->getElementNames(); for ( const auto& rName : aElements ) { @@ -213,7 +213,7 @@ DocumentSignatureHelper::CreateElementList( xSubStore.clear(); // Object folders... - Sequence< OUString > aElementNames = rxStore->getElementNames(); + const Sequence< OUString > aElementNames = rxStore->getElementNames(); for ( const auto& rName : aElementNames ) { if ( ( rName.match( "Object " ) ) && rxStore->isStorageElement( rName ) ) diff --git a/xmlsecurity/source/helper/documentsignaturemanager.cxx b/xmlsecurity/source/helper/documentsignaturemanager.cxx index 557557f6bae8..19cdc2fb4d1d 100644 --- a/xmlsecurity/source/helper/documentsignaturemanager.cxx +++ b/xmlsecurity/source/helper/documentsignaturemanager.cxx @@ -177,7 +177,7 @@ bool DocumentSignatureManager::isXML(const OUString& rURI) if (readManifest()) { - for (const uno::Sequence<beans::PropertyValue>& entry : m_manifest) + for (const uno::Sequence<beans::PropertyValue>& entry : std::as_const(m_manifest)) { OUString sPath; OUString sMediaType; @@ -393,7 +393,7 @@ bool DocumentSignatureManager::add( eAlgorithmID); } - uno::Sequence<uno::Reference<security::XCertificate>> aCertPath + const uno::Sequence<uno::Reference<security::XCertificate>> aCertPath = xSecurityContext->getSecurityEnvironment()->buildCertificatePath(xCert); OUStringBuffer aStrBuffer; diff --git a/xmlsecurity/source/helper/ooxmlsecexporter.cxx b/xmlsecurity/source/helper/ooxmlsecexporter.cxx index 062c76d5c47b..cf87d6e1ad17 100644 --- a/xmlsecurity/source/helper/ooxmlsecexporter.cxx +++ b/xmlsecurity/source/helper/ooxmlsecexporter.cxx @@ -242,7 +242,7 @@ void OOXMLSecExporter::Impl::writeRelationshipTransform(const OUString& rURI) m_xDocumentHandler->startElement("Transform", uno::Reference<xml::sax::XAttributeList>(pAttributeList.get())); } - uno::Sequence< uno::Sequence<beans::StringPair> > aRelationsInfo = comphelper::OFOPXMLHelper::ReadRelationsInfoSequence(xRelStream, rURI, m_xComponentContext); + const uno::Sequence< uno::Sequence<beans::StringPair> > aRelationsInfo = comphelper::OFOPXMLHelper::ReadRelationsInfoSequence(xRelStream, rURI, m_xComponentContext); for (const uno::Sequence<beans::StringPair>& rPairs : aRelationsInfo) { OUString aId; |