diff options
| author | Norbert Thiebaud <nthiebaud@gmail.com> | 2013-02-18 04:04:16 -0600 |
|---|---|---|
| committer | Andras Timar <atimar@suse.com> | 2013-02-18 21:38:42 +0000 |
| commit | cbe8883b51c532a9891afda720647709d1741adc (patch) | |
| tree | ceaf89b84c9c267b9dca020d789369eac19bb15c /xmlsecurity/source | |
| parent | e681622f3dcdd979e5c1b261ccc671d2fe9d0f37 (diff) | |
coverity#982591 Dereference after null check
Change-Id: I8651ecb0287d686da3e1ca6a6e46549abe3e0c38
Reviewed-on: https://gerrit.libreoffice.org/2225
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
Diffstat (limited to 'xmlsecurity/source')
| -rw-r--r-- | xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx b/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx index fa8f7d52601b..a3bda1367f42 100644 --- a/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx +++ b/xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx @@ -509,17 +509,20 @@ SecurityEnvironment_NssImpl::getPersonalCertificates() throw( SecurityException } priKeyList = PK11_ListPrivateKeysInSlot(slot) ; - if( priKeyList != NULL ) { + if( priKeyList != NULL ) + { for( curPri = PRIVKEY_LIST_HEAD( priKeyList ); !PRIVKEY_LIST_END( curPri, priKeyList ) && curPri != NULL ; - curPri = PRIVKEY_LIST_NEXT( curPri ) ) { + curPri = PRIVKEY_LIST_NEXT( curPri ) ) + { xcert = NssPrivKeyToXCert( curPri->key ) ; if( xcert != NULL ) certsList.push_back( xcert ) ; } + SECKEY_DestroyPrivateKeyList( priKeyList ) ; } - SECKEY_DestroyPrivateKeyList( priKeyList ) ; + } //secondly, we try to find certificate from registered private keys. |