xmlsecurity: prefer passing OUString by reference

Change-Id: I44b96a8adc2f6309088d99ff3bce438f660d302d

6 files changed, 8 insertions, 8 deletions

diff --git a/xmlsecurity/source/component/documentdigitalsignatures.cxx b/xmlsecurity/source/component/documentdigitalsignatures.cxx
index 896ee9fbea82..3be1610a1d47 100644
--- a/xmlsecurity/source/component/documentdigitalsignatures.cxx
+++ b/xmlsecurity/source/component/documentdigitalsignatures.cxx
@@ -293,7 +293,7 @@ DocumentDigitalSignatures::ImplVerifySignatures(
                 m_sODFVersion, aSignInfos[n]);
             const std::vector< OUString > aElementsToBeVerified =
                 DocumentSignatureHelper::CreateElementList(
-                rxStorage, OUString(), eMode, mode);
+                rxStorage, eMode, mode);
 
             const SignatureInformation& rInfo = aSignInfos[n];
             css::security::DocumentSignatureInformation& rSigInfo = arInfos[n];
diff --git a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
index b9452c3b0045..bd297874c708 100644
--- a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
+++ b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
@@ -437,7 +437,7 @@ IMPL_LINK_NOARG(DigitalSignaturesDialog, AddButtonHdl)
 
             std::vector< OUString > aElements =
                 DocumentSignatureHelper::CreateElementList(
-                    mxStore, OUString(), meSignatureMode, OOo3_2Document);
+                    mxStore, meSignatureMode, OOo3_2Document);
 
             sal_Int32 nElements = aElements.size();
             for ( sal_Int32 n = 0; n < nElements; n++ )
@@ -576,7 +576,7 @@ void DigitalSignaturesDialog::ImplFillSignaturesBox()
                 m_sODFVersion, maCurrentSignatureInformations[n]);
             std::vector< OUString > aElementsToBeVerified =
                 DocumentSignatureHelper::CreateElementList(
-                mxStore, OUString(), meSignatureMode, mode);
+                mxStore, meSignatureMode, mode);
 
             const SignatureInformation& rInfo = maCurrentSignatureInformations[n];
             //First we try to get the certificate which is embedded in the XML Signature
diff --git a/xmlsecurity/source/helper/documentsignaturehelper.cxx b/xmlsecurity/source/helper/documentsignaturehelper.cxx
index 11f6c6e7f1e9..2ec4f030be80 100644
--- a/xmlsecurity/source/helper/documentsignaturehelper.cxx
+++ b/xmlsecurity/source/helper/documentsignaturehelper.cxx
@@ -76,7 +76,7 @@ int compareVersions(
 //then mimetype and all content of META-INF must be excluded.
 void ImplFillElementList(
     std::vector< OUString >& rList, const Reference < css::embed::XStorage >& rxStore,
-    const OUString rRootStorageName, const bool bRecursive,
+    const OUString& rRootStorageName, const bool bRecursive,
     const DocumentSignatureAlgorithm mode)
 {
     OUString aMetaInfName(  "META-INF"  );
@@ -185,7 +185,7 @@ DocumentSignatureHelper::getDocumentAlgorithm(
 std::vector< OUString >
 DocumentSignatureHelper::CreateElementList(
     const Reference < css::embed::XStorage >& rxStore,
-    const OUString /*rRootStorageName*/, DocumentSignatureMode eMode,
+    DocumentSignatureMode eMode,
     const DocumentSignatureAlgorithm mode)
 {
     std::vector< OUString > aElements;
diff --git a/xmlsecurity/source/helper/xmlsignaturehelper.cxx b/xmlsecurity/source/helper/xmlsignaturehelper.cxx
index b5e2869b4031..e32721046306 100644
--- a/xmlsecurity/source/helper/xmlsignaturehelper.cxx
+++ b/xmlsecurity/source/helper/xmlsignaturehelper.cxx
@@ -75,7 +75,7 @@ bool XMLSignatureHelper::Init()
 
 void XMLSignatureHelper::SetStorage(
     const Reference < css::embed::XStorage >& rxStorage,
-    OUString sODFVersion)
+    const OUString& sODFVersion)
 {
     DBG_ASSERT( !mxUriBinding.is(), "SetStorage - UriBinding already set!" );
     mxUriBinding = new UriBindingHelper( rxStorage );
diff --git a/xmlsecurity/source/helper/xsecctl.hxx b/xmlsecurity/source/helper/xsecctl.hxx
index 0b5469b57541..c45836e99aeb 100644
--- a/xmlsecurity/source/helper/xsecctl.hxx
+++ b/xmlsecurity/source/helper/xsecctl.hxx
@@ -131,7 +131,7 @@ public:
         xReferenceResolvedListener = xListener;
     }
 
-    void addReference( sal_Int32 type, OUString uri, sal_Int32 keeperId )
+    void addReference( sal_Int32 type, const OUString& uri, sal_Int32 keeperId )
     {
         signatureInfor.vSignatureReferenceInfors.push_back(
                 SignatureReferenceInformation(type, uri));
diff --git a/xmlsecurity/source/xmlsec/biginteger.cxx b/xmlsecurity/source/xmlsec/biginteger.cxx
index ae63a291836d..72eb669a09e4 100644
--- a/xmlsecurity/source/xmlsec/biginteger.cxx
+++ b/xmlsecurity/source/xmlsec/biginteger.cxx
@@ -25,7 +25,7 @@
 
 using namespace ::com::sun::star::uno ;
 
-Sequence< sal_Int8 > numericStringToBigInteger ( OUString numeral )
+Sequence< sal_Int8 > numericStringToBigInteger ( const OUString& numeral )
 {
     if( numeral.getStr() != NULL )
     {