diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2017-11-27 09:46:06 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2017-11-27 14:04:40 +0100 |
| commit | a2656563f1a7639a99276fda90b6c8f675d20fc5 (patch) | |
| tree | cc9eb4f064b1e8cdfce9ac42c52dfa6ae54f2b70 /xmlsecurity | |
| parent | 0093ae5f2ca1141f199aa9ae3b34b05a33def928 (diff) | |
loplugin:unnecessaryparen: Warn about parentheses around literals
...that are not composed of multiple tokens, like ("foo" "bar"). Also don't yet
warn about Boolean literals, which are sometimes wrapped in parentheses to
silence unreachable-code warnings.
To avoid multiple warnings about code like
f((0))
switch to generally using a set of ParenExpr to keep track of which occurrences
have already been handled.
Change-Id: I036a25a92836ec6ab6c56ea848f71bc6d63822bc
Reviewed-on: https://gerrit.libreoffice.org/45317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'xmlsecurity')
| -rw-r--r-- | xmlsecurity/source/framework/saxeventkeeperimpl.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/xmlsecurity/source/framework/saxeventkeeperimpl.cxx b/xmlsecurity/source/framework/saxeventkeeperimpl.cxx index c1855ecd31ca..f082b452bad0 100644 --- a/xmlsecurity/source/framework/saxeventkeeperimpl.cxx +++ b/xmlsecurity/source/framework/saxeventkeeperimpl.cxx @@ -445,7 +445,7 @@ void SAXEventKeeperImpl::smashBufferNode( */ m_xXMLDocument->clearUselessData(m_pRootBufferNode->getXMLElement(), aChildElements, - bIsNotBlocking?(nullptr): + bIsNotBlocking?nullptr: (m_pCurrentBlockingBufferNode->getXMLElement())); /* @@ -497,7 +497,7 @@ void SAXEventKeeperImpl::smashBufferNode( m_xXMLDocument->clearUselessData(pBufferNode->getXMLElement(), aChildElements, bIsBlockInside?(m_pCurrentBlockingBufferNode->getXMLElement()): - (nullptr)); + nullptr); /* * remove the node if it is empty, then if its parent is also |