summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--RepositoryExternal.mk1
-rw-r--r--external/pdfium/Library_pdfium.mk1
-rw-r--r--external/pdfium/UnpackedTarball_pdfium.mk1
-rw-r--r--external/pdfium/visibility.patch.122
4 files changed, 2 insertions, 23 deletions
diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 952e915aa7a7..405ad054510e 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -4152,6 +4152,7 @@ ifneq ($(ENABLE_PDFIUM),)
define gb_LinkTarget__use_pdfium
$(call gb_LinkTarget_set_include,$(1),\
-I$(call gb_UnpackedTarball_get_dir,pdfium)/public \
+ -DCOMPONENT_BUILD \
$$(INCLUDE) \
)
$(call gb_LinkTarget_use_libraries,$(1),pdfium)
diff --git a/external/pdfium/Library_pdfium.mk b/external/pdfium/Library_pdfium.mk
index e7618791bcb8..3a05bbdaaba5 100644
--- a/external/pdfium/Library_pdfium.mk
+++ b/external/pdfium/Library_pdfium.mk
@@ -31,6 +31,7 @@ $(eval $(call gb_Library_add_defs,pdfium,\
-DMEMORY_TOOL_REPLACES_ALLOCATOR \
-DUNICODE \
-DWIN32_LEAN_AND_MEAN \
+ -DCOMPONENT_BUILD \
))
$(eval $(call gb_Library_set_generated_cxx_suffix,pdfium,cpp))
diff --git a/external/pdfium/UnpackedTarball_pdfium.mk b/external/pdfium/UnpackedTarball_pdfium.mk
index ba1a7e994dbf..93d3fede6e3c 100644
--- a/external/pdfium/UnpackedTarball_pdfium.mk
+++ b/external/pdfium/UnpackedTarball_pdfium.mk
@@ -8,7 +8,6 @@
#
pdfium_patches :=
-pdfium_patches += visibility.patch.1
pdfium_patches += ubsan.patch
# Fixes build on our baseline.
pdfium_patches += build.patch.1
diff --git a/external/pdfium/visibility.patch.1 b/external/pdfium/visibility.patch.1
deleted file mode 100644
index 14a380bbfa16..000000000000
--- a/external/pdfium/visibility.patch.1
+++ /dev/null
@@ -1,22 +0,0 @@
-diff --git a/public/fpdfview.h b/public/fpdfview.h
-index 0542b0541..2c9a37b4a 100644
---- a/public/fpdfview.h
-+++ b/public/fpdfview.h
-@@ -175,7 +175,6 @@ typedef int FPDF_ANNOT_APPEARANCEMODE;
- // Dictionary value types.
- typedef int FPDF_OBJECT_TYPE;
-
--#if defined(COMPONENT_BUILD)
- // FPDF_EXPORT should be consistent with |export| in the pdfium_fuzzer
- // template in testing/fuzzers/BUILD.gn.
- #if defined(WIN32)
-@@ -191,9 +190,6 @@ typedef int FPDF_OBJECT_TYPE;
- #define FPDF_EXPORT
- #endif // defined(FPDF_IMPLEMENTATION)
- #endif // defined(WIN32)
--#else
--#define FPDF_EXPORT
--#endif // defined(COMPONENT_BUILD)
-
- #if defined(WIN32) && defined(FPDFSDK_EXPORTS)
- #define FPDF_CALLCONV __stdcall