diff options
-rw-r--r-- | fpicker/source/office/iodlgimp.cxx | 8 | ||||
-rw-r--r-- | fpicker/source/office/iodlgimp.hxx | 1 | ||||
-rw-r--r-- | unusedcode.README | 4 |
3 files changed, 3 insertions, 10 deletions
diff --git a/fpicker/source/office/iodlgimp.cxx b/fpicker/source/office/iodlgimp.cxx index f93b84d20775..99797dae8424 100644 --- a/fpicker/source/office/iodlgimp.cxx +++ b/fpicker/source/office/iodlgimp.cxx @@ -165,14 +165,6 @@ SvtFileDialogURLSelector::~SvtFileDialogURLSelector() } //----------------------------------------------------------------------------- -void SvtFileDialogURLSelector::OpenURL( const String& rURL ) -{ - INetURLObject aObj( rURL ); - DBG_ASSERT( aObj.GetProtocol() != INET_PROT_NOT_VALID, "SvtFileDialogURLSelector::OpenURL: Invalid URL!" ); - m_pParent->OpenURL_Impl( aObj.GetMainURL( INetURLObject::NO_DECODE ) ); -} - -//----------------------------------------------------------------------------- void SvtFileDialogURLSelector::Activate() { m_pMenu->Clear(); diff --git a/fpicker/source/office/iodlgimp.hxx b/fpicker/source/office/iodlgimp.hxx index 54784520ab13..7a30e9392758 100644 --- a/fpicker/source/office/iodlgimp.hxx +++ b/fpicker/source/office/iodlgimp.hxx @@ -100,7 +100,6 @@ protected: inline SvtFileDialog* GetDialogParent() { return m_pParent; } protected: - void OpenURL( const String& rURL ); virtual void FillURLMenu( PopupMenu* _pMenu ) = 0; diff --git a/unusedcode.README b/unusedcode.README index 08f51b7bc85d..c721d6237327 100644 --- a/unusedcode.README +++ b/unusedcode.README @@ -28,7 +28,9 @@ d) gcc will only emit code for inlines if those inlines are used, so e) if a constructor is listed as unused, and it's the *only* ctor in the class, then no object of that class can be construsted, so the whole thing is unused, which can lead to a whole cascade of tricky but logical fallout. -f) there's more actually unused code then what's listed. The idea is that what's +f) if a destructor is listed as unused, and a constructor isn't, then there's + a leak somewhere, and the destructor most likely *should* be called. +g) there's more actually unused code then what's listed. The idea is that what's listed is definitely unused under the generation configuration, not that it's a list of all unused code. If the count of unused easy hits 0 then we can have a look at the non-easy and if that hits 0, then strip out |