diff options
-rw-r--r-- | drawinglayer/source/processor2d/vclpixelprocessor2d.cxx | 22 | ||||
-rw-r--r-- | drawinglayer/source/tools/emfpbrush.cxx | 4 | ||||
-rw-r--r-- | drawinglayer/source/tools/emfphelperdata.cxx | 10 | ||||
-rw-r--r-- | drawinglayer/source/tools/emfphelperdata.hxx | 6 | ||||
-rw-r--r-- | drawinglayer/source/tools/emfppen.cxx | 2 | ||||
-rw-r--r-- | emfio/CppunitTest_emfio_emf_test.mk | 24 | ||||
-rw-r--r-- | emfio/CppunitTest_emfio_wmf_test.mk | 58 | ||||
-rw-r--r-- | emfio/source/reader/emfreader.cxx | 27 | ||||
-rw-r--r-- | emfio/source/reader/wmfreader.cxx | 4 |
9 files changed, 77 insertions, 80 deletions
diff --git a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx index 039986566d00..2ac5bbc0c8d6 100644 --- a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx +++ b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx @@ -519,16 +519,18 @@ namespace drawinglayer { primitive2d::Primitive2DContainer aDecomposition; rMetafilePrimitive.get2DDecomposition(aDecomposition, getViewInformation2D()); - const primitive2d::ModifiedColorPrimitive2D aPrimitiveR( - aDecomposition, - basegfx::BColorModifierSharedPtr( - new basegfx::BColorModifier_RGBLuminanceContrast( - 0.5, // red - -0.5, // green - -0.5, // blue - 0.0, // luminance - 0.0))); // contrast - processBasePrimitive2D(aPrimitiveR); + primitive2d::BasePrimitive2D* pBasePrimitive = nullptr; + const primitive2d::Primitive2DReference aPrimitiveR( + pBasePrimitive = new primitive2d::ModifiedColorPrimitive2D( + aDecomposition, + basegfx::BColorModifierSharedPtr( + new basegfx::BColorModifier_RGBLuminanceContrast( + 0.5, // red + -0.5, // green + -0.5, // blue + 0.0, // luminance + 0.0)))); // contrast + processBasePrimitive2D(*pBasePrimitive); RenderMetafilePrimitive2D(rMetafilePrimitive); } else diff --git a/drawinglayer/source/tools/emfpbrush.cxx b/drawinglayer/source/tools/emfpbrush.cxx index d55a16ad30d7..19b1441ddb1d 100644 --- a/drawinglayer/source/tools/emfpbrush.cxx +++ b/drawinglayer/source/tools/emfpbrush.cxx @@ -211,7 +211,7 @@ namespace emfplushelper if (additionalFlags & 0x02) { SAL_INFO("cppcanvas.emf", "EMF+\tuse transformation"); - rR.readXForm(s, brush_transformation); + EmfPlusHelperData::readXForm(s, brush_transformation); hasTransformation = true; SAL_INFO("cppcanvas.emf", "EMF+\tm11: " << brush_transformation.get(0,0) << " m12: " << brush_transformation.get(1,0) << @@ -297,7 +297,7 @@ namespace emfplushelper if (additionalFlags & 0x02) { SAL_INFO("cppcanvas.emf", "EMF+\tuse transformation"); - rR.readXForm(s, brush_transformation); + EmfPlusHelperData::readXForm(s, brush_transformation); hasTransformation = true; SAL_INFO("cppcanvas.emf", "EMF+\tm11: " << brush_transformation.get(0,0) << " m12: " << brush_transformation.get(1,0) << diff --git a/drawinglayer/source/tools/emfphelperdata.cxx b/drawinglayer/source/tools/emfphelperdata.cxx index 0f81783dec5d..e4f3e3ce7322 100644 --- a/drawinglayer/source/tools/emfphelperdata.cxx +++ b/drawinglayer/source/tools/emfphelperdata.cxx @@ -860,12 +860,8 @@ namespace emfplushelper float lx, ly, lw, lh; rMS.ReadFloat(lx).ReadFloat(ly).ReadFloat(lw).ReadFloat(lh); SAL_INFO("cppcanvas.emf", "EMF+ DrawString layoutRect: " << lx << "," << ly << " - " << lw << "x" << lh); - OUString text = read_uInt16s_ToOUString(rMS, stringLength); - EMFPStringFormat *stringFormat = static_cast< EMFPStringFormat* >(maEMFPObjects[formatId & 0xff].get()); - - (void)(text); // avoid warning - (void)(stringFormat); // avoid warning - + // OUString text = read_uInt16s_ToOUString(rMS, stringLength); + // EMFPStringFormat *stringFormat = static_cast< EMFPStringFormat* >(maEMFPObjects[formatId & 0xff].get()); // css::rendering::FontRequest aFontRequest; // // if (stringFormat) @@ -1249,6 +1245,8 @@ namespace emfplushelper ", " << transform.get(0,2) << ", " << transform.get(1,2)); } + (void)text; // avoid warning + // rendering::FontRequest aFontRequest; // // add the text action // setFont(aFontRequest, flags & 0xff, rFactoryParms, rState); diff --git a/drawinglayer/source/tools/emfphelperdata.hxx b/drawinglayer/source/tools/emfphelperdata.hxx index 67f423436fa4..21f5dcdddabd 100644 --- a/drawinglayer/source/tools/emfphelperdata.hxx +++ b/drawinglayer/source/tools/emfphelperdata.hxx @@ -223,7 +223,7 @@ namespace emfplushelper // readers void processObjectRecord(SvMemoryStream& rObjectStream, sal_uInt16 flags, sal_uInt32 dataSize, bool bUseWholeStream = false); - void ReadPoint(SvStream& s, float& x, float& y, sal_uInt32 flags); + static void ReadPoint(SvStream& s, float& x, float& y, sal_uInt32 flags); // internal mapper void mappingChanged(); @@ -248,8 +248,8 @@ namespace emfplushelper ::basegfx::B2DSize MapSize(double iwidth, double iheight); // readers - void ReadRectangle(SvStream& s, float& x, float& y, float &width, float& height, bool bCompressed = false); - bool readXForm(SvStream& rIn, basegfx::B2DHomMatrix& rTarget); + static void ReadRectangle(SvStream& s, float& x, float& y, float &width, float& height, bool bCompressed = false); + static bool readXForm(SvStream& rIn, basegfx::B2DHomMatrix& rTarget); }; } diff --git a/drawinglayer/source/tools/emfppen.cxx b/drawinglayer/source/tools/emfppen.cxx index 851518b486f5..cb8bbf4cb8d5 100644 --- a/drawinglayer/source/tools/emfppen.cxx +++ b/drawinglayer/source/tools/emfppen.cxx @@ -184,7 +184,7 @@ namespace emfplushelper if (penDataFlags & PenDataTransform) { - rR.readXForm(s, pen_transformation); + EmfPlusHelperData::readXForm(s, pen_transformation); } if (penDataFlags & PenDataStartCap) diff --git a/emfio/CppunitTest_emfio_emf_test.mk b/emfio/CppunitTest_emfio_emf_test.mk index 6965613e9cd8..49cf14f90e51 100644 --- a/emfio/CppunitTest_emfio_emf_test.mk +++ b/emfio/CppunitTest_emfio_emf_test.mk @@ -7,31 +7,31 @@ # file, You can obtain one at http://mozilla.org/MPL/2.0/. # -$(eval $(call gb_CppunitTest_CppunitTest,emfio)) +$(eval $(call gb_CppunitTest_CppunitTest,emfio_emf)) -$(eval $(call gb_CppunitTest_set_componentfile,emfio,emfio/emfio)) +$(eval $(call gb_CppunitTest_set_componentfile,emfio_emf,emfio/emfio)) -$(eval $(call gb_CppunitTest_set_include,emfio,\ +$(eval $(call gb_CppunitTest_set_include,emfio_emf,\ $$(INCLUDE) \ -I$(SRCDIR)/emfio/inc \ )) -$(eval $(call gb_CppunitTest_use_externals,emfio,\ +$(eval $(call gb_CppunitTest_use_externals,emfio_emf,\ boost_headers \ libxml2 \ )) -$(eval $(call gb_CppunitTest_add_exception_objects,emfio,\ +$(eval $(call gb_CppunitTest_add_exception_objects,emfio_emf,\ emfio/qa/cppunit/emf/EmfImportTest \ )) -$(eval $(call gb_CppunitTest_use_sdk_api,emfio)) +$(eval $(call gb_CppunitTest_use_sdk_api,emfio_emf)) -$(eval $(call gb_CppunitTest_use_library_objects,emfio,\ +$(eval $(call gb_CppunitTest_use_library_objects,emfio_emf,\ emfio \ )) -$(eval $(call gb_CppunitTest_use_libraries,emfio,\ +$(eval $(call gb_CppunitTest_use_libraries,emfio_emf,\ basegfx \ drawinglayer \ cppu \ @@ -46,10 +46,10 @@ $(eval $(call gb_CppunitTest_use_libraries,emfio,\ utl \ )) -$(eval $(call gb_CppunitTest_use_ure,emfio)) -$(eval $(call gb_CppunitTest_use_vcl,emfio)) +$(eval $(call gb_CppunitTest_use_ure,emfio_emf)) +$(eval $(call gb_CppunitTest_use_vcl,emfio_emf)) -$(eval $(call gb_CppunitTest_use_components,emfio,\ +$(eval $(call gb_CppunitTest_use_components,emfio_emf,\ configmgr/source/configmgr \ dtrans/util/mcnttype \ framework/util/fwk \ @@ -63,6 +63,6 @@ $(eval $(call gb_CppunitTest_use_components,emfio,\ unotools/util/utl \ )) -$(eval $(call gb_CppunitTest_use_configuration,emfio)) +$(eval $(call gb_CppunitTest_use_configuration,emfio_emf)) # vim: set noet sw=4 ts=4: diff --git a/emfio/CppunitTest_emfio_wmf_test.mk b/emfio/CppunitTest_emfio_wmf_test.mk index 82f53ce2f3fe..c24dd19acfef 100644 --- a/emfio/CppunitTest_emfio_wmf_test.mk +++ b/emfio/CppunitTest_emfio_wmf_test.mk @@ -7,32 +7,32 @@ # file, You can obtain one at http://mozilla.org/MPL/2.0/. # -$(eval $(call gb_CppunitTest_CppunitTest,emfio)) +$(eval $(call gb_CppunitTest_CppunitTest,emfio_wmf)) -$(eval $(call gb_CppunitTest_set_componentfile,emfio,emfio/emfio)) +$(eval $(call gb_CppunitTest_set_componentfile,emfio_wmf,emfio/emfio)) -$(eval $(call gb_CppunitTest_set_include,emfio,\ +$(eval $(call gb_CppunitTest_set_include,emfio_wmf,\ $$(INCLUDE) \ -I$(SRCDIR)/emfio/inc \ )) -$(eval $(call gb_CppunitTest_use_externals,emfio,\ +$(eval $(call gb_CppunitTest_use_externals,emfio_wmf,\ boost_headers \ libxml2 \ $(if $(filter PDFIUM,$(BUILD_TYPE)),pdfium) \ )) -$(eval $(call gb_CppunitTest_add_exception_objects,emfio, \ +$(eval $(call gb_CppunitTest_add_exception_objects,emfio_wmf, \ emfio/qa/cppunit/wmf/wmfimporttest \ )) -$(eval $(call gb_CppunitTest_use_sdk_api,emfio)) +$(eval $(call gb_CppunitTest_use_sdk_api,emfio_wmf)) -$(eval $(call gb_CppunitTest_use_library_objects,emfio, \ +$(eval $(call gb_CppunitTest_use_library_objects,emfio_wmf, \ emfio \ )) -$(eval $(call gb_CppunitTest_use_libraries,emfio,\ +$(eval $(call gb_CppunitTest_use_libraries,emfio_wmf,\ $(call gb_Helper_optional,BREAKPAD, \ crashreport) \ basegfx \ @@ -58,7 +58,7 @@ $(eval $(call gb_CppunitTest_use_libraries,emfio,\ xmlreader \ )) -$(eval $(call gb_CppunitTest_use_externals,emfio,\ +$(eval $(call gb_CppunitTest_use_externals,emfio_wmf,\ $(if $(filter LINUX MACOSX %BSD SOLARIS,$(OS)), \ curl) \ jpeg \ @@ -69,7 +69,7 @@ $(eval $(call gb_CppunitTest_use_externals,emfio,\ )) ifeq ($(OS),MACOSX) -$(eval $(call gb_CppunitTest_add_libs,emfio,\ +$(eval $(call gb_CppunitTest_add_libs,emfio_wmf,\ -framework IOKit \ -F/System/Library/PrivateFrameworks \ -framework CoreUI \ @@ -78,12 +78,12 @@ $(eval $(call gb_CppunitTest_add_libs,emfio,\ endif ifeq ($(ENABLE_JAVA),TRUE) -$(eval $(call gb_CppunitTest_use_libraries,emfio,\ +$(eval $(call gb_CppunitTest_use_libraries,emfio_wmf,\ jvmaccess \ )) endif -$(eval $(call gb_CppunitTest_use_externals,emfio,\ +$(eval $(call gb_CppunitTest_use_externals,emfio_wmf,\ gio \ graphite \ harfbuzz \ @@ -91,30 +91,30 @@ $(eval $(call gb_CppunitTest_use_externals,emfio,\ lcms2 \ )) ifeq ($(ENABLE_HEADLESS),) -$(eval $(call gb_CppunitTest_use_externals,emfio,\ +$(eval $(call gb_CppunitTest_use_externals,emfio_wmf,\ epoxy \ )) endif ifeq ($(OS),MACOSX) -$(eval $(call gb_CppunitTest_use_system_darwin_frameworks,emfio,\ +$(eval $(call gb_CppunitTest_use_system_darwin_frameworks,emfio_wmf,\ ApplicationServices \ )) -$(eval $(call gb_CppunitTest_use_system_darwin_frameworks,emfio,\ +$(eval $(call gb_CppunitTest_use_system_darwin_frameworks,emfio_wmf,\ $(if $(filter X86_64,$(CPUNAME)),,QuickTime) \ Cocoa \ Carbon \ CoreFoundation \ )) ifneq ($(ENABLE_MACOSX_SANDBOX),TRUE) -$(eval $(call gb_CppunitTest_use_libraries,emfio,\ +$(eval $(call gb_CppunitTest_use_libraries,emfio_wmf,\ AppleRemote \ )) endif endif ifeq ($(USING_X11),TRUE) -$(eval $(call gb_CppunitTest_use_externals,emfio,\ +$(eval $(call gb_CppunitTest_use_externals,emfio_wmf,\ cairo \ cups \ dbus \ @@ -125,14 +125,14 @@ $(eval $(call gb_CppunitTest_use_externals,emfio,\ endif ifeq ($(ENABLE_HEADLESS),TRUE) -$(eval $(call gb_CppunitTest_use_externals,emfio,\ +$(eval $(call gb_CppunitTest_use_externals,emfio_wmf,\ cairo \ freetype \ fontconfig \ )) else ifeq ($(OS),LINUX) -$(eval $(call gb_CppunitTest_add_libs,emfio,\ +$(eval $(call gb_CppunitTest_add_libs,emfio_wmf,\ -lm \ -ldl \ -lpthread \ @@ -142,12 +142,12 @@ endif endif ifeq ($(OS),ANDROID) -$(eval $(call gb_CppunitTest_add_libs,emfio,\ +$(eval $(call gb_CppunitTest_add_libs,emfio_wmf,\ -llog \ -landroid \ -llo-bootstrap \ )) -$(eval $(call gb_CppunitTest_use_externals,emfio,\ +$(eval $(call gb_CppunitTest_use_externals,emfio_wmf,\ cairo \ fontconfig \ freetype \ @@ -156,14 +156,14 @@ $(eval $(call gb_CppunitTest_use_externals,emfio,\ endif ifeq ($(OS),IOS) -$(eval $(call gb_CppunitTest_use_system_darwin_frameworks,emfio,\ +$(eval $(call gb_CppunitTest_use_system_darwin_frameworks,emfio_wmf,\ UIKit \ CoreFoundation \ )) endif ifeq ($(OS),WNT) -$(eval $(call gb_CppunitTest_use_system_win32_libs,emfio,\ +$(eval $(call gb_CppunitTest_use_system_win32_libs,emfio_wmf,\ advapi32 \ crypt32 \ gdi32 \ @@ -183,7 +183,7 @@ $(eval $(call gb_CppunitTest_use_system_win32_libs,emfio,\ endif ifeq ($(OS), $(filter LINUX %BSD SOLARIS, $(OS))) -$(eval $(call gb_CppunitTest_add_libs,emfio,\ +$(eval $(call gb_CppunitTest_add_libs,emfio_wmf,\ -lm $(DLOPEN_LIBS) \ -lpthread \ -lX11 \ @@ -191,27 +191,27 @@ $(eval $(call gb_CppunitTest_add_libs,emfio,\ )) endif -$(eval $(call gb_CppunitTest_use_ure,emfio)) +$(eval $(call gb_CppunitTest_use_ure,emfio_wmf)) -$(eval $(call gb_CppunitTest_use_components,emfio,\ +$(eval $(call gb_CppunitTest_use_components,emfio_wmf,\ configmgr/source/configmgr \ i18npool/util/i18npool \ ucb/source/core/ucb1 \ unotools/util/utl \ )) -$(eval $(call gb_CppunitTest_use_configuration,emfio)) +$(eval $(call gb_CppunitTest_use_configuration,emfio_wmf)) # See gb_CppunitTest__use_vcl (solenv/gbuild/CppunitTest.mk; headless): ifeq ($(USING_X11),TRUE) -$(call gb_CppunitTest_get_target,emfio): \ +$(call gb_CppunitTest_get_target,emfio_wmf): \ $(call gb_Library_get_target,desktop_detector) endif # Hack to suppress ASan ODR violation warnings about symbols present in both the # vcl objects linked into this test library and the vcl library (which gets # dynamically loaded during the test): -$(call gb_CppunitTest_get_target,emfio): \ +$(call gb_CppunitTest_get_target,emfio_wmf): \ EXTRA_ENV_VARS := \ ASAN_OPTIONS="$${ASAN_OPTIONS+$$ASAN_OPTIONS:}"detect_odr_violation=0 diff --git a/emfio/source/reader/emfreader.cxx b/emfio/source/reader/emfreader.cxx index 158f5bdcbfd7..dc8ffdee523f 100644 --- a/emfio/source/reader/emfreader.cxx +++ b/emfio/source/reader/emfreader.cxx @@ -18,16 +18,14 @@ */ #include <emfreader.hxx> - #include <osl/endian.h> #include <basegfx/matrix/b2dhommatrix.hxx> #include <vcl/dibtools.hxx> #include <o3tl/make_unique.hxx> - +#include <tools/stream.hxx> #include <memory> #ifdef DBG_UTIL -#include <tools/stream.hxx> #include <vcl/pngwrite.hxx> #endif @@ -456,6 +454,17 @@ namespace emfio mpInputStream->SeekRel(nRemainder); } + // these are referenced from inside the templates + SvStream& operator >> (SvStream& rStream, sal_Int16 &n) + { + return rStream.ReadInt16(n); + } + + SvStream& operator >> (SvStream& rStream, sal_Int32 &n) + { + return rStream.ReadInt32(n); + } + /** * Reads polygons from the stream. * The \<class T> parameter is for the type of the points (sal_uInt32 or sal_uInt16). @@ -544,18 +553,6 @@ namespace emfio } } - // these are referenced from inside the templates - - SvStream& operator>>(SvStream& rStream, sal_Int16 &n) - { - return rStream.ReadInt16(n); - } - - SvStream& operator>>(SvStream& rStream, sal_Int32 &n) - { - return rStream.ReadInt32(n); - } - /** * Reads a poly polygon from the WMF file and draws it. * The \<class T> parameter refers to the type of the points. (e.g. sal_uInt16 or sal_uInt32) diff --git a/emfio/source/reader/wmfreader.cxx b/emfio/source/reader/wmfreader.cxx index d71e234826d9..43a51372ee4f 100644 --- a/emfio/source/reader/wmfreader.cxx +++ b/emfio/source/reader/wmfreader.cxx @@ -114,7 +114,7 @@ namespace { - static void GetWinExtMax(const Point& rSource, tools::Rectangle& rPlaceableBound, const sal_Int16 nMapMode) + void GetWinExtMax(const Point& rSource, tools::Rectangle& rPlaceableBound, const sal_Int16 nMapMode) { Point aSource(rSource); if (nMapMode == MM_HIMETRIC) @@ -129,7 +129,7 @@ namespace rPlaceableBound.Bottom() = aSource.Y(); } - static void GetWinExtMax(const tools::Rectangle& rSource, tools::Rectangle& rPlaceableBound, const sal_Int16 nMapMode) + void GetWinExtMax(const tools::Rectangle& rSource, tools::Rectangle& rPlaceableBound, const sal_Int16 nMapMode) { GetWinExtMax(rSource.TopLeft(), rPlaceableBound, nMapMode); GetWinExtMax(rSource.BottomRight(), rPlaceableBound, nMapMode); |