summaryrefslogtreecommitdiff
path: root/include/svx/svdhdl.hxx
diff options
context:
space:
mode:
Diffstat (limited to 'include/svx/svdhdl.hxx')
-rw-r--r--include/svx/svdhdl.hxx2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/svx/svdhdl.hxx b/include/svx/svdhdl.hxx
index 9214f5acd8ec..f93386efd757 100644
--- a/include/svx/svdhdl.hxx
+++ b/include/svx/svdhdl.hxx
@@ -270,7 +270,7 @@ public:
bool IsUseLuminance() const { return bUseLuminance; }
- Color GetColor() const { return aMarkerColor; }
+ const Color& GetColor() const { return aMarkerColor; }
void SetColor(Color aNew, bool bCallLink = false);
void SetSize(const Size& rNew);
7&id=d2b3ea4d377bf05830f6eb11d53fd55ea6b435fc'>loplugin:useuniqueptr in sfx2Noel Grandin Change-Id: I7b406cd07cae579de608faa3ec47dd1190dea411 Reviewed-on: https://gerrit.libreoffice.org/60003 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2018-04-18tdf#42949 Remove unnecessary localization headers of sfx2Gabor Kelemen Found by searching for the header names and the localization functions: git grep -l -e \<sfx2/sfxresid.hxx\> -e \<sfx2/strings.hrc\> | xargs grep -c -e SfxResId -e GetResString | grep :0$ | grep -v /pch Change-Id: If0571ae4029b5fb2699cdd6ea768d3cd240bdce3 Reviewed-on: https://gerrit.libreoffice.org/53073 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> 2018-02-01tdf#42949 Remove unneeded helpids.h headers (2/3)Gabor Kelemen A side effect of the .ui migration is that we use a lot less HIDs in the code. A lot of files still contain helpids.h includes even if no actual HID is referenced. This cleans up directories r* - svx*. Found with: git grep helpids.h | cut -d : -f 1 | xargs grep -c HID_ | grep :0$ Change-Id: I81bdb80161b0207f5df651eb17c58caef44250d3 Reviewed-on: https://gerrit.libreoffice.org/46869 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> 2018-01-15More loplugin:cstylecast: sfx2Stephan Bergmann Change-Id: Ifdb964558f070e7c9ee87eabeaafa5c3c079c0c9 2018-01-12More loplugin:cstylecast: sfx2Stephan Bergmann auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: Ia3bed56999f3d684f706ce0bd5be8a2269b06d22 2017-12-11loplugin:salcall fix functionsNoel Grandin since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2017-11-09new loplugin simplifydynamiccastNoel Grandin simplify dynamic_cast followed by static_cast Change-Id: I965afcf05d1675094cfde53d3590a0fd00f26279 Reviewed-on: https://gerrit.libreoffice.org/44460 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> 2017-10-23loplugin:includeform: sfx2Stephan Bergmann Change-Id: I5e9a7a2580a710880023288f5ed3584708c4769d 2017-10-01Wayland: Make various popups work in the overflow toolbarMaxim Monastirsky Were failing to show, with this warning: Gdk-WARNING **: Tried to map a popup with a non-top most parent Change-Id: Ib68b5fc9b3edb3d25a23b66397c13833a4d080ac Reviewed-on: https://gerrit.libreoffice.org/42936 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com> 2017-08-08loplugin:unusedmethodsNoel Grandin Change-Id: Id66cf12e3a59aeed1b9a7a111b841e30b248635b Reviewed-on: https://gerrit.libreoffice.org/40876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2017-07-21loplugin:constparams in sfx2Noel Grandin Change-Id: Id982c8fb5654433e9db10e2da6a86a6c8d90b9b4 Reviewed-on: https://gerrit.libreoffice.org/40261 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2017-07-21de-hrc various thingsCaolán McNamara e.g. helpid[s].hrc -> helpids.h and insert include guards where missing move "ordinary" defines into .hxx files remove .hrc entries that are used as arguments to dialog factory when a dedicated method can be added instead Change-Id: I792fb8eb0adfaa63cf354e6e57401fc943e9196e 2017-06-21loplugin:unusedfields in sfx2 part2Noel Grandin Change-Id: I227b643641250d47ac6b2218f57ddb231765960e Reviewed-on: https://gerrit.libreoffice.org/39038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2017-06-12cleanup unused css/frame/* includesJochen Nitschke Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65 Reviewed-on: https://gerrit.libreoffice.org/38633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2017-06-06Eliminate dynamic_cast<const SfxVoidItem*>, use SfxPoolItem::IsVoidItem()Eike Rathke Change-Id: I09dafffd64dd107e802d016494d884f32363521a 2017-05-07revert OSL_ASSERT changesChris Sherlock Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380 2017-05-07tdf#43157: convert sfx2 module away from OSL_ASSERT to assertChris Sherlock Change-Id: I3facbef60a0d629db8f3028dd1b9f38e8f17e83e 2017-04-23Replace GetImage with CommandInfoProvider::GetImageForCommandMaxim Monastirsky And move ToolBoxButtonSize->ImageType mapping code to a common place. Change-Id: If158f4b6f2750054fcf64491c2941706e7d3a329 2017-01-26Remove dynamic exception specificationsStephan Bergmann ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> 2017-01-19use rtl::Reference in SfxPopupWindowNoel Grandin instead of storing both a raw pointer and an uno::Reference Change-Id: I8fc679cd22f2ac24fb3f1c71939318921c1d674b 2017-01-17replace #ifdef SOLARIS with #ifdef __sunMichael Stahl Check for a macro that is defined by the compiler, we don't really need one defined by the build system. Change-Id: Iccb8e3198396881395c97a6b81690ebe64b7e9d2