summaryrefslogtreecommitdiff
path: root/oox/source
diff options
context:
space:
mode:
Diffstat (limited to 'oox/source')
0 files changed, 0 insertions, 0 deletions
eviewed-on: https://gerrit.libreoffice.org/c/core/+/171054 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> 2024-05-13Revert "reduce symbol visibility in sw"Thorsten Behrens This reverts commit 1a6711276f0c8abeb0028a47cc345a7453374a38. After some discussion and experiments, it turned out this rather fundamentally breaks clang's PCH build. Conclusion was: this change is not significant enough to warrant making life harder for developers. Excerpt of errors (affected were vbaswobj, msword & swui libs): - ld.lld: error: undefined symbol: SwFormat::~SwFormat() >>> referenced by fmtcol.hxx:37 (sw/inc/fmtcol.hxx:37) >>> core/workdir/CxxObject/sw/inc/pch/precompiled_vbaswobj.o:(SwFormatColl::~SwFormatColl()) - ld.lld: error: undefined symbol: SwFrameFormat::SetPositionLayoutDir(short) >>> referenced by precompiled_msword.cxx >>> core/workdir/CxxObject/sw/inc/pch/precompiled_msword.o:(vtable for sw::SpzFrameFormat) - ld.lld: error: undefined symbol: SwFrameFormat::SetLayoutDir(SwFrameFormat::tLayoutDir) >>> referenced by precompiled_swui.cxx >>> core/workdir/CxxObject/sw/inc/pch/precompiled_swui.o:(vtable for sw::SpzFrameFormat) Change-Id: I1dcf115cc191b1ebf1f8d5023c0c5015f891287a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167549 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> 2024-03-13reduce symbol visibility in swNoel Grandin Change-Id: Ib3edefc365d3c605c3024e160572fa4030100ef1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164724 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2024-03-05make more symbols private in writerNoel Grandin Change-Id: I2c4745910fc3654f2021e77f9fa590d3da3464ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163749 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2024-02-14tdf#159565 prerequisite: make hidden sections have zero-height framesMike Kaganski As mentioned in commit bb733957dd39e6f0b9d80bb59eb0177188794797 (tdf#114973 sw: enable SelectAll with hidden para at start/end, 2023-01-27), the hidden sections didn't have frames. That prevented correct handling of the case when such a frame was in the beginning of the document. This change re-implements the hidden section to use 0-height frames, like hidden paragraphs, as a pre-requisite for a follow-up change. Some layout breakages noticed while working on this are unit-tested now. This change needed to handle the case when the first section is hidden, and then goes a page break with page style. In this case, the page style must apply to the very first page of the document. Implementing this now, when the frame that defines the page style is not the first in the document, I accidentally fixed also the previously broken case when the first paragraph was hidden. Now the page style defined in the second paragraph's page break will apply correctly. This change makes hidden sections break outer section's frames. This means that when text borders are shown, there will be an artifact in the place of the hidden sections (a horizontal line breaking outer frame). I suppose it's not a problem, actually helping to see the layout better, so in line with the "show text borders" helper functionality. If this proves to be problematic, this can be handled specially in a follow-up. Change-Id: I14ebf0559b463186aba28902cd10c5cc978ba456 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163151 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> 2023-09-27pass SwAttrSet around explicitlyNoel Grandin instead of using SfxItemSet and static_cast'ing it everywhere Change-Id: I12d1a6bd2dec7035fa16206ea01346a3a73c1457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157309 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2023-08-23tdf#156116 - A11Y - fix object name does not update in accessibility sidebarBalazs Varga when we modify the name on the Navigator sidebar. Update the related accessibility issue after we modify the name on the sidebar. Change-Id: I8f4b8780ff1ffe7cfb86ff837c9579d6b785b832 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155904 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> 2023-06-29Simplify a bitMike Kaganski Change-Id: Ia1c142d9841075f307fba69f79999697992a5c5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153735 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> 2023-01-17sw: document SwSectionNodeMiklos Vajna Note how all the table cells, sections, flys etc have low-level sections, but only the UI-level section's start node is called a section node. Change-Id: I730f17b3a63c9e49ee099f82aa39f7a55b2da3fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145634 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> 2022-11-25tdf#141438 Clean old comments //FEATURE::CONDCOLLBogdan B Change-Id: I350a9c0a033edddf805170534561b6dca0bf5ae0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143172 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> 2022-11-18Fix typoAndrea Gelmini Change-Id: Id63d9cbd5c224904c852249cb5aee7509136166b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142909 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> 2022-11-18sw: handle joining and splitting nodes for online a11y checkTomaž Vajngerl Change-Id: I706bf56209beebbe2987bce436536c3d9ade51f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142655 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> 2022-11-18sw: add a menu option to enable/disable online a11y checkTomaž Vajngerl Change-Id: I656037ef4e40e7c79daef5dd73f8f10c9818ac25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142215 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> 2022-11-17sw: Change online a11y checker again from SwContentNode to SwNodeTomaž Vajngerl This is needed because SwTableNode is not a content node, so we need to work with the most generic SwNode and ask if the node derives from sw::BroadcastingModify, which is required for node tracking (SwTableNode and SwContentNode support that). Change-Id: Idc28a5a9f1f8a250e2a28bb955ed320d02b6c1b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141787 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> 2022-11-16Fix typoAndrea Gelmini Change-Id: I64295144d0fb0bd1b07d06dd7a51a670deb0a7df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142732 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> 2022-11-15sw: Run a11y check for all content nodesTomaž Vajngerl Change-Id: Icc3ff1be31a01b22242c48dec6d830e645ecb310 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141784 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> 2022-10-22loplugin:unusedmethodsNoel Grandin Change-Id: I3c94d68cb85adc2005a5a5e3b03a311732f782c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141617 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2022-10-07use more SwPositionNoel Grandin part of the process of hiding the internals of SwPosition Change-Id: I3107ad6cb8636125ec98342ec4ed69d2c703a74b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2022-09-23add a new SwContentNode::GoNext variantNoel Grandin that takes a SwPosition and keeps the nNode and nContent fields there in sync. this is part of the process of hiding the internals of SwPosition. Change-Id: I1996e588703ca2400fa84e979c72cc5382e5b700 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140435 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2022-09-20add CanJoinNext method that takes a SwPosition*Noel Grandin part of the process of hiding the internals of SwPosition Change-Id: I401fa4d98a2e53a082bfb39f3d13315261a0a2ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140246 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2022-08-26make the parameter to SwTableNode::MakeOwnFrames optionalNoel Grandin since most of the call sites seem to be just creating a temporary and then ignoring it Change-Id: Ia50cdd4ce5eca665351d3f76e395178bab827b08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138879 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2022-08-23asserts unnecessary for SwNode::operator==Noel Grandin since we're directly comparing pointers. Various places are already comparing SwNodeIndex from different documents like this, so this doesn't make the code any looser than before. Change-Id: Ic8feacee67b9495649ffc9560ce105078850a677 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138701 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2022-08-17add comparison operators for SwNodeNoel Grandin which will make it easier when I do more conversion of code doing stuff like rPos.nNode == to rPos.GetNode() == Add an assert to make sure we are talking about nodes from the same parent node array. Change-Id: I12011768d67e7fbe5a87663c661a5cc444f1deb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138320 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2022-08-13pass SwNode instead of SwNodeIndex to SwNode constructorsNoel Grandin part of the process of hiding the internals of SwPosition Change-Id: I0b2dd3e24c82c1551a7275ffc78991823354858a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138224 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2022-07-26convert CRSR_SKIP_* to typed enumNoel Grandin Change-Id: Ia5cb9915fc7ad3238f4386f5ed3e43efc4b74a32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137478 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2022-07-25rename SwIndex->SwContentIndexNoel Grandin to help my poor brain with the different kinds of index we have floating around Change-Id: I47ed223922170687d7e07812445aed66b3218230 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137404 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2022-07-25SwIndex/SwIndexReg is only used to deal with SwContentNodesNoel Grandin so make that apparent in the type system and naming, instead of implicit. Which requires adding a small helper class for the one place we were instantiating an SwIndexReg by itselg Change-Id: I74db37239aed0005e5a2a01916635fa93de638f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137403 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2022-06-10sw doc model xml dump: show table row propertiesMiklos Vajna Also extract SwTableNode::dumpAsXml() from SwStartNode::dumpAsXml(), ideally dumpAsXml() should only dump own members, not members of other classes. Change-Id: I5ef3e90d0cdd23ba44c192de1802844acad64cc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135575 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> 2022-02-08add template versions of SwContentNode::GetAttrNoel Grandin Change-Id: I62c0d54c9e1dc89c5684210075219c1eeee9f942 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129602 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2021-12-01sw doc model xml dump: show the format of section nodesMiklos Vajna The SwSectionNode has an SwSection, which is registered in an SwSectionFormat, which finally tells us if it's a protected one. Change-Id: Ie46c516f900f1c479c11cbbaf061973400614a2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126151 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>