diff options
Diffstat (limited to 'sc')
-rw-r--r-- | sc/source/filter/oox/worksheetbuffer.cxx | 2 | ||||
-rw-r--r-- | sc/source/ui/dbgui/pfiltdlg.cxx | 6 | ||||
-rw-r--r-- | sc/source/ui/miscdlgs/optsolver.cxx | 8 | ||||
-rw-r--r-- | sc/source/ui/view/gridwin.cxx | 5 |
4 files changed, 12 insertions, 9 deletions
diff --git a/sc/source/filter/oox/worksheetbuffer.cxx b/sc/source/filter/oox/worksheetbuffer.cxx index e4319194e785..8104f367ead7 100644 --- a/sc/source/filter/oox/worksheetbuffer.cxx +++ b/sc/source/filter/oox/worksheetbuffer.cxx @@ -234,7 +234,7 @@ void WorksheetBuffer::finalizeImport( sal_Int16 nActiveSheet ) { ScDocument& rDoc = getScDocument(); - for ( auto aSheetInfo: maSheetInfos ) + for ( const auto& aSheetInfo: maSheetInfos ) { // make sure at least 1 sheet (the active one) is visible if ( aSheetInfo->mnCalcSheet == nActiveSheet) diff --git a/sc/source/ui/dbgui/pfiltdlg.cxx b/sc/source/ui/dbgui/pfiltdlg.cxx index c7c8b758c9ca..6de187cfe378 100644 --- a/sc/source/ui/dbgui/pfiltdlg.cxx +++ b/sc/source/ui/dbgui/pfiltdlg.cxx @@ -107,9 +107,9 @@ void ScPivotFilterDlg::dispose() m_pBtnRegExp.clear(); m_pBtnUnique.clear(); m_pFtDbArea.clear(); - for (auto a : aValueEdArr) a.clear(); - for (auto a : aFieldLbArr) a.clear(); - for (auto a : aCondLbArr) a.clear(); + for (auto& a : aValueEdArr) a.clear(); + for (auto& a : aFieldLbArr) a.clear(); + for (auto& a : aCondLbArr) a.clear(); ModalDialog::dispose(); } diff --git a/sc/source/ui/miscdlgs/optsolver.cxx b/sc/source/ui/miscdlgs/optsolver.cxx index 76eac3a7538b..0744602ca764 100644 --- a/sc/source/ui/miscdlgs/optsolver.cxx +++ b/sc/source/ui/miscdlgs/optsolver.cxx @@ -346,13 +346,13 @@ void ScOptSolverDlg::dispose() m_pBtnCancel.clear(); m_pBtnSolve.clear(); mpEdActive.clear(); - for (auto p : mpLeftButton) + for (auto& p : mpLeftButton) p.clear(); - for (auto p : mpRightButton) + for (auto& p : mpRightButton) p.clear(); - for (auto p : mpOperator) + for (auto& p : mpOperator) p.clear(); - for (auto p : mpDelButton) + for (auto& p : mpDelButton) p.clear(); ScAnyRefDlg::dispose(); } diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx index ecfd538ad142..bb1ae4311d43 100644 --- a/sc/source/ui/view/gridwin.cxx +++ b/sc/source/ui/view/gridwin.cxx @@ -5953,8 +5953,11 @@ static void updateLibreOfficeKitSelection(ScViewData* pViewData, ScDrawLayer* pD Rectangle aBoundingBox; std::vector<OString> aRectangles; - for (auto aRectangle : rRectangles) + for (const auto& rRectangle : rRectangles) { + // We explicitly create a copy, since we need to expand + // the rectangle before coordinate conversion + Rectangle aRectangle(rRectangle); aRectangle.Right() += 1; aRectangle.Bottom() += 1; |