diff options
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/source/generic/fract.cxx | 31 |
1 files changed, 1 insertions, 30 deletions
diff --git a/tools/source/generic/fract.cxx b/tools/source/generic/fract.cxx index 1a78d4dfc654..d50cffc990aa 100644 --- a/tools/source/generic/fract.cxx +++ b/tools/source/generic/fract.cxx @@ -112,8 +112,6 @@ Fraction::Fraction( double dVal ) : mpImpl(new Impl) try { mpImpl->value = rational_FromDouble( dVal ); - if ( HasOverflowValue() ) - throw boost::bad_rational(); mpImpl->valid = true; } catch (const boost::bad_rational&) @@ -127,15 +125,6 @@ Fraction::~Fraction() { } -bool Fraction::HasOverflowValue() -{ - //coverity[result_independent_of_operands] - return mpImpl->value.numerator() < std::numeric_limits<sal_Int32>::min() || - mpImpl->value.numerator() > std::numeric_limits<sal_Int32>::max() || - mpImpl->value.denominator() < std::numeric_limits<sal_Int32>::min() || - mpImpl->value.denominator() > std::numeric_limits<sal_Int32>::max(); -} - Fraction::operator double() const { if (!mpImpl->valid) @@ -164,12 +153,6 @@ Fraction& Fraction::operator += ( const Fraction& rVal ) mpImpl->value += rVal.mpImpl->value; - if ( HasOverflowValue() ) - { - mpImpl->valid = false; - SAL_WARN( "tools.fraction", "'operator +=' detected overflow" ); - } - return *this; } @@ -186,12 +169,6 @@ Fraction& Fraction::operator -= ( const Fraction& rVal ) mpImpl->value -= rVal.mpImpl->value; - if ( HasOverflowValue() ) - { - mpImpl->valid = false; - SAL_WARN( "tools.fraction", "'operator -=' detected overflow" ); - } - return *this; } @@ -231,7 +208,7 @@ Fraction& Fraction::operator *= ( const Fraction& rVal ) bool bFail = checked_multiply_by(mpImpl->value, rVal.mpImpl->value); - if (bFail || HasOverflowValue()) + if (bFail) { mpImpl->valid = false; } @@ -252,12 +229,6 @@ Fraction& Fraction::operator /= ( const Fraction& rVal ) mpImpl->value /= rVal.mpImpl->value; - if ( HasOverflowValue() ) - { - mpImpl->valid = false; - SAL_WARN( "tools.fraction", "'operator /=' detected overflow" ); - } - return *this; } |