diff options
Diffstat (limited to 'vcl/skia/x11/gdiimpl.cxx')
| -rw-r--r-- | vcl/skia/x11/gdiimpl.cxx | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/vcl/skia/x11/gdiimpl.cxx b/vcl/skia/x11/gdiimpl.cxx index 635beb1edb09..9b93a603dc38 100644 --- a/vcl/skia/x11/gdiimpl.cxx +++ b/vcl/skia/x11/gdiimpl.cxx @@ -91,10 +91,14 @@ X11SkiaSalGraphicsImpl::createWindowContext(Display* display, Drawable drawable, switch (renderMethod) { case SkiaHelper::RenderRaster: - // TODO The Skia Xlib code actually requires the non-native color type to work properly. + // Make sure we ask for color type that matches the X11 visual. If red mask + // is larger value than blue mask, then on little endian this means blue is first. + // This should also preferably match SK_R32_SHIFT set in config_skia.h, as that + // improves performance, the common setup seems to be BGRA (possibly because of + // choosing OpenGL-capable visual). displayParams.fColorType - = (displayParams.fColorType == kBGRA_8888_SkColorType ? kRGBA_8888_SkColorType - : kBGRA_8888_SkColorType); + = (visual->red_mask > visual->blue_mask ? kBGRA_8888_SkColorType + : kRGBA_8888_SkColorType); return sk_app::window_context_factory::MakeRasterForXlib(winInfo, displayParams); case SkiaHelper::RenderVulkan: return sk_app::window_context_factory::MakeVulkanForXlib(winInfo, displayParams); |