summaryrefslogtreecommitdiff
path: root/.gitreview
AgeCommit message (Expand)Author
2019-05-15git-review: Use the hostname instead of alias.Jan Holesovsky
2012-07-06git-review integration: .gitreview for core repository addedDavid Ostrovsky
generated by cgit (git 2.34.1) at 2024-07-15 20:56:11 +0000
>dnd/source.cxx
AgeCommit message (Collapse)Author
2017-09-30Use explicit function names for fooA/fooW WinAPI; prefer fooWMike Kaganski
We should only use generic foo function name when it takes params that are also dependent on UNICODE define, like LoadCursor( nullptr, IDC_ARROW ) where IDC_ARROW is defined in MSVC headers synchronised with LoadCursor definition. We should always use Unicode API for any file paths operations, because otherwise we will get "?" for any character in path that is not in current non-unicode codepage, which will result in failed file operations. Change-Id: I3a7f453ca0f893002d8a9764318919709fd8b633 Reviewed-on: https://gerrit.libreoffice.org/42935 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-03-25Fix typosAndrea Gelmini
Change-Id: I85214642167d9c7876fd0fdc2cb7cf8e85765614 Reviewed-on: https://gerrit.libreoffice.org/35627 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-02-10Remove MinGW supportStephan Bergmann
In OOo times, there'd originally been efforts to allow building on Windows with MinGW. Later, in LO times, this has been shifted to an attempt of cross- compiling for Windows on Linux. That attempt can be considered abandoned, and the relevant code rotting. Due to this heritage, there are now three kinds of MinGW-specific code in LO: * Code from the original OOo native Windows effort that is no longer relevant for the LO cross-compilation effort, but has never been removed properly. * Code from the original OOo native Windows effort that is re-purposed for the LO cross-compilation effort. * Code that has been added specifially for the LO cross-compilation effort. All three kinds of code are removed. (An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing --with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.) Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568 Reviewed-on: https://gerrit.libreoffice.org/34127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-11loplugin:externvar (clang-cl)Stephan Bergmann
Change-Id: I7219f2e720b7c1581c59cefe39e152c5aa20a8fe
2016-10-16clang-cl loplugin: dtransStephan Bergmann
Change-Id: I1d55f3e7ecbde486f318d5175b1570f0caa33255 Reviewed-on: https://gerrit.libreoffice.org/29870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-04-Werror,-Wnon-virtual-dtorStephan Bergmann
Why was CDTransObjFactory a class with virtual functions in the first place? Change-Id: I315243a2268be67e03feb923ca7f64fd37818337
2015-07-28tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants in dtrans. Change-Id: Ia7e3c37681c763089dd31c861854a9b500996305 Reviewed-on: https://gerrit.libreoffice.org/17318 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-15Fix typosAndrea Gelmini
Change-Id: Id05ea8cf8aed878bedfe73c274df3c67b64bad37 Reviewed-on: https://gerrit.libreoffice.org/16263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2014-12-20TyposJulien Nabet
Change-Id: I3475be796cf2655d9b619b86c9686aeef4b97b82
2014-08-25set names on the Win32-only threadsMichael Stahl
Nice to see what weird threads are running. Change-Id: Ic9888aa3260d0aeb5858cde5415571ab23c75484
2014-02-04fdo#54938 Convert dtrans, remoteb., reportd., ucbhelper to cppu::supportsSer..Alexandre Vicenzi
Change-Id: I42cf7dc139b79b715f3c330f9bca7d333de8bafc Reviewed-on: https://gerrit.libreoffice.org/7762 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-11-19remove most use of RTL_CONSTASCII_USTRINGPARAM macroNoel Grandin
This is largely unnecessary when working with OUString Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-06-05use uno::Reference#clear() method...Noel Grandin
...instead of assigning an empty value. Reduces code noise. Change-Id: Ic95b081a41fb740a738c92b3407a9514ccb8b06e
2013-04-19remove unused component_canUnload functionsMatúš Kukan
Change-Id: Id3f41e2a620c47bb848718d0fc994739be2d64fc
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-03-04doubled includesThomas Arnhold
Change-Id: I70ec796188e2388e1e4d699126f7ae817f5ff86e
2013-02-12fdo#46808, use constructor for datatransfer::DataFormatTranslatorNoel Grandin
Change-Id: I68fd87ae71f764099b00b05a29cf5194d24da58d