summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-06-16tdf#134759 sw: clear items in SwAttrSet::CopyToModify()Michael Stahl
Setting new items but not clearing existing items smells like an obvious omission. Why would we want a union of two nodes' items? This improves things a bit for the bugdoc, but now it ends up with a different wrong list on the node 254. Change-Id: I3f5db0a4f81ac6e9af56d1faaefc2cb107dff597 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131841 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-06-16Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to c7fba791de12f34179bb355fedbc111f4112bde8 - tdf#149572 update "Left Paragraph Border" and "Right Paragraph Border tdf#149242 changed the Horizontal positioning labels in the "to" control from: "Left paragraph border" -> "Left of paragraph text area" and "Right paragraph border" -> "Right of paragraph text area" This patch updates the option names and makes corrections to in the description of the referent of these options. Change-Id: I604cb4354f239d476375791fa57865d10b1d0d24 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135881 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-06-16Next release is 7.5Samuel Mehrbrodt
According to 27ebceb366356f65c836e7edcc3609193f6e009c Change-Id: I0fe247ca398a3c4607840c1a190453c52204749b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135986 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2022-06-16Revert "enable Skia on big-endian too"Rene Engelhard
This reverts commit b06663135f9c7c08f5866a87a1fb0932df5af8bd. Still/Again fails to build. See https://lists.freedesktop.org/archives/libreoffice/2022-June/089026.html Change-Id: I195c1584256d1da5fee3bbd1d7291a6639428acf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135771 Tested-by: Jenkins Tested-by: René Engelhard <rene@debian.org> Reviewed-by: René Engelhard <rene@debian.org>
2022-06-16fail big-endian builds with --enable-skia. Point to --disable-skiaRene Engelhard
Change-Id: I0a1e5289a36e39eeea00e0fd67fbcf1fe7c902f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135772 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: René Engelhard <rene@debian.org> Reviewed-by: René Engelhard <rene@debian.org>
2022-06-16sc: uitest: move test where it belongsXisco Fauli
Change-Id: I59ce2a70622a6f3be112a5234a7d91d2efd372f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135996 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-16tdf#149524: fix crash in Writer after a label has just been createdJulien Nabet
see bt here: https://bugs.documentfoundation.org/attachment.cgi?id=180683 Change-Id: Iba461ffe65392a7e0e779f68d1f0737a444ae724 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135675 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-16tdf#149529 crash on deref deleted ScDocument*Caolán McNamara
maybe a problem since commit 46419cd7a2d453c6f252c28dfb9dbfb08605e1c4 Date: Tue Jun 18 15:11:30 2013 -0400 ScFormulaCell is no longer a child class of ScBaseCell. Change-Id: Id33072f193045e2eaf51373b47dac803f9a5d52c presumably the cloned ScColorScaleEntry should end up with a ScFormulaCell for the destination document and not the source one Change-Id: I451d5827be183198b61116ab8c582cfda03b2031 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135998 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-06-16sw HTML export, XHTML mode: fix lost <li> with a list header + itemMiklos Vajna
There is a general mismatch between XHTML and Writer lists: XHTML can only contain list items (for ordered or unordered lists), while Writer can contain list headers and list items. List headers have no bullet or number at the start, list items are the normal text nodes. Commit 8c2607ae3ce143586e623532b8ae5288277ec3ac (sw HTML export, XHTML mode: fix lost </li> when last list item is not numbered, 2022-02-21) fixed the list item end side of this problem: if all text nodes in a list are headers, then don't write ul/ol at all, otherwise end list headers with </li> as well to make sure the output XML is valid. However, this created a mis-match, the starting <li> for list headers in a list which have non-header text nodes at as was not adapted. Fix the problem by extending OutHTML_SwFormat() so list headers in a list with non-header text nodes always have a <li> and </li>, and this condition is the same on the start/end side. Calculating if at least one text node is non-header in a list may not be cheap, so reuse the already calculated info from OutHTML_NumberBulletListStart() in OutHTML_SwFormat(). Change-Id: I3817a489f16166fc5b4c33ee64e2283c41a4402c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135999 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-06-16drop special case for win 64bit download name, use x86-64 consistentlyChristian Lohmaier
"x64" was introduced in 2013 for the 64bit windows packages in efdad0b126abd3c151b545740d0530a0a832d482 for no apparent reason. Change-Id: Ifae4faaeb99b4e8950cc64bb993d29c0a3ff24dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135923 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-06-16BridgeFactory should be a singletonNoel Grandin
regression from commit 9be078ae0d4cc4e4c01952bb42c9bb5943bbde86 Date: Sat Jul 4 09:12:35 2020 +0200 binaryurp: create instances with uno constructors Change-Id: Ib7a7316fdee4afffac35b282adaf437ff8bdd009 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135904 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-16Resolves: tdf#149579 Expand Range.Sort single cell to Range.CurrentRegionEike Rathke
Change-Id: Ib0ab1c2d0dd45f35f43cf710f7c15791d282ad4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135997 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-06-16tdf#148072: sc: Add UItestXisco Fauli
Change-Id: Ibb03fc001db63ac8ba6624ab14d046f4ee1039d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135995 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-16tdf#128150 Add OOXML import/export for "use background fill"Samuel Mehrbrodt
and allow editing this fill property in area dlg Change-Id: Ic63ba11e9d499d4a0fb22f6739587e3e25140b8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134406 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-06-16make meType in ScCellValue privateNoel Grandin
as a first step to wrapping up the internals of this class and adding some asserts Change-Id: Ic13ddd917948dbf3fd6d73f44b8efcc727726baf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135994 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-16share ScSortedRangeCache between threadsLuboš Luňák
It's the same data for all threads, they access it as read-only, so it doesn't make sense for each thread to build its own copy. Change-Id: Ia1559c61d976bcce78661cae7e030bb8430aed7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135794 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-06-16Add precision to text orientation in extended tipOlivier Hallot
Change-Id: I9f2c6290baa6f251dba38c3a75e61c775d87fd5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135615 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-06-16tdf#149089 snap to grid if IsSnapToChars() is falseMark Hung
for non-CJK scripts. Non Asian text was centered within as many cells as required according to ODF1.2 20.301. But it also required that text should be snapped to grid if style:layout-grid-snap-to is true ( i.e. IsSnapToChars() is false ) per ODF1.2 20.305. That means ODF1.2 20.301 ruled. This patch changes the width of inserted SwKernGridPortion so that non-CJK text aligns to the edge of text grid to make ODF1.2 20.301 rule, an provide more consistent layout result as expected. Change-Id: Id6b4d2b965e20670eb9ddf657d36b8a49073f32a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135654 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2022-06-16One call to XCellRangeAddressable::getRangeAddress() is enoughEike Rathke
... each needs to obtain it via ScUnoConversion::FillApiRange(). Change-Id: Ie98d5130067701f40c441d08bdb9faf7913bcdb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135972 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-06-16tdf#125040 Recreate Contextual Single for WriterMaxim Monastirsky
Change-Id: I791631aedb9efbb7bbdc41234ee39e1d3c834ce1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135959 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-06-16tdf#125040 Avoid flickering on context changeMaxim Monastirsky
Change-Id: I442fada34e10fe13e68987abba34969a8ab50bc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135958 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-06-16crashreportScraper: use argparse to parse the argumentsXisco Fauli
Change-Id: Idc1d32683c5113042fe4e7ec97357b6d76c5217e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135973 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-16Fix typoAndrea Gelmini
Change-Id: I7ff6efac1edd171f65ebd901d8f03f38364496b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135927 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-06-16Fix typoAndrea Gelmini
Change-Id: I0ccce1c6e143b819dbb78d6fb74ccde8ce737f84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135928 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-06-16Fix typoAndrea Gelmini
Change-Id: I9b29e51e550ea9f13497e1f46cf4cdc11cf8faa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135925 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-06-16Fix typo in codeAndrea Gelmini
Change-Id: Ic2c07abd89361aaef0f216ee71d0fa8ce8529233 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135924 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-06-16fix download-filename for Windows aarch64 buildsChristian Lohmaier
was incorrectly using x64 Change-Id: Ieb7c90c6b1ed3abd73315a15c59490ea639954c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135922 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-06-16Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to a17fbdee73a7f567637c56a1b6354c0fef3b3a10 - tdf#149353 positioning objects in multipage and multicolumn paragraphs Presented as <note> in "to paragraph" (shared/01/05260200.xhp), while only the text is embedded as a paragraph in "to character" (shared/01/05260300.xhp) because there is already a <tip> on that page, without much other text. <note> added to swriter/guide/anchor_object.xhp that positioning is only on the page where the anchor is located. Change-Id: I8173050620fbeb8fc78d747ad05d8ab1f74f1346 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135169 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-06-16Fix typoAndrea Gelmini
Change-Id: I92524505c8e7c82bf7c1263afc257f8e6d632ea9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135926 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-06-16Fix typoAndrea Gelmini
Change-Id: Ic6252987b61d0f55a96193bdc5da5fecc1a36171 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135930 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-06-16Fix typoAndrea Gelmini
Change-Id: I38f2e4011f348574d1d2adb7eb34cac6b2df43da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135929 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-06-16Missing test dependenciesStephan Bergmann
> warn:vcl.builder:4159485:4159485:vcl/source/window/builder.cxx:479: DBG_UNHANDLED_EXCEPTION in VclBuilder > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/svt/ui/editcontrol.ui" > warn:vcl.builder:4159485:4159485:vcl/source/window/builder.cxx:479: DBG_UNHANDLED_EXCEPTION in VclBuilder > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/modules/swriter/ui/annotation.ui" and > warn:vcl.builder:4164787:4164787:vcl/source/window/builder.cxx:479: DBG_UNHANDLED_EXCEPTION in VclBuilder > when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/sfx/ui/tabbar.ui" when building CppunitTest_sw_ww8export CPPUNIT_TEST_NAME=testCommentExport::Load_Verify_Reload_Verify from scratch Change-Id: I36eedd31c8ee55f2992cb1aec3b26cfdbc4e2a27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135964 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-16Related: tdf#149325 tdf#52602 SvNumberFormatsObj::addNew accept differingEike Rathke
... resulting format code of an existing format as not attempting to add a duplicate. It makes no sense to insist on strictness if the client can't know the rules.. Change-Id: I0c8ca215984bf84487036ccf2b570128b1694d54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135898 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-06-16Related: tdf#147844 fix warning about negative extra space in manage changesCaolán McNamara
Change-Id: I20c98578e2e96bc06e3c90c12eeda81ab06c988d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135913 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-16Add property name to IllegalArgumentException in SvxShape::setPropertyValueImplSamuel Mehrbrodt
Change-Id: I5e10f2c35568449a99f1972db614199a6336e6b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135962 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-06-16sw content controls: allow the properties dialog in read-only selMiklos Vajna
Once you enter a checkbox or picture content control, the selection is read-only to avoid loosing content the next time the content control is updated. But this means you can't launch the properties dialog to e.g. enable placeholder mode. Fix this by relaxing the restriction and allow the properties dialog on protected cursor as well, matching Word behavior. Change-Id: Ifef9af66d077682c46c852c9ecba2df5f17234fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135965 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-06-16allocate column in ScTable::DeleteBeforeCopyFromClip() (tdf#149554)Luboš Luňák
Change-Id: I22607f1dd0ec1c083f6a52a2ecccb976fc133687 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135864 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-06-16This should apparently be a true assertStephan Bergmann
...as dereferencing a past-the-end iterator would be fatal, as seen with <https://ci.libreoffice.org/job/lo_ubsan/2432/> during UITest_sw_fieldDialog at > warn:legacy.tools:19040:19040:vcl/source/treelist/treelist.cxx:1353: Entry not in model or wrong view > /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/debug/safe_iterator.h:283: > error: > attempt > to > dereference > a > past-the-end > > iterator > . > > Objects involved in the operation: > iterator "this" @ 0x0x7fc0a42e1fe8 { > type = Hٷm�␡ (mutable iterator); > state = past-the-end; > references sequence with type `NSt7__debug13unordered_mapIP15SvTreeListEntrySt10unique_ptrI15SvViewDataEntrySt14default_deleteIS4_EESt4hashIS2_ESt8equal_toIS2_ESaISt4pairIKS2_S7_EEEE' @ 0x0x7fc0a42e1fe8 > } > > > Fatal exception: Signal 6 Change-Id: Ibd547536849b15d56711e065262197a2e168db3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135961 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-16Related: tdf#123846 don't auto toggle radiobuttons with left/rightCaolán McNamara
just do the default cursor move, toggle can be triggered with space/return or directly with 0-9 (+ a for 10) Change-Id: I654ca64e49b3a9d4672668553095e971a5c9d1e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-16loplugin:moveitNoel Grandin
Change-Id: Ic593974a44d9e327e0385c7ffaaa6d42576ae01a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135911 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-16Fix typoAndrea Gelmini
Change-Id: I169bb6381af825b3024c57a0a9996e1390a27d09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135931 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-06-16sw: document SwFormatWrapInfluenceOnObjPosMiklos Vajna
The legacy iterative process doesn't need this, but the newer straightforward one does. Change-Id: I33932f37d5ad7bae0ffe5f23abdf2c4d82b84598 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135920 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-06-16Correct parsing of ST_PercentageMike Kaganski
Change-Id: I227b2abd493d3a4ce6f4e4dcd256aa29653fdce0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135886 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-06-16Revert "Fix typo"Adolfo Jayme Barrientos
This reverts commit 157d58605acc714a5756525b567d6b59a1322d35. Reason for revert: IT IS NOT A TYPO Change-Id: I06ccc29f4a093068b0ba211682e1624476b8a6c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135946 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-06-16tdf#149551 write draw:text-rotate-angle only onceRegina Henschel
The attributes 'vert' and 'vert270' set property TextPreRotateAngle on import from OOXML. The property TextRotateAngle can be set by macro. Both were written to file as 'draw:text-rotate-angle' attribute. So we got a file format error 'duplicate attribute'. The values are now added and the sum is written. That gives the same rendering as after applying a macro. Using the sum is a workaround. We have currently no way to save the direction specified by 'vert' and 'vert270' as style:writing-mode to ODF. Change-Id: I93fd8ca42b82c1ed7f1bf6e33d932e5510615b2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135901 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2022-06-16Fix extended tips in labeloptionspage.uiOlivier Hallot
Change-Id: Ib82fd7a19a837521afbe0d0a6c154d4c5c5f2824 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135755 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-06-15Update git submodulesMartin Srebotnjak
* Update translations from branch 'master' to 140d3bcbbdf20e83d772d419515e49846ae7e105 - Updated Slovenian translation Change-Id: Ic93876c783b228af11b625e1a2e7370567798a84
2022-06-15Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to ef3257698791a7e3312d5d859ac8229ee48a0e69 - update translations for master/7.4 and force-fix errors using pocheck Change-Id: I748d74278038427100e6927f374e17d69a2eaee9
2022-06-15Advanced Diagram support: make UI visualization experimental onlyXisco Fauli
In 391cb44d415e2126f668ecf62387d5e98ffa6f5c "Advanced Diagram support: UI visualization & simple interactions" added a UI visualization to advanced diagrams. However, the feature is incomplete at the moment, specially towards LibreOffice 7.4, thus, make it experimental for now. This can be reverted later on Change-Id: Ibf21d11899460ab9ef1ddf91cffb851171119618 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135912 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2022-06-15tdf#52602: sc_vba_macro_test: Add unittestXisco Fauli
Change-Id: I3e6ab3d8f3e9dddfec90f1a9762e7bf2007c10db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135899 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>