summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-07-17loplugin:useuniqueptr in SvxAsianLayoutPage_ImplNoel Grandin
Change-Id: I6380ccceabb9ce9c3c7c187e913e7384d8854b5b Reviewed-on: https://gerrit.libreoffice.org/57516 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17drop reference to removed chart2_opengl_shaderCaolán McNamara
Change-Id: I8bd1727028d18367ffa160a87aa548bca60c212f
2018-07-17tdf#105262 Clean up CopyGraphicXisco Fauli
It's only available in read-only mode, it doesn't work and the images can be copied with the normal copy option Change-Id: I6493147309104b2b0f3881a667547c38d7633ef3 Reviewed-on: https://gerrit.libreoffice.org/57162 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-17Pop all remaining arguments on stack in ScInterpreter::Iterateparameters().Winfried Donkers
(And not all but one.) Change-Id: I42c0ea0f188fa16258022041ab8fc898f5d64ab5 Reviewed-on: https://gerrit.libreoffice.org/57503 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-07-17tdf#81943 sw RTF import: fix missing wrap in background for in-table shapeMiklos Vajna
Regression from commit 015fd55c94b7b650ed8e572cafaf3b0f903b01b9 (tdf#96275 RTF import: fix anchor of shapes inside tables, 2016-05-10), remember more context when delaying the import of a shape. Change-Id: Idc02868eb3fe5b7637c9fd00c841bf71423adf2b Reviewed-on: https://gerrit.libreoffice.org/57531 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-17loplugin:useuniqueptr in ScCondFormatManagerDlgNoel Grandin
Change-Id: Icca18a88686493b30e89a3fc00880968a48fe964 Reviewed-on: https://gerrit.libreoffice.org/57528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17loplugin:useuniqueptr in ScTpCalcOptionsNoel Grandin
Change-Id: Iebf8bc4036ed6b530e088429a71200097816bccd Reviewed-on: https://gerrit.libreoffice.org/57526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17loplugin:useuniqueptr in ImportExcelNoel Grandin
Change-Id: I46f62022cbbbcda75a4daa916ff6841048a334ce Reviewed-on: https://gerrit.libreoffice.org/57522 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17loplugin:useuniqueptr in SwViewShellNoel Grandin
Change-Id: I2060769860be8527f7966d2d83fe9a6f533f8271 Reviewed-on: https://gerrit.libreoffice.org/57520 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17loplugin:useuniqueptr in HTMLAttrContextNoel Grandin
Change-Id: I1a1c5054a27c8731eb397c63af26347b979375ee Reviewed-on: https://gerrit.libreoffice.org/57519 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17loplugin:useuniqueptr in SwRelNumRuleSpacesNoel Grandin
Change-Id: I0f5ab46d117114b4d90f15252a7ea7fa01dab039 Reviewed-on: https://gerrit.libreoffice.org/57518 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17loplugin:useuniqueptr in SwXShapeNoel Grandin
Change-Id: I7081485c63e17078cfbae7211d20809b0aec6fc3 Reviewed-on: https://gerrit.libreoffice.org/57517 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17loplugin:useuniqueptr in PrintFontManagerNoel Grandin
Change-Id: I539e167b0b9d3523d50cbebc13227867c5f05bd5 Reviewed-on: https://gerrit.libreoffice.org/57515 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17loplugin:useuniqueptr in PPDParserNoel Grandin
Change-Id: Id7ffe7967d2b6a7f394a4e096c04218c10aeda37 Reviewed-on: https://gerrit.libreoffice.org/57514 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17loplugin:useuniqueptr in XMLRedlineExportNoel Grandin
Change-Id: I337b6c068e28a5cf69d9c0b6a30b480834d8a227 Reviewed-on: https://gerrit.libreoffice.org/57513 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17remove the GL based 3D chartsMarkus Mohrhard
Change-Id: Ia578c71ae70aa0a85b49fa50138edf90f961b1e9 Reviewed-on: https://gerrit.libreoffice.org/57533 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-16Update git submodulesCaolán McNamara
* Update helpcontent2 from branch 'master' - reword Block any links from untrusted documents documentation Change-Id: I7f509ca500d859e4332fdc94f9a265fa34a64fcb Reviewed-on: https://gerrit.libreoffice.org/57509 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16tdf#113646, export font size for dxf recordsMarkus Mohrhard
Change-Id: I6dd6b0ef858fd933603be4435f7810c739b72ef0 Reviewed-on: https://gerrit.libreoffice.org/57471 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-16tdf#69460, tdf#118416: Don't copy whole columns to the clipboardTor Lillqvist
...for the BITMAP or PNG formats either. Change-Id: Ib1739ceb917fe24dac412007fd6522e40f5517c4 Reviewed-on: https://gerrit.libreoffice.org/56577 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-16uitest for bug tdf#102525Zdeněk Crhonek
Change-Id: Idb3810d99ebbd33bf0961f362694d0f4961fb912 Reviewed-on: https://gerrit.libreoffice.org/57463 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-07-16tdf#118681 make sure we're using the right font char mapCaolán McNamara
Change-Id: I64265dac5d0d18b092d64ef656997d7177a425a4 Reviewed-on: https://gerrit.libreoffice.org/57504 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16Remove obsolete (cargo-cult copied) dependenciesJens Carl
Change-Id: Iab52f84d7a9fbe8ad460ef09190452b053c5c661 Reviewed-on: https://gerrit.libreoffice.org/57476 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-16tdf#118635 relative checkbox disabled on reopenCaolán McNamara
Change-Id: Ic52737e5122b1ae37390061a5f7cf17b69e7e665 Reviewed-on: https://gerrit.libreoffice.org/57498 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16Upgrade to ICU 62.1Eike Rathke
Change-Id: I9426e77aa85cfe068df59db47b8ac50b59cd4eb3 Reviewed-on: https://gerrit.libreoffice.org/57500 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-16tdf#118549 crash on dialog teardownCaolán McNamara
only an issue for the current partially complete interim case Change-Id: Iaf1ef4dabca1cdd5d2d90028edf5793cf45feb20 Reviewed-on: https://gerrit.libreoffice.org/57501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16try to make the windows tinderboxes happierNoel Grandin
at the moment about 1 in 10 builds fail Change-Id: I29ada5555170bf7c3f603b684ab4dc7b1932c44c Reviewed-on: https://gerrit.libreoffice.org/57491 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16convert SW*READER constants to scoped enumNoel Grandin
Change-Id: I7cf635e238a16e7ec96e585e6eb5e2e9c39b545a Reviewed-on: https://gerrit.libreoffice.org/57497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16loplugin:useuniqueptr in SwXTextSearchNoel Grandin
Change-Id: I30fcea4f03b29dfcd434f4544d5c52dc7ca9d4a9 Reviewed-on: https://gerrit.libreoffice.org/57422 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16tdf#118769 parent of modal dialog not setCaolán McNamara
Change-Id: Ie3b1a626eb0ca4f39e015a18fede935b36ed194e Reviewed-on: https://gerrit.libreoffice.org/57492 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16coverity#1401328 Uncaught exceptionCaolán McNamara
Change-Id: I08c91c9c84d53f567332e5780b14173b8c8e5fb1 Reviewed-on: https://gerrit.libreoffice.org/57462 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16loplugin:mergeclasses update results outputNoel Grandin
Change-Id: Id1138cf7358c610aff77b7d7073c61cd3f13129c Reviewed-on: https://gerrit.libreoffice.org/57485 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16move freeze/thaw to WidgetCaolán McNamara
Change-Id: I3944092c26ca81028912f6fb206b148b49e4f172 Reviewed-on: https://gerrit.libreoffice.org/57489 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16loplugin:useuniqueptr in SwUndoDrawDeleteNoel Grandin
Change-Id: I7d7e89a9ffa67141e459772791caae2937458b8f Reviewed-on: https://gerrit.libreoffice.org/57425 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16loplugin:mergeclasses merge ResourceManager into SlideSorterModuleNoel Grandin
Change-Id: If78dc81e41180e7449b389e36223ee78d6ac91ec Reviewed-on: https://gerrit.libreoffice.org/57486 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16loplugin:mergeclasses merge BPixelRaster into BZPixelRasterNoel Grandin
Change-Id: Ib6f7bfd2392daa5512d5fa68b69428ae9c8876f9 Reviewed-on: https://gerrit.libreoffice.org/57488 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16forcepoint#50 refetch FirstNonHeadlineRowCaolán McNamara
Invalid read of size 8 at 0x43D42DE6: SwFrame::GetUpper() const (frame.hxx:664) by 0x44427435: SwRowFrame::ShouldRowKeepWithNext() const (tabfrm.cxx:4618) by 0x4441FA5C: SwTabFrame::MakeAll(OutputDevice*) (tabfrm.cxx:2403) by 0x4433492F: SwFrame::PrepareMake(OutputDevice*) (calcmove.cxx:343) by 0x44431B6F: SwFrame::Calc(OutputDevice*) const (trvlfrm.cxx:1799) by 0x44334430: SwFrame::PrepareMake(OutputDevice*) (calcmove.cxx:246) by 0x44431B6F: SwFrame::Calc(OutputDevice*) const (trvlfrm.cxx:1799) by 0x44334430: SwFrame::PrepareMake(OutputDevice*) (calcmove.cxx:246) by 0x44431B6F: SwFrame::Calc(OutputDevice*) const (trvlfrm.cxx:1799) by 0x44334A67: SwFrame::OptPrepareMake() (calcmove.cxx:354) by 0x443982CE: SwFrame::OptCalc() const (frame.hxx:1051) by 0x44395F18: SwLayAction::FormatContent_(SwContentFrame const*, SwPageFrame const*) (layact.cxx:1794) Address 0x352771b0 is 144 bytes inside a block of size 280 free'd at 0x4C2EDAC: free (vg_replace_malloc.c:530) by 0x4E5B9D7: rtl_freeMemory_SYSTEM(void*) (alloc_global.cxx:237) by 0x4E5BC93: rtl_freeMemory (alloc_global.cxx:303) by 0x4E5A7A2: rtl_cache_free (alloc_cache.cxx:1081) by 0xF28B5B9: FixedMemPool::Free(void*) (mempool.cxx:49) by 0x442FF36D: SwRowFrame::operator delete(void*, unsigned long) (rowfrm.hxx:123) by 0x444243E8: SwRowFrame::~SwRowFrame() (tabfrm.cxx:3702) by 0x4441630C: SwFrame::DestroyFrame(SwFrame*) (ssfrm.cxx:384) by 0x4441AC31: SwTabFrame::RemoveFollowFlowLine() (tabfrm.cxx:900) by 0x4441D7EB: SwTabFrame::MakeAll(OutputDevice*) (tabfrm.cxx:1836) by 0x4433492F: SwFrame::PrepareMake(OutputDevice*) (calcmove.cxx:343) by 0x44431B6F: SwFrame::Calc(OutputDevice*) const (trvlfrm.cxx:1799) Change-Id: I36fe0df0ef96b4019e0ca5756b06df72e9f0d8cb Reviewed-on: https://gerrit.libreoffice.org/57480 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16Add missing sal/log.hxx headersGabor Kelemen
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from connectivity to cui Change-Id: I9903c10d0a04bbeb93d0f776d1d252b152459499 Reviewed-on: https://gerrit.libreoffice.org/57408 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-16sw: prefix members of SwDateTimeField and SwFormatDropMiklos Vajna
Change-Id: I8824da58ccbbe3cd377e8f258941676598145062 Reviewed-on: https://gerrit.libreoffice.org/57477 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-16oox: refactor CommonBehaviorContext to inherit from FragmentHandler2.Mark Hung
Although it's convenient to inherit from TimeNodeContext, but only mpNode is used so it's really not necessary. Change-Id: I922774df4c420ee9982f1c31e720f4fd85991e02 Reviewed-on: https://gerrit.libreoffice.org/57395 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-16oox: enum MS_AttributeNames -> enum class AnimationAttributeEnumMark Hung
It's the attribute enum for the target animation. Remove MS_ prefix since it is in oox::ppt namespace and prepend Animation to make the purpose more clear. Change-Id: I0b6bbaf30ae4e2cf1cb0f6d5d24ba9f31e0b0773 Reviewed-on: https://gerrit.libreoffice.org/57353 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-16cppcheck: useInitializationList in vclJochen Nitschke
reorder members of GIFLZWDecompressor to ease initialization. use rtl_allocateZeroMemory in ImplVectMap to avoid memset in ctor. Change-Id: Icfcfe73ec7e52988036995d8dbc604361aee893b Reviewed-on: https://gerrit.libreoffice.org/57481 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-07-16coverity#1437962 and 1437961 and 1437955 and 1437951 resource leakNoel Grandin
regression from commit 0fb5ca6cc9cc55a4436a36c533461769b1fc8526 tdf#79877 perf loading docx file, writerfilter/ improvements Change-Id: I76792bd635eacc60647a097e070ce7b963fd122f Reviewed-on: https://gerrit.libreoffice.org/57478 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16coverity#1437959 Copy into fixed size bufferCaolán McNamara
Change-Id: I5578e195c834b2a3ceacd5c528f58d1d03502c2e Reviewed-on: https://gerrit.libreoffice.org/57461 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16loplugin:useuniqueptr in SwUndoSortNoel Grandin
Change-Id: I9e524c9c653fd4b1f61e407eee12ca3a7fdc14df Reviewed-on: https://gerrit.libreoffice.org/57420 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16return BaseProcessor2D by std::unique_ptrNoel Grandin
Change-Id: Ibad6e989d2d7ba779e7557e41552d06c076f657b Reviewed-on: https://gerrit.libreoffice.org/57448 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16SvPersistBase no longer necessaryNoel Grandin
Change-Id: I928c0898d77d30bd6ca755d07acac6f78b20563b Reviewed-on: https://gerrit.libreoffice.org/57436 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16loplugin:useuniqueptr in SwHistoryNoel Grandin
Change-Id: Ie36cdf1e7b3d09ae27cb2a5b51f8a644693fe2b3 Reviewed-on: https://gerrit.libreoffice.org/57424 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16loplugin:useuniqueptr in SwSdrUndoNoel Grandin
Change-Id: I67276f2cd13cce8a7cb047216ead40c5afc384bd Reviewed-on: https://gerrit.libreoffice.org/57423 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16loplugin:useuniqueptr in UndoTransliterate_DataNoel Grandin
Change-Id: I1c6e865a6f59ce7f31c42d28b2b463a577b3cc28 Reviewed-on: https://gerrit.libreoffice.org/57421 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16loplugin:useuniqueptr in SwUndoInsertsNoel Grandin
Change-Id: I678798048b5ff5fc917fd2c37180d977a2a1d606 Reviewed-on: https://gerrit.libreoffice.org/57419 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>