summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-10-18sw: prefix members of MailDeliveryErrorNotifier, SwAddressIterator, ...Miklos Vajna
... SwAddressPreview and SwCondCollItem See tdf#94879 for motivation. Change-Id: I6702b3d2287aa3c9df1bac8520746901ae2e2f25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123729 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-10-18salhelper : simplify salhelper::TimerManager initalization and use std::mutexArnaud Versini
Change-Id: I48c59e267683e081ef45049b280eb38ce231a39c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123723 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-18xmlsecurity: fix new tests on WNTMichael Stahl
Tests added in commit 40d70d427edddb589eda64fafc2e56536953d274 don't actually run on WNT but that wasn't obvious because commit 149df1fec6472e30582162e17e04c75aee91d26a prevented running them in Jenkins on master, they failed only in the libreoffice-7-1 backport. xmlsecurity/qa/unit/signing/signing.cxx(631) : error : Assertion Test name: testODFDoubleX509Certificate::TestBody assertion failed - Expression: (nActual == SignatureState::NOTVALIDATED || nActual == SignatureState::OK) - 2 This is an oddity where NSS claims the signature in the document is valid but CryptoAPI claims it is invalid; the hashes passed into the validation functions are the same. Just allow BROKEN as an additional result value on WNT. xmlsecurity/qa/unit/signing/signing.cxx(550) : error : Assertion Test name: testODFX509CertificateChain::TestBody equality assertion failed - Expected: 0 - Actual : 1 The problem here is that with NSS the tests use a custom NSS database in test/signing-keys so we need to make these certificates available for CryptoAPI too. The following one-liner converts the NSS database to a PKCS#7 that can be loaded by CrytpAPI: > openssl crl2pkcs7 -nocrl -certfile <(certutil -d sql:test/signing-keys -L | awk '/^[^ ].*,[^ ]*,/ { printf "%s", $1; for (i = 2; i < NF; i++) { printf " %s", $i; } printf "\n"; }' | while read name; do certutil -L -d sql:test/signing-keys -a -n "${name}" ; done) > test/signing-keys/test.p7b Then one might naively assume that something like this would allow these certificates to be added temporarily as trusted CAs: + HCERTSTORE hRoot = CertOpenSystemStoreW( 0, L"Root" ) ; + HCERTSTORE const hExtra = CertOpenStore( + CERT_STORE_PROV_FILENAME_A, + PKCS_7_ASN_ENCODING | X509_ASN_ENCODING, + NULL, + CERT_STORE_OPEN_EXISTING_FLAG | CERT_STORE_READONLY_FLAG, + path); + if (hExtra != NULL && hRoot != NULL) + { + BOOL ret = CertAddStoreToCollection( + hRoot, + hExtra, + CERT_PHYSICAL_STORE_ADD_ENABLE_FLAG, + 0); + SAL_DEBUG("XXX hExtra done " << ret); + } There is no error from this, but it doesn't work. Instead, check if CertGetCertificateChain() sets the CERT_TRUST_IS_UNTRUSTED_ROOT flag and then look up the certificate manually in the extra PKCS#7 store. Change-Id: Ic9865e0b5783211c2128ce0327c4583b7784ff62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123667 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-10-18xmlsecurity: fix some obvious copypastaMichael Stahl
These 2 calls to CertAddStoreToCollection follow calls where m_hCertStore was already added and according to the comments they should add the other store instead. (regression from commit 813e1f5a8ae4800e8a11c612de4e3b0a97f1368d) Change-Id: If375f603647a702feb0ca8f272126a15d5d0e906 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123666 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-10-18cid#1492880 avoid Improper use of negative valueCaolán McNamara
Change-Id: Idb64ec73e6cb7f032d61b6670ed27a2418e3a6f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123724 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-17Simplify Sequence in accessibilityJulien Nabet
+ retrieve a missing aKeyEvent.GetCharCode() aSeq3 Change-Id: If575513996304f67b8e87a145052cb1b9279a212 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123719 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-17just do one lookup for loop detectionCaolán McNamara
Change-Id: I2b20c15f2e3ec3c4a23d78f6fab85db763fce033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-17basic: simplifiy class initializationArnaud Versini
Change-Id: I87fa2f606011aab8e34d9445d9e9299786f05747 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123324 Tested-by: Jenkins Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2021-10-17Simplify Sequences in xmlsecurityJulien Nabet
Change-Id: I749e19f786ad006dffcd65dd1ee60e57c428f57b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123717 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-17Use range based for loopsHossein
* Use range based for loops where it was possible in svgio + Goal: Better readability of the code Change-Id: I6259e2391006287d5d330277dd8d700012c32932 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123712 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-17WIN release SalPrinter's SalGraphics borrowed HDCJan-Marek Glogowski
Regression from commit d27187b158d7e3f92180b1f2ab79b048dc5318a5 ("vcl:use unique_ptr<SalWinGraphics> in WinSalPrinter"). Would need something like Rust's Borrowing semantics to prevent. Ideas on IRC to make this bug more unlikely were some extra HDC + SalGraphics struct to pass around or something like unique_ptr reference passing and moving the value into a local copy. For now just add some additional comments. Change-Id: I472ee9acb4a4c02177c27ecd1c1277dfc812cadf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123440 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2021-10-17Specialize comphelper::makePropertyValue for arithmetic typesMike Kaganski
This allows to pass e.g. bit fields to the function, like struct Foo { bool b : 1; }; Foo foo {true}; comphelper::makePropertyValue("foo", foo.b); Change-Id: I8f725d0101d90fb8b6012375c085918d1cadc6f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123639 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-17Simplify comphelper::makePropertyValueMike Kaganski
Avoid default-constructing members that get immediately re-defined. Change-Id: Ib863745577983582c80e1b172060ba20ce6135a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123638 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-17Simplify Sequence in xmlhelpJulien Nabet
Change-Id: I4a7363686498151a840b1c400d466b1c2d583e7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123718 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-17Simplify Sequence in b*Julien Nabet
Change-Id: I0817d9a35a9c3fc43badb6cc60727de69849b063 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123720 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-17tdf#144988 correct font size in multiline Fontwork textRegina Henschel
The error happened if ScaleX in TextPath is true. In that case the original font size is used for rendering if possible. Only if a paragraph is longer as its sub-path length, the rendered font size for the whole text is reduced until the text fits. The error was, that in case the first paragraph was too long and the second paragraph fits, the fact that the first paragraph was too long was overwritten from the factor for the second paragraph. That resulted in wrong position and size of the text and overlapping characters. The meaning of fScalingFactor is related to the usual case, where ScaleX is false. Keeping original font size is not achieved by using value 1 for fScalingFactor (which would be obvious), but the adaption to case ScaleX==true is done in FitTextOutlinesToShapeOutlines() by tweaking the width from the text bounding rectangle. Change-Id: Icf5829018a83be0f1197304d17da10a88130f702 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123714 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2021-10-17Simplify Sequences in xmloff (+ merge 2 SetError)Julien Nabet
Change-Id: If4055bbeb858b1b87ecb3f8c0b87da4b008e3c16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123716 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-17Simplify vector initialization in writerfilterJulien Nabet
Change-Id: I54f6eaed64f0a4209e57ce12b5cbb38d2cf66fb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123709 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-17Simplify vector initialization in xmlsecurityJulien Nabet
Change-Id: Ia19ffa1213d578c30f35545bcca515669e7ff7a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123710 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-17Simplify vector initialization in vclJulien Nabet
Change-Id: I881627313221081f72f8421c91417e4c111cfd97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123708 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16Simplify vector initialization in ucbJulien Nabet
Change-Id: I4b03ab81a17efc125bc5e3b159cf212198c43d22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123707 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16cid#1492880 make Improper use of negative value explicitCaolán McNamara
Change-Id: Ie55748f2037a320812fdf6288dd1671a39fe018b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123706 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-16Simplify vector initialization in svlJulien Nabet
Change-Id: I8ff1eb008f3173791c7c1020db08d29451998f42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123699 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16Fix a forgotten return of the valueMike Kaganski
... ever since its introduction in commit 5ea5c0afebd272d5f44e6524c0f67b5317639919 Change-Id: Ic2f082db43c961185921137c6b64b2e1abef28e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123704 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-16ofz#40004 TimeoutCaolán McNamara
Change-Id: I261f6acec53936e4a644bb4b38bbc41fa9ad120c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123702 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-16ofz#40008 check if column exists before EndListening attemptCaolán McNamara
Change-Id: Iad6a7f215aa36fb6f8bb35e14aa5b882bf9773f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123703 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-16Simplify vector initialization in scJulien Nabet
Change-Id: If5b7632cfbc81f89d68ce8fbce1fac265e8354fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123692 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16Simplify vector initialization in sfx2Julien Nabet
Change-Id: Ibff7203a86b42c58738d8b4836a61bf1c5806962 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123698 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16Simplify vector initialization in swJulien Nabet
Change-Id: Ibded138d113e56b78b12c96c7ecd8258564627ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123701 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16Simplify vector initialization in svxJulien Nabet
Change-Id: I139776f74fb93f90dae787eeae18e4a2a2ed7351 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123700 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16Simplify vector initialization in filterJulien Nabet
Change-Id: I78653b32a5418e44733e3d2740a9a7dd784f17ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123686 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16Simplify vector initialization in reportdesignJulien Nabet
Change-Id: Ic1927155b23f056fc1117b7726ab4b2eff8a6da3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123690 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16Simplify vector initialization in salJulien Nabet
Change-Id: Ia3e4dd8cad79b156d44eb03f1ae3d308204df2e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123691 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16Simplify vector initialization in ooxJulien Nabet
Change-Id: I1d7cfd157d56a501be4497e6f4e94f3f33429139 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123689 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16Simplify vector initialization in drawinglayerJulien Nabet
Change-Id: Iee9c13149d3614ecd9f812cfbb85e4534c33c1be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123684 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16Simplify vector initialization in helpcompilerJulien Nabet
Change-Id: I800fa0a6ac3b0dce1e0408858646dc7db5510623 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123688 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16Simplify vector initialization in extensionsJulien Nabet
Change-Id: Ia83209304a7ed889cdd643c8034420c032ccad6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123685 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16Simplify vector initialization in sdextJulien Nabet
Change-Id: If3cebeadff5496ae214614b49116060d24b6082f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123696 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16Simplify vector initialization in sdJulien Nabet
Change-Id: I5f56919efeea66ce6e644f2cb123fd264edbcb73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123697 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16Use sal::systools::COMReference and drop ComSmartMike Kaganski
Change-Id: Ic6e0c87f607264629cdec1fdcd0c3144d8fbf8e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123695 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-16Simplify vector initialization in fpickerJulien Nabet
Change-Id: If75810cb09e13d5d9b9490b20a0a99b1745e17be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123687 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16Simplify vector initialization in desktopJulien Nabet
Change-Id: Ia7c99cb9c0e8be7299bc664b80cc8932d2766469 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123683 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16Simplify vector initialization in cuiJulien Nabet
Change-Id: I9c1b793f02eff56251cf13959e88c4648db4ab0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123665 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16add use-underline to spacing control labelsCaolán McNamara
set all entries to use the same icon-size Change-Id: Ibb949a039175ce2b93323bace7102a5f32aecfd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-16resave with latest gladeCaolán McNamara
Change-Id: I0fae7cd556a6158787e139b0b419e6a7ead18658 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123675 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-16gtk4: focus can only enter popover if its parent widget can-focusCaolán McNamara
even though the popover is a separate toplevel window. Change-Id: I2ff799f0070b2233953af9e96c6eafeadb58b2cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123674 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-16Fix typoAndrea Gelmini
Change-Id: I66712db3b74e45728e3104c24823a962fd498037 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123677 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16Fix typoAndrea Gelmini
Change-Id: I101231dc8daa99254a086bd635817e20c23a8ff4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123679 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16Fix the copypaste errorMike Kaganski
... ever since commit 6eea9416a3a5be2d2f6aab6c58ab4e6d4b085ea8 Change-Id: Ic3f6f6876d398cd48cd480518d99a516cea95a31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123636 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16adapt to the change from tools::Long* to std::vector<tools::Long>*Tomoyuki Kubota
since d4dc6b5c Change-Id: Ic2104185aec40e01b81d3559c161d894a473d3a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123631 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-03-05 04:17:59 +0000