summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-11-09custom widgets: add Tab widgetsTomaž Vajngerl
Change-Id: If9acc47b9a7751858d3394741e3984b3c2a49936
2018-11-09custom widgets: draw ListBox widgetTomaž Vajngerl
Change-Id: I1a3b709fdc4fb21fc4ad22542ff669c98b13487d
2018-11-09custom widgets: first round of basic widgets with cairoTomaž Vajngerl
- Radiobutton - Checkbox - Combobox - Editbox - Spinbox - Scrollbar Change-Id: I46bd2753a7c1806f4cd4583455e76c77494225b4
2018-11-09Support drawing custom widgets in headless backendTomaž Vajngerl
..and fallback the headless dawing also in gtk3 where needed Change-Id: Ic5da8fa7a04089342db8e2f334ced69691a15217
2018-11-09lokit: Draw dialogs without using a MetaFileTomaž Vajngerl
A native widgets aren't part of a VCL metafile so they are ignored when the metafile is replayed. When drawing a dialog to a custom device, the first draw goes to the metafile, which is then replayed to the final device, but no native widgets get drawn. This commit changes this behavior for LOKit where it draws without using the intermediate VCL metafile. Change-Id: I823db30c8bceb83830c6c993d4238b39e1331c09
2018-11-09custom widgets: Custom Widget ThemesTomaž Vajngerl
Change-Id: I7ec57d18fe99f906aeb6dbb40d0d30c2ac8b51c4
2018-11-09SvStream::m_isConsistent is always trueNoel Grandin
ever since commit a3b0ee88be3c6bff94ec6fe908f209c1dbb9748d Date: Sun Jul 10 22:17:35 2011 +0100 strip out unused methods found by loplugin:singlevalfields Change-Id: I4feab1195f78549a48f4b1a9017bc5101474228f Reviewed-on: https://gerrit.libreoffice.org/63173 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-09Make XclRange::GetCol/RowCount more robustStephan Bergmann
Under (new-in-Clang) -fsanitize=implicit-signed-integer-truncation, CppunitTest_sc_filters_test failed with > Testing file:///.../sc/qa/unit/data/xls/pass/crash-7.xls: > warn:sc:27699:27699:sc/source/filter/excel/xlroot.cxx:158: XclRootData::XclRootData - cannot get output device info: N3com3sun4star3uno9ExceptionE msg: invalid attempt to assign an empty interface of type com.sun.star.frame.XFrame! > warn:legacy.osl:27699:27699:sc/source/filter/excel/xilink.cxx:631: XclImpSupbook::XclImpSupbook - unknown special SUPBOOK type > warn:sc:27699:27699:sc/source/filter/excel/xilink.cxx:703: XclImpSupbook::GetExternName - index must be >0 > warn:legacy.osl:27699:27699:sc/source/filter/excel/xistream.cxx:802: XclImpStream::Ignore - record overread > sc/source/filter/inc/xladdress.hxx:72:47: runtime error: implicit conversion from type 'int' of value -511 (32-bit, signed) to type 'sal_uInt16' (aka 'unsigned short') changed the value to 65025 (16-bit, unsigned) > #0 in XclRange::GetColCount() const at sc/source/filter/inc/xladdress.hxx:72:47 (instdir/program/libscfiltlo.so +0x2510655) > #1 in ImportExcel::ReadDimensions() at sc/source/filter/excel/impop.cxx:255:27 (instdir/program/libscfiltlo.so +0x24e52c4) > #2 in ImportExcel8::Read() at sc/source/filter/excel/read.cxx:1110:49 (instdir/program/libscfiltlo.so +0x2589a90) > #3 in ScFormatFilterPluginImpl::ScImportExcel(SfxMedium&, ScDocument*, EXCIMPFORMAT) at sc/source/filter/excel/excel.cxx:145:35 (instdir/program/libscfiltlo.so +0x230df62) > #4 in ScDocShell::ConvertFrom(SfxMedium&) at sc/source/ui/docshell/docsh.cxx:1265:52 (instdir/program/libsclo.so +0xcc8db50) > #5 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:787:23 (instdir/program/libsfxlo.so +0x389f0df) > #6 in ScBootstrapFixture::load(bool, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned long, rtl::OUString const*) at sc/qa/unit/helper/qahelper.cxx:582:21 (workdir/LinkTarget/CppunitTest/../Library/libscqahelper.so +0x869b5) > #7 in ScBootstrapFixture::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned long, rtl::OUString const*) at sc/qa/unit/helper/qahelper.cxx:597:12 (workdir/LinkTarget/CppunitTest/../Library/libscqahelper.so +0x86fa6) > #8 in ScFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) at sc/qa/unit/filters-test.cxx:125:51 (workdir/LinkTarget/CppunitTest/libtest_sc_filters_test.so +0x4623a) > #9 in test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:130:20 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x7526d) > #10 in test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:155:5 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x79127) > #11 in ScFiltersTest::testCVEs() at sc/qa/unit/filters-test.cxx:146:5 (workdir/LinkTarget/CppunitTest/libtest_sc_filters_test.so +0x4729d) [...] so it smells like the given XclRange (with maFirst.mnCol=512, maFirst.mnRow=0, maLast.mnCol=0, maLast.mnRow=0) already is the result of some previous lenient parsing of invalid input. Change-Id: Ib7915eac5526fc295e7fbbc1c001549b991ddbf7 Reviewed-on: https://gerrit.libreoffice.org/63200 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-09Resolves: tdf#121290 Crash, if press F4 for a selected calloutCaolán McNamara
Change-Id: Idf73b21ae2f27f4966705c8faf9fd38abc502ae4 Reviewed-on: https://gerrit.libreoffice.org/63178 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-09tdf#121275 fallback to gtk3 under wayland with unknown desktopCaolán McNamara
Change-Id: Ie63da823faf9067e61ca4870f464d49425bbc907 Reviewed-on: https://gerrit.libreoffice.org/63123 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-09Clean up excess slashes in pathsStephan Bergmann
Change-Id: I8e16746fc8d89adc8882303f67760341c1968aed Reviewed-on: https://gerrit.libreoffice.org/63190 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-09tdf#121276 gtk3_kde5: Don't prevent creating new filesMichael Weghorn
This takes over for gtk3_kde5 what was done for kde5 in commit c0f45c89063fa5c4334ff9e624d24d48638ffb4d. Change-Id: Ieca71498bd0cc00ca07b83f6e1178d983169d5be Reviewed-on: https://gerrit.libreoffice.org/63172 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2018-11-09Fix creation/removal of GPG socketdirStephan Bergmann
<https://gerrit.libreoffice.org/#/c/50978/> "gpg4libre: fix failing gpg test due to over-long filenames" had introduced the gb_CppunitTest_run_gpgconf target in xmlsecurity/CppunitTest_xmlsecurity_signing.mk, calling `gpgconf --craete-socketdir`. A 2018-03-18 comment there notes that "Stephan's last comment: (and `gpgconf --remove-sockedir` be called after the test?) is not addressed yet, will do in follow-up commit". Follow-up d7ecf4a4e37a9eeffa2b40f9fe5a2e6a8f90c876 "properly check for gpgconf (and --create-socketdir) working" makes gb_CppunitTest_run_gpgconf conditional. However, in configure.ac, HAVE_GPGCONF_SOCKETDIR=TRUE is missing, so even after follow-up 7a95ee8d0badb2cbbd137a6e18af1bada35ae933 "actually add HAVE_GPGCONF_SOCKETDIR to config_host.mk.in...", config_host.mk will always contain export HAVE_GPGCONF_SOCKETDIR= so gb_CppunitTest_run_gpgconf will never be executed (and `pgconf --crate-socketdir` will never called). But even if it were executed, it would not create the socket dir that the test code in xmlsecurity/qa/unit/signing/signing.cxx is actually using, as gb_CppunitTest_run_gpgconf sets GNUPGHOME=.../workdir/CppunitTest/xmlsecurity_signing.test.user while xmlsecurity/qa/unit/signing/signing.cxx's SigningTest::setUp sets GNUPGHOME=.../workdir//CppunitTest/xmlsecurity_signing.test.user/ and the GPG software is apparently picky about extra slashes when computing the socket dir name from the GNUPGHOME env var. (That `gpgconf --create-socketdir` was never executed with the current setup shows that calling it explicitly is probably not really needed, as the GPG software apparently creates it automatically on demand.) However, what is still missing is to remove the socket dir again (see the comment quoted above), and, probably more importantly, to exit any gpg-agent daemon operating on that socket dir that has (indirectly) been started by the tests in xmlsecurity/qa/unit/signing/signing.cxx. At least with Fedora 29 gpgconf from gnupg2-2.2.9-1.fc29.x86_64, that daemon is successfully terminated by calling `gpgconf --remove-socket`. So move the call to `gpgconf --create-socketdir` from the makefile to the test setup code (which makes it easier to guarantee that a single GNUPGHOME value, and thus a single socket dir, is used), and add a corresponding `gpgconf --remove-socketdir` call to the test shutdown code. (As argued above, the `gpgconf --create-socketdir` call shouldn't be stricktly necessary, but it looks cleaner to do it explicitly anyway.) Change-Id: I2ec8f08943ed63ec27f8507461588ee7cdadf372 Reviewed-on: https://gerrit.libreoffice.org/63181 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-09Revert "Fix some layout values"Julien Nabet
Nothing proves this is ok since no feedback. Moreover, since it's only of the assumption that setWidth and setHeight should have value >= 0 or -1, let's revert this one. This reverts commit d467214ac24e22818ff933d76148f3f0987c65ca. Change-Id: Ia030706d150afaebaedc0ec201814cca80db248a Reviewed-on: https://gerrit.libreoffice.org/63171 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-09css::security::DocumentSignatureInformation::SignatureTime is 32 bitStephan Bergmann
...and has always represented the time of day in 100th of seconds. When tools::Time had been changed to 64 bit nanoseconds in 9830fd36dbdb72c79703b0c61efc027fba793c5a "date/time IDL datatypes incompatible change", conversion between the two has apparently been forgotten, so that CppunitTest_desktop_lib under (new-in-Clang) -fsanitize=implicit-signed-integer-truncation failed with > xmlsecurity/source/component/documentdigitalsignatures.cxx:536:38: runtime error: implicit conversion from type 'sal_Int64' (aka 'long') of value 192536379741069 (64-bit, signed) to type '::sal_Int32' (aka 'int') changed the value to 1585795981 (32-bit, signed) > #0 in DocumentDigitalSignatures::ImplVerifySignatures(com::sun::star::uno::Reference<com::sun::star::embed::XStorage> const&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, DocumentSignatureMode) at xmlsecurity/source/component/documentdigitalsignatures.cxx:536:38 (instdir/program/libxmlsecurity.so +0x488319) > #1 in DocumentDigitalSignatures::verifyDocumentContentSignatures(com::sun::star::uno::Reference<com::sun::star::embed::XStorage> const&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&) at xmlsecurity/source/component/documentdigitalsignatures.cxx:296:12 (instdir/program/libxmlsecurity.so +0x484ea6) > #2 in non-virtual thunk to DocumentDigitalSignatures::verifyDocumentContentSignatures(com::sun::star::uno::Reference<com::sun::star::embed::XStorage> const&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&) at xmlsecurity/source/component/documentdigitalsignatures.cxx (instdir/program/libxmlsecurity.so +0x4890fa) > #3 in SfxObjectShell::ImplAnalyzeSignature(bool, com::sun::star::uno::Reference<com::sun::star::security::XDocumentDigitalSignatures> const&) at sfx2/source/doc/objserv.cxx:1368:47 (instdir/program/libsfxlo.so +0x3866a04) > #4 in SfxObjectShell::ImplGetSignatureState(bool) at sfx2/source/doc/objserv.cxx:1397:74 (instdir/program/libsfxlo.so +0x3869118) > #5 in SfxObjectShell::GetDocumentSignatureState() at sfx2/source/doc/objserv.cxx:1575:12 (instdir/program/libsfxlo.so +0x3863e57) > #6 in SfxObjectShell::CheckForBrokenDocSignatures_Impl() at sfx2/source/doc/objmisc.cxx:974:38 (instdir/program/libsfxlo.so +0x3812535) > #7 in SfxObjectShell::CheckSecurityOnLoading_Impl() at sfx2/source/doc/objmisc.cxx:924:5 (instdir/program/libsfxlo.so +0x38120bc) > #8 in SfxObjectShell::FinishedLoading(SfxLoadedFlags) at sfx2/source/doc/objmisc.cxx:1072:9 (instdir/program/libsfxlo.so +0x3818a89) > #9 in SwDocShell::LoadingFinished() at sw/source/uibase/app/docsh.cxx:1200:5 (instdir/program/libswlo.so +0xcfd4f08) > #10 in SwDocShell::Load(SfxMedium&) at sw/source/uibase/app/docshini.cxx:582:13 (instdir/program/libswlo.so +0xd091a39) > #11 in SfxObjectShell::LoadOwnFormat(SfxMedium&) at sfx2/source/doc/objstor.cxx:3053:20 (instdir/program/libsfxlo.so +0x3895e54) > #12 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:725:40 (instdir/program/libsfxlo.so +0x389bdd5) > #13 in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/sfxbasemodel.cxx:1795:36 (instdir/program/libsfxlo.so +0x3a40e1e) > #14 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) at sfx2/source/view/frmload.cxx:688:28 (instdir/program/libsfxlo.so +0x40c30c0) > #15 in framework::LoadEnv::impl_loadContent() at framework/source/loadenv/loadenv.cxx:1149:37 (instdir/program/libfwklo.so +0x1520131) > #16 in framework::LoadEnv::startLoading() at framework/source/loadenv/loadenv.cxx:383:20 (instdir/program/libfwklo.so +0x1510b16) > #17 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/loadenv/loadenv.cxx:169:14 (instdir/program/libfwklo.so +0x150c7c8) > #18 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx:619:12 (instdir/program/libfwklo.so +0x166f1ce) > #19 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx (instdir/program/libfwklo.so +0x166f3da) > #20 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at unotest/source/cpp/macros_test.cxx:50:60 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x8f176) > #21 in DesktopLOKTest::loadDoc(char const*, LibreOfficeKitDocumentType) at desktop/qa/desktop_lib/test_desktop_lib.cxx:215:19 (workdir/LinkTarget/CppunitTest/libtest_desktop_lib.so +0xf2ca0) > #22 in DesktopLOKTest::testGetSignatureState_Signed() at desktop/qa/desktop_lib/test_desktop_lib.cxx:2254:37 (workdir/LinkTarget/CppunitTest/libtest_desktop_lib.so +0x185a42) [...] Change-Id: I935f2e37ce6bcb0448f89e75a4f34f78ba54f58d Reviewed-on: https://gerrit.libreoffice.org/63136 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-09fix oss-fuzz buildCaolán McNamara
Change-Id: I22823323e0b4e15dbd6ea5f7efd35301995315bf
2018-11-09tdf#121294: Allow better localization of gallery properties dialog titleMuhammet Kara
Change-Id: I0ebd1c19a4dfd566f027eb937a2793068a45f913 Reviewed-on: https://gerrit.libreoffice.org/63165 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-11-09loplugin:useuniqueptr in SmDistanceDialogNoel Grandin
Change-Id: Ib5bda0c8cdd0e86ce27a56bfb1b86bc78d93a56f Reviewed-on: https://gerrit.libreoffice.org/63129 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-09loplugin:singlevalfields in scNoel Grandin
Change-Id: I7b87680b9d76bb390a0657f5f1783c3a7c9edbc4 Reviewed-on: https://gerrit.libreoffice.org/63127 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-09loplugin:singlevalfields in swNoel Grandin
Change-Id: Icdb155f9fa7ae79fc193c2da436d9500e7be4d29 Reviewed-on: https://gerrit.libreoffice.org/63126 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-09Do put a BRAND_SHARE_RESOURCE_SUBDIR setting into fundamentalrc for iOSTor Lillqvist
Not sure wht it was commented out. For now use $(LIBO_SHARE_RESOURCE_FOLDER) which is the same "program/resource" as on Unix. Change-Id: I81b8dd4868e68c3a8c38f9b4f84de7bfc8383d28
2018-11-09Alignment (whitespace) cleanupTor Lillqvist
Change-Id: Ie46906d5aa84d91efcb88ca795797883e883939f
2018-11-09Do produce messagte catalogs for sw, too, for iOS, when necessaryTor Lillqvist
Change-Id: I9d22b44e6a835819ad32d1402a0d84ed2e465a73
2018-11-09Related: tdf#121134: Changing http to https where possibleSophia Schröder
Change-Id: I86ece713abdcecab7873b61ea0c08b28b8bcd8bd Reviewed-on: https://gerrit.libreoffice.org/63082 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-09Related: tdf#121134: Changing http to https where possibleSophia Schröder
Change-Id: Ic222fbe902686efe75061d1354339e37671144b8 Reviewed-on: https://gerrit.libreoffice.org/63084 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-09Related: tdf#121134: Changing http to https where possibleSophia Schröder
Change-Id: I6d99873416d9679f330a471b1f836f084bd5d0c9 Reviewed-on: https://gerrit.libreoffice.org/63092 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-09Related: tdf#121134: Changing http to https where possibleSophia Schröder
Change-Id: I3a8d66f97a9e33c9415a469c2c6e7a6b5df89248 Reviewed-on: https://gerrit.libreoffice.org/63091 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-09Related: tdf#121134: Changing http to https where possibleSophia Schröder
Change-Id: Iac627b2884d1cc77cf63ec3bd814f5601080e26f Reviewed-on: https://gerrit.libreoffice.org/63079 Tested-by: Jenkins Reviewed-by: Sophia Schröder <sophia.schroeder@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-09Update git submodulesSophia Schröder
* Update helpcontent2 from branch 'master' - Related: tdf#121134: Changing http to https where possible Change-Id: Ib302c781800d05395be2bfb39a994dec192a3590 Reviewed-on: https://gerrit.libreoffice.org/63021 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-09Update git submodulesSophia Schröder
* Update helpcontent2 from branch 'master' - Related: tdf#121134: Changing http to https where possible Change-Id: Ia406490db4a23c7f9d48f14a74ccb5849f04e184 Reviewed-on: https://gerrit.libreoffice.org/63019 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-09Update git submodulesSophia Schröder
* Update helpcontent2 from branch 'master' - Related: tdf#121134: Changing http to https where possible Change-Id: I5b7df43fd43c07377ac2ec1e0dcecb7a245330f9 Reviewed-on: https://gerrit.libreoffice.org/63011 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-09Update git submodulesSophia Schröder
* Update helpcontent2 from branch 'master' - Related: tdf#121134: Changing http to https where possible Change-Id: I983391c76f7c73ad0edeb85faacdc088a9d73df6 Reviewed-on: https://gerrit.libreoffice.org/62995 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-09Update git submodulesSophia Schröder
* Update helpcontent2 from branch 'master' - Related: tdf#121134 Changing internal and external "http://" links to the more secure "https://" where https is available, even to avoid some redirections. Cleanup of source file(s) included. Change-Id: Ica52ea5910bd439fe9cd295c40f7947083b65d6b Reviewed-on: https://gerrit.libreoffice.org/62897 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-09Revert "NB tabbed compact calc: copy files to install dir"andreas_kainz
This reverts commit bc8d99997b8087dad2a7a6c4ce768e532c4e2d56. Change-Id: I729efca84c364b2ced44511855c9902e4e8afde5 Reviewed-on: https://gerrit.libreoffice.org/63158 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-09tdf#121276 kde5: Don't prevent creating new filesMichael Weghorn
Setting QFileDialogs FileMode to either 'QfileDialog::ExistingFile' or 'QFileDialog::ExistingFiles' will prevent the creation of new files, which should not be done for a save dialog. After all, selecting multiple files at once is probably not a use case for a save dialog after all. Change-Id: Idc4ae5c3bd19352dbc5610b5bcc073423362cb71 Reviewed-on: https://gerrit.libreoffice.org/63142 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2018-11-09Resolves: tdf#121181 expand message boxes to show full titleCaolán McNamara
as MsgBox used to do Change-Id: I03d459b8c18f60a19ea5b0034a8d98f6aa4f5ce4 Reviewed-on: https://gerrit.libreoffice.org/63117 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-09make factory a little more legibleCaolán McNamara
Change-Id: I555e01ede3d8ce2a08f67c3ce6fc686861ea6519 Reviewed-on: https://gerrit.libreoffice.org/63139 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-09tdf#42949 Fix IWYU warnings in chart2/source/controller/dialogs/*hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie6fb9f03f36d71e7b07ef70238d969db65121c8f Reviewed-on: https://gerrit.libreoffice.org/61506 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-11-09starmath: create XMLImporter instances with an uno constructorMiklos Vajna
Change-Id: I96623f6d87ec2f380b37a2de51a089e0a4d59136 Reviewed-on: https://gerrit.libreoffice.org/63134 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-11-09tdf#121116: don't adapt start/end widths if they are set explicitlyMike Kaganski
after commit b8fe3f84a60ea73aed9748844aee80441eb0fc7d Related: #i122121# moved automatic StartEnd adaption to svx Change-Id: Ic4639834ffa55d110f232fbad5f140a8e76df3e9 Reviewed-on: https://gerrit.libreoffice.org/63071 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-09tdf#119581 add FormatPaintbrush to text and table popupmenuandreas kainz
Change-Id: Ic88248078cb34a590396a84dd733818108d9dce4 Reviewed-on: https://gerrit.libreoffice.org/63124 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-09Fix many Java subsequentcheck test by using JUHJan-Marek Glogowski
Splits gb_JunitTest_set_unoapi_test_class_and_jars into two separate defines as: - gb_JunitTest_use_unoapi_jars - gb_JunitTest_use_unoapi_test_class Then replaces many of the gb_JunitTest_use_jars lists with the new gb_JunitTest_use_unoapi_jars to fix the JUH dependencies. This probably adds some unneeded JUH dependencies to some Java tests, but that shouldn't be a problem. Change-Id: I0c4fce6b50f7c6eb8d62bfb2c50f056b97584794 Reviewed-on: https://gerrit.libreoffice.org/63119 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-11-09Simplify and fix Java UNO API test makefilesJan-Marek Glogowski
Originally I just wanted to add the juh.jar to the list of jars of the UNO API tests, but this became tedious work, so after the first few files I decided to replace the similiar makefiles with a common define for the *_unoapi* tests. This patch adds two new make defines to be used used by Java UNO and UNO API tests: - gb_JunitTest_set_unoapi_test_defaults - gb_JunitTest_set_unoapi_test_class_and_jars The first one will deduce most defaults from the test name, but still allows to optionally override most settings. If a test doesn't match the default at all, the 2nd define still shares the common jar files and the main Java UNO class, so the second define adds these to your makefile. The real fix is to add juh.jar to gb_JunitTest_use_jars. Change-Id: I4342fdac5e31f85ea18fb4268e13c287a7adc2b7 Reviewed-on: https://gerrit.libreoffice.org/63118 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-11-09Colibre icons: add icons for context menuesandreas kainz
Change-Id: I22cbbafb0ed4fe361d88aa791adfdc9c7fe0fca4 Reviewed-on: https://gerrit.libreoffice.org/63140 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-09Fix typosAndrea Gelmini
Change-Id: I4beaec7bf6b023a73be464a8c38b0701ff3ae1b1 Reviewed-on: https://gerrit.libreoffice.org/63116 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-09lok: sc: make hi-dpi/zoom compatible with retrieving cell cursorMarco Cecchetti
A bit different approach than trying to handle different zoom levels at the samet time: instead, always handle the spreadsheet at 100%, but use cairo to scale to the actual zoom level. Change-Id: I318aec8fa4baaab2ee1f271223b2e10e26d41fcf Reviewed-on: https://gerrit.libreoffice.org/63040 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-11-09loplugin:useuniqueptr extend to checking more local var deletesNoel Grandin
Change-Id: I5da0f6ecd2577e92e679ed26dd42629dbac4afd4 Reviewed-on: https://gerrit.libreoffice.org/63132 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-09loplugin:useuniqueptr in ScHeaderFieldsObjNoel Grandin
Change-Id: I7d9855a45ebfb5bc185e964d4437ab0c9c2deff4 Reviewed-on: https://gerrit.libreoffice.org/63131 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-09fix bug in listbox height calc in ExtensionBox_ImplNoel Grandin
found by loplugin:singlevalfields Change-Id: Ide29da9222c8323e87fe640bd3548306c1778919 Reviewed-on: https://gerrit.libreoffice.org/63125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-09loplugin:useuniqueptr in ResultSetForQueryNoel Grandin
Change-Id: Ie375f7fded2592cd1e926f14be0216608c2695d6 Reviewed-on: https://gerrit.libreoffice.org/63130 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-24 14:08:12 +0000