summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-09-04Translate German comments/debug strings (leftovers in dirs test to uui)Johnny_M
Translates leftovers found using a custom regex. Additionally: - A few spelling fixes Change-Id: I3772e1b914acc487d80ab14efb815cb178ca3dcb Reviewed-on: https://gerrit.libreoffice.org/41831 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-09-04sw: prefix members of SwFormatCharFormatMiklos Vajna
Change-Id: Id1f860b1355ad835fd2ab991c4bbb7db49dbda69 Reviewed-on: https://gerrit.libreoffice.org/41875 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-04loplugin:unnecessaryparen include c++ castsNoel Grandin
Change-Id: I132d3c66f0562e2c37a02eaf4c168d06c2b473eb Reviewed-on: https://gerrit.libreoffice.org/41874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-04coverity#1417293 'Constant' variable guards dead codeCaolán McNamara
Change-Id: I7ac4d61acf84f6e93138f6df50e8b9a71d939de8
2017-09-04stray debuggingCaolán McNamara
Change-Id: Iabe56218f8914d8d858446eb177cb89dc1cd8601
2017-09-04crashtesting: uninherited GDIObj is also possible hereCaolán McNamara
e.g. kde239472-4.doc and W_META_CREATEPALETTE etc create objects that can be selected but are just a base GDIObj Change-Id: I4b99978c49f5abb7fb1c616d044ba25c793577be Reviewed-on: https://gerrit.libreoffice.org/41869 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-04New loplugin:dyncastvisibilityStephan Bergmann
...to find uses of dynamic_cast where the static (base) type has hidden visibility while the dynamic (derived) one has default visibility, and which may thus fail at least on macOS like happened in d5ed3cd6dbd22bb18542778f1c48f4d5b3ae0f95 "Make WinMtfFontStyle's base class EMFIO_DLLPUBLIC, too". libcxxabi's __dynamic_cast takes static_type and dst_type arguments. Now, if dst_type (the derived type, with default visibility) is taken from .so A (and thus references the version of the base type info hidden in .so A) but the __dynamic_cast call is made from .so B, it passes for static_type the base type information hidden in .so B, and __dynamic_cast will consider the cast to fail. I'm not sure whether hidden intermediary types (in the hierarchy between the dynamic_cast's base and derived types) acutally cause a problem too, but lets flag them with the plugin anyway. The fixes use SAL_DLLPUBLIC_RTTI. For one, there appear to be no other reasons than type visibility to make those classes SAL_DLLPUBLIC. For another, this nicely avoids any actual changes on Windows (where SAL_DLLPUBLIC expands to nothing, and many of the affected classes were explicityl introduced into class hierarchies as "MSVC hacks"). Change-Id: Ia85a9635cebffb1009a9efc1484b8bd4025585d4 Reviewed-on: https://gerrit.libreoffice.org/41802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-04new loplugin:redundantpointeropsNoel Grandin
Change-Id: I8428d86ea9628d69c2b40b36feee3da428a9fe1d Reviewed-on: https://gerrit.libreoffice.org/41787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-04Translate one German variable nameJohnny_M
No functional change is intended. Change-Id: I47312070bea07b0c4994da4f99aa99684cfd850e Reviewed-on: https://gerrit.libreoffice.org/41832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-04tdf#106988 Default favorite charactersheiko tietze
Update of default list according design meeting decision Change-Id: I7db04cf402b5e9ed813f5c15188c45ae52dc7a3e Reviewed-on: https://gerrit.libreoffice.org/41523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-09-04Updated coreOlivier Hallot
Project: help 9d09fe1dd6d9ad7036a42152e558d19cfced237f Add es and ast for helponline localization Change-Id: Ie93eb6af531b882afe573d03e93f8f428afd1def Reviewed-on: https://gerrit.libreoffice.org/41872 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-09-04tdf#89130 Draw: Better UI for handling layer attributesUlrich Gemkow
This is a RFC to implement comment#2 in tdf#89130: Add shortcuts to change layer attributes and make the current attribute values visible in the tab layer name. Already implemented is that pressing LeftMouse+Shift toggles layer visibility. When a layer is not visible its name is displayed in blue. This patch adds that pressing LeftMouse+Ctrl toggles layer locked/unlocked and LeftMouse+Ctrl+Shift toggles layer printable/not printable. The name of a locked layer is displayed italic. The name of a nonprintable layer is underlined. This also adds an Undo action for all changes to mirror the behavior of the layer attribute change dialog box. Change-Id: I5d8fa0585d4f088768716956583e324e66e29602 Reviewed-on: https://gerrit.libreoffice.org/41366 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-03some color view error was removedandreas kainz
Change-Id: Idaebe57a51f589bf626dad9d989a9aefcf9cdfd8 Reviewed-on: https://gerrit.libreoffice.org/41718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-09-03Assertion when editing pattern fieldTamás Zolnai
Change-Id: Ia515382556329feeec359254d3be3f90d2fd17ad Reviewed-on: https://gerrit.libreoffice.org/41870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-03Resolves: tdf#112145 pdf export of editengine highlight color fails sometimesCaolán McNamara
When setting a fill or line color on the outputdevice, put it back to its previous setting when finished with the record, PRIMITIVE2D_ID_POLYPOLYGONCOLORPRIMITIVE2D was the one in this case but protect the other similar ones here too Change-Id: Ifb9b182d72bb6c48a9d9480270fde4384be6291e Reviewed-on: https://gerrit.libreoffice.org/41761 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-03android: prevent null pointer exception on startTomaž Vajngerl
Change-Id: Ifb59ba0cd634d9753f90716bda2af4f58d576afa Reviewed-on: https://gerrit.libreoffice.org/41173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-09-03Removed duplicated includeAndrea Gelmini
Change-Id: Id17744f8c2d48a04e1b5e64a11739605709fb6c3 Reviewed-on: https://gerrit.libreoffice.org/41865 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-03Fix typosAndrea Gelmini
Change-Id: I0ce33d497d405398145653b9b7da81bd066f68e1 Reviewed-on: https://gerrit.libreoffice.org/41868 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-03tdf#112180: avoid crash with specific ttfJulien Nabet
by synchronizing announced size of data (mnByteCount) with the real size of data (mpRawBytes) Change-Id: I973bec9deb1150b630d1df32c89b33c253e4b3d2 Reviewed-on: https://gerrit.libreoffice.org/41860 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-03tdf#112169: Crash while saving character background color to DOCXTamás Zolnai
Change-Id: Iff12b9587b639166caef86f895fb841e83596817 Reviewed-on: https://gerrit.libreoffice.org/41857 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-03iOS, avmedia lib not usedjan Iversen
Change-Id: I13636250552211fa53039178851a64b9e2715cef
2017-09-03set parent for insert media file dialogCaolán McNamara
Change-Id: I71eace1995b229caa75e61df363fd8bad981bed1 Reviewed-on: https://gerrit.libreoffice.org/41851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-03SfxItemPool::AddRef always adds 1Jochen Nitschke
Change-Id: I710ff662ed5b8a77d228e49804d3de418899c76b Reviewed-on: https://gerrit.libreoffice.org/41859 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-09-03Fix leak BacktraceState (enable-dbgutil)Julien Nabet
buffer is created from sal/osl/unx/backtraceapi.cxx with: 70 auto b1 = new void *[maxDepth]; 71 int n = backtrace(b1, static_cast<int>(maxDepth)); 72 return std::unique_ptr<BacktraceState>(new BacktraceState{ b1, n }); and from sal/osl/w32/backtrace.cxx with: 79 auto pStack = new void *[maxDepth]; 80 // https://msdn.microsoft.com/en-us/library/windows/desktop/bb204633.aspx 81 // "CaptureStackBackTrace function" claims that you "can capture up to 82 // MAXUSHORT frames", and on Windows Server 2003 and Windows XP it even 83 // "must be less than 63", but assume that a too large input value is 84 // clamped internally, instead of resulting in an error: 85 int nFrames = CaptureStackBackTrace( 0, static_cast<ULONG>(maxDepth), pStack, nullptr ); 86 87 return std::unique_ptr<BacktraceState>(new BacktraceState{ pStack, nFrames }); Introduced with: https://cgit.freedesktop.org/libreoffice/core/commit/?id=bc9a2ba677ce3fcd46c2bbef6e8faeacb14292c1 Change-Id: Iea0528f5d2b38ff1f3dc4bd50ff035bb100ab981 Reviewed-on: https://gerrit.libreoffice.org/41854 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-03SfxItemPool_Impl::nInitRefCount is always 1Jochen Nitschke
since removal of serialisation code Change-Id: I8cbd7ecd3d4bb61a8d9e6bc098f09f43c02a8f4c Reviewed-on: https://gerrit.libreoffice.org/41850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-03svx: Fix memleak at early returns from SvxXMLXTableExportComponent::saveTakeshi Abe
Change-Id: Ic6da38a47f2c2f2e350a15bad2b2731ed12409a9 Reviewed-on: https://gerrit.libreoffice.org/41853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-03Breeze icons: update editstyle iconandreas kainz
Change-Id: Ic7930b722a36f08555b16c96449d6d6758c2a0a1 Reviewed-on: https://gerrit.libreoffice.org/41788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-09-03svg.js: fix undefined variablefxwan
Change-Id: I9f79d400e78e42b47ebb4078e2618789c34da85a Reviewed-on: https://gerrit.libreoffice.org/37640 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-03svg.js: lift Source & Builder Class outta _parsePath func for less GCfxwan
Change-Id: Id45021a7a7aa4c60d59afa86363d0bd54a7948ff Reviewed-on: https://gerrit.libreoffice.org/37638 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-03tdf#63913 fix Win explorer multi-select open unnamed docs bugNaeil ZOUEIDI
Multi-select explorer action on Windows defaults FILEOPEN 2 different ODF file type documents as template - e.g. opening two different type of files (ie : ODS & ODF) then doesn't keep the original filenames. So now changing the open command for the different file extensions to the same one "soffice.exe -o %1", will keep the names of the _2_ files as they originally are when they are opened together. Change-Id: I2cd5fcb046f294742e59f69b7bf2a897a6ce0c29 Reviewed-on: https://gerrit.libreoffice.org/36995 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-03gpg4libre: When encrypting, show all available GPG keysKatarina Behrens
(not only private ones) Change-Id: I3fd248f4cace1ea248267d5696da9cb70940744e Reviewed-on: https://gerrit.libreoffice.org/41508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-03gpg4libre: Recycle certificate selection dialog for encryptionKatarina Behrens
Change-Id: I699ecff1f62b3dae7ac275823c6721810589c4cf Reviewed-on: https://gerrit.libreoffice.org/41507 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-09-02tdf#37153 ConsiderWrapOnObjPos: also affect wrap-thru objsJustin Luth
MSO doesn't make a distinction when the wrapping is THROUGH. Both DOC and DOCX enable this compatibility setting. Change-Id: I123801fc83b5f4ac6a26a5ea77ba6dba2c60ec39 Reviewed-on: https://gerrit.libreoffice.org/41795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-09-02Just remove an unused variable, no need to keep it commented-outTor Lillqvist
Change-Id: I9719013074413c98f6557c2ef9605838d32855d2
2017-09-02MAC, remove build breaker in session.cxxjan Iversen
commented out unused variable, to allow mac to build. Change-Id: Ibc9f7418f402f4646cd68dd434597b3c1bee53df
2017-09-02tdf#111974: Ensure sufficient space for all sheets in FormulaBuffer...Dennis Francis
and not just for the number of sheet fragments. This is important because we changed the internal storage of FormulaBuffer from based on std::map to std::vector in d17a83fa549f828f29e6939b16ba8b568a75f95e With help from Markus Mohrhard, was able make a simple unit test working in subsequent_filters-test.cxx after adding the missing the component emfio to CppunitTest_sc_subsequent_filters_test.mk Change-Id: I7320dd537266e540d585d3fccfbb8665bba457c7 Reviewed-on: https://gerrit.libreoffice.org/41792 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk>
2017-09-02tdf#96703: getDocumentStorage is called during initializationJulien Nabet
So use DocumentGuard::MethodUsedDuringInit instead of DocumentGuard::DefaultMethod to avoid com.sun.star.lang.NotInitializedException Then we'll got to tackle ODatabaseModelImpl::getOrCreateRootStorage: no source to create the storage from! Change-Id: I1f01bb46088445f3cb3264baee9ad4d45bb5fa8c Reviewed-on: https://gerrit.libreoffice.org/41837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-02Updated coreOlivier Hallot
Project: help de0193157e3b09f5da4ac1a1f17625cc3bf62c14 Add localization to helponline UI * Add support for localization in helponline UI. + translate 4 words + prepare for focused google search * Tweak the index search, open search index for all modules. Change-Id: Id7ad4fd63fe1f9d1334fb65febdee6f60c24361a Reviewed-on: https://gerrit.libreoffice.org/41839 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-09-02Updated coreOlivier Hallot
Project: help c23137d31109336ceed3d429aa60c360c62eba25 Add explanation on Writer compatibility option Change-Id: I99234e637b5ebb752a71d8508b0e7ade40267cac Reviewed-on: https://gerrit.libreoffice.org/41545 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-09-02Typos for "available"Julien Nabet
Change-Id: I8050b1f2ea5414b6e6da3392e8e22d330c794ff5 Reviewed-on: https://gerrit.libreoffice.org/41836 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-02sw: retrieve subject name from signatureAshod Nakashian
From CryptoAPI. Change-Id: I5ec33a754f71d3617090a03887355077d0ffedd7 Reviewed-on: https://gerrit.libreoffice.org/41789 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-02set parent for open file dialogCaolán McNamara
Change-Id: Ic823085567afde211b3991ebb60199dd336f562d Reviewed-on: https://gerrit.libreoffice.org/41819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-02add CVE-2016-10504 testcaseCaolán McNamara
Change-Id: I303259d7d1a92ef1fe5e0816ec154fe51fd831b2 Reviewed-on: https://gerrit.libreoffice.org/41830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-02Replace list by vector session.cxx (vcl)Julien Nabet
+ simplify loops Change-Id: Ic25576db83fe47f7da45667912d24d8ec44494e1 Reviewed-on: https://gerrit.libreoffice.org/41803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-02convert SHAPEFLAG defines to scoped enum ShapeFlagJochen Nitschke
they were defined in escherex.hxx as SHAPEFLAG_* and in msdffimp.hxx as SP_*. Added include for escherex.hxx to msdffimp.hxx. Filled the missing flag bits. ShapeFlag::Deleted is not used at the moment. Convert ADD_SHAPE macro to lambda. Fix horizontal/vertical mixup in RtfSdrExport::AddLineDimensions. Comments for flag Connector were wrong. The flag applies to shapes which ARE connectors. MSO definition: "connector: A line that is used to connect two or more shapes and that remains connected to those shapes." So Rectangles and such with Connector flag don't make sense. Change-Id: I735de00110411b280a302840dc0fcdfac5156399 Reviewed-on: https://gerrit.libreoffice.org/41754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-02dynamic column container: fix some more for loopsNoel Grandin
and add reverse-iterator functionality Change-Id: Ide7ee9d2152871d414246303d76c91da36557524 Reviewed-on: https://gerrit.libreoffice.org/41727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-02use more ErrCode.IsWarning()Noel Grandin
Change-Id: I92a84cbe3d9a9e794d3e875c60d8db7cb40ae5bd Reviewed-on: https://gerrit.libreoffice.org/41827 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-02Add context attribute to translatable entry in .ui file.Kiyotaka Nishibori
a translatable entry without context attribute in 'fpicker/uiconfig/ui/explorefiledialog' causes failure of 'make translation': Traceback (most recent call last): File "/home/kiyotaka/Sources/libreoffice-testing/solenv/bin/uiex", line 30, in <module> keyid = entry.msgctxt + '|' + entry.msgid TypeError: unsupported operand type(s) for +: 'NoneType' and 'str' Error: Failed to execute /home/kiyotaka/Sources/libreoffice-testing/solenv/bin/uiex -i /home/kiyotaka/Sources/libreoffice-testing/fpicker/uiconfig/ui/explorerfiledialog.ui -o /home/kiyotaka/Sources/libreoffice-testing/workdir//pot/fpicker/messages.pot Change-Id: Icdd5e283a30108b45f4b62967e2ce287d338b582 Reviewed-on: https://gerrit.libreoffice.org/41828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-02set parent for insert ole object file dialogCaolán McNamara
Change-Id: Iffa30802f65c950290d74a79c66d679b0ff9d5ea Reviewed-on: https://gerrit.libreoffice.org/41814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-02set parent for insert image file dialogCaolán McNamara
Change-Id: Ibf2adff486947926b9624e762873fb8c46e59c71 Reviewed-on: https://gerrit.libreoffice.org/41813 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-22 09:35:56 +0000