Age | Commit message (Collapse) | Author |
|
Change-Id: I37b04d39efa7b328cff0df54a5b187876db8ba5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110171
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
Change-Id: I3fa0cd7e31a8c89b5fb1eba7b36636e02a785df8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110140
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
otherwise there is no point in subclassing this helper class
Change-Id: I141d32ec84e782003cb41c6ca7abc27fd9a16860
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110167
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This partially reverts LO 6.4.5
commit 598ca431de96d8bfcf18fa2945e9e30f98387474
The output set can contain more than just the font name.
Things like colour and fontsize were being lost when
the "else" clause was added.
Since it looks like the main intent of the else clause was
to avoid specifying a font name twice, erase that from the
property set before writing out the rest of the font properties.
There is a unit test that enforces that.
(I was not able to reproduce the original problem that
this was trying to fix. The entire commit is hard to
revert, and I will assume that the rest of the commit
is useful/accurate, so just fix up a careless portion
of the commit.)
Change-Id: I772e40e8bd75c0589f3308d4d7470229855aed8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110034
Tested-by: Jenkins
Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
Change-Id: Ib52e1b5659b9517692765690834adbddbb1239b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109547
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ibc2e428fcda41f4e9150f3e5029ba346c459c4b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110159
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
lock against scrolling to cursor if the IM requests the surrounding
text around the cursor
seen on launching a menu from a sidebar comment's menubutton in writer
if the cursor is a scroll-off page position in the main document
Change-Id: I325004987f576df65188629bf6fb63e0ed0be9bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110153
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I36df8be817d0f0cb75efa00b0b523f379f67d1d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110126
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Ib939c1f34ae79abfc077080d2c2561ee0ee4a4fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110156
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
(Spotted by cppcheck)
There's a warning that MacroName is overwritten without being used,
and I think it's right; to me it looks like a typo, however I have
exactly zero understanding of VBA macros.
The function starts with:
OUString MacroName( rMacroName );
if ( !MacroName.isEmpty() )
{
OUString aMacroName = MacroName.trim();
if( aMacroName.startsWith("!") )
733 MacroName = aMacroName.copy(1).trim();
.....
MacroResolvedInfo aMacroInfo = resolveVBAMacro( pShell, aMacroName );
if( !aMacroInfo.mbFound )
throw uno::RuntimeException( "The procedure doesn't exist" );
745 MacroName = aMacroInfo.msResolvedMacro;
cppcheck is complaining MacroName written at 733 is always overwritten
at 745 without being used; I think this is a typo and it should be
'aMacroName' that's assigned at 733.
Change-Id: Iac568fea4cb6d1a5430bc32a6cf08311edcb1003
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109849
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
cppcheck spotted a repeated nullptr pair of if's near
the start that can be squashed.
Those gurantee that later pXMLElement is non-null, so
we don't need the test later.
Change-Id: Ie8fc24490ef031416709d55e6fbdd99e9853c4f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110157
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
... removed in commit 6e0fa7d4c7b45c98418c289d1d4715eb9eb133f7.
Change-Id: I6a58ad9d676a5f4b6f654e114eb640d7f82682c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110164
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I01cd06ed51197ffe21102fb1fd0fcdce88ab333b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108810
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit e8a9157878f156e599e66349d7fb60ca39e62514)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109746
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
(cherry picked from commit 820984cdd2bc8f1bd8675606ec92eb42e01fff75)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109796
Tested-by: Jenkins
|
|
Our Mutes uses sritical sections on Windows anyway
Change-Id: Ieb4a8431700215758aaf84dc7a8c2db4b4030804
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110158
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
This removes the need to synchronize using global mutex, and allows
to get correct result when base directory is unavailable.
Change-Id: I9ae70a7d0e8f0840a533a2d0d222336cc0bf0b4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110163
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
- only very few classes (SwNode, SwFormat) are the "owners"
of SwBorderAttrs in the SwCache
- this bookkeeping should not be in such a fundamental class of writer
- also: encapsulate most of the interaction with the cache in the new
sw::BorderCacheOwner. This is mostly to protect the innocent user:
* As interacting with the SwCache directly is very errorprone, because
its glorious idea of using void* of the "owners" as keys to the
entries.
* In C++, reinterpret_cast<void*>(this) might be different along the
class heirachy. This might easily slip under the radar of a casual
user.
Change-Id: I0da774b47885abf52f63aab8d93ebbf41dcf8040
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110112
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
|
|
Change-Id: Ie9dab2d4813b986bf7eb4e2f7dee37171e9be9fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110162
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I5c0071460855317024ab6f61e6b3010d12546227
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110128
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Iad9b007f8a67353343813a44f46a8a0b88b555fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110136
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
when no slide is selected, SyncPageSelectionToDocument(xSelection).first
returns SAL_MAX_UINT16, which is greater than 0
Change-Id: I20225dc3c89a34358949f991d1548e11803c3131
Change-Id: I787d46ff97a6a1401c5bc4ffc136aefc4bbeea29
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110154
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
to ec4eee5be0f97d8664d4b6651613b4fe7e67b68c
- Fix typos
Change-Id: I1789ae94470eb270f9227d26c1f668ad70bbf448
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110161
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: Ifb2b309e2ffe51e491da83f64c12d9c0956fed4f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110127
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
This is similar to the text node deletion case, but here no text is
deleted, just a text node with bullet numbering is turned into one
without a numbering.
Again, it is not necessary to repaint all text frames of the numbering,
since the bullet char is the same for all nodes (unlike e.g. Arabic
numbering).
Change-Id: Ieb071031ca5ce0421c4120c4c89089af6c811848
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110125
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
* Update helpcontent2 from branch 'master'
to f05a74cdb79ebe1da4e58a1df147488d536c8d1e
- Related to tdf#75923: update command "Add to AutoCorrect" in Spelling
* tdf#75923 changed "Always Correct" control to "Add to AutoCorrect"
updated this label change, and clarified the operation of
the button
+ add "Check grammar" control, and adjust explanation
+ add "Ignore Rule" control and explanation.
(and no changes to "hidden" paragraph on Ignore Rule)
* re-arrange presentation of controls to correspond to order
of dialog box
+ add <tip> about how to make New Dictionaries
Thanks to Peter CM/MartinPC!
+ add links in Related topics to "AutoCorrect" and "Spelling Options"
* update to <h2>,<note>
Change-Id: I352d36f09aa7858481da0cc035b84b99b7311622
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109810
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
|
|
* Update helpcontent2 from branch 'master'
to 3afce37d8a47b2b95a8228492b223b462b5e6502
- Create SF_Calc help page (ScriptForge)
Also fixes localization issues in previously created pages adding/removing localize="false" tags.
Change-Id: I71c8dad854be5cacfd4c701850fe539630689d45
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109882
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: Iaba5c16c9f80431a5a9c03b94087e3f0b14fd9d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110132
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
gtk will take the focus out on hiding the GtkSalObject's child widget,
we want to keep it in. e.g. writer's comments in margin feature put
cursor in a sidebar comment and scroll the page so the comment is
invisible, we want the focus to stay in the invisible widget, so its
there when we scroll back or on a keypress the widget gets the keystroke
and scrolls back to make it visible again
Change-Id: If200779ef1b9cdfa9c4b027c27eca0afd5013ac5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110094
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Let's update the master slide combobox by context change.
populateMasterSlideDropdown() will fill the list when we
switch to normal view. The same method is called when the
sidebar created in normal view.
mpMasterSlide->Clear() will clean the list when we switch
to master view. The same happens, when the sidebar is created
in a master view context (the list is empty).
Change-Id: I322619e409a5352ddcd59a249dd0c874054c1e4c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110075
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit 2be52f741e283b5f172ae536f0e99ce0f38df9e1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110114
Tested-by: Jenkins
|
|
* Update helpcontent2 from branch 'master'
to 9104dcbfe3c4d7a845520ad62d34efa0d3356abe
- correction to option labels in AutoCorrect options
* corrections to three option labels to align them with
actual options in AutoCorrect dialog
* removed mention of "digits" in <note> because the "digit"
example was recently added to the "replace dashes" table.
* updated to <note>,<tip>
Change-Id: I32a5c874487e4ccd9c65cca346323257bb27d12a
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110053
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
Tested-by: Jenkins
|
|
* improve choices for accelerator keys
+ add tooltip for "Add to AutoCorrect"
+ add missing extended tip for "Add to Dictionary"
* change "Always correct to" to "Always AutoCorrect to"
in Spelling context menu.
+ add tooltip for "Always AutoCorrect to"
Change-Id: I54428fcd03ed7205a503935c77a7e08f9682bb1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109809
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
O[U]StringBuffer methods
Change-Id: I0ffbc33d54ae7c98b5652434f3370ee4f819f6f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110090
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
So we can call it in the dtor, so we can't forget calling it.
Change-Id: I9cea58ca53763d85a4c239fd90611ac1c398564d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110092
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Ibfbea62c1890d72d5b7b4611d9c09d49e67a85ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110116
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
Change-Id: Ifb63fa5162ea2fe0d1083c6a4361e9595af23317
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110038
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
|
|
Change-Id: Ibbe7aa2229c2a522725bc600a1ba94844910cc84
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110087
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
apple silicon supports to cross compile without special build-tools/full
cross-compiling setup, so just always pass the build/host for firebird.
firebird and nss don't recognize the -macos specifier, so substitute it
by -darwin to make those happy…
Change-Id: I953317fc87da2a20dc91acd88c8528796c3b2a69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110093
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
check for AARCH64 is done for all OS now, so get rid of the superfluous
statement.
The all-OS line was initially ARM64 for apple silicon, then AARCH64 was
added in addtion since that is what ~all other tools use as label - and
finally use withing LO was also unified to use AARCH64 and ARM64 was
removed…
Change-Id: Ief7e5d8bd399c839ff2910fa91ca5bbbff4bcf31
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110080
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
* Use findall since there might be more than 1 bugId in the summary
* put everything from 'source/core/' in others
Change-Id: I7d8d6e28f06a97415378c3d235b617ebc7441fbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110072
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
The main problem is that when editing an existing user-defined index,
the "Create From" changes aren't applied, because it does
pCurTOX->SetCreate() and not pNewTOX->SetCreate().
But that wasn't obvious as the function is obviosly very confused about
its 3 different TOX variables.
pTOX is just used at the end, so just move it there.
pCurTOX can be const.
Then there is an odd condition on pSh->HasSelection() which ends up
doing DelRight() but fortunately it's dead code since commit
e9da29679bce3b544add9233a4aca2b19b78da1a #i97572# cleared the selection
already.
The pNewTOX = pCurTOX there seems pointless because pNewTOX is already a
copy of *pCurTOX.
Change-Id: I1e9c8178e314a188a50272410fbe566e4a566742
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110021
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
The intention of the InvalidateNumRule() call is probably to make sure
that generated number portions in e.g. Arabic numbering are up to date.
But this is not necessary for bullets and causes not needed
invalidations.
Change-Id: Iad555727e5e2b069bbffae0e7650fb8c75a56770
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110079
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I4f03c1cd8bc12f3fa09c815837b289ff088c91d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110086
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I569c7f34acbdf8451cd5c9acf1abd334637072d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110051
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
GetMessageW returns a BOOL with three defined return values; a
bit unexpected (-1 = error, 0 = WM_QUIT, * = dispatch message).
So this tries to handle the non-dispatch results in some way.
It's not clear for me, if there is some sensible way to "recover"
from an error, but from all I've read it doesn't look like it.
"Recover" means in this case, that the last call failed but next
call may still succeed without changing the parameters.
Change-Id: Ib1f366c7ce8b48158d1935938b49d8da991b30e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110043
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Change-Id: I5fb9c630cb4c7e51add571c1fe24b1e5f14cffba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110045
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I5bf2ba8fa432af8b6a560cc60c18bef799834fd0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110039
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
|
|
While looking for some reason for multiple ABORTED Jenkins runs,
presumely due to unprocessed Idles, I found the ImplSalYield code
way too hard to follow, so this restructures the PeekMessage loop
and adds some better comments to make that easier.
We now bail out a bit earlier in m_nNoYieldLock mode and also
account for eventual tick wraps in single message mode, which
isn't needed, as we already just process one message, but it
removes additional conditions and further simplifies the code.
We also now explicitly report GetMessageW non-message return
codes.
Change-Id: Ibd745d5540dd9998570ece9aeb0d37886b627eb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110042
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Missing from commit 9613165239ade3f0b4d3d06e238430aabc9fcff3
("WIN move dtrans code into vcl/win/dtrans").
Change-Id: I257017ae617f72c3ce48828ee34e9246af08fd8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110073
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
This builds on top of commit ada07f303e7cd1e39c73abe0741aefe7d9d73a57,
to allow 0-byte ODT, ODS etc.
Possible TODO would be somehow use default template for such empty files,
getting the template name using SfxObjectFactory::GetStandardTemplate.
That would enable using 0-byte ODF files as means to "create new document
at this location from default template" workflow.
Change-Id: I36e07b80f60c42aecdcc6a7357e5bdd18f62e4f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109989
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Ie40801df8866b52c1458e020ffa9cba120720af7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109552
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
Change-Id: Ic07b3eac1b4e3a5555da5a54d2ce1fa4d284d886
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110047
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|