summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-10-05fix broken SwRect corner gettersLuboš Luňák
BottomRight() wasn't equal to Point( Right(), Bottom()). Smart *sigh*. Change-Id: I0af1c018cdf10a4ff23d95752004e565b4102b13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123076 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-10-05Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 80e65e1d4c346cde0c056a2288dfc02c5aae8f92 - tdf#119891 Help page for scanner dialog Change-Id: Ic379a8c79504d74ea02126b96504214ee968aa1b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123081 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-10-05tdf#119891 Scanner dialog has no Help buttonOlivier Hallot
Added extended tips for the SANE dialog Help page will follow Change-Id: Ibf60eacb561fd65caa682bfa710e52b93b6148d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123080 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-10-05Related: tdf#144817 tdf#144335 Persist SwNavigator tracking settingsJim Raykowski
Add persistence to Writer Navigator Outline, Table, and Section tracking settings. Change-Id: If2d406d0540083d982c2e7ffb78b1a6e156817c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122874 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-10-04drop 'using namespace std' in l*Julien Nabet
Change-Id: I88909cf813f39a52c70d3cbcb19ff326d9bb42d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123069 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-04drop 'using namespace std' in sax/sc/scaddins/sfx2/shellJulien Nabet
Change-Id: I422a6d5b0151115203fd2d7c0fc5597903d3ec8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123064 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-04Related: tdf#143391 avoid creatinging a negative height for the scroll areaCaolán McNamara
this is similar to the case of IconViewImpl::CursorUp so presumably needs the same safety check Change-Id: Id1a79c27daabbf4e2077d46c3d14324695922ca1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123066 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-04Resolves: tdf#143391 scrolling by an entry height taller than visible areaCaolán McNamara
leads to use of a rectangle with a negative height. Drop the attempted optimization, of reducing the area to copy to the min required, if the area is already shorter than the height of the area to scroll. Change-Id: Ic17d3d017f5280d1f6b655a2fc61627f512849cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-04Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to e8881fe8aa87f07547d433e9fbb82e0e768eb719 - update translations for master and force-fix errors using pocheck Change-Id: I1658b92ce4e7a15ad5539e5dcba48bfd1951744f
2021-10-04Bump Glade version for sanedialog.uiOlivier Hallot
Change-Id: I9d787d392d5582fdfbe1928c5e3918863f178260 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123058 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-04Fix typosAndrea Gelmini
Change-Id: Id88532da843e659d337f3529333a17a0c00c8328 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123050 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-04cid#1492313 Logically dead codeNoel Grandin
Change-Id: I2e3802881e5fde178dfc2f999b2ddb35923c221b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123055 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-04Add sal/config.h in preparation for patchChris Sherlock
The convention is that we need to add sal/config.h to the start of files. Made in preparation of movement of PhysicalFontCollection to vcl::font namespace and test class. Change-Id: I7768d9b4c7335f0d9feeba96f0dc67aaaaf8441e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122259 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-04loplugin:constmethodNoel Grandin
Change-Id: I56af10be5f1155db4c7f2190495fe036a9b4236a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123054 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-04We need com_sun_star_animations_AnimatePhysics_get_implementationTor Lillqvist
Fix crash in iOS app reported at https://github.com/CollaboraOnline/online/issues/3321 . Change-Id: I1b5fedb0d5db84cc3f6a75b52c29a39ebe7a6ed9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123046 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123047 Tested-by: Jenkins
2021-10-04Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to 54e30f4bb12626aad1d101d2de20a9b5df10770e - Fix typos Change-Id: I23fad13f1010360c5129358b929c4cabeab89f40 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123049 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-10-04Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 60ed9a0af0790ab7c7ed13149d6f1da200b2470a - tdf#105601 Update Calc's Data menu documentation This patch updates the names of items in the Data menu. It also removes the link for Data Provider, which was previously removed in 24939a5b43b9fe889c3aace027c668666ff61987 The "Streams" page was also updated to inform that the feature is still experimental. Change-Id: Iccd6059e1c4f2203a3c64cc2b32c90eb281194dc Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122934 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-10-04Use isRepresentableInteger hereMike Kaganski
Change-Id: I8ba202232fa42765a8b04113639fdac4b5724aa2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122941 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-04tdf#144439: generate list format string on level changeVasily Melenchuk
Changed values for included upper levels should cause generation of new list format string. Same applies to outlines editing. Change-Id: I90e19d6b5169f68c83ae3e55ec41b9016623d8ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122590 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2021-10-04tdf#144578: numbering: generate include upper levels for UIVasily Melenchuk
In spite of used list format in ODF for UI we still need to show prefix/suffix (already was there) and included upper levels (done in this patch) for correct visualization of level properties. Moved initialization of ListLevel to later steps to avoid overriding of generated values for prefix, suffix and IncludeUpperLevel by some invalid values. Change-Id: I5d132426c06021ed526d16fb09276523105aa7b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122686 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2021-10-04tdf#144609: numbering "None" should still show prefix/suffixVasily Melenchuk
Unlike it was implemented in tdf#143605, prefix and suffix should be displayed anyway, we do not display only numbers. Moreover tdf#143605 did accidentally fix tdf#135164 in a invalid way. So this patch is also providing a better fix for it: untittest is already created and failing without it. Problem in tdf#135164 is inability to distingush missing level text (bullet char in given case) and empty ("") one. In first case we should use abstract level definition. In second - not. Change-Id: Ica3a714d22de4d2f14ebbcb12f0e1311dbc9b801 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122609 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2021-10-04Update git submodulesAndras Timar
* Update dictionaries from branch 'master' to 6c9f1f6c2546d192d1a3b25d5f48d8081170e8be - Avoid duplicated pt_BR_pt_BR.properties in packaging's filelist Change-Id: I5ebb15f0a9f391fdf686ea7ebc7fba98c373b2a6 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/123048 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-10-04Update git submodulesJohnny_M
* Update helpcontent2 from branch 'master' to f49393db3d21f7de379b589c253eb4eb6252cba9 - tdf#132643 Translate German section IDs Change-Id: I5abbe33292ea3ce25d78a7ca3bf161bd8feced38 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122986 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-10-04Related: tdf#141633 similiarly support match combo/listbox font sizesCaolán McNamara
to the desired zoomed font size in the table control Change-Id: Iaf3b004544fdb0311b6c67baad612ba648e8c546 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123043 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-04ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: If6ebf0fb1fa0e3db830ff9d22b1a90446bd3c2d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123039 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-04Pass shell's layout to getLayoutFrame hereJim Raykowski
Change-Id: Ic11d3c6105226059d79f6dd9ff4a2c117131a135 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122665 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-10-04[tdf#42982]Improve runtimeException's MessageVerne-Lai
Change-Id: Ieb1bc302c2c1093561082704e26e3ff3b648db91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122902 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-10-04Breeze: tdf#144637 update & fix table cell borderRizal Muttaqin
Change-Id: I84c5ff88298794b3ccbb883af1664fa93fcc9532 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123034 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-10-04tdf#144674 no context menu in SQL QueryCaolán McNamara
Change-Id: I3c6e9e7896da171d089579165f466b4b6e59a1a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123030 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-04sw: prefix members of SwFieldDataOnlyDlgWrapper, SwPtrItem, ...Miklos Vajna
... SwUINumRuleItem and SwWrtShellItem See tdf#94879 for motivation. Change-Id: I2b360aae78200fcc0a479ec76e895331c6a0e124 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123035 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-10-04tdf#144817 SwNavigator: Section tracking optionJim Raykowski
Add a check button to the section context menu in the content tree to turn section tracking on or off. Change-Id: Ib8c49626f31f41cf85818630d126dee98e1db809 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122844 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-10-04tdf#77051 DOCX: fix user index and index entry supportLászló Németh
defined by field code \f. E.g. INDEX \f "user-index" inserts only the entries defined by XE "entry" \f "user-index" field codes. Revert commit a7bc9c1e4977bd3430df69287fa0a8377a686c58 "fdo#77051: Preservation of Index field flag '\f'", which added an undocumented UNO property only for round-trip support of INDEX, but not for XE index entries, so the DOCX export still resulted a broken index with lost entries, not only the import was broken because of the missing functionality in com.sun.star.text.DocumentIndex. Now the import uses com.sun.star.text.UserIndex and com.sun.star.text.UserIndexMark index and index entry fields, which support the requested user index not only during the DOCX and OpenDocument round-trip, but its run-time functionality, the multiple user-defined indices. Note: for manual testing, update the user index (the first index) of the left original unit test document IndexFieldFlagF.docx: the updated index is not empty, as before, but contains the user index entries. Change-Id: Ia6139bba88907051fd050cfd40809f5544b9a89e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122930 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-10-04SwNavigator: Use select by address function for tracking Fields,Jim Raykowski
Comments, and Hyperlinks Field, comment, and hyperlink tracking selection in the Navigator content tree is done by comparing content address. This patch uses the lcl_SelectByContentTypeAndAddress function to replace redundant code. Change-Id: Idb9f48c46bb432bf2405e4fb0bd8d1830f2c26e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123031 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-10-04drop 'using namespace std' in sd + ucbJulien Nabet
Change-Id: I7d15e9a8c37c29cd6d51c2000f72d1961cd6ff62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123029 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-04Update git submodulesRoss Johnson
* Update helpcontent2 from branch 'master' to 957430b19287e080ddf30b14643e9a653d9293ea - tdf#102151 - reworded the description of page style First Page Number The current description implies that numbering will start at 1 if this option isn't selected. I think most users know what this option is intended for but rewording can make it unambiguous. Related changes: 1) Translate some id's from german to english Change-Id: I4f7734e47b3708be7d1948a7a038ab564d1013e8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123013 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-10-04tdf#144788 SwNavigator: Add footnotes and endnotes to content treeJim Raykowski
This patch introduces lcl_SelectByContentTypeAndAddress function which is useful for content types that can have non unique string entries which can be selected incorrectly by use of the lcl_SelectByContentTypeAndName function. Although footnotes and endnotes names are always unique, lcl_SelectByContentTypeAndAddress is used here in preference of lcl_SelectByContentTypeAndName. Change-Id: Ia118f717f72877cddb932ef19f6d155a7227845d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122970 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-10-04Add extended tips to generalpagewizard.uiOlivier Hallot
Change-Id: Ib5fd25fa109a7cd949fe455701e2240a5a2bcc1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123023 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-10-03Bump Glade release for generalpagewizard.uiOlivier Hallot
Change-Id: I5fbc312316e6fa790026f0b4514cf269ad99afcf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123020 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-10-03drop 'using namespace std' in packageJulien Nabet
Change-Id: Ifa9f5c310a8be988c1058644540ac52f160bc156 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123018 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-03cid#1492280 avoid Missing move assignment operatorCaolán McNamara
Change-Id: I59269ea818a98b4d5a2bf476b3aff2ca4f105a93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123025 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-03Use placement new to avoid one of the allocation calls...Noel Grandin
...when cloning a SfxItemSet. Change-Id: I344fee3863006066eade16db9df37599fc210be3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123001 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-03cid#1492171 annotate Data race conditionCaolán McNamara
and cid#1492172 Data race condition Change-Id: I2ab0d3af626b8d8007082a3dd944149973f8b63e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123026 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-03add missing use-underline to menu entriesCaolán McNamara
Change-Id: I86bf3b52c68e5b4de25af5724df09b817ece0f58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123028 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-03unterminated call to function 'call': missing ')'.Caolán McNamara
Change-Id: Ida812eb3a002da3d99ddf3179d674a653f7ed2b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123027 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-03A more lightweight O[U]StringConcatenationStephan Bergmann
...compared to a full-blown O[U]String, for temporary objects holding an O[U]StringConcat result that can then be used as a std::[u16]string_view. It's instructive to see how some invocations of operator ==, operator !=, and O[U]StringBuffer::insert with an O[U]StringConcat argument required implicit materialization of an O[U]String temporary, and how that expensive operation has now been made explicit with the explicit O[U]StringConcatenation ctor. (The additional operator == and operator != overloads are necessary because the overloads taking two std::[u16]string_view parameters wouldn't even be found here with ADL. And the OUString-related ones would cause ambiguities in at least sal/qa/rtl/strings/test_oustring_stringliterals.cxx built with RTL_STRING_UNITTEST, so have simply been disabled for that special test-code case.) Change-Id: Id29799fa8da21a09ff9794cbc7cc9b366e6803b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122890 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-03drop 'using namespace std' in desktop, e*, f*Julien Nabet
Change-Id: I277dc957798093001f9a3935f97db8ac0314e6a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123022 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-03drop 'using namespace std' in cpputoolsJulien Nabet
Change-Id: Ib454519ba3fb316557dc902c3ed03f9dec9d7900 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123021 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-03drop 'using namespace std' in cppuJulien Nabet
Change-Id: I1c9e6d27e47e25bc5c96ceac8d72c7c112c73d61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123019 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-03drop 'using namespace std' in drawinglayerJulien Nabet
Change-Id: I0221a05b82494971e9c557430dc2f8fe67e494ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123017 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-03cid#1371270 avoid Missing move assignment operatorCaolán McNamara
and... cid#1371301 Missing move assignment operator cid#1371295 Missing move assignment operator cid#1371215 Missing move assignment operator Change-Id: Ib03cddd42128d41e99173e9673bcf6f3cb5ddcbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122998 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>