summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-05-16Give unique, comprehensible names to idles tdf#97087Muhammet Kara
Timers and idles should have programmer comprehensible, unique names. Change-Id: Ida131a4e3ddb7f065d876d78dd501fa831d4cf4a Reviewed-on: https://gerrit.libreoffice.org/24605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-16comment unused biff constantsJochen Nitschke
keep them for documentation Change-Id: Id0b8753ce10df2e656551f4d1d25543544504db3 Reviewed-on: https://gerrit.libreoffice.org/24856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-16fix typoMarkus Mohrhard
Change-Id: Icfc4b73d5664c205ad642c660af5227f403d20ff Reviewed-on: https://gerrit.libreoffice.org/25021 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-15tdf#99783 Invalidate SID_ATTR_CHAR_OVERLINEMaxim Monastirsky
Change-Id: I450f3922408879ec812e4a92fc4950388ce00a73
2016-05-15coverity#1361575 Logically dead codeCaolán McNamara
commit 6312dfdc16f7da09f48628f51bb20b09dc5b7001 Date: Wed May 11 20:11:18 2016 +0200 convert TSS_TYPE to scoped enum changed - if ( ( nInstance < PPT_STYLESHEETENTRYS ) && to + if ( ( nInstance < TSS_Type::LAST ) && but PPT_STYLESHEETENTRYS is 9 and TSS_Type::LAST is 8 Change-Id: I08fb0ad04332cd17e1bdc724799f2927a77359a7
2016-05-15coverity#1361587 Dereference null return valueCaolán McNamara
and coverity#1361588 Dereference null return value Change-Id: Ia282c37e94d9d4131d18b3ccf6a8b7cb12c12344
2016-05-15coverity#1361589 Resource leakCaolán McNamara
this is the pattern used everywhere else. Change-Id: I18bdb43203bae8b9e36d59b4c457aa2087fdc117
2016-05-15coverity#1361592 Uninitialized scalar fieldCaolán McNamara
Change-Id: I6cb8827c9da73516e71aee889cfdfcb7598a9926
2016-05-15coverity#1361590 Uninitialized scalar fieldCaolán McNamara
Change-Id: Idb2ab797294f676e4e734cd272244928adf3f221
2016-05-15Updated coreAdolfo Jayme Barrientos
Project: help ce76ee35c4ee0c5cd6e7b450df2d95b289461e2d tdf#99809 Add back some syntax highlighting tags… … accidentally removed in 8799ced9da7b7aeb37fadf700e062cc3255ebfe0 Change-Id: I799b62bb169dbc0505ed03deef6e460d75a66e9d
2016-05-14tdf#99699 Do nullptr check BEFORE calling methodMichael Weghorn
This fixes a segmentation fault accidently introduced with commit a1fb4ac1991a8da2e527b64a0a01a88a8f2959e3. Change-Id: I244e325934db22e1bffd03486cc5e84f539101f2 Reviewed-on: https://gerrit.libreoffice.org/24994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-14add framework for new calc function testsMarkus Mohrhard
Change-Id: I65aa84d1fa7537ea180232e5c7308a76c3919870 Reviewed-on: https://gerrit.libreoffice.org/24996 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-14add yearfrac test caseRaal
Change-Id: I83a917ebaa360266f84e822fafba7b4834a69387 Reviewed-on: https://gerrit.libreoffice.org/24995 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-14Fix bogus nGroup for SmMatrixNode's tokenTakeshi Abe
It was an obvious mistake because TRGROUP's type is SmTokenType. Change-Id: Ib3b932482c61bd9568aa579d94f742d0dd0b5462 Reviewed-on: https://gerrit.libreoffice.org/24948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-05-14crashtesting: Error: attempt to increment a singular iteratorCaolán McNamara
revert commit 96fab0513215cc416e96e1b2089466afd0d2791c Author: Noel Grandin <noel@peralex.com> Date: Thu May 12 10:07:50 2016 +0200 clang-tidy modernize-loop-convert in writerfilter to xmlsecurity for OOXMLPropertySet::resolve which modifies the mProperties it iterates over e.g. fdo67086-1.docx, fdo72640-6.docx etc Change-Id: I14f829d1425d56110c0aa8d42e751bd2f1d3dd2a
2016-05-14cppcheck: uninitialised members in vclJochen Nitschke
and remove clear() on std::vector types in ctors Change-Id: I8e239676d46e30049d4d5886a5b8de99cadd3f45 Reviewed-on: https://gerrit.libreoffice.org/24983 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-14recognize #REF! particles of invalidated references, tdf#86575 follow-upEike Rathke
... also in OOXML where they were wrongly written so upon next save they'd become a single #REF! as Excel expects. Also for Excel A1 UI notation. Change-Id: I5039d941f003bd4bed762c0e8cd754c23f1c8aa7
2016-05-13remove various crutches for boost::bind/boost::mem_fnMichael Stahl
These aren't used any more, and the C++11 std equivalents don't use get_pointer() overloads. Change-Id: Ib97a6a595863e21a1621c63709ea2b28f6550fde Reviewed-on: https://gerrit.libreoffice.org/24982 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-13filter: convert boost::bindMichael Stahl
Change-Id: Ib17cfa114b7a218c31690c780cf14e128a7992c2 Reviewed-on: https://gerrit.libreoffice.org/24981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-13sdext: replace boost::bindMichael Stahl
MSVC 2013 with non-debug runtime requires an additional assignment operator in OUStringBufferAppender. Change-Id: Ic93fc8d6b1d4760f0eb89e34beb1fcb18e783f73 Reviewed-on: https://gerrit.libreoffice.org/24980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-13recognize #REF! particles of invalidated references, tdf#86575 follow-upEike Rathke
... so they result in an invalid reference again producing a #REF! error instead of a bad string producing #NAME? error. This way we can handle the invalid #REF!.A1 and similar references that were wrongly written to ODFF between 2013 and 2016 until 5.1.4 As a benefit, this is now also the case in UI, e.g. when recompiling changed names with already invalidated references. Change-Id: I117d709f594b7c37d899528a51220c1855b7817d
2016-05-13Related tdf#99272: Prevent bogus com.sun.star.uno.Type(Short[].class) etc.Stephan Bergmann
...so that the JNI UNO bridge will not accidentally reinterpret a Short[] as a short[]. <https://wiki.openoffice.org/wiki/Uno/Java/Specifications/Type_Mapping> makes it clear that the former is not a valid Java representation for UNO type "sequence of short". Needed one fix in bogus test code. Also fixed the two bogus places in odk/examples mentioned in f53e427291321eabe8d060a737e750a94739f911 "Resolves: tdf#99272 new Short[] used instead of new short[]". Change-Id: I8321eb1294ec77b3a9bf73cafb6e7fe337157bb7
2016-05-13more places we use other than end ellipsizeCaolán McNamara
Change-Id: I72b6cb29a8c32540309dcc20fbe5f66dd1a1b774
2016-05-13we don't have an end ellipsize (yet)Caolán McNamara
Change-Id: I987ba9a74d126cc1535db428d105ca3a3fb7c362
2016-05-13Related: tdf#99523 two undo actions listed after dragging a slideCaolán McNamara
to a new place. "Delete Slides" and "Drag and Drop Slides", there should only be the "Drag and Drop Slides" shown. There is one more EndUndo than StartUndo. The extra one is the last one of View::DragFinished. I surmise that this is meant to match the BegUndo of View::StartDrag which is not called in this situation. This doesn't fix tdf#99523, but its the first thing I noticed, so fix that first. Change-Id: I3c31a3cfe83f28892112568bacfb25294366d6cf
2016-05-13tdf#35957 check for preconditions earlierDavid Tardon
This cuts the number of calls of chart::VSeriesPlotter::calculateYMinAndMaxForCategory from ~10 billion to 1760 and load time from a minute to a second... Change-Id: I8ec07d82aa0e915659ce4cbdf6cd1bdd381d6245
2016-05-13sw: document the MoveInvalidXAccToEnd() oddityMichael Stahl
Change-Id: I9e1e3b277a75a2f8c95fa71308af6aff7d81ccc7
2016-05-13tdf#99722 sw: avoid buffering a11y events for not-visible framesMichael Stahl
The problem with the bugdoc is that all pages are moved by 60 twips or so in CheckViewLayout(), which generates a event for every SwTextFrame but there is no SwAccessible for the SwTextFrame yet hence it is a CHILD_POS_CHANGE on the parent, which happens to be (because SwPageFrames are not accessible) the SwRootFrame so that's how we get an enormous number (~90k per 500 pages) WeakReference in the buffered SwAccessibleEvent_Impl pointing to the same object (the SwAccessible of the root frame). Then at a later stage the events are actually sent and SwAccessibleContext::InvalidateChildPosOrSize() discards all but 80 or so that are on the first page. So check the visiblility before buffering the event, to avoid scalability issues in the WeakReference. This brings the cpu-time from 1:37 to 0:17 for the 500 pager, and the full bugdoc is now just 3-4 seconds slower than with a11y disabled. Change-Id: Ia91653fd7572f32ce3cf765a4ecd2b7077ace8f6
2016-05-13Resolves: tdf#99730 lower the barrier for inferior systems, cripple the testEike Rathke
Change-Id: Ifdb9330a0614800831d2e0b673d975e6304738e5
2016-05-13Resolves: tdf#99692 crash in SwPostItMgr with change trackingCaolán McNamara
and annotations presumably since the original commit 0761f81643a6890457e9ef7d913ab5c88c2593a4 Author: Oliver-Rainer Wittmann <orw@apache.org> Date: Thu Dec 19 18:50:58 2013 +0000 - rely annotations on text ranges on new annotation marks - support arbitrary text ranges for annotations - fix undo/redo regarding annotations an text ranges - support annotations on overlapping text ranges - fix *.docx import for annotations on overlapping text ranges - fix ODF import of annotations on text ranges Change-Id: If2aa4ba74f03d0af11def55c2bd299211b3d5d77
2016-05-13Resolves: tdf#99556 if the num of arguments is not 1 infer a rawCaolán McNamara
not just if the num of arguments is > 1 Change-Id: If0cae16cc52685315708ac3b2b8456ede7c1a6ce
2016-05-13Convert VIEWOPT_CORE2 to scoped enumNoel Grandin
Change-Id: I2ceda4d350df56e2a70c47cec589d6e8427d2b0a Reviewed-on: https://gerrit.libreoffice.org/24956 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13Resolves: tdf#96092 crash on activating manage changes sidebarCaolán McNamara
Change-Id: I39ab778114e2317ac471e92f9441ed4a83e7023b
2016-05-13fix ShowTrackFlags legal bitsCaolán McNamara
Change-Id: Iaf3db8f860e6605b3f1d2d025a2e4e4ae3ca4ed7
2016-05-13only ever seen this with Khmer OS fonts, and their name is in ascii anywayCaolán McNamara
Change-Id: I4d6d7d9f79f111ea4ba7dcef201ef31c3ad7d4f9
2016-05-13convert TSS_TYPE to scoped enumNoel Grandin
Change-Id: Ic76d7bfcfe4015c6a02dc5989f8300e5ddde706e Reviewed-on: https://gerrit.libreoffice.org/24896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13tdf#42949: clean up includes in include/oox/ole with iwyuJorenz Paragas
Change-Id: I9cbdc78b540b0f735c451ac561f0f0ccdaf7efbd Reviewed-on: https://gerrit.libreoffice.org/24911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13docxtablestyleexport: can pass the serializer by const refMiklos Vajna
Change-Id: I32409693ffefe753db5b7a5afc2fbec4030e5e93 Reviewed-on: https://gerrit.libreoffice.org/24950 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-13Resolves: tdf#99272 new Short[] used instead of new short[]Caolán McNamara
bridge code expects to see short[] not Short[] so the mapping doesn't work and office blows up regression from... commit ecc90694175190cd6e2b9d1bed8f32850d41ce88 Date: Wed Oct 15 14:14:28 2014 +0200 java: use 'Short.valueOf' instead of 'new Short' git grep "new Short\[\]" shows two suspicious cases of this in odk, but they were always thus, so leaving them untouched. Change-Id: I3306659b5c3f4e0643c200373da777da248bbd42
2016-05-13Fix unittest failure on aarch64Tomáš Chvátal
Change-Id: Ice8d67a7531ef718a9e45d3e5d30817822383749 Reviewed-on: https://gerrit.libreoffice.org/24924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-13slideshow: replace boost::mem_fn with std::mem_fnMichael Stahl
Change-Id: I0b02b2b13cacac48d94e541671a446368f5e527f Reviewed-on: https://gerrit.libreoffice.org/24885 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-13slideshow: tweak BaseContainerNode::forEachChildNodeMichael Stahl
Mac OS X clang/libc++ refuse to invoke a "const" std::mem_fn object. And you thought that MSVC was the only one with a deficient stdlib. Change-Id: Ib7a659adbd270a20b9fdcd661df1bd78d40768ca Reviewed-on: https://gerrit.libreoffice.org/24901 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-13convert EXCHG_OUT_ACTION_FLAG to scoped enumNoel Grandin
and split it off into its own field and parameter Change-Id: Ib13dea5e9475a74cd66a0da4e5ec50a51fbda9d5 Reviewed-on: https://gerrit.libreoffice.org/24926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13clang-tidy modernize-loop-convert in toolkit to uuiNoel Grandin
Change-Id: I805aa1389ef8dde158f0b776d6b59579fa3082e4 Reviewed-on: https://gerrit.libreoffice.org/24921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13clang-tidy modernize-loop-convert in vclNoel Grandin
Change-Id: I79e97a4826bfe3918de223cccf48646a1404f901 Reviewed-on: https://gerrit.libreoffice.org/24922 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13clang-tidy modernize-loop-convert in writerfilter to xmlsecurityNoel Grandin
Change-Id: I334411c6b57c028ffb41b5deb72002f9d54038c3 Reviewed-on: https://gerrit.libreoffice.org/24923 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13convert SHOWTRACK to scoped enumNoel Grandin
Change-Id: Ibf06f6c79f80d7265ae3239c1ea0088118e92e21 Reviewed-on: https://gerrit.libreoffice.org/24894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13Fix wrong commentJulien Nabet
Change-Id: Idcb57eaa43c753bf4920787c5f342e1ac923ff3f Reviewed-on: https://gerrit.libreoffice.org/24939 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-05-13Convert ACT to scoped enumNoel Grandin
Change-Id: I68ec79c9c85abcd91da379eecf3ed4331a15861b
2016-05-13convert PROT to scoped enumNoel Grandin
Change-Id: I7aaa5c45a224d2f97861864bed00eaddb9b7f317
generated by cgit (git 2.34.1) at 2025-02-23 04:34:46 +0000