summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-25drop OConnectionURLEdit and OConnectionHelperCaolán McNamara
Change-Id: I028b243b21a41f3fbd23dea57ea90f77e4a5317c Reviewed-on: https://gerrit.libreoffice.org/62327 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25rename DBOConnectionTabPageSetup back to OConnectionTabPageSetupCaolán McNamara
Change-Id: I3d5c90e51922350ca3bb6f59fc94bf5768c995f1 Reviewed-on: https://gerrit.libreoffice.org/62326 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25fix up wizards pagesCaolán McNamara
Change-Id: Icea2c91d06af4fc5d190186d4f6d624ebfc991ff Reviewed-on: https://gerrit.libreoffice.org/62325 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25drop unused stuffCaolán McNamara
Change-Id: Icd92801dc88c603c369bfb6c85bf4278ea609ea9 Reviewed-on: https://gerrit.libreoffice.org/62324 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25weld OJDBCConnectionPageSetupCaolán McNamara
Change-Id: I8c194c8efa17079253c857e171af203c17d3aff3 Reviewed-on: https://gerrit.libreoffice.org/62323 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25weld OSpreadSheetConnectionPageSetupCaolán McNamara
Change-Id: Ibcf63af2bb1272d35420ac1b6f71aaa6f147ec16 Reviewed-on: https://gerrit.libreoffice.org/62322 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25rename DBOTextConnectionHelper back to OTextConnectionHelperCaolán McNamara
Change-Id: Ie20403b88c8510465ab7cccbb431072331dbc96f Reviewed-on: https://gerrit.libreoffice.org/62321 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25rename DBCharSetListBox back to CharSetListBoxCaolán McNamara
Change-Id: I14c8b95ee166b75aa309f701be569f54b57538aa Reviewed-on: https://gerrit.libreoffice.org/62300 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25remove unused stuffCaolán McNamara
Change-Id: I5ae616f46cb86b35435e007f98e4b0f882a75751 Reviewed-on: https://gerrit.libreoffice.org/62299 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25weld OTextConnectionPageSetupCaolán McNamara
Change-Id: Iaa4fdc97be23ccd50471c26923745fd565e10653 Reviewed-on: https://gerrit.libreoffice.org/62298 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-25avoid running into commandline length limits on win with all-lang helpChristian Lohmaier
also simplify the recipe by removing the one-time-use only calls to helper commands Unclear though why help adds the lang-dirs individually, as all come from the same subdir and end up in the same target dir... Change-Id: I489b1ac3f1312a565fb2a9cfc071d94201c74555 Reviewed-on: https://gerrit.libreoffice.org/62304 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-10-25loplugin:unusedmethodsNoel Grandin
Change-Id: I1f9ac5f8a090f365d9a21486029e1c13d721a4a4 Reviewed-on: https://gerrit.libreoffice.org/62338 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-25tdf#42949 Fix IWYU warnings in include/xmlscript/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iacc5b98b947a26ca920cb9c49e579bc61d69b0c9 Reviewed-on: https://gerrit.libreoffice.org/62119 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-25vcl: use default member initializer for PDFElementMiklos Vajna
Less code and other classes in the same header already do this. Change-Id: I8a64cabcdb4b95acb7e2f55ec371568702d9c331 Reviewed-on: https://gerrit.libreoffice.org/62333 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-25tdf#108064 OOXML export: keep preset dashes with linewidth < 1ptAdam Kovacs
Before this patch prstDash xml tags were preserved only with linewidth 1/4 pt, 1/2 pt or 3/4 pt below 1 pt. Now it is working for example with 0.33 pt. Change-Id: I36372edfaea560d8913cd4aa8ee551ee059ec682 Reviewed-on: https://gerrit.libreoffice.org/61737 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-10-25Fix typoAndrea Gelmini
Change-Id: I48748a2ceb359c3da8f838887e48a81a717df552 Reviewed-on: https://gerrit.libreoffice.org/61711 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-10-25Adapt external/epm/asan.patch.0 to pre-C99Stephan Bergmann
...as e.g. still used in <https://ci.libreoffice.org/job/lo_daily_update_gandalf/511/> Change-Id: I11d85ff9ae7462a4149272344e0b0f52eb120c22
2018-10-25LibreLogo: add unit testsLászló Németh
for program running and command name expansion, and for following fixes: tdf#106792: regression in line length and continuous line drawing tdf#100941: line breaking by "magic wand" tdf#120422: program lines are different paragraphs by "magic wand" Also add function __is_alive__() to LibreLogo.py to check LibreLogo program termination via XScript API. Change-Id: If884b3fd608a6e8077be853eb2dd17fbdfff2011 Reviewed-on: https://gerrit.libreoffice.org/62263 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-10-24tdf#120038 Fix broken svg galler arrow A25andreas kainz
Change-Id: I833e4d7bddec89d83ea09fbf677c818988c149ce Reviewed-on: https://gerrit.libreoffice.org/62312 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-24Fix typosAndrea Gelmini
Change-Id: I64cfe4c24d3abb4a8445fd2e7b832b2bdb0b40d3 Reviewed-on: https://gerrit.libreoffice.org/62310 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-24Removed executable permission on hxx fileAndrea Gelmini
Change-Id: I0004193fc0de93632cdd05628052c35cc524690f Reviewed-on: https://gerrit.libreoffice.org/62311 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-24Fix typoAndrea Gelmini
Change-Id: I403de8537d36dbd476e34070e1a02d4db52fba82 Reviewed-on: https://gerrit.libreoffice.org/62313 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-24ofz#11103 Integer-overflowCaolán McNamara
Change-Id: I4ca56e675056b8bd40c6e9b43516815511b33f20 Reviewed-on: https://gerrit.libreoffice.org/62302 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24hdo is always a HWPDrawingObjectCaolán McNamara
Change-Id: Ia9484304e9fc3c5bc9aa833bf14711203e9e72fe Reviewed-on: https://gerrit.libreoffice.org/62306 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24ofz#11119 Direct-leakCaolán McNamara
since... commit 55f0b65b0568b8a8b1d823578eea1cbf633f4134 Date: Tue Oct 23 09:27:51 2018 +0200 loplugin:useuniqueptr in LoadDrawingObject Change-Id: Id5c7929482a1dc00584c4c1a228d993525fc8ed6 Reviewed-on: https://gerrit.libreoffice.org/62307 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24tdf#120764 Toolbar popups sometimes not showing under WaylandMaxim Monastirsky
This happens with gtk 3.24 if the toolbar button is clicked when the tooltip of that button is visible. The warning gtk emits is "Tried to map a popup with a non-top most parent". The solution is to hide the tooltip early on mouse button press event processing. (gtk does hiding too, but in a way which isn't useful here - see the code comment. We also have similar code for the non-native case in ImplHandleMouseEvent of winproc.cxx.) Note that it's likely a gtk bug, as this new tooltip behavior breaks some native cases too, e.g. combo boxes with tooltips. But we can't leave our toolbars broken until this is fixed upstream. Change-Id: I1ce8bffcd78a3bcbbfe2ffdd1bd006ae5dc79618 Reviewed-on: https://gerrit.libreoffice.org/62207 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-10-24Tell the actual end result and not an intermediate one in the SAL_INFO()Tor Lillqvist
Change-Id: If896ed5b1a8daa3dc057888b858b6b0d5da18f28
2018-10-24pvs-studio: silence V530 use std::unique_ptr less weirdlyCaolán McNamara
Change-Id: I24bcf03ca9277597aea6ccaac661c7e4e3869541 Reviewed-on: https://gerrit.libreoffice.org/62168 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24external/epm: AddressSanitizer: strcpy-param-overlapStephan Bergmann
...during CustomTarget_instsetoo_native/install Change-Id: Ia796057b98044ccd227c150788d5caa1ef68eb25 Reviewed-on: https://gerrit.libreoffice.org/62308 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-24weld ODbAdminDialogCaolán McNamara
Change-Id: I691ce67b55fb16d06d7266ebe671ac31e30c05d5 Reviewed-on: https://gerrit.libreoffice.org/62297 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24fix OGeneralSpecialJDBCDetailsPageCaolán McNamara
Change-Id: Iee83dcd992ff5d66ff4090019ceb764051a9c776 Reviewed-on: https://gerrit.libreoffice.org/62296 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld TextConnectionSettingsDialogCaolán McNamara
Change-Id: Iaa08d066d9c2198bca7e21f619fb89808620fba9 Reviewed-on: https://gerrit.libreoffice.org/62295 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24rename DBOCommonBehaviourTabPage back to OCommonBehaviourTabPageCaolán McNamara
Change-Id: I7877f746280b76bce73998e1ad48f21b02eb521c Reviewed-on: https://gerrit.libreoffice.org/62294 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24drop now unused OCommonBehaviourTabPageCaolán McNamara
Change-Id: I0a7ff8a018cbe20481360196f6f2ed919f11ded8 Reviewed-on: https://gerrit.libreoffice.org/62293 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld DBMySQLNativeSettingsCaolán McNamara
Change-Id: I0c4f27e02f9dd6c7bb42ffe49043e98e043d9084 Reviewed-on: https://gerrit.libreoffice.org/62292 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OTextDetailsPageCaolán McNamara
Change-Id: I81abd72fb7843aebcf093e421472ecca6998847e Reviewed-on: https://gerrit.libreoffice.org/62291 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OMySQLODBCDetailsPageCaolán McNamara
Change-Id: I8f0c291a9bfc3c9cc5edb6095fd31aba68a6feac Reviewed-on: https://gerrit.libreoffice.org/62290 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OGeneralSpecialJDBCDetailsPageCaolán McNamara
Change-Id: I0db0801167d36a04ebbe467b29862efcbb54e599 Reviewed-on: https://gerrit.libreoffice.org/62289 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OUserDriverDetailsPageCaolán McNamara
Change-Id: I05db75b90dbb4302f968f129437630adb47a35a8 Reviewed-on: https://gerrit.libreoffice.org/62288 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OOdbcDetailsPageCaolán McNamara
Change-Id: I798fa10a1cb4288b0a73e8439b71851c56113129 Reviewed-on: https://gerrit.libreoffice.org/62287 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OAdoDetailsPageCaolán McNamara
Change-Id: I81cbac086a00cdaa649c2794a9192dce8e7c5efe Reviewed-on: https://gerrit.libreoffice.org/62286 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OLDAPDetailsPageCaolán McNamara
Change-Id: I9477a52419db08812ccef95107c410685449fa6c Reviewed-on: https://gerrit.libreoffice.org/62285 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld ODbaseDetailsPageCaolán McNamara
Change-Id: Ia0d953ee2d4a4f35ba6f59bb6bd6b1a04ed25f63 Reviewed-on: https://gerrit.libreoffice.org/62284 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24weld OConnectionTabPageCaolán McNamara
Change-Id: Icdbe5d95d0850d131018d21d0a21cb12109d565c Reviewed-on: https://gerrit.libreoffice.org/62283 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24add adjustment to specialsettingspageCaolán McNamara
Change-Id: Ia897b8f01618e499817f16e8ac2d1e0a8bef3367 Reviewed-on: https://gerrit.libreoffice.org/62282 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-24Reorganize FrameBorderPrimitive creationArmin Le Grand
Step1: Basic concept, move stuff to svx and new SdrFrameBorderPrimitive2D Step2: Adapt all creators/usages to use SdrFrameBorderData/SdrFrameBorderPrimitive2D, check functionality Step3: Re-implement mergre of BorderLinePrimitive2D during decomposition of SdrFrameBorderPrimitive2D to keep the number of primitives low from the start, make merge optional (not urgently needed) Step4: Migrate and isolate all helper methods and classes involved in geometry creation of border lines to the implementation (.cxx) of the new primitive Change-Id: I840b6765439bd995f2c57ef36315427b1f0f3e21 Reviewed-on: https://gerrit.libreoffice.org/62247 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-10-24Simplify containers iterations in test..toolsArkadiy Illarionov
Use range-based loop or replace with STL functions. Change-Id: If8fac9236a4696c8e56c0e81c60c429782581b96 Reviewed-on: https://gerrit.libreoffice.org/62262 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24remove more rtl::OUString and OString prefixesNoel Grandin
which seem to have snuck back in since the great rounds of removals. Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1 Reviewed-on: https://gerrit.libreoffice.org/62229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24ScDoubleItem is deadNoel Grandin
i.e. no way to get any useful information out of it, at least since commit 8b3fcb6a4f80e803586120535768745f6637b34d Date: Fri Aug 11 10:01:25 2017 +0530 Removing unused SfxItemPool serialisation from svx Which means that SID_RANGE_VALUE is also useless. Possibly the commit that added this had a bug, and it meant to use SvxDoubleItem, which implements the necessary QueryValue/PutValue methods to be able to interact with macro code. Change-Id: I6ffb0c46f6f0864f202d71f0e157d7e1d0f54f51 Reviewed-on: https://gerrit.libreoffice.org/62232 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-24Introduce OutputDevice type OUTDEV_PDFJan-Marek Glogowski
Originally I thought mpPDFWriter can be used to create PDF from any OutputDevice, but it's actually just set for the internal VirtualDevice of the PDF writer. So this gets rid of all the special mpPDFWriter and GetPDFWriter() handling and replaces it with checks for OUTDEV_PDF. But since ImplPDFWriter used to be a OUTDEV_VIRDEV, this also introduces OutputDevice::IsVirtual(), which now replaces most of the direct OUTDEV_VIRDEV checks. Change-Id: I11824143b6b8833ecc81119762448cbdf1145dbc Reviewed-on: https://gerrit.libreoffice.org/62257 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>