summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-07-28loplugin:checkunusedparams more part1Noel Grandin
seems I got one of the checks wrong, and was missing a bunch of stuff Change-Id: I2c662fc4e735f8d6cbe56c6f82906a60a580331b Reviewed-on: https://gerrit.libreoffice.org/40481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-27sw: these arrays are constantTakeshi Abe
Change-Id: Id80e939412ed05324300189949d47b3f33bb5116 Reviewed-on: https://gerrit.libreoffice.org/40263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-27ofz#2759 null dereferenceCaolán McNamara
Change-Id: I23671f0cea592c92a05b34b3cf284a47a73962b1
2017-07-27sw: convert to assertMichael Stahl
Change-Id: I96f91105d32b18c29bd82eedcf2f93c54ad5f229
2017-07-27sw: assert that index is valid in SwFntObj::DrawText()Michael Stahl
If nCnt = 0 the only thing that will happen is an infinite loop. Change-Id: I23c5d0ff9d36fbfb3eabc93476fe3ca1c558f91c
2017-07-27sw: inline pointless RESCHEDULE macroMichael Stahl
Change-Id: I093c8fbf5bb181d8e530fe33805a16aea94cdd62
2017-07-27tdf#108991 sw: fix crash due to not formatted but "valid" SwTextFrameMichael Stahl
SwTextNode::EraseText() on the paragraph at the start of the selection notifies the SwTextFrame: 0 in SwFrame::ImplInvalidateSize() (this=0x3088a20) at sw/source/core/layout/wsfrm.cxx:1568 1 in SwFrame::InvalidateSize() (this=0x3088a20) at sw/source/core/inc/frame.hxx:849 2 in SwTextFrame::InvalidateRange_(SwCharRange const&, long) (this=0x3088a20, aRange=..., nD=-62) at sw/source/core/text/txtfrm.cxx:741 3 in SwTextFrame::InvalidateRange(SwCharRange const&, long) (this=0x3088a20, aRange=..., nD=-62) at sw/source/core/text/txtfrm.cxx:708 4 in SwTextFrame::Modify(SfxPoolItem const*, SfxPoolItem const*) (this=0x3088a20, pOld=0x0, pNew=0x7ffc8da38c50) at sw/source/core/text/txtfrm.cxx:1005 5 in SwClient::SwClientNotify(SwModify const&, SfxHint const&) (this=0x3088a20, rHint=...) at sw/source/core/attr/calbck.cxx:67 6 in SwModify::CallSwClientNotify(SfxHint const&) const (this=0x2f05550, rHint=...) at sw/inc/calbck.hxx:355 7 in SwModify::ModifyBroadcast(SfxPoolItem const*, SfxPoolItem const*) (this=0x2f05550, pOldValue=0x0, pNewValue=0x7ffc8da38c50) at sw/inc/calbck.hxx:176 8 in SwModify::NotifyClients(SfxPoolItem const*, SfxPoolItem const*) (this=0x2f05550, pOldValue=0x0, pNewValue=0x7ffc8da38c50) at sw/source/core/attr/calbck.cxx:142 9 in SwTextNode::EraseText(SwIndex const&, int, SwInsertFlags) (this=0x2f05550, rIdx=SwIndex (offset 1), nCount=62, nMode=SwInsertFlags::DEFAULT) at sw/source/core/txtnode/ndtxt.cxx:2355 10 in SwUndoDelete::SaveContent(SwPosition const*, SwPosition const*, SwTextNode*, SwTextNode*) (this=0x3052950, pStt=0x7ffc8da390b8, pEnd=0x7ffc8da39100, pSttTextNd=0x2f05550, pEndTextNd=0x2faefe0) at sw/source/core/undo/undel.cxx:387 However, at this point the first page, which contains this paragraph, is not visible; so the Action that is created in ViewShell::ImplEndAction() will skip over the first page and start at the 2nd page, which is the first visible one. Now it happens that the last paragraph in the document has a page break on it, and formatting it causes it to move forward (a new page to be inserted and the empty 2nd page to be deleted). Unfortunately it then decides to reset the mbValidSize flag on the preceding SwTextFrame, assuming that it was set by its own moving forward, and not already set before. 0 in ValidateSz(SwFrame*) (pFrame=0x3088a20) at sw/source/core/layout/calcmove.cxx:1082 1 in SwContentFrame::MakeAll(OutputDevice*) (this=0x308b4a0) at sw/source/core/layout/calcmove.cxx:1276 2 in SwFrame::PrepareMake(OutputDevice*) (this=0x308b4a0, pRenderContext=0x306f850) at sw/source/core/layout/calcmove.cxx:346 3 in SwFrame::Calc(OutputDevice*) const (this=0x308b4a0, pRenderContext=0x306f850) at sw/source/core/layout/trvlfrm.cxx:1760 4 in SwLayAction::IsShortCut(SwPageFrame*&) (this=0x7ffc8da394a0, prPage=@0x7ffc8da392b8: 0x7491e30) at sw/source/core/layout/layact.cxx:1085 5 in SwLayAction::InternalAction(OutputDevice*) (this=0x7ffc8da394a0, pRenderContext=0x306f850) at sw/source/core/layout/layact.cxx:490 6 in SwLayAction::Action(OutputDevice*) (this=0x7ffc8da394a0, pRenderContext=0x306f850) at sw/source/core/layout/layact.cxx:351 7 in SwViewShell::ImplEndAction(bool) (this=0x30829c0, bIdleEnd=false) at sw/source/core/view/viewsh.cxx:278 8 in SwViewShell::EndAction(bool) (this=0x30829c0, bIdleEnd=false) at sw/inc/viewsh.hxx:605 9 in SwCursorShell::EndAction(bool, bool) (this=0x30829c0, bIdleEnd=false, DoSetPosX=false) at sw/source/core/crsr/crsrsh.cxx:258 10 in SwActContext::~SwActContext() (this=0x7ffc8da396a0, __in_chrg=<optimized out>) at sw/source/core/edit/edws.cxx:159 11 in SwWrtShell::DelRight() (this=0x30829c0) at sw/source/uibase/wrtsh/delete.cxx:260 So at the end of the Action, the first page is still not valid, and the SwTextFrame has mbValidPos = false, but it does have mbValidSize = true. Then when the SwCursorShell::UpdateCursor() calls SwViewShell::MakeVisible(), which creates another Action, the SwTextFrame is not formatted and its SwTextPortions do not match the paragraph text content, which is the cause of the crash. Change-Id: I6e8153c574469a94d190fda8bc3007d17a474c7f
2017-07-27sw: fix string accesses in SwScanner::NextWord() (related: tdf#109081)Michael Stahl
getWordBoundary() can return bounds that do not include the starting nPos, if there are ZWSP characters at the starting position. This happens in the bugdoc of tdf#109081 where paragraph starts with 3 ZWSP and then 5 dashes, SwScanner is created from 0 to 1 and bounds are 3 to 8. Change-Id: I5fc41b98568a7211fc7d5f29bb87840371a4c005
2017-07-27tdf#108887 : Move the code of ScDrawView::CheckOle()...Dennis Francis
to getOleSourceRanges( renamed from getChartSourceRanges) and optionally calculate source ranges to avoid code duplication and do OLE detection as done in CheckOle() which was working well before the commit c55d52262ea1d5f869a9528fd051ee19e687f1cc. Matching test cases (in uitest) coming up soon in another commit. Change-Id: I64a12eef02afb488bed4bc8de1a18823c89128bb Reviewed-on: https://gerrit.libreoffice.org/40278 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jean-Baptiste Faure <jbfaure@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-27Moving legacy contexts to FastContexts:Mohammed Abdul Azeem
ScXMLDataPilotTableContext ScXMLDPSourceSQLContext ScXMLDPSourceTableContext ScXMLDPSourceQueryContext ScXMLSourceServiceContext ScXMLDataPilotGrandTotalContext ScXMLSourceCellRangeContext ScXMLDataPilotFieldContext ScXMLDataPilotFieldReferenceContext ScXMLDataPilotLevelContext ScXMLDataPilotDisplayInfoContext ScXMLDataPilotSortInfoContext ScXMLDataPilotLayoutInfoContext ScXMLDataPilotSubTotalsContext ScXMLDataPilotSubTotalContext ScXMLDataPilotMembersContext ScXMLDataPilotMemberContext ScXMLDataPilotGroupsContext ScXMLDataPilotGroupContext ScXMLDataPilotGroupMemberContext ScXMLDPFilterContext Change-Id: Ie01ddb0f740a1b41a44e4abc9fe1bea3ab32cb12 Reviewed-on: https://gerrit.libreoffice.org/40326 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-27loplugin:externandnotdefined + loplugin:unreffunJan-Marek Glogowski
Change-Id: Iedd529d4b5064beed3d2fd99cfe4e0312c024187
2017-07-27add test for update address code, related tdf#107289Markus Mohrhard
Change-Id: I955cf49fe5fa47fb38d2c8dacf4aadc8e3f7d651 Reviewed-on: https://gerrit.libreoffice.org/39317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-27Ditch use of EditTextObject::Store() in ScGlobal::EETextObjEqual()Eike Rathke
This was the last incarnation of SfxItem binary stream serialization that is to be eliminated after clipboard use is gone. The "full" EditTextObject::operator==() in EditTextObjectImpl::operator==(), and via ContentInfo::operator==() in SfxItemSet::operator==(), also compare the SfxItemPool pointers which gets in the way here (not stored to stream hence didn't matter and maybe the reason for not having switched EETextObjEqual() to use operator==() back in the days). Introduce *::Equals() functions that do not compare pool pointers and let SfxItemSet::Equals() in that case not assume it would be operating on one pool only. Change-Id: Ifff939a92101c7f74695b676a45a7fdbb4f1d7f6 Reviewed-on: https://gerrit.libreoffice.org/40492 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-27Related: tdf#106872 factor out getting selected shapesCaolán McNamara
Change-Id: I765c482a41e9681a1eb145c1833cc94f35a27db3
2017-07-27Related: tdf#106872 amount of a11y selection listeners constantly growsCaolán McNamara
so it gets progressively slower Change-Id: Ib53c69231c902d064b939be096e0dbeab2f0fc71 Reviewed-on: https://gerrit.libreoffice.org/40490 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-27tdf#90510 : Override default point label placement setting...Dennis Francis
with global label placement setting if available while importing xls chart. Added unit test in chart2import.cxx that asserts one of the point label setting in the bugzilla xls document. Change-Id: Id331f56c05873554b22920e02805909c50fb8619 Reviewed-on: https://gerrit.libreoffice.org/40402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-27sw: add new TextParagraph property to XTextRangeMiklos Vajna
A text range represents a selection or cursor position, so similar to sections or tables, it makes sense to expose the containing paragraph as well. This new property does exactly that. Change-Id: If92a3b5e61f13c7c14ca52bc8593a2b286a596cc Reviewed-on: https://gerrit.libreoffice.org/40483 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-27Makefile: fix fetching for the build platformMichael Stahl
The invocation of make fetch added in commit fe3fb5ecd3b66e32cc5aa64a2afffa572353740e didn't do anything because the force-restart didn't actually restart make because it touched "Makefile" but the make read "$(BUILDDIR)/Makefile", and make isn't smart enough to notice those are the same. Change-Id: I85cbcba3bf9c3c7b89d4ee33f772820d19542f4a Reviewed-on: https://gerrit.libreoffice.org/40482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-27make animation loop sal_uInt32 consistentlyCaolán McNamara
all this foo is ultimately animated gifs and the count there is limited to unsigned 16bit Change-Id: Ib6e6dde7355f3619bb7735743e686e6338a235ee
2017-07-27align ImpVclMEdit::SetMaxTextWidth arg with TextEngine::SetMaxTextWidthCaolán McNamara
Change-Id: I7cc7531d6a1770edd8b644c6958b91275a53dd84
2017-07-27Resolves: tdf#109289 add SvxColorListBox::IsValueChangedFromSavedCaolán McNamara
and remove PushButton::IsValueChangedFromSaved Change-Id: Ib1c51e27fd708c5d4811c90ef5659b4d55dd8860
2017-07-27Related: tdf#109289 move PushButton::IsValueChangedFromSaved to consumerCaolán McNamara
inheriting the IsValueChangedFromSaved from PushButton has allowed undesirable behaviour to be selected Change-Id: Ifccb1657d2565005e6f9e239c6118f2e5ae7970c
2017-07-27loplugin:constparams in chart2Noel Grandin
Change-Id: Ic325b79f04e04aa19e08a60db30b982d90f04c80 Reviewed-on: https://gerrit.libreoffice.org/40480 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-27simplify unusedfields pluginNoel Grandin
using some wrappers around callee and caller AST nodes Change-Id: I599a04a18caa3ada70bcb266e228208b7a81f1a1
2017-07-27lok: sc: copy / paste confusion -- workaroundMarco Cecchetti
Problem: 1. (a) copied April 2. (a) pasted -> April 3. (b) copied March 4. (a) pasted -> March [should have been April] where (a), (b) are different views Solution: A real solution would require to have one clipboard per view. This patch is only a workaround, which doesn't allow to paste content which has been copied in a different view; it takes also care to disable the "Paste" entry in the context menu. Change-Id: I3254f130af106299b0b519884a4ca03db08fc4c8 Reviewed-on: https://gerrit.libreoffice.org/40459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-07-27loplugin:constparams in xmlsecurityNoel Grandin
Change-Id: I41f153af55262d201c0fb024460de0e9f1c14670 Reviewed-on: https://gerrit.libreoffice.org/40472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-27loplugin:constparams in filterNoel Grandin
Change-Id: I0ba463fcaff4c449f762a7969e0feab659b37adf Reviewed-on: https://gerrit.libreoffice.org/40471 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-27gtk3: Resolves: tdf#109227 take modifier key into account for dndCaolán McNamara
Change-Id: Id0aa4ced8644ddbee9e1a0453887f07907547aae
2017-07-27fix oss-fuzz build moreCaolán McNamara
Change-Id: I3fa40382fcc9ac0d60329044c7820d1af8eb5a7f Reviewed-on: https://gerrit.libreoffice.org/40473 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-27loplugin:constparams in slideshowNoel Grandin
Change-Id: Ifa9fda35020d456338781879df9fba4c0ee535fd Reviewed-on: https://gerrit.libreoffice.org/40469 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-27tdf#109202 Add mimetype to image elementSamuel Mehrbrodt
Browsers don't recognize base64 svg if the mimetype is missing. So we add the image mimetype to our flat odf export, which the xhtml export uses and transforms it into an xhtml document. Change-Id: I21aafdb97b4104e14e2d40abda73a526bb37041a Reviewed-on: https://gerrit.libreoffice.org/40371 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-27replace sal_uLong variables with sal_uInt32 for SvNumberFormatter IDsJochen Nitschke
Replace the stopgap type sal_uLong as SvNumberFormatter format index uses sal_uInt32. SwInsertDBColAutoPilot uses format indices from SvNumberFormatter and from the property "FormatKey" which is stored as sal_Int32 but ctor guards against negative values. Change type of loop variable in SwCaptionDialog to avoid narrowing in GetFormatStr/GetFormatKey. Change-Id: I79980696c07760f7ff026bb1bacf0e069363898c Reviewed-on: https://gerrit.libreoffice.org/40464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-27xmlsecurity mscrypt: drop unused parameters in akmngrMiklos Vajna
Change-Id: I5e8b3e472caa058c4c8f10b423783d963a6ab1c0 Reviewed-on: https://gerrit.libreoffice.org/40465 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-27correct some Date related typesJochen Nitschke
signature of Date and Date::DateToDays is (sal_uInt16 d, sal_uInt16 m, sal_Int16 y) same types as css::util::Date members Day, Month and Year Change-Id: Ifa35574d2d335f7bf816dd5209988f4eaf7c5ac2 Reviewed-on: https://gerrit.libreoffice.org/40462 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-27loplugin:constparams in svxNoel Grandin
and fix a bug in the plugin itself when calling operator's like the one on std::function<> Change-Id: I1617607107eeff06785c1841f69e13ad2926218e Reviewed-on: https://gerrit.libreoffice.org/40446 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-27LibreOffice.natvis: fix BigPrtArray visualiser.Mike Kaganski
Also visualisers for uno_Any and SwNode are tweaked. Visualisers for uno::Reference, rtl::Reference and VclPtr added. SwFrameFormats visualiser reimplemented to follow implementation of boost::multi_index_container. Minor reformatting. Change-Id: I24ccb8bfccd7f7514697ca3f36490672ad549aef Reviewed-on: https://gerrit.libreoffice.org/40466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-07-26Restore and fix and fix harder the EditTextObject::operator==()Eike Rathke
... chaining down to EditTextObjectImpl::operator==() that compared unique_ptr instead of content with ContentInfo::operator==() that needed to use XEditAttribute::operator==() instead of comparing pointers. That resulted in always false.. Wrong as a chain of commit 5a7a4325eca58c253270d4e9d327042a9ee2c5f0 Date: Tue Nov 10 14:59:05 2015 +0200 editeng: boost::ptr_vector->std::vector<std::unique_ptr> and commit 4ff5a5558472beee85eb1234dcc2aa2ed9000f6c Date: Tue Jan 19 15:17:30 2016 +0200 loplugin:unusedmethods Plus XEditAttribute::operator==() was wrong since commit 71158788efb32ffc3bac5154c38ca5d79525155c Date: Thu May 4 08:11:41 2006 +0000 INTEGRATION: CWS impressc03u3 (1.8.40); FILE MERGED 2006/04/27 12:33:10 cl 1.8.40.1: #i64360# fixed operator== that (to fix a crash comparing items of different types) changed - ( (pItem == rCompare.pItem) || (*pItem == *rCompare.pItem)); + ( (pItem == rCompare.pItem) || + ( pItem->Which() != rCompare.pItem->Which()) || + (*pItem == *rCompare.pItem)); so returning true if Which-IDs differed, instead of + ((pItem == rCompare.pItem) || + ((pItem->Which() == rCompare.pItem->Which()) && + (*pItem == *rCompare.pItem))); Change-Id: I8300c04001e98cb71e520bbe2c180aec0c0a3333 Reviewed-on: https://gerrit.libreoffice.org/40455 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-26gbuild: strip away unexpected CR char at the end of Windows filenamesMiklos Vajna
As reported at e.g. <https://ask.libreoffice.org/en/question/90346/building-libreoffice-in-cygwin-leads-to-infinite-loop/>, sometimes MSVC (seen with 2013 on libreoffice-5-2, but there is no indication that 2015 on master would be different) emits CR characters at the end of filenames, resulting in unnecessary rebuilds at per-module builds, and actually to an infinite loop when doing toplevel make. Given that CR characters are unexpected in any filenames, it should be safe to just strip those away unconditionally. Change-Id: I3d56670b4d930a32489f889085711bfd436de82a Reviewed-on: https://gerrit.libreoffice.org/40452 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-26Mark SvXMLTokenMapEntry arrays as constantTakeshi Abe
Change-Id: I37565540ec5dc3bfddf6cdeb20447f837e3014b6 Reviewed-on: https://gerrit.libreoffice.org/40374 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-26android: configure - add missing flags for x86 targetingChristian Lohmaier
Change-Id: Ia70f713cdfe2b532dfa4b8aa7876f830b3ef8175
2017-07-26tdf#109364: fix assert in LibXSLTTransformer.cxxJulien Nabet
by replacing createFromAscii with OStringToOUString + RTL_TEXTENCODING_UTF8 Change-Id: I92ab20812968d13546132afb65c9b956a9c8be8e Reviewed-on: https://gerrit.libreoffice.org/40456 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-07-26Resolves: tdf#104141 CAIRO_FORMAT_A1 vs N1BitLsbPalCaolán McNamara
where vcl transparency is the opposite of cairo's so we've been switching the source color to the opposite for drawing on CAIRO_FORMAT_A1 and then sucking out the bits "as-is" to give the right results. Now instead use the right source color and toggle CAIRO_FORMAT_A1 bitmaps to N1BitLsbPal in getBitmap. Then additionally toggle all N1BitLsbPal bitmaps input to drawBitmap to CAIRO_FORMAT_A1 when making a cairo surface from them. Change-Id: I45c6d4f3894c6a22a07a3bd65950cd8070e8eaff Reviewed-on: https://gerrit.libreoffice.org/40453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-26Updated coreBuovjaga
Project: help a0efca32e5ebee152776ac81f8e4f59892faead0 tdf#97745 Fix width on wide screens Change-Id: I91a84a0d3460ab7ccacd1ec1f14ef7b97db3b767 Signed-off-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/40427 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-07-26Related: tdf#102909 gtk3: remove configure loophole of non-native menubarCaolán McNamara
the ENABLE_DBUS + ENABLE_GIO thing is to allow building against an old gtk2 baseline. If building against gtk3 then gio and dbus are available, and allowing the unusual configure path through gtk3 results in a non-supported cruddy build Change-Id: Ic6306fe2f9951714fd5875c24aedda1d7c6f2b93 Reviewed-on: https://gerrit.libreoffice.org/40420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-26loplugin:unusedmethodsNoel Grandin
Change-Id: I7f26ee112ed89ee3e69c56930260565f66ff145b Reviewed-on: https://gerrit.libreoffice.org/40442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-26convert SfxGroupId to scoped enumNoel Grandin
in the process I had to teach the idl compiler to cope with identifiers like SfxGroupID::Math, which has the side effect of requiring a space before a ':' in some of the .sdi files. Change-Id: If256599cb8aa1dfc0a33642c5070c5560702f3ba Reviewed-on: https://gerrit.libreoffice.org/40441 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-26remove unused constants in float3d.hxxNoel Grandin
Change-Id: I9ad3c8c2d5616d6e62a42f3f5dcaebc46e4959bb Reviewed-on: https://gerrit.libreoffice.org/40440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-26loplugin:unusedfieldsNoel Grandin
Change-Id: I21e538b8e9c7a5f0fb233019efac37a3555e3c93 Reviewed-on: https://gerrit.libreoffice.org/40438 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-26tdf#99634 Change equal sign tooltip to 'Formula'Yousuf Philips
Change-Id: Ic1bedf1c6ca7fb2a5346aede6c12a6dab372d189 Reviewed-on: https://gerrit.libreoffice.org/40431 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-07-26tdf#100491 fix DOCX import shape line with arrow markerVasily Melenchuk
Line shape with arrow end markers was rendering rather thick arrow, not connected to main line. Moreover, arrow width should depend on actual line width. Change-Id: I8d9a6e7f5d89a1645dcc5939ecc592e86e6fe34f Reviewed-on: https://gerrit.libreoffice.org/40286 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
generated by cgit (git 2.34.1) at 2025-02-21 00:43:38 +0000