summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-02-10tdf#139511 Correct calculation of minimum row height during resize.Gülşah Köse
Change-Id: Id47b5877d56850c80395897a83daae8e24f5c099 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110662 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-10pass FastAttributeList around by rtl::ReferenceNoel
Change-Id: I958a22f60975c74dfaeb8469b4c0cd3759d40130 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110653 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-10clean up SdrObject cloningNoel
using operator= implies that overwriting an SdrObject is a useful operation, but that is not at all true - they are typically linked into and referred to by many other things. So rather use a copy-constructor. Also clean up a couple of weird "do some stuff after the clone" code into the main copy constructor. Change-Id: Iefc1481b527602748b5f3abed06e7cca66c0581c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110633 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-10tdf#134210 Import crop position of bitmap filled shape.Gülşah Köse
Change-Id: I6a62d68cd0f57e53934851a2f53dae05bf7d3730 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110262 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-10Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to c36ab9284db666581cb814ce6f2265107439c4ee - Fix typos Change-Id: Ic59e55a6b3b31211dedca20572f53914eb9a47ef Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110660 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-02-10Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 8364e1a17ab04680905248d96be010af0d8c7ede - "Formula" -> "Text Formula" in Table menu help Change-Id: I5415717ed44c57ef76a259fc349cdd6e007e54fb Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110571 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2021-02-10Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to b8df7b86811aa6433f2df6e8fbcbcf635020f894 - tdf#137084 add relatedtopics section to Styles menu help + add links to guide pages for "Update Selected Style" and "New Style from Selction" commands Change-Id: I6c5e9bfe7a9129ed4202af82ed1e45a1d49d3fbd Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110565 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2021-02-09tdf#123052: sc: Move UItest to CppUnitTestXisco Fauli
Change-Id: If7a30aef44a722b4c0d91ecd7626a2a39fe1290a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110652 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-09tdf#139301 line dash interoperability: fix asynchron UI testLászló Németh
to avoid false alarms during slow testing. Also the test doesn't open the same file n times for testing the n line dash styles now. The problem reported by Stephan Bergmann. See also commit 8cc78b527bf2b7dcaaff73d8f0770f3d324ac839 ("Avoid test_tdf139301 hanging upon failure") and commit commit 183c06fc02a50fb117bb6162e4d6e56cdd34fad1 ("tdf#139301 fix OOXML-compatible preset dash styles"). Change-Id: I4b072f334a59abda373ab3a92f27afafda981145 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110574 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-02-09no need to use unique_ptr for a simple value classNoel
Change-Id: Id83cd16fe3eb815ad419cc331e65fb731161bd30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110635 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-09loplugin:stringview (clang-cl)Stephan Bergmann
Change-Id: I5c2420d5fb886926540bb3502c130404786f1698 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110641 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-09loplugin:fakebool (clang-cl)Stephan Bergmann
But GetMessageW encodes more than true vs. false in its BOOL return value, so silence the unhelpful loplugin with auto. Change-Id: I77d053b760e93f918367532c63a6dfe963faa12d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110645 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-09Revert "on SelMouseButtonDown check if window pointer is not null"Caolán McNamara
because there is no pWin for the cases where an EditEngine is hosted in a native widget, e.g. comment in a sidebar in writer or format header/footer in calc's format page, header/footer, edit... and with change applied clicking doesn't move the cursor This reverts commit 0a2fa32f8756b3c99975df6d98736a8e9abb625a. Change-Id: Ie1da24d22b6d298f0c074f7bf187c5d891b78368 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110648 Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Tested-by: Jenkins
2021-02-09configure.ac: allow --enable-python=system on macOS if PYTHON is non-emptyAndrew Udvare
This will work as long as a valid Python is in PATH, such as /usr/bin/python3 from Xcode or another version in some prefix like /opt/local. Change-Id: Ic967c3ce2f9949d94c11c3449363841a1565cfa9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108486 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-02-09loplugin:cppunitassertequals (clang-cl)Stephan Bergmann
Change-Id: I9ab5d2047f9a13fb919c31ca66a0020feac08701 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110644 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-09loplugin:fakebool followed by loplugin:implicitboolconversion (clang-cl)Stephan Bergmann
Change-Id: I0f61268b2027eb617b2312615ea544387af1b381 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110643 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-09Silence -Werror,-Wunused-variable (clang-cl)Stephan Bergmann
Change-Id: Ic023076a8673144cb2cf4e5a36d44d592900682e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110642 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-09tdf#104502 sc: skip hidden columns at printing pagesAttila Szűcs
Page calculation counted the hidden columns, resulted printing blank pages by accident. Extend GetPrintArea() and GetTableArea() to count pages without the hidden columns, too. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I4817965a675e059cdc8f81ca3bb6e128af874f2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110028 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-02-09sw: document SwTextAttrMiklos Vajna
Just a summary, sw/README has more on this. Change-Id: I43fb32e17520fb60fedbc7ae85cf881d3a343c6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110634 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-09sw doc model xml dump: show more details of SwTextFootnoteMiklos Vajna
Most importantly the node index of the referred footnote. Change-Id: Ibfa333a57052ffd5c9d7edab960f72041348c9fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110632 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-09tdf#140225 call cancel before destroying menubarCaolán McNamara
a) in case there are some menus open cancel them before removing their parent menubar b) when a GtkSalMenu is deleted clear the action-group of the hierarchy and flag it as needed a refresh, clearing it of any references to the deleted GtkSalMenu Change-Id: I9ec59c52c72b8b58976a8ee41727ca7612ebf6b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110542 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-09Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 5cfd09886740bea6de229184cee57820f1d069e4 - Remove excessive <literal> Change-Id: Iec2b5ccf9a97aff667afc343634d1a688ed12601 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110563 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-02-09ScriptForge - (SF_String) more severe check on the date validity of IsADate()Jean-Pierre Ledure
So far IsADate checked the format of the date only, not the validity vs. leap years, days in month, etc. Corrected with an error check on the DateSerial() builtin function Change-Id: I3fc53ea83e0a1472b2861f256266c4422cce2580 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110590 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-02-09tdf#140151: sc_uicalc: Add unittestXisco Fauli
For some reason, this test fails on Mac and Windows. I tried different approaches but all of them failed. See https://gerrit.libreoffice.org/c/core/+/110551 Since I don't know any other way of testing this bug, let test it at least on Linux Change-Id: I40e0afe6c850533e4a1db0fec30838a66f206512 Change-Id: Ide728ad41cf3952d1acf8fd98a64b72ee7c5cda6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110624 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-09ofz#30663 Direct-leakCaolán McNamara
since... commit 17149f65f03a34e88bb4a10abcd20e6891f5d7ca Date: Sun Feb 7 10:41:46 2021 +0100 Let depthGuard handle everything Change-Id: Icb978724000aec75a84ca6ecfd0fe9e299291db6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110623 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-09Update git submodulesMiklos Vajna
* Update helpcontent2 from branch 'master' to 246f9b7f85571b7b31c56a40aed21dcb1602f2fd - tdf#91920 sw page gutter margin: add help Cover the default, the mirrored and the from-top cases. Change-Id: Icf4da5232c1c2a693a5741f6c207d59acd79294b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110629 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-02-09ScriptForge - (SF_Array) new Copy() methodJean-Pierre Ledure
Duplicate the array A simple assignment copies the reference, not the data In code like: Dim a, b a = Array(1, 2, 3) b = a a(2) = 30 MsgBox b(2) ' Displays 30 Replace by b = SF_Array.Copy(a) to get a real duplication of the initial array Change-Id: I62b931b92995c6607a3b354c60f0ebafb042b88a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110591 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-02-09simply use DrawTransformedBitmapEx()Luboš Luňák
And leave the work to the function instead of trying to handle it manually. Change-Id: Ia1ede2378d461a57e5c338ab5cabe908c320b2b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110599 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-02-09report what value was found in messageCaolán McNamara
Change-Id: I512cedcd46f829b97b62a57d90d5a4a81d024d66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110562 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-09ofz#30330 recursion too deepCaolán McNamara
Change-Id: Iaa3961cd6501f45c93bf02a42da7816d0b83097f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110489 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-09lok: Take indent and margins into accountDennis Francis
... when painting tiles with edit-text content. Conflicts: sc/source/core/tool/editutil.cxx Change-Id: I31199c18ed5aab005d56241046a9f7109691db99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109755 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit bc025dac6ce3301f5798e8ada4fee07b415de76a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110619 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2021-02-09default to CertificateValidity::INVALIDCaolán McNamara
so if CertGetCertificateChain fails we don't want validity to be css::security::CertificateValidity::VALID which is what the old default of 0 equates to notably commit 1e0bc66d16aee28ce8bd9582ea32178c63841902 Date: Thu Nov 5 16:55:26 2009 +0100 jl137: #103420# better logging turned the nss equivalent of SecurityEnvironment_NssImpl::verifyCertificate from 0 to CertificateValidity::INVALID like this change does Change-Id: I5350dbc22d1b9b378da2976d3b0abd728f1f4c27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110589 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-02-09tdf#134592 DOCX import: preserve formatting of CREATEDATE fieldsMiklos Vajna
The create date of a document doesn't really change, so we can only loose if the cached result of the field is not preserved. Change-Id: I0105d9c5bb9a06cacc1f5fed2a10b6626fa80fd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110596 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-02-09loplugin:referencecasting check for Reference::queryNoel
Change-Id: I008d16d933c70df132699872ac4c39a5c1f87b34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110592 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-09return by unique_ptr from NewGeoDataNoel Grandin
Change-Id: Iab806959d79ce828069cb16b6a7883981d85dfaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-09Remove deadcode SwModify::CheckCaching()Bjoern Michaelsen
Change-Id: I0048b211fa9b458456fbb408bcc82dbbe81a9504 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110595 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2021-02-08Remove SwModify::SetInDocDTOR ...Bjoern Michaelsen
... its only used once in SwTOXType and has no place in SwModify, which is the base of ~everything in Writer still. Change-Id: I07007f08723f8db2dd09bb7c07cb0ebfc2a6506a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110594 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2021-02-08tdf#139724 differentiate / improve labels on two "Outline" .unosSeth Chaiklin
.uno:SetOutline and .uno:OutlineFont refer respectively to selection of an Outline format and application of the font outline attribute. The patch adjusts, elaborates or expands their labels and tooltips to make them more comprehensible in the UI. Plus a small followup to clean-up adjustment of labels for .uno:DefaultBullets and .uno:DefaultNumbering. (tdf#139667) Change-Id: Ic8951bf338fd699ae57ca52374aaa03fe4c797db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110436 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-08Remove unneeded breaksAndrea Gelmini
Extending this: https://gerrit.libreoffice.org/c/core/+/110512 Change-Id: I90d15fa6992a566e89c76dfab5fc863b33e0078a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110523 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-02-08Remove unneeded breaksAndrea Gelmini
Extending this: https://gerrit.libreoffice.org/c/core/+/110512 Change-Id: I1c5bfcddeb0f5619dc848bbf02408cf166bebc8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110521 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-02-08Avoid macro redefinition warnings in sanitizer buildsStephan Bergmann
...when configure.ac happens to detect USE_SDT_PROBES, after c5c0f8df855dfd4478c57170e251e4a9bcff1c10 "Replace strtmpl.cxx with actual C++ templates in strtmpl.hxx": > In file included from jurt/source/pipe/staticsalhack.cxx:20: > sal/rtl/ustring.cxx:48:9: error: 'RTL_LOG_STRING_BITS' macro redefined [-Werror,-Wmacro-redefined] > #define RTL_LOG_STRING_BITS 16 > ^ > sal/rtl/string.cxx:39:9: note: previous definition is here > #define RTL_LOG_STRING_BITS 8 > ^ > In file included from jurt/source/pipe/staticsalhack.cxx:20: > sal/rtl/ustring.cxx:48:9: error: duplicate defines [loplugin:duplicatedefines] > #define RTL_LOG_STRING_BITS 16 > ^ > sal/rtl/string.cxx:39:9: note: previous define [loplugin:duplicatedefines] > #define RTL_LOG_STRING_BITS 8 > ^ > In file included from jurt/source/pipe/staticsalhack.cxx:55: > sal/rtl/ustrbuf.cxx:29:9: error: duplicate defines [loplugin:duplicatedefines] > #define RTL_LOG_STRING_BITS 16 > ^ > sal/rtl/string.cxx:39:9: note: previous define [loplugin:duplicatedefines] > #define RTL_LOG_STRING_BITS 8 > ^ Change-Id: I23a1e058cf0d9ab7821dd9b1a2cba22fc69263c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110584 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-08tdf#134059: sc: Add UItestXisco Fauli
Change-Id: I81d0afa56eee32f87f64b8d0461c95552e34525f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110582 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-08tdf#94235 Only write data-label-series attr to ODF 1.3 docsSamuel Mehrbrodt
Change-Id: I63cb49a29486f9ae64c7fe8af5c65be52683993f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110583 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-02-08uitest: sc: blind fix for failing test (take 2)Xisco Fauli
Change-Id: Id7bc0bb4552513cdd8a287f6f239ef899c18d143 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110587 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-08jsdialog autofilter: show submenu on demadSzymon Kłos
- add posibility to trigger full update - send information if docking window is visible - send close message on builder destruction Change-Id: I0b3abc5ebcacf7f9a48910edf1bf0d73e8120d6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110578 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-02-08tdf#91920 sw page gutter margin: handle mirrored marginsMiklos Vajna
- SwPageDesc::Mirror: generate "right gutter margin" from gutter margin for mirrored pages, we just lost the gutter margin here previously - SwBorderAttrs::CalcRight: handle right gutter margin, so gutter increases the right margin, not the left margin on mirrored pages - lcl_CalcBorderRect: similar to left and top margins, compensate for right margin gutter as well, so borders are independent from the gutter margin (Word compat) Change-Id: Ie4d3459ab6edcc60b20c2fed08dbf45060ca9828 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110585 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-08tdf#124176: Use pragma once instead of include guardsShobhit
Applied clang format Change-Id: Idb3f4dc8726115f8d53721bea28cbe3e53adef3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110188 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-02-08sal_Unicode is always char16_t in LIBO_INTERNAL_ONLY code nowStephan Bergmann
...since 9ac98e6e3488e434bf4864ecfb13a121784f640b "Finally switch MSVC to sal_Unicode = char16_t, too" Change-Id: I0df169307618aba3f609400312737c6e1e1d3aaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110581 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-08tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorTarun Sharma
Change-Id: Ib7f122b20734ad51c6326e369e5e7eee1bf08a21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109861 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-08ScriptForge - (SF_DialogControl) Fix list of propertiesJean-Pierre Ledure
List was incomplete: trre control properties were missing Additionally, comments wre reread thanks to writing of help files Typos or approximations were reviewed Change-Id: I799011f27d89d93278027f5f3cf9853d3d2371cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110575 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
generated by cgit (git 2.34.1) at 2025-02-19 10:27:40 +0000