summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-10-01tdf#142578: xlsx export: use continuous numbering for dfx nodesVasily Melenchuk
Since all dxf records are stored in one place it is required from color filter and conditional formatting to use continuous numbering for dxf structures to avoid id collision. Change-Id: I91146e34d462d812b480db137cda522f6db7ef8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122915 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2021-10-01mark this string explicitely untranslatableAndras Timar
it will be localized with STR_BOOKMARK_FORBIDDENCHARS Change-Id: I31416d53987ac1ec174add3b7114b18f5d38d1f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122908 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2021-10-01tdf#144616 PPTX import: fix hyperlinks on shapesTibor Nagy
Follow-up to commit 6e200689eb309cdbe1e4f08311a400835de19bfb "tdf#141704 PPTX import: fix hyperlinks on images" Change-Id: Ie9f1ba56d03462bb8d7ab376e23c89c921a8bcd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122610 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-10-01Resolves: tdf#140992 Paste/Cut should mark Edit as modifiedCaolán McNamara
Change-Id: Id56b5bf2e922394da7e730f4bab652808253c54e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-01Consider leading minusMike Kaganski
An overlook from commit be8da97976658ff19b4dd010bff328cd3f424c1b Change-Id: I2f639a9d865b43b38e19ad35a0a9e6b5bc1c1c8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122863 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-01else branch doesn't make sense, dereferences nullCaolán McNamara
if xModel.is() is false then xModel->getCurrentController() is just going to crash. like this since it was introduced in commit eafba820349005ea5426cab58911f9ff99969966 Date: Tue Jan 5 22:32:38 2010 +0100 autorecovery: define a new css.document.XDocumentRecovery interface, implement it in both SFX and DBACCESS, and use it in the autorecovery Change-Id: I8ea43a0679d43cb9b865ecae5260129d17b6a386 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122898 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-01Update git submodulesSteve Fanning
* Update helpcontent2 from branch 'master' to b81bdbf9511ce46f4556582c0b971e35c509d468 - In CONVERT_OOO help description, add pointer to CONVERT function. Change-Id: I662c6c4dcaaa622b4e9dec1b575cd488300585a6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122866 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-10-01Use std::memmove instead of loopMike Kaganski
Change-Id: Ia88ceaaad700bf3c2c8db9bb19146b75146dad3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122861 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-01tdf#143104 Fix xlsx import/export of color filter colorsVasily Melenchuk
1. In XLSX filter colors are always stored in dxf as foreground colors, so Calc should keep them, if possible. So practically use only one color during import. 3. On export we need to distinguish type of filter, this is done with cellColor=0 or cellColor=1 attribute of <colorFilter>. 4. Since p.1 there is no need to keep on export separate dxf structures for fg and bg colors: we always use only foreground color for color filters. Co-authored-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Change-Id: Iacd352ae46bf84859dc15ee695b6dc63240afe7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122593 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-10-01Drop static_cast syntactic noiseMike Kaganski
Change-Id: I699f22aac871fdcef9ee9326ac30091239fa02be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122862 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-01Always use buffer on stackMike Kaganski
Change-Id: I39ed2485a67ec7a8b24ab90ea0d69a5982374334 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122860 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-01Update git submodulesRoss Johnson
* Update helpcontent2 from branch 'master' to 0b9b6542a8432d8a7bb3fc8185c0937dff0329bd - tdf#33749 - revised help text for merge and split in Calc The earlier change (reverted) overlooked the difference between "Merge Cells" and "Merge and Center Cells", leaving users without adequate means to merge cells while retaining text alignment. This patch restores previous usability and moves forward to resolve the issues raised in this bug report. Reverted the two changes from earlier work on tdf#33749: 1) Cell context menu back to 7.2 2) Format - Merge Cells menu back to 7.2 3) Help pages to reflect that Moving forward with the following changes: 1) Rename "Split Cells" to "Unmerge Cells" (Calc only) 2) Add "Merge Cells" and "Unmerge Cells" to the Formatting toolbar alongside "Merge and Center Cells". 3) Re-label the Format - Merge Cells menu to Format - Merge and Unmerge Cells. 4) Help pages to reflect core including fixing the duplicate entry in the built help/hid2file.js by consolidating the relevant Calc and Writer help pages together to remove the duplicate bookmark hid branch value. Removed the module specific version. 5) Removed duplicate entry from helpers/unocmds.txt. Change-Id: Ica50f507eea74acd430bef3042fb9739d1cff7b2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122810 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-10-01sw: simplify DocxAttributeOutput::CharBorder()Miklos Vajna
pInherited is already nullptr at that point, so need to only change it when pPoolItem is not nullptr. Addresses <https://gerrit.libreoffice.org/c/core/+/122790/2#message-054924f056e40364c82cc92987cb7ca7d981c564>. Change-Id: I456d4efba5b1d621c1b31bb2a2ec834c04cc62ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122901 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-10-01tdf#141220 sw: fix textbox popped out of off-page shapeDaniel Arato (NISZ)
When you moved it downwards off the page it was anchored to, the textbox inside a shape used to appear exactly one page above the shape it was supposed to follow. This is hopefully fixed by the present commit. Regression from c9eb53f200225f2ee6ca695e1326843a487aee51 (tdf#135198 sw editing: text box fell out of its shape). Change-Id: Ib388292ca26444daa1900417347824059ee03f07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122687 Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-by: Balazs Varga <varga.balazs3@nisz.hu> Tested-by: Balazs Varga <varga.balazs3@nisz.hu>
2021-10-01tdf#144437: rtf export: bookmark position is written to current runVasily Melenchuk
Bookmark was written to not current position thus did appear not at desired place inside paragraph. Change-Id: I917f74c95666efd38c5befeb927b75783915b2e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122722 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-10-01Resolves tdf#144677 - Show bookmarks like fieldsHeiko Tietze
Color and condition follow field shading now Change-Id: I810c90fee2663b1148c139b6e7978ba161fd37b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122829 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-10-01sc: colorfilter dangling pointer fixedVasily Melenchuk
Upper call to aParam.RemoveAllEntriesByField can invalidate pEntry, making further calls to pEntry->SetQueryBy* illegal. Anyway at this branch we are disabling color filter, so this is not required. Change-Id: Ia595649975b659d28056ba3f3658c306e63088f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122822 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2021-10-01loplugin:nullptr (clang-cl)Stephan Bergmann
Change-Id: I47ac4ff7d82eb5732ad54e3b42c18c3665c83b82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122845 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-01Writer Navigator: Make fields always show in the content treeJim Raykowski
Currently, a field that is not visible, for example, when in folded outline content or a hidden section, is not shown under the Fields category. This patch changes the behavior to always show the field. Change-Id: Iea85a2c69df68bb0d37e8d94662d3ca9c81b0e41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122842 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-09-30no need to allocate ImplVectMap on the heapNoel Grandin
Change-Id: If4175ee8f0853b9ef1bb0657338116e2ee57064a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122897 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-30loplugin:constmethod handle more casesNoel Grandin
remove some of the naming limitations, and handle pointer parameters better. I only let the plugin run up till vcl/ Change-Id: Ice916e0157031ab531c47f10778f406b07966251 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122892 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-30Related: tdf#141633 drawing buttons to outputdevice affects later drawingCaolán McNamara
since... commit 0b76e106b8054c91a7b7d793d9219f6ee9ae7d2c Author: Oliver Bolte <obo@openoffice.org> Date: Thu Sep 4 06:42:10 2003 +0000 INTEGRATION: CWS mt801 (1.21.132); FILE MERGED 2003/08/29 14:35:52 mt 1.21.132.1: #80064# Print button with color... In the "sample db" example (Mockup.odb) there are two buttons with a yellow background, when printed part of the table control is also incorrectly painted with a yellow background. Change-Id: I481b721801b5e1d1c78dc7a01cb20745702f5c01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122895 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-30-Werror,-Wshadow (clang-cl)Stephan Bergmann
Change-Id: I4bd8427dcd4cd68053fe4e607c4ba05be215ffb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122882 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-30Extended loplugin:referencecasting/redundantcast (clang-cl): winaccessibilityStephan Bergmann
Change-Id: I6de94437ed00b295be1c388ac4a2c0784dd3cc6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122883 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-30tdf#144697: svl_qa_cppunit: Add unittestXisco Fauli
Change-Id: I7a62f7c5c8e6fceebcb9671fa28ec98dd7a312a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122878 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-09-30tdf#141633 multiple line entry font size/zoom not taking effectCaolán McNamara
The "sample db" example (Mockup.odb) has multiline entries used in its "Journal Entry" column. Those are painted by taking snapshots of a never-really-shown textview widget. But the textview is always drawn using its original default font size and changing the page zoom and/or font size had no effect on the size of text in the "Journal Entry" column. explicitly emit style_updated to get the GtkTextView to sync its font size from the css changed by the set_font Change-Id: Ic7d644b13c28f30a2c646b9d4098ea6e7f0dab81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-30vcl: initialize variables in ImplMapRes declarationChris Sherlock
Change-Id: I379a555c8e148ba0294198fb5e12582f73a51554 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122771 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-30Extended loplugin:referencecasting/redundantcast (clang-cl): embeddedobjStephan Bergmann
Change-Id: I345b6535df2df4770191dc1aae0ca024b747a50a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122887 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-30Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 2d9ad5a39e416c967af625426572b68498d3c68b - tdf#144713 rename tab indices -> tab order in group controls Change-Id: I0e4bf13841b104b6f7f0765a933f4ba13fbdd3c1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122679 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-09-30Missing include for intptr_tStephan Bergmann
...at least when building with clang-cl against recent MSVC 2019 standard library: > external/clew/source/include\clew/clew.h(319,9): error: unknown type name 'intptr_t' > typedef intptr_t cl_context_properties; > ^ Change-Id: Ib438b680964028461ac3e566410fc90259d015b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122888 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-30Extended loplugin:referencecasting/redundantcast (clang-cl): extensionsStephan Bergmann
Change-Id: Ifd431845dc9bb53b87be400a3f5635c8fdc4b2fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122885 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-30Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 692cf2deaf301a4fb1bce976a9f16e28c5f3c895 - Fix auto_redact help page for l10n Change-Id: I45a698daf4744ecffbd7178d40edb8bd70a76bbe Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122852 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-09-30Extended loplugin:referencecasting/redundantcast (clang-cl): embedservStephan Bergmann
Change-Id: I342859fbeaffee5d396cbb6ae3e5db41f5cdbb79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122886 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-30Extended loplugin:referencecasting/redundantcast (clang-cl): shellStephan Bergmann
Change-Id: Iee72782ca3f9e536b391cc45d910792f66ce01a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122884 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-30-Werror,-Wformat (clang-cl)Stephan Bergmann
> sal/cppunittester/cppunittester.cxx(553,115): error: format specifies type 'unsigned int' but the argument has type 'ULONG64' (aka 'unsigned long long') [-Werror,-Wformat] > printf("\tat %s in %s: line: %lu: address: 0x%0X\n", pSymbol->Name, line->FileName, line->LineNumber, pSymbol->Address); > ~~~ ^~~~~~~~~~~~~~~~ > %0llX > sal/cppunittester/cppunittester.cxx(558,64): error: format specifies type 'unsigned int' but the argument has type 'ULONG64' (aka 'unsigned long long') [-Werror,-Wformat] > printf("\tat %s, address 0x%0X.\n", pSymbol->Name, pSymbol->Address); > ~~~ ^~~~~~~~~~~~~~~~ > %0llX > sal/cppunittester/cppunittester.cxx(576,50): error: format specifies type 'unsigned int' but the argument has type 'DWORD' (aka 'unsigned long') [-Werror,-Wformat] > printf("*** Exception 0x%x occurred ***\n\n",ex->ExceptionRecord->ExceptionCode); > ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > %lx ...but where SYMBOL_INFO::Address is documented to be of type ULONG64, which in turn is documented to be a typedef for unsigned __int64, for which there is the MSVC-extension I64 format specifier Change-Id: Ibed1d3fa49ac6fd988174c6041071292fc66dd3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122872 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-30no need to copy the name in XmlWalker::attributeNoel Grandin
sName and the parameter we pass to xmlGetProp are both null-terminated char strings Change-Id: Ia8cb036f33cada8fa59d1e4f05df318a9cf28115 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122875 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-30cui: better label for the OLE insert progressbarMiklos Vajna
It's inserting an OLE object, not really loading a document. Change-Id: Ie33e5ef8e80acbd2bfebd68119540c6d168ab120 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122877 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-09-30loplugin:consttobool (clang-cl)Stephan Bergmann
Change-Id: I8947750dbcc0cfdfd04fac3b9e22d85dc6f8da80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122873 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-30loplugin:sallogareas (clang-cl)Stephan Bergmann
Change-Id: I6a529d2eb737d284bf1e9c1857680c33581f5e0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122846 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-30loplugin:external (clang-cl)Stephan Bergmann
Change-Id: I71be097d5051d39295f9f85d3e2329564388b4c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122851 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-30loplugin:cstylecast (clang-cl)Stephan Bergmann
Change-Id: I2c68832a23d80dbe208212ce36b14b21b5312f5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122850 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-30loplugin:unusedcapturedefault (clang-cl)Stephan Bergmann
Change-Id: Ib7b3bfb7a3162e032cf6c9bf7f19576434592a00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122849 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-30tdf#143575, tdf#143974 - Remove custom precision format in BASICAndreas Heinisch
Change-Id: Iefe046fa223f85204b27ebabe81523aa1a97f92f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122856 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-09-30loplugin:constparams improve handling of pointer paramsNoel Grandin
Change-Id: I4c0002e72703eded435bfe4985f5b0121bf8524b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122843 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-30loplugin:includeform (clang-cl)Stephan Bergmann
Change-Id: Ia374fe0a7a0392e91821fecd1e6ee5917864d59c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122848 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-30loplugin:fakebool (clang-cl)Stephan Bergmann
Change-Id: I48ee1c1906ab06a487059128eb1eba0d6adb068f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122847 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-30Simplify comparisons in the loopMike Kaganski
Change-Id: I9963a527d2323f4df8c3b46c13f5b7993e22f163 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122855 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-30Related: tdf#141633 support setting a custom font for TextViewCaolán McNamara
Change-Id: I4c27a21c5c682fc73c37594749627e4cc7c0822d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122833 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-30tdf#141633 set correct font sizes in tableview child widgetsCaolán McNamara
Change-Id: Ic96a0ad8203bf3903546c0c2f07d96254ca01e4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122832 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-30vcl: remove MetaActionType param from DrawBitmap/DrawBitmapEx/DrawMaskChris Sherlock
This is needed to allow for a clean abstract class DrawingInterface, which I will introduce in a followup patch. Change-Id: I1bb631872e44a82094dcfff07c0f418e9a4a0224 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122614 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2025-03-13 02:40:39 +0000