summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-03-07lok: Allow changing comment text of document redlinesPranav Kant
The id of the redline is optional. If not mentioned, the current redline is assumed to be the one whose comment text will be changed. Change-Id: Ia859de171603239a78f4bdef5eff0facd580d027 Reviewed-on: https://gerrit.libreoffice.org/34923 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-03-07bLicenseException is always falseStephan Bergmann
...ever since 3c289e248a4f7c6940bb7429ee70d17a6196016c "jl152 import 263446 from native0jl:#i77196# supporting licenses, suppress license switch, subsequent accepting of licenses for bundled/shared extensions" Change-Id: I138016f6c83de8a7e085d4191ee06e0a1232203c
2017-03-07Notebookbar: don't show unnecessary separators in the popupSzymon Kłos
Change-Id: I89d11e2859676696e7bc0751ae9e71e5ae939a79 Reviewed-on: https://gerrit.libreoffice.org/34945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
2017-03-07tdf#105570: Treat sprmTTableHeader properly.Vitaliy Anderson
Only take into account sprmTTableHeader if all previous rows had it. Change-Id: I0f81da366c148963503b4aeba778f5d97aa72d26 Reviewed-on: https://gerrit.libreoffice.org/34931 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-03-07tdf#104287 RTF import: handle bitmap shapes inside tablesMiklos Vajna
Regression from commit 015fd55c94b7b650ed8e572cafaf3b0f903b01b9 (tdf#96275 RTF import: fix anchor of shapes inside tables, 2016-05-10), the problem was that since shapes inside tables are now buffered, some previously hidden problems in the buffering became visible. For one, there was no code to make sure that a bitmap shape is not appended at the end of the buffer again when it gets re-played. For another, only the bitmap shape itself was buffered, not its size. Change-Id: I04d65eb794ff6b160ef77af85479ba25ea5f8aa7 Reviewed-on: https://gerrit.libreoffice.org/34940 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-07only one use of GetLastSaveDirectoryCaolán McNamara
which is to get its value and do a const_cast dance to save and restore its value which is a strange thing to do just for one obscure dialog when no other use of the save/load dialogs does this Change-Id: I7700d7ed738d578869284d415197de06167001b5
2017-03-07can use a reference hereCaolán McNamara
Change-Id: I3e9599e92679a66cae410090b5d17651a3698cce
2017-03-07improve scoping and zero some thingsCaolán McNamara
Change-Id: I04402009ffd91e35a72026ca357e1e158a258035
2017-03-07Resolves: coverity#1402073 Mixing enum typesCaolán McNamara
Change-Id: Ifb8ca51cd8937b740c810083b45d5e7fbb06d91f
2017-03-07make SfxApplication ctor privateCaolán McNamara
Change-Id: I85d2a112b1f7e6215480d89e038d6515d641d147
2017-03-07a size is a sizeEike Rathke
Change-Id: I98b54ac353bc0c078f31b447aec2eff7e80b4308
2017-03-07Resolves: tdf#102777 broadcast SC_TAB_INSERTED when inserting scenarioEike Rathke
So ScViewData::maTabData gets an entry added which deleting the scenario can remove again. Change-Id: I166baeff5408ef67faef41364515a13b8d4610bb
2017-03-07coverity#1402074 Resource leakCaolán McNamara
and coverity#1402075 Resource leak coverity#1402076 Resource leak Change-Id: I41f2ad480a43e3563b08a6316d4e74bfe8efd378
2017-03-07A11Y nitpick: correct mnemonic widget mappingGabor Kelemen
This warning appeared while opening the 4th page of Mail Merge Wizard warn:vcl:5291:1:vcl/source/window/builder.cxx:220: missing either source femalecolft or target fieldname member of Mnemonic Widget Mapping warn:vcl:5291:1:vcl/source/window/builder.cxx:220: missing either source femalefieldft or target fieldvalue member of Mnemonic Widget Mapping Change-Id: Ibde465ab1a3603a6b4f831e8d7939b512c4b593e Reviewed-on: https://gerrit.libreoffice.org/34934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-03-07add icgCaolán McNamara
Change-Id: Ib017705ca38c83cd7dfbedec60e2c7adf3f3c6a3
2017-03-07convert RES_FIELDS to scoped enumNoel Grandin
and rename to SwFieldIds Change-Id: I50d2b7550f68b4b020ffc1603f931c671c8e1de6 Reviewed-on: https://gerrit.libreoffice.org/34924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-03-07Remove unused include/systools/win32/comptr.hxxStephan Bergmann
(there's a close cousin in fpicker/source/win32/filepicker/ that's actually in use there) Change-Id: I3250112703f09871e7451257b0417d1d3c332f73 Reviewed-on: https://gerrit.libreoffice.org/34932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-07Remove redundant 'inline' keyword, Linux reduxStephan Bergmann
Change-Id: I10c7dbd6a7acce309b056a1ae57c39f00f22c46d
2017-03-07Add Tooltips for emoji toolbar controlAkshay Deep
Change-Id: I93d9fb1af42d83c7f7f518a1441f4666fd7ee30a Reviewed-on: https://gerrit.libreoffice.org/32231 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-03-07remove dead codeJochen Nitschke
was deactivated in 2010 by commit 9334f7757330fdd113d37b3faed728e56e6330c8 Temporarily disable the extra ACL check. Change-Id: Ia9d2b7f55285e78f0737bf798b627740ccb11979 Reviewed-on: https://gerrit.libreoffice.org/34937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-07tdf#51358 Support for BarnDoorWipe transition animation in SVG supportRohan Kumar
ported the class BarnDoorWipe Change-Id: I10c98cf575c76bb0c96a9622721d1ab368941dca Reviewed-on: https://gerrit.libreoffice.org/33323 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-03-07tdf#95416 Removed ../ in filter/source/svg/test filesJeevan
Change-Id: I9f281c48ddd78f2a897e26b9af57fef2e89604d3 Reviewed-on: https://gerrit.libreoffice.org/34890 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-03-07starmath: Avoid creating SmFontNode with a default tokenTakeshi Abe
when an unexpected token is found. Change-Id: I1a11c08ce54c55bb32289498fbb26af019396b83 Reviewed-on: https://gerrit.libreoffice.org/34918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-03-06oss-fuzz: Module_xmlsecurity has gpg inside ENABLE_NSSCaolán McNamara
which is probably wrong, but nothing uses --disable-nss except IOS and the static build where nss is not built Change-Id: Icdd24ffc301715a0227e31f67335c8775806e085
2017-03-06The 'fLockObj' field of an 'ObjProtect' MUST be 0x0001 says the specTor Lillqvist
So generate such a record only when the protection state is on. See https://msdn.microsoft.com/en-us/library/dd922139(v=office.12).aspx Change-Id: I710395527cd53dc47018806e51fcc699e11fb461
2017-03-06The 'reserved1' bit of a 'Formula' MUST be zero according to current specTor Lillqvist
See https://msdn.microsoft.com/en-us/library/dd908919(v=office.12).aspx . This means we will never set the EXC_FORMULA_RECALC_ONLOAD flag, hmm? Change-Id: Ic081caa7f98426394cbc7b0b320fa1a5a9a34f6c
2017-03-06Set the 'unused2' bit of 'Font' to 1 iff 'uls' is greater than 0 per specTor Lillqvist
See https://msdn.microsoft.com/en-us/library/dd906117(v=office.12).aspx . Change-Id: I4ff278f4cdd388947bbe81b88b6c39ff2b208b1a
2017-03-06masOS codesign: Use of unset variable is an errorAndras Timar
Change-Id: I270b7ab66d502e767a62e7e98ec3cefe7b9646d5
2017-03-06don't try to install pdfium lib in --disable-pdfiumRene Engelhard
Change-Id: I77f2ab2b627ceee2d6b0d44e530b4ac691510bf3
2017-03-06Try harder to debug the random TB failures hereKhaled Hosny
Change-Id: I490302e56e6dcc222fc9b65755f16272bb53af56 Reviewed-on: https://gerrit.libreoffice.org/34930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-03-06remove unused #includeLionel Elie Mamane
Change-Id: I97111309432359968e890aacd0a285d068991307
2017-03-06tdf#40575 remove obsolete MAX_DAYS checkLionel Elie Mamane
Change-Id: Ifccf3a1fe27011a8e72464bf76cadcf16f5f5fa7
2017-03-06Revert "tdf#106283: Registry settings are not read properly on Windows"Stephan Bergmann
This reverts commit 8cfda7206139b3017346c435591c77c9741ba8ee. The problem in that issue is that the configmgr/source/winreg.cxx code generates .xcu data where such an extension prop doesn't have an oor:type attribute, which is not allowed. On the other hand, it is important that the PropertyNode representing such an extension prop has a staticType_ of TYPE_ANY, so that later layers or programmatic calls can store values of different type.
2017-03-06Check for divide by 0 in Calc function NPER.Winfried Donkers
Plus improve efficiency and use correct prefixes for variable names. Change-Id: I2ba0863a57aad4c89bc930fa69b08ed90b070002 Reviewed-on: https://gerrit.libreoffice.org/34902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-03-06Add constraint and divide by 0 check for Calc function RRI.Winfried Donkers
Plus rename variables with correct prefixes and common names. Test for type of error in unit test. Change-Id: I48d2fee180e5e093189c1bb6fe889cbf74260fc4 Reviewed-on: https://gerrit.libreoffice.org/34882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-03-06Check for divide by zero in Calc function SLN.Winfried Donkers
Plus use correct prefixes for variable names. Change-Id: Ia60117bec22eb305cb351a2e5fa0e757b4897139 Reviewed-on: https://gerrit.libreoffice.org/34872 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-03-06tdf#106236 Check for all constraints with Calc function PDURATION.Winfried Donkers
Plus use of correct prefixes for variable names. Change-Id: I430039fa23fc73e13bf1992f4188a67ae47b52ab Reviewed-on: https://gerrit.libreoffice.org/34819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-03-06tdf#106210 Apply correct constraint for calc function EFFECTIVE.Winfried Donkers
(= ODFF formula EFFECT) Change-Id: Ib9adeece3d2f1331b80ce8eae74831420e6c2e6b Reviewed-on: https://gerrit.libreoffice.org/34682 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-03-06Notebookbar: fixed vertical alignmentSzymon Kłos
Change-Id: I19d06f9dd2d4ec65de687b36d8a80eb7c7beba22
2017-03-06libreofficekit: GTK 3.22 deprecates gtk_show_uriMichael Stahl
Avoid -Werror=deprecated-declaration and use gtk_show_uri_on_window instead, which needs a GtkWindow. Change-Id: Ia77978348809c8d88cb2823a1549cbdeffcc6c97 Reviewed-on: https://gerrit.libreoffice.org/34926 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-03-06Fix flip issue in Snake animation subtypeRohan Kumar
Fix flipOnYAxis function, alongwith minor tweaks. Change-Id: If8958de9eb651a15f86963f2e40eb364011ce41f Reviewed-on: https://gerrit.libreoffice.org/33918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-03-06tdf#51358 Importing ClockWipe in SVG engineRohan Kumar
Most of the constants and transition info table were already written, i just added the perform method. Change-Id: Ib8e2d8e7ca7e26dc54a1e309a2b6271ee7603f34 Reviewed-on: https://gerrit.libreoffice.org/33847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-03-06tdf#51358 Support for VeeWipe transition in SVG SupportRohan Kumar
Ported the class Veewipe Change-Id: I13b9d7235967e3dd1b1b1638c27e76d11708d1e0 Reviewed-on: https://gerrit.libreoffice.org/33764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-03-06loplugin:simplifyboolStephan Bergmann
Change-Id: Ied05f5d8b09b3bab4bddfe0a189c5039f81b6f18
2017-03-06sw: remove unnecessary upcastsJochen Nitschke
guess some broken compiler needed these Change-Id: If0132f6363555fea2ef880bd7af343c2d7b2a0a4 Reviewed-on: https://gerrit.libreoffice.org/34925 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-06Simplify SAL_INFO message compositionStephan Bergmann
Change-Id: I665c77f984cebba8803ff81a78dd31578bdeef51
2017-03-06Remove one more MinGW leftoverStephan Bergmann
i.e., WNT=OS implies MSVC Change-Id: I87b02dcbfe74405326b60f49bceaf99de7c56b83 Reviewed-on: https://gerrit.libreoffice.org/34920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-06oss-fuzz: add in requirements for pptCaolán McNamara
Change-Id: Ie4118e4057ceb5268469576c79f1db8226b7655b
2017-03-06tdf#103847: Pass also XFillStyleItem to subtabsKatarina Behrens
this resolves the issue of non-preset gradient and hatch values not being shown. Bitmap is still broken (beyond repair) Change-Id: Ifad8f3a56b534e26def69c0b0bb2ed55de53bcda Reviewed-on: https://gerrit.libreoffice.org/34908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-03-06XUniversalContentBroker pBroker unused directlyCaolán McNamara
since... commit 1ce99678e5647076da3c152f0b7350e5ddd410e4 Author: Stephan Bergmann <sbergman@redhat.com> Date: Tue Aug 18 15:23:03 2015 +0200 Simplify from ucbhelper::getSystemPathFromFileURL to osl::FileBase (vnd.sun.star.wfs is long gone) Change-Id: I91a72bd9104df2e0ab640b67d0ec34fc172c36e9