Age | Commit message (Collapse) | Author |
|
Change-Id: I476f0ffaef383f3227c0c12b50fcdebf393190f6
Reviewed-on: https://gerrit.libreoffice.org/17487
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
|
|
Change-Id: I24316edbf9fc95281b0bfdbcffbc670a3df4c853
Reviewed-on: https://gerrit.libreoffice.org/17550
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: Id9dee9cfe065b30c2ae9bade1098d16e2c659c23
|
|
Change-Id: Idad2cf21bc6e64797a3662f5204f8d77289ce940
|
|
Change-Id: I0f18205f63c6bd5f9375cf3328b72ba5ef84cbde
|
|
Change-Id: I3cc3973e3740009b543d9a841396182e76e16203
|
|
Change-Id: Ic1c22a4840c09249e9a1e8cf0712ee942fd030b1
|
|
e3a74864a02d2ed362f7bfb82c5ce6068b908101 was subtly wrong:
in a --enable-online-update build, the assertion triggered with
nonsensical stacks like:
4 in osl_joinWithThread(oslThread) at /sal/osl/unx/thread.cxx:441
5 in osl::Thread::join() at /include/osl/thread.hxx:111
6 in (anonymous namespace)::UpdateCheckJob::notifyTermination(com::sun::star::lang::EventObject const&) at /extensions/source/update/check/updatecheckjob.cxx:312
7 in framework::Desktop::impl_sendNotifyTerminationEvent() at /framework/source/services/desktop.cxx:1665
8 in framework::Desktop::terminate() at /framework/source/services/desktop.cxx:307
...
14 in binaryurp::(anonymous namespace)::request(void*) at /binaryurp/source/reader.cxx:85
15 in cppu_threadpool::JobQueue::enter(long, bool) at /cppu/source/threadpool/jobqueue.cxx:115
16 in cppu_threadpool::ORequestThread::run() at /cppu/source/threadpool/thread.cxx:171
The problem is that the early-return case is (accidentally) doing the
right thing for an attempt to join a thread that has already terminated
normally, but the assertion must not trigger when the terminated
thread's ID is re-used by a later thread.
Change-Id: I2a6764d2ec189d96ccb366db14395029bb8e73ad
|
|
Change-Id: I97f33c8db59d2fc084b5e4eb389bff3d8254d4f0
|
|
Change-Id: I088633e4cff278e1add8eeea8828f9ba9c9fb140
|
|
Change-Id: Ic45f65d10835eb39b6709e7adeed1392905ea631
|
|
It is necessary the thread name for debugging LOKit threads.
Change-Id: I713595eb1319234ff90a6eddebcac5ebad912b04
|
|
Add a dependency from main.xcd to config_host.mk to rebuild it when the
version number changes.
Change-Id: I6878d58def57942f117b0b6e49a6c03abbeca5af
Reviewed-on: https://gerrit.libreoffice.org/17539
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: Ia13742604347d11c0225ba5db05d2eb6b6b29d7f
Reviewed-on: https://gerrit.libreoffice.org/17528
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I6070421b2275b7fdd698fdc87cc349fc87846513
|
|
I missed a similar bug lower down
Change-Id: I673c69dd1d36cc1b502a7de7821a05d859313aac
|
|
Bug introduced by commit fb14be5f8f74f83ba89e15f891ddf1f753dcc62f
"create new 'enum class' SotClipboardFormatId to unify types"
Change-Id: I3febb927f658ac27d2b864869775db3b71940a5c
|
|
Also fixed one comment I forgot in the previous patch
Change-Id: I3ee090b03bb3d5b5c0d4095c991f22a894ed912a
Signed-off-by: Michael Stahl <mstahl@redhat.com>
|
|
If the Win32 implementation deadlocks on a self-join, at least assert in
the same situation on UNIX.
Change-Id: I1b9e3da95837d456e6933e8fd9a256869cb4bde9
|
|
Change-Id: I6694bf83e1e5ba6563d399e454442ce3574e8d26
|
|
Change-Id: I5f775234f44c23386af19f973a9f895a39fa31d5
|
|
Change-Id: I0c90efb477a7e9ee4acac98f97c9ff77e75cdec4
|
|
Change-Id: I37661729a2d9f05b58eef5a21effff8f8516b1b7
|
|
with the variadic variants in extensions.
Change-Id: I45e9dc5769150181df88791b3f748002ca713c02
Reviewed-on: https://gerrit.libreoffice.org/17517
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
requested by Phil Jung
Change-Id: Id6b803e64868a5194572b3356fa98defa18bff33
|
|
Change-Id: I0dd91ba9f7b3cbe9c6799c40b7e16a8a58f9d89e
|
|
Change-Id: Icdc568e4d771cb8ebeca329a897d3694408ffaa4
|
|
Change-Id: I17b193e79f4eaf54c9ae8f5c6dfd204b8fc4ad3b
|
|
free(NULL) does not crash, it is defined to do nothing. Did I not know
that in 2010?
Change-Id: Ia6c4817ea87b646d643a19daabfe7850c5416cc8
|
|
Change-Id: Ia3fc26c8d3ec433e2cdf401b0fc0d70de4611210
|
|
Change-Id: I33457a2e1a213c6eb172ab188272e9688cd2ccad
|
|
Change-Id: Ic2eec30cfb5f61c53777eefeeb8bad6f552da2fc
Reviewed-on: https://gerrit.libreoffice.org/17355
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
We now have a complete toolbar controller in chart2.
Change-Id: I007d9b058e3d6800204ac035cc2aef5e93c1208b
|
|
Change-Id: Id0658cf561570a2ae15fb7fd603e6437da9cfaf2
|
|
This was only done in the new gtk3 backend, all other backends seem to
ignore the GDK_KEY_RELEASE event (especially the gtk2 one). So make the
gtk3 backend code consistent with the other backends.
Change-Id: I3bdecb7ce05190ee2496bc552ca79375fb6fd713
Reviewed-on: https://gerrit.libreoffice.org/17431
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ifc2f4592fdd4cfebdefc0c4b94656ffc06ddf879
|
|
Change-Id: I9548c80f0bda342477cde249f9b55dde95e9c0f4
Reviewed-on: https://gerrit.libreoffice.org/17524
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Project: help bbece63b0f7b182f8bbf36accef29bb7a42e7800
missing space Open Statement[Runtime] → Open Statement [Runtime]
Change-Id: If90b4d89c0dc7172b417b30dd242278386813244
|
|
(Not that I know if there is any good reason to keep it optional.)
Change-Id: I92c52ad201661755e2d6eb023be7e268249b75a2
|
|
Change-Id: I2b3c8eedabeaecd8dcae9fe69c951353a5686883
Reviewed-on: https://gerrit.libreoffice.org/17521
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
from both the code and the XCU files
Change-Id: I47f1f33c3ad4a37e346e3b8020dd9d3e284ccb77
Reviewed-on: https://gerrit.libreoffice.org/17522
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
I did not notice this before, as my user profile had a custom window
size; but with an empty user profile the buffer had a 0,0 size, so the
buffered result was empty, as no ImplHandleResize() was invoked.
Change-Id: Ie299ad1323944941afc407dc90f2459d72885d42
|
|
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba
Reviewed-on: https://gerrit.libreoffice.org/17506
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
Change-Id: Ie551cc9c1de20c017d8cf9f4d6f060729f9c245b
|
|
with the variadic variants in embedserv and eventattacher.
Change-Id: I556ad208a7ffcf85c484e298cdbb1324b8a6a659
Reviewed-on: https://gerrit.libreoffice.org/17499
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
The web wizard runs some XSLT over the exported file. It registers
a handler that is called when the output stream is closed, and this
Process.streamClosedHandler() calls terminate(), which causes the
deadlock, because it wants to join() the extra XSLT thread but the
handler is actually called from the XSLT thread itself.
Fix that by moving the terminate() to another function that runs in the
main thread.
It does not deadlock on Unixes because osl_joinWithThread() actually
detects an attempt to join the calling thread and returns early.
Change-Id: Ia176562fa28b97c7e8956c1e8975c9aa6ee23236
|
|
Change-Id: I9888f8ab7bccdd2902d619487279999f2ff9ab13
|
|
Change-Id: I3afde8e7f8b0b88e8f1a5d1ad71429c2aa7d7a94
|
|
The hard-coded "/" separator causes getFileURLFromSystemPath to fail,
and it's not obvious why the URL is being converted to a system path
in the first place.
Change-Id: I06ebe6d92954c4f3c884ae6f0b327ea8a36c10a4
|
|
... at least not if VCLXWindowImpl::OnProcessCallbacks drops it and
calls arbitrary event handlers.
So try to make nested SolarMutexReleaser work in that case (although
poorly).
Change-Id: I1e2a1f4d6f42f826692696f7d92d1c3d71291f39
|