summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-03-16Colibre icons: add cellborder iconandreas kainz
Change-Id: Ifd74d3cfbc6b4b1c2c4a7a1b5529e137a7b041eb Reviewed-on: https://gerrit.libreoffice.org/51446 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-16Tango icons: move svg and xcf source files to tango_svgandreas kainz
Change-Id: I94a2c7a1048a3e29776a0b5b6f78a7d043b751ca Reviewed-on: https://gerrit.libreoffice.org/51376 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-03-16First cut at annotating 'exotic' filters.Michael Meeks
The idea being that we can improve security by warning for these. Change-Id: I7d993417bfb6a8fe868bc3e07ccbcfe71bf285ff Reviewed-on: https://gerrit.libreoffice.org/50387 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-03-16rhbz#1392145 ensure titlebar close button matches 'outside' directionCaolán McNamara
Change-Id: I20e925c58adb56acd4d1a63720d330c8b6613441 Reviewed-on: https://gerrit.libreoffice.org/51433 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16Related: tdf#115964 convert the problematic dialog to a native gtk3 oneCaolán McNamara
Change-Id: I84e10f1c45dfbe267f9b350d74271ac149bdaf43 Reviewed-on: https://gerrit.libreoffice.org/51432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16Related tdf#116264 trailing newlines used for msgbox padding now harmfulCaolán McNamara
Change-Id: Ibe53f71514ffa7d5ca5728b742964f1ab4827692 Reviewed-on: https://gerrit.libreoffice.org/51427 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16can get the window from the SwViewCaolán McNamara
Change-Id: Ifa3033b928db817ccdc4337f8995179bc488fcb6 Reviewed-on: https://gerrit.libreoffice.org/51425 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16use real frames, etcCaolán McNamara
Change-Id: Ie21a7058c51c3c456de473bf0a88f46cb76a44a4 Reviewed-on: https://gerrit.libreoffice.org/51424 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16use digit width instead of char widthCaolán McNamara
its the same across backends Change-Id: I37c83cbf1139babcd014c7cfdee06a13bea845c7 Reviewed-on: https://gerrit.libreoffice.org/51423 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16weld SignatureLineDialogCaolán McNamara
Change-Id: I14cbc7e1aa70696abdeb21eae31176566f17e066 Reviewed-on: https://gerrit.libreoffice.org/51422 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16lokdialog: do not lock events when opened ScFilter DialogHenry Castro
When exists 2 or more views and one of the views open the ScFilter dialog, the other views are locked and no event process. In tiled rendering case, collaborative editing is not functional with 2 or more views are locked, so the patch prevents locking the other views Change-Id: I0133d38ac5ecef4d3ebc22f3e922602704dcd0b3 Reviewed-on: https://gerrit.libreoffice.org/51370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-03-16iOS, solved call stack problem.jan Iversen
Stack was not corrupted, but the call stack was not intact when passing the assembler code. Change-Id: If07909dce2b4a73634a130e5f50e84312115b845
2018-03-16move cairo extract bitmap code from canvas to vclNoel Grandin
part of making GetMask/GetAlpha an internal detail of vcl Change-Id: I45c2e9fdae08d7f444a64e8e04a6f65bb525cbd1 Reviewed-on: https://gerrit.libreoffice.org/51417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16loplugin:useuniqueptr in SvUnoWeakContainerNoel Grandin
just use a std::vector here, these are small objects, no need to allocate them separately Change-Id: Ie9f8df88eb7c291e2c99177d0f5e4bfc1c7ab542 Reviewed-on: https://gerrit.libreoffice.org/51415 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16move some mask code from SvxMSDffManager::ImportGraphic inside BitmapExNoel Grandin
part of moving GetMask/GetAlpha touching code inside vcl Change-Id: I46e908ed6216dd521143ca94d2dcbd7e95d8b9ce Reviewed-on: https://gerrit.libreoffice.org/51408 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-16fix crash on pdf import of tdf59883-2Noel Grandin
after commit a9ef943769b06e6bdffe7326f288b27e08a95698 Date: Wed Feb 28 11:09:43 2018 +0200 loplugin:useuniqueptr in sdext Change-Id: I3f54002764ee42162279bade49a3e3b21e136917 Reviewed-on: https://gerrit.libreoffice.org/51402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16Typo in error messageStephan Bergmann
Change-Id: Ia56a47b46989027588afc291bf8f82299903cdaa
2018-03-16ofz#6950 Integer-overflowCaolán McNamara
Change-Id: I56d8da7d6f376744803153b29d1dfe638e10b001 Reviewed-on: https://gerrit.libreoffice.org/51398 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16tdf#113182: DOCX filter: new values of wrap property in text boxSerge Krot
Added support of "none" and "through" values of the w:wrap poroperty in the text box. Change-Id: I83f0c9e8162e93bf457f228d49d3b426050d4dc6 Reviewed-on: https://gerrit.libreoffice.org/51396 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-16simplify ImageList::GetAsHorizontalStripNoel Grandin
no need to repeat logic the BitmapEx constructor already implements Change-Id: Ic958b3a3baafe9911b8461e1fc512e36616db89c Reviewed-on: https://gerrit.libreoffice.org/51401 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-16sdk/lib dir missing from Linux installation setsStephan Bergmann
...after cfd2691e5bf398304d7816227b933e53907b6204 "[API CHANGE] Remove salcpprt static library" had removed the sole regular File item from gid_Dir_Lib_Sdk, leaving only Unixlink items. But the solenv/bin/modules/installer.pm code used to only auto-create any directories that contain regular Files. Changed that to also consider Unixlinks in addition to regular Files. And to add insult to injury, the code in solenv/bin/modules/installer/simplepackage.pm creating the actual symlinks represented by the Unixlink items silently does nothing when a symlink cannot be created (because the partent dir is missing). To be fixed in another follow-up commit. Change-Id: Ic7a682a17ac59c789c85c56c825dd623bc59428c
2018-03-16chart2 lok: tunnel context menu of the chart edit viewPranav Kant
Change-Id: I0c8b3cfe1666ad81f808871a87e4b0fa64ef593c Reviewed-on: https://gerrit.libreoffice.org/51345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-03-16weld SvxObjectTitleDescDialogCaolán McNamara
Change-Id: Id08c201ee4377fe84618906725e7699d29dc1160 Reviewed-on: https://gerrit.libreoffice.org/51395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16loplugin:useuniqueptr in ScDPSaveDimensionNoel Grandin
Change-Id: I169a8eff540c866958da37c25a03550542433f16 Reviewed-on: https://gerrit.libreoffice.org/51372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16Simplify codeStephan Bergmann
...avoiding loplugin:salunicodeliteral and loplugin:stringconstant Change-Id: I560682ac87b24f47fc16a6ef17232c7fbc8c9099
2018-03-16don't bother dithering for 256bit displaysNoel Grandin
which surely are a minority by now Also drop the GetColorCount() method on OutputDevice and clean up the remaining call sites to use GetBitCount() Change-Id: I4e2c6f2523796f7df7f54eb005f1539e34d9ea40 Reviewed-on: https://gerrit.libreoffice.org/51389 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-16move framework/toolkit use of BitmapEx::GetMask inside vclNoel Grandin
Change-Id: I2a942377d6e9b8b09673e5ad2804e0e7fb2bb943 Reviewed-on: https://gerrit.libreoffice.org/51387 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16tdf#116403: consider borders when updating right-aligned tab in indexMike Kaganski
Change-Id: I415d8fcfdd75e6d608ec2e3ba228146cf8139278 Reviewed-on: https://gerrit.libreoffice.org/51388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-16Resolves: tdf#115923 try a different approach to solving tdf#46637Caolán McNamara
Try scrolling to the cell the mouse is over if its not fully visible already and this is not autofill selection. To avoid the mouse over the autofill handle which overflows into neighbours scrolling the neighbour cell into view before its truly desired to be selected when the mouse passes the center point in other words, for autofill go back to how it always was Change-Id: I6f67ad0f49c2d4087949f71f38322f06ced13c79 Reviewed-on: https://gerrit.libreoffice.org/51361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16remove constructor with UniqueID from GraphicObjectTomaž Vajngerl
Change-Id: I03924c993a95adaf6e19589779546fce2b38c745 Reviewed-on: https://gerrit.libreoffice.org/51333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-16Remove XGraphic creation with Grap.Obj. URL in GraphicProviderTomaž Vajngerl
Change-Id: Ie51be332df88791cb13c3835582acc0a4e7250f9 Reviewed-on: https://gerrit.libreoffice.org/51332 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-16remove some GraphicObject URL funct. from GraphicImportHelperTomaž Vajngerl
GraphicImportHelper is an implementation of XGraphicObjectResolver which is mostly used to "resolve" a GraphicObject URL to the internal storage URL (and save the graphic to the storage in the process). Most of the GraphicObject URL functionality was removed so the required overrides from XGraphicObjectResolver interface now return an empty result or do nothing. Change-Id: Iee6bb71b15411d03ef82ab4d20d234ff0e834425 Reviewed-on: https://gerrit.libreoffice.org/51331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-16tdf#116213 OS X and OpenGL bitmap scaline sizes are not 32-bit alignedChris Sherlock
Change-Id: I92b43ae2f034bf63cc3f212ec8728c5c6b5e8934 Reviewed-on: https://gerrit.libreoffice.org/51222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-03-16iOS, added description of __cxa_throwjan Iversen
Change-Id: I6a537957528a0d2de989b347bde1167e21544236
2018-03-16tdf#104789 Export opacity attribute nameSzymon Kłos
Change-Id: Id47ab6b3cb20fbcebb2d7fa589f3b0d7552e2cce Reviewed-on: https://gerrit.libreoffice.org/51369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-16tdf#104786 Don't export empty 'to'Szymon Kłos
Change-Id: I16b573fd6455813c6be5c2f5a0f0a820360a239f Reviewed-on: https://gerrit.libreoffice.org/51359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-16tdf#90627 Don't save empty conditionsSzymon Kłos
Change-Id: I5a953c1b0fff7bf41a59360a8f52596264ddf266 Reviewed-on: https://gerrit.libreoffice.org/51293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-16Fix typosAndrea Gelmini
Change-Id: If70b03cad4c46010a59cf3bee139e801230fa3aa Reviewed-on: https://gerrit.libreoffice.org/51385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-16Revert "sd lok: Set the view size to full page size and hide ruler, scrollbars"pranavk
Pushed by mistake. Let's revert until tests passes This reverts commit 1354bafdc707b87f8db1e89c96382c4f4f460554. Change-Id: I4a8973f4e22332115143319a264fefa68e343dcc Reviewed-on: https://gerrit.libreoffice.org/51386 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-03-16sd lok: Set the view size to full page size and hide ruler, scrollbarsPranav Kant
... such that during insertion of objects when sd calculates the center of the view to place the object, it is the center of the whole slide, not the center of the default rectangle of 800x600. It's also important to hide rulers, scrollbars so that correct center is calculated; we don't need them anyways in LOK. Change-Id: I1180541c1b8c8a35f39112ca0a670c9d96d1320b Reviewed-on: https://gerrit.libreoffice.org/51347 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-03-16lokdialog: Invalidate upon window size changePranav Kant
This problem can be seen with some of the dialogs like chart dialogs where not all of the area which should be invalidated is invalidated. The reason being that their container gets resized but not lok-invalidated. Change-Id: I12eb68e8644ca67b2666badb7b772b92a145c624 Reviewed-on: https://gerrit.libreoffice.org/51264 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-03-16loplugin:useuniqueptr in SwAccessibleTableNoel Grandin
Change-Id: Ife93c2bb6c0d064946dc760b8cbc6133b9e97c62 Reviewed-on: https://gerrit.libreoffice.org/51371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16loplugin:useuniqueptr in SwBlockCursorNoel Grandin
Change-Id: I3c3b9969ea26bd378a25a3c58e4710a5538889fb Reviewed-on: https://gerrit.libreoffice.org/51373 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16chart2 lok: give parent to data table dialog to tunnel itPranav Kant
Change-Id: Ie82a9a6d9b499e5da34e04f0c2f5fc7c164b098e Reviewed-on: https://gerrit.libreoffice.org/51346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-03-16use more TypedWhichId in sfxsidsNoel Grandin
Change-Id: I136427319ce2f1117501517efec2f03019bbf71e Reviewed-on: https://gerrit.libreoffice.org/51339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16loplugin:useuniqueptr in SmCategoryDescNoel Grandin
Change-Id: I4a6be3c84fb7c64b5f72499e5393e44f02514201 Reviewed-on: https://gerrit.libreoffice.org/51334 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16solenv: sort the clang-format blacklistChris Sherlock
LC_ALL=C sort solenv/clang-format/blacklist > ~/blacklist mv ~/blacklist solenv/clang-format/blacklist Change-Id: Id00c5dc912220c6af6b1334e833abef4a0889ee0 Reviewed-on: https://gerrit.libreoffice.org/51349 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-16Modernize a bit filter (part2)Julien Nabet
mainly by using for-range loops + some algo simplifications Change-Id: I25b02676527d551985434e07e7dc5f2927d4955e Reviewed-on: https://gerrit.libreoffice.org/51377 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-16tdf#112118: DOC: properly import/export border distanceMike Kaganski
DOCX part was done in fb959e581c900b392efd0bb329b7cf30c8ed56a5. This commit fixes DOC part. Line width wasn't taken into account on import; and export was done only with "from text" distance, which gave poor interoperability with Word, where the borders were close to page edge. The common code is moved to editeng/source/items/frmitems.cxx and include/editeng/boxitem.hxx. Change-Id: I3d1d1312cb9dc9a9e00d9847ec11234cd787df60 Reviewed-on: https://gerrit.libreoffice.org/51366 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-16Clip BColor lightness value at 1.0Stephan Bergmann
UBSan build started to fail CppunitTest_sw_ooxmlexport8 with > /include/tools/color.hxx:59:27: runtime error: value 258.5 is outside the range of representable values of type 'unsigned char' > #0 0x2ad219182418 in Color::Color(basegfx::BColor const&) /include/tools/color.hxx:59:27 > #1 0x2ad219175e48 in (anonymous namespace)::lcl_compute3DColor(Color, int, int, int) /editeng/source/items/borderline.cxx:50:16 > #2 0x2ad219175574 in editeng::SvxBorderLine::threeDLightColor(Color) /editeng/source/items/borderline.cxx:77:12 > #3 0x2ad21917ea78 in editeng::SvxBorderLine::GetColorOut(bool) const /editeng/source/items/borderline.cxx:573:23 where lcl_compute3DColor had been called with (aMain=rgba(255, 255, 255, 255), nLight=3, nMedium=40, nDark=83) Change-Id: I0f4569d9fd9f54164efe395960bcc8a6840e7744 Reviewed-on: https://gerrit.libreoffice.org/51351 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>