Age | Commit message (Collapse) | Author |
|
Drop Build prefix and settle on Lib and Exe prefixes. Also add a
note about the "else" part of the condition and fix offenders.
While at it, define COND_LIB_SAL_TEXTENC to be used by sal to
prevent diverting coditions in build and cxx code.
Change-Id: I944587ca1ccbe46b765d1a631a7214c8126fe951
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128136
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Change-Id: If6d5384d4692fba94070bb11bb5a47a66b813f58
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128135
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
And I should have tested gb_Helper_optionals_and. Inspecting the
generated token for comparison doesn't result in gb_[T1]_[T2],
as I expected. So first filter the token from BUILD_TYPE, then
filter-out the result from the input token. If true, then both
sets are equal == and.
Change-Id: I74a324f766331b30a0af9c9bfd7c927c1d21df53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128115
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
In addition, changed argument datatype from Int to Long.
Change-Id: I702e09b6b8061d7cf00dd403e4681a0ab348d4c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128100
Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
Change-Id: I183f19f6abd4ca3f54d13533c8551deb09cd9458
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128118
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
In
commit ec50b9e5eaec7c94df35617676077ef0d65cecc7
no need to allocate Sw2LinesPos separately on heap
I made this change,
// If there's no doubleline portion involved or start and end are both
// in the same doubleline portion, all works fine, but otherwise
// we need the following...
- if( pSt2Pos != pEnd2Pos && ( !pSt2Pos || !pEnd2Pos ||
+ if( (pSt2Pos || pEnd2Pos) && ( !pSt2Pos || !pEnd2Pos ||
pSt2Pos->aPortion != pEnd2Pos->aPortion ) )
I tried to follow the explanation in the comment, since the
existing comparison of pointers made no sense, since the two objects
would always be distinct.
However, that appears to have caused this bug, so change the
comparison to directly represent the original logic.
Change-Id: I95d6d870cecd762d4eb809d371e4a61b6641c85e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128133
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
when they have no text in them
Change-Id: I70c18898abf21141f3b30b7dee9c931c9b27cffb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128124
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Upon opening a Writer document containing some languages that do not
use hyphen, an alert is created with the text:
'Missing hyphenation data Please install the hyphenation package for
locale "ab_CD".'
in which 'ab_CD' is the locale.
This patch removes the warning for these languages, that do not use
hyphenation:
* Arabic script languages (except Uighur)
+ Persian (Farsi)
+ Kashmiri
+ Kurdish (Central Kurdish and Southern Kurdish with Arabic script)
+ Punjabi
+ Sindhi
+ Malai
+ Somali
+ Swahili
+ Urdu
"Words are not hyphenated in Arabic language text, however hyphenation
is possible for Uighur text written in the Arabic script"
https://www.w3.org/International/i18n-tests/results/word-break-shaping
The list from MS documents is lenghty, but some of the languages are
were not available in LibreOffice, so they are ommited:
https://docs.microsoft.com/en-us/typography/script-development/arabic
There were languages like Hausa and Kanuri from Nigeria that use both
Latin and Arabic script, but only Latin script was listed in the
LibreOffice languages, so they were also ommited.
* CJK languages
+ Japanese
+ Korean
+ Chinese
+ Yue Chinese
"CJK languages differ from European languages in that there are no
hyphenation rules"
https://tug.org/TUGboat/tb25-0/cho.pdf
* Vietnamese
"In Vietnamese all words consist of single syllables, so they are
often very short; hyphenation is not allowed at all."
https://tug.org/TUGboat/tb29-1/tb91thanh-vntex.pdf
Hyphenation is declined in Vietnamese orthography since 1975
https://www.quora.com/When-did-hyphenation-decline-in-Vietnamese-orthography
The fix for Japanese (tdf#143422) was previously done in:
53d5555f13371252874ec962dee4643168d26780 and the functionality is
preserverd with the current patch.
An alternate approach would be adding all the unicode scripts,
specifying the script for each langauge, and decide upon the script
(mostly) and not (only) the language.
More information about the hyphenation usage of many scripts can be
found in:
https://r12a.github.io/scripts/
This is the list of Unicode scripts:
https://unicode.org/standard/supported.html
https://en.wikipedia.org/wiki/Script_(Unicode)#List_of_scripts_in_Unicode
Change-Id: I7d2b4ee55a0893d1f0d1f9cd3b7cc037a49589b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126435
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
to a5cccb45ec8ea2e4e45a92668136d4cbe045f7f4
- tdf#145866 Fix information about accessing Function List
Change-Id: Icfa91482c8260dc838e53eee5dafee54fca7a5b0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127953
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: I5d410461d7b4e8466533fc4186ee77ec99fae089
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128123
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
...after c35f81148fb18ba070516edcbb4d614444899235 "Use
sal::systools::CoInitializeGuard and sal::systools::ThrowIfFailed"
Change-Id: I3df9fd523820e1d3651480d51ebbaafaafa3ed48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128095
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Currently we don't destinguish between between extensions without
code, which couldn't be executed with DISABLE_DYNLOADING, and all
other extensions, like translations, dictionaries, etc., so there
is no need for a static unopkg.
Change-Id: I427a51b3174d074e467a582e808490a85e98e8eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128114
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Untested change - this code seems to be not compiled in 'make check'.
Change-Id: I02189c88360da585b8419f96cbe2677b224e6712
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128122
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Idae8112f0684f6d3aac70c4450eedc77e48432dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128121
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
I'm not sure how useful this is today. Still hard-disabled on Mac
and Win. Obviously unneeded for static builds.
Change-Id: I3a95dede3c596ccdc0d15eba9edc072ad35f33fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128089
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Tested-by: Jenkins
|
|
Change-Id: I7c272880d6567bc669d4c3c2684aa2e0daeca1b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128120
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I5633674ba7dcb03d9ad3049fa5eb380d385983b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128119
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I4a106a670daaca85cefed08c7baeaa980841a233
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128117
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Let's do like MYSQL JDBC where no system schemas appear and let's remove:
- information_schema
- performance_schema
- mysql
Remove all the crufts about information_schema then.
Also, Mysql 5.1 has been released in 2008 and 5.0 beta was in 2005 (no production date indicated in Wikipedia for 5.0)
So we can consider there's no need in 2022 to test if Mysql > 49999
Change-Id: I49715bb5aa21681b687bab0e75603e4bd0c422de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128062
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
* Update helpcontent2 from branch 'master'
to 93f11134d0d2e6005dcb1f15c0f9ea97d06ba7ca
- Document the theme palette, as a second special one
The palette list is followed first by the theme colors, finally by the
document colors.
Change-Id: I3183f709a1de27eaf6cba33e747831dd7a4b7168
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128128
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
the glue WindowInstance is created on demand, and on creation descends
into any existing open dialogs and changes their help handlers. We could
not descend into child dialogs, but we shouldn't change the app frame
help handler anyway.
Change-Id: I8d149d324f04824fbe9eec517d8c482fd96b125b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128112
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
to c5aa1b0f8efcfb5e4963af8ce667ccb5866fc317
- tdf#97674 Add information on how to remove protection from a section
This patch adds detailed information on how to remove protection from a section. It also adds bookmarks so that when the user presses F1 in the warning message, the appropriate help page is shown.
Change-Id: Ie4c310375995ce56e7e0153255ab8366b16dc532
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128068
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: Ieaf94ce6ce524c4c017cbe1bb82fa75bd5f7e801
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128094
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
it doesn't need any of the logic in DefaultProperties
Change-Id: I75d56a29f1edf2819c22a1fd69df464948544aaa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128093
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The input file has a single page, with a full-page PDF image, which
contains a hyperlink. Similar to pdfcrop, we used to wrap this into a
form XObject, so page-level annotations like hyperlinks were lost.
Explicitly merge page-level annotations from the source page to the page
that contains the PDF image to preserve those annotations.
Change-Id: I96e8bc9d33440b91f3514486d6a8bd75047546b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128108
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
and use a better width calculation
Change-Id: Ib873a8ed9e6424c09630650af352ba5a20c674b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128051
Reviewed-by: Kevin Suo <suokunlong@126.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: I3ffc2303ae1851ab909612ae9bb7f70a077b24fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128097
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
We don't need E3D_INVENTOR_FLAG, we can just check if the SdrObjKind is
in the right range.
Which exposes some dodgy code in DrawViewShell::GetMenuStateSel
SfxItemState::DEFAULT == rSet.GetItemState( OBJ_TITLETEXT ) ||
SfxItemState::DEFAULT == rSet.GetItemState( OBJ_OUTLINETEXT ) ||
which has been there ever since
commit f47a9d9db3d06927380bb79b04bb6d4721a92d2b
Date: Mon Sep 18 16:07:07 2000 +0000
initial import
just remove that.
In SwFEShell::ImpEndCreate() move some logic around to avoid
using an out-of-range SdrObjKind value
Change-Id: I4620bfe61aca8f7415503debe3c84bfe5f4368a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127763
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I1d312798b66ae4ef4be1ac7c838d2f0e18691f80
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128069
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Idd188ed20191668c412791e8f081be7ca377478f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128103
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I5a69596e65b300bd57fd539fe696f1c064ce555f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128102
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I57f67465e4f8ca6fc6bd47d7b095e9b470d9d2c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128101
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I1435f3e8c8ecf41ecd6b2766e19009c6b1783326
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128099
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
* Update helpcontent2 from branch 'master'
to 16edeee7671a4dcbc23180e0d1829cbc1fbf2e92
- tdf#146580 No info on Document palette
Change-Id: I79fe3f451bbaa43824e1ee5659456324412b79fd
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128032
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
to AttributeProperties, since it only applies to AttributeProperties
and its sub-classes.
Change-Id: I01527f75815659d1cf2a9859888ef04c561633a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128092
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
These methods are part of the implementation of DefaultProperties,
so they do not belong in a superclass
Change-Id: I553f5d5b771aa0a408a8ade25f009cc56f829c72
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128091
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
to make it clearer - PageProperties just ignores stuff,
but it is not a logic error to set props on it (or so
it seems from its comments)
Change-Id: Iba3dbcdffae6165a14e9a2d71e4111fbbd29febb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128090
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Icbf19e86b833c0cec08a9ac5c41c01fd2dd1a4e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128060
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
The include is set explicitly in RepositoryExternal.mk . And
when using system cuckoo, it's not necessary to refer to the
unpacked tarball location.
Change-Id: Idd241f7551fb98cb5948c4e7007204ad3a8d87a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128061
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
the XPopupMenu from CreateMenuInterface owns the vcl menu after it's
created.
Change-Id: I0959b3359a4683ce8ca50912136f829b8bbee859
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128063
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
for this case
Change-Id: Ib60577d10bd4a91ea01c5aa6fcf3d50b38fbe24d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128065
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ia68f492ebd4ac81feb44e736c53f0f4a2d99274d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128096
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
> workdir/UnpackedTarball/freetype/src/autofit/aflatin.c:1992:44: runtime error: applying zero offset to null pointer
etc. seen during CppunitTest_sd_misc_tests etc.
Change-Id: Id85c4331f9a892d99e4f3b9cae37b4ffe8c53973
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128034
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Id2053d255624cef365753debea83d4bf1c3d9de3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128070
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
It also claimed "You will not see this message again", but I don't see
how the matching flag would be static.
Change-Id: Ia003dc9c6326d44ad4f4409bed6aca490bfc964e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128064
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
since commit 200cc2d20a21ceb5d176604f9c384f15c6a87570 (2014)
Change-Id: Idf0eb7b484eff26be6b341cbb217572eb8da7306
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127809
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
accidtionally committed with
commit 302b44125aa0c1d5216f986ecf8e341cd6e57418
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Thu Dec 9 11:45:36 2021 +0200
use background XShapeGroup for bar-chart area
Change-Id: Id9fd82a94fd2bb046901fcd4373aac71586d0d13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128057
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
called the wrong method to set new properties,
rather than overwrite all existing properties
Change-Id: I85de598a14876c110e414371fc07a3fde9c6a123
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128059
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
... by moving it into ImplCreate(DragSource|DropTarget).
The existing Create* variant now checks for headless mode and the
IsRunningUnitTest flag, before creating the platform variants.
There are two small helpers to initialize either X11 or Ole based
UNO DnD interace implementations.
Unfortunatly Windows requires to move two dtrans header files, but
at least any other changes are minimal.
Change-Id: Id79459ad71a26243b1c9cb1fe38ab236b0ab8fa6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128049
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Just the $(filter $(gb_MERGEDLIBS),$(2)) in the "if" was wrong,
but reformat and add a comment to make the code easier to read.
This way we correctly header-depend on all requested libraries,
but just export-depend on the real libraries.
And actually use gb_LinkTarget__is_build_lib in the ifeq, as
otherwise the build now fails for the reduced dependencies.
Change-Id: I24d5701891324f5055c9dfa535bd854d09fbb905
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127994
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|