summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-08-20New loplugin:unusedcapturedefaultStephan Bergmann
In sc/qa/unit/ucalc_formula.cxx, dropping the capture-default from the lExpectedinF lambda revealed that MSVC in C++17 mode (i.e., when building without --with-latest-c++) requires ROW_RANGE (a local const int variable from the enclosing TestFormula::testTdf97369) to be captured, even though all uses of that variable within the lambda body are constant expressions. That is still true at least for the latest Visual Studio 2019 version 16.11.1. (This is not an issue for the lExpectedinH and lExpectedinI lambdas a few lines further down, as they, in addition to using that ROW_RANGE, also use the local const double variables SHIFT1 and SHIFT2, whose uses are not constant expressions, so they are implicitly captured and loplugin:unusedcapturedefault does not suggest dropping those lambdas' capture-defaults in the first place.) Change-Id: Iee7efb485187cbe8eba6a2d470afca4993eb1816 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120693 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-20go on switching from boost::property_tree to JsonWriterMarco Cecchetti
JsonWriter provides better performance than boost::property_tree and it is also cleaner, so we need to start using the latter in place of the former as much as possible. Change-Id: I8c1e910c0b3d511b89679e622e2cc5d4848a8b47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120656 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-08-20loplugin:unusedmethodsNoel Grandin
Change-Id: I9ce1ae787b735200cd57b0f470a6e5e3146657fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120777 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-20Fine tune new sm import / exportdante
Change-Id: I7e7ec875b3d0f8f1d62f22270a306bc2f57421ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120768 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-20Improve code reability with different function namesdante
Change-Id: I0799cb26642197813b054c1bde39cf1ced7519a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120767 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-20Fix typo in new SmMlElement exporterdante
Change-Id: Ia1e7963dbb2f69a8b8f43903882521da94eaffe5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120766 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-20use Primitive2DDecompositionVisitor in ViewObjectContact (tdf#105575)Noel Grandin
..to avoid container construction Change-Id: Iae7a8ea8c31b6c8bcf4d161273be7b32fe41a021 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120779 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-20Make some scripts more portableIlmari Lauhakangas
Change-Id: Ia89059eea51ca396a7c74143625ac9a6706de198 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120773 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-20tdf#141097 Revert "Veto process exit while an OLE client is connected"Michael Warner
This reverts changes that were made to prevent process exit when an OLE client is connected. These commits had the side effect of preventing the use case of creating a document via OLE, and then allowing the user to view/edit and ultimately quit from the GUI. Revert "More hacks for quit requests from an OLE Automation client" This reverts commit 05e03911cd1f8a355b6410d3997cffc2c794a1e9. Revert "Veto process exit while an OLE client is connected" This reverts commit 89f883bd90a50587868a57397b6350ed9559a20f. Change-Id: I29a1e42a830815bc8d1ff0056c22d86b8f98cc1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118596 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-08-20loplugin:unusedfieldsNoel Grandin
Change-Id: Ie27afe4c2438c44baece4b926572584c6695dc39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120774 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-20make BitmapPalette a COW typeNoel Grandin
so we can avoid copying it during rendering Change-Id: Id83d2bb2682f46188ee6ccc90c92d338a1e05b98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120759 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-20tdf#91519: prevent jump to top of the comment viewBayram Çiçek
In Writer, there are 3 issues about comment section: - comment section scrolls to top of its view when clicking inside a comment view. - clicking inside a comment view, scrolls the view to old cursor location automatically (if old cursor out of the visible area) - comment section scrolls automatically to the old *selected* text (if it's out of visible area) when clicking inside the Writer canvas view this commit is intended to solve these issues Change-Id: If7d62373f5215adea85512b66b78736e04e02c3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118638 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2021-08-20allow build with poppler <= 0.82Caolán McNamara
Change-Id: Ia062a788fec9c67c18382c2ff5f4b4df35bd17d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120771 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-20Mark external/clucene/patches/nullstring.patch as sent upstreamStephan Bergmann
Change-Id: Id9e0010575110ef6fae5cf93943bb226a7727e09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120770 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-20msan: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
nCheckPos is always set to something, but for nCheckPos != 0 nType might be left uninitialized, so test nCheckPos == 0 before nType seen in ooo76602-1.slk and ooo10703-1.html with distro-configs/LibreOfficeOssFuzz.conf ==623515==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x59600b4 in SvNumberFormatter::PutandConvertEntry(rtl::OUString&, int&, SvNumFormatType&, unsigned int&, o3tl::strong_int<unsigned short, LanguageTypeTag>, o3tl::strong_int<unsigned short, LanguageTypeTag>, bool, bool) svl/source/numbers/zforlist.cxx:658:72 #1 0x8c7f72 in ScImportExport::Sylk2Doc(SvStream&) sc/source/ui/docshell/impex.cxx:2130:48 #2 0x8bcb26 in ScImportExport::ImportStream(SvStream&, rtl::OUString const&, SotClipboardFormatId) sc/source/ui/docshell/impex.cxx:392:13 #3 0x650f4b in TestImportSLK sc/source/ui/docshell/docsh.cxx:3360:19 #4 0x6055a7 in LLVMFuzzerTestOneInput vcl/workben/slkfuzzer.cxx:87:11 #5 0x555b53 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) (/out/slkfuzzer+0x555b53) #6 0x541622 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:323:6 #7 0x54722e in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) (/out/slkfuzzer+0x54722e) #8 0x56fa82 in main /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10 #9 0x7fbd8b65ebf6 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21bf6) #10 0x51cc49 in _start (/out/slkfuzzer+0x51cc49) Uninitialized value was created by an allocation of 'nType' in the stack frame of function '_ZN14ScImportExport8Sylk2DocER8SvStream' #0 0x8c27c0 in ScImportExport::Sylk2Doc(SvStream&) sc/source/ui/docshell/impex.cxx:1837 Change-Id: I0422ca34827319d1e35d453606a7afe6a9de3840 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120762 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-20tdf#143957 Qt5 always create an OpenGLContextJan-Marek Glogowski
Nothing checks the result and a lot of code just uses it. Change-Id: I1a672e98d42673fd684538ead831622f6a14e9f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120761 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-08-20VCL allow plugins to declare OpenGL supportJan-Marek Glogowski
... and get rid of the whole GetBackendCapabilities, which was just overkill. Maybe this should even be some bitmap + enum + set/get function, but I'm too lazy... In the end add a bool for the OpenGL support of the VCL plugin (or maybe sticking it into ImplSVData, which is already some catchall for common VCL data). Change-Id: I9f0ececac482d8e2a94ef6024628e9631b49e773 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120760 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-08-20Add a SmMlElement tree to the sm documentdante
Change-Id: Ide764b512004198277baed60ac4e1a5ef0d1c2dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120765 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-20Add security handlers to the iteratorsdante
Change-Id: I0cc8dd92c7ae870e58f0f9118df76569d6deecd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120764 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-20Convert AreaTransparencyGradientPopup to WeldToolbarPopupSzymon Kłos
Change-Id: I3cbb17de9953281e884f6c1b2984bc4865a56227 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118471 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120700 Tested-by: Jenkins
2021-08-19Fix locking of public UriReference members againStephan Bergmann
...after 074790ad6f4e02e7aed3f9c954f0b4005b40fa21 "remove some locking from UriReference" (and its follow-up 0f44815ce7b2925189cd603853ce55d8363549dd "loplugin:constmethods"): The m_path member is modified by UrlReference::setName in stoc/source/uriproc/UriSchemeParser_vndDOTsunDOTstarDOTscript.cxx. Also make the non-mutated members (for which locking is thus indeed not needed) private for now. (The original intention was that there can be further parsers for other URI schemes, which might need to modify further UriReference members. If such further parsers are ever implemented, the relevant members can be made public again, and the locking be restored where necessary.) Change-Id: I80b437fe14f43294a52e465a7e1f31ddf2ab0482 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120749 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-19external/clucene: Avoid std::string(nullptr) constructionStephan Bergmann
The relevant constructor is defined as deleted since incorporating <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p2166r1.html> "A Proposal to Prohibit std::basic_string and std::basic_string_view construction from nullptr" into the upcoming C++23, and has caused undefined behavior in prior versions (see the referenced document for details). That caused > workdir/UnpackedTarball/clucene/src/core/CLucene/index/SegmentInfos.cpp:361:13: error: conversion function from 'long' to 'std::string' (aka 'basic_string<char, char_traits<char>, allocator<char>>') invokes a deleted function > return NULL; > ^~~~ > ~/llvm/inst/lib/clang/14.0.0/include/stddef.h:84:18: note: expanded from macro 'NULL' > # define NULL __null > ^~~~~~ > ~/llvm/inst/bin/../include/c++/v1/string:849:5: note: 'basic_string' has been explicitly marked deleted here > basic_string(nullptr_t) = delete; > ^ at least when building --with-latest-c++ against recent libc++ 14 trunk (on macOS). (There might be a chance that the CLucene code naively relied on SegmentInfo::getDelFileName actually returning a std::string for which c_str() would return null at least at some of the call sites, which I did not inspect in detail. However, this would unlikely have worked in the past anyway, as it is undefined behavior and at least contemporary libstdc++ throws a std::logic_error when constructing a std::string from null, and at least a full `make check` with this fix applied built fine for me.) Change-Id: I2b8cf96b089848d666ec37aa7ee0deacc4798d35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120745 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-19Revert "tdf#59820 - Adjust column width of imported ASCII files"Andreas Heinisch
This reverts commit aaabfc644afd57577980998c83f94a271f633c02. Reason for revert: Large csv files will not open in a reasonable amount of time. Change-Id: I7d3d3bf0341bcb83f86be88e8911879de13918ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120720 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-08-19Make the logic more logical.., tdf#102846 follow-upEike Rathke
Same functionality better readable. Change-Id: Idb891a6e2f0a35528d6a1862e5743a22772eec11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120754 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-19tdf#143526 add Korean Numbering test case & fix Hanja number codepointDaeHyun Sung
add Korean Numbering test cases 1. koreanCounting 2. koreanLegal 3. koreanDigital 4. koreanDigital2 fix Korean Hanja number codepoint for Zero(0) Following MS Office's numFmt Strng example https://docs.microsoft.com/en-us/openspecs/office_standards/ms-docx/a1bb5809-e361-4e49-8e16-7f1a67da4121 Korean Hanja notation for Hanja is `零 U+96F6` on MS Word 2019 and that document. So, fix the Korean Hanja number code pointfor Zero(0) `零 U+96F6` Change-Id: I1a5b95640a93e7fbc3a0e724b154587877b198a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120676 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-08-19Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to dd88f0407623a3c075727254abe5c93a88a5dedb - tdf#143930 update Security help page about new feature This is a follow-up to tdf#90401 that was fixed, so now the Security page needs to be updated to inform that the names and dates of comments and tracked changes are also removed. Change-Id: I6c677d197b6a770b1c36a5f40af94e40715e4a9c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120716 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-19ofz: add expat generate_hash_secret_salt to ignorelist for msanCaolán McNamara
use of the return value is flagged as use-of-uninitialized-value otherwise Change-Id: I574a1829ea4ff0343129c1d9b6dcc74168aa6909 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120752 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-19Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to 76b01db756aadf10c3bcde322355c05881f40652 - Fix typos Change-Id: I28e4e508bcedeb1da1d31f2636ed6fc66b932653 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120742 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2021-08-19Removed executables bits on docx fileAndrea Gelmini
Change-Id: I9e4de09bdf39c788bd015ac84b3add89ea80f3c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120743 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2021-08-19Fix typoAndrea Gelmini
Change-Id: I225688ee50b87c5019f83060ec8bbf614df6174f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120744 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2021-08-19tdf#143624 PPTX: slideshow setting “Manual forwarding” not exportedTibor Nagy
Follow-up to commit f8ddaaf0f5e1fb61e0d4404ea28757bc652ae4be (tdf#142915 PPTX import: support for presentation's timing attribute). Change-Id: I1b175d406d2cd0fc40ba7085517709fb477fed58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120529 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-19Resolves: tdf#102846 CSV: Detect separator, limit preview line concatenationsEike Rathke
In CSV import preview, if a line starts with a quote character and none of the remembered last field separators used occur in data in conjunction with a closing quote, then reading data tried to concatenate line by line to form a data field to be presented in the preview, worst case the entire file.. For the preview, detect one possible not yet selected separator if used with a quoted field (similar to commit c807e7ea7a0725a4d8375eda07d6f70870e0d50a for tdf#56910 space separator) and limit the number of source lines that are tried to be concatenated if no separator was encountered after a possibly closing field quote. Change-Id: Iefd37a8301161e72cb607cea88d4faadad47b4ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120690 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-19loplugin:sequenceloop (macOS)Stephan Bergmann
Change-Id: I5d004dfcce2ce1aad520f9e541432a60627161a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120739 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-19use sanitize-excludelist.txt for fuzzing CC as well as CXXCaolán McNamara
Change-Id: Ia470dbb9ab3ce86bedbadfd69ea145806530e4dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120741 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-19ScriptForge - (PDF Export) get/set options, export as PDF fileJean-Pierre Ledure
Next methods are introduced in SF_Session: - GetPDFExportOptions to extract a dictionary of the 40+ existing options for PDF export - SetPDFExportOptions to update the existing options When applied the options are permanent also for user manual exports Those methods are not available in Python. Next method to export a document to PDF: - ExportAsPDF: it uses the options set above and/or takes next specific and transitional options: pages, password, watermark This method is implemented for use from Basic and Python Change-Id: Ic5c4190cff579e62137930f422638aad98e61a16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120740 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-08-19Revert "Simplify Rect2Poly"Mike Kaganski
This reverts commit 5b025285b3528910a4360899abb2bbbaadc72c97. Reason for revert: the semantics change for empty rectangle is significant. See also 9343551f5588ffa4916e2c5d33cbd6fcf56ca99d. Change-Id: I5df0c07067840d39af0a187ca9a104963cdeefab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120651 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-19loplugin:constmethodsNoel Grandin
Change-Id: I786096b989daa6004a6527aafbe825b6f0a22d90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120710 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-19Fix typosAndrea Gelmini
Change-Id: I45243c6312545d51409574447e27f5320d4da79c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120493 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-19Avoid infinite loop in dbgutil buildsMike Kaganski
As mentioned in tdf#117162 comment 13, there are cases when SdrObject::Free does not modify maAllIncarnatedObjects. So the fix for tdf#143514 needs the change to account for that. Change-Id: I249c6a3b095c5d3c644dcb1bbc900b42793ea820 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120648 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-19ofz#37370 Null-dereferenceCaolán McNamara
since... commit 5b025285b3528910a4360899abb2bbbaadc72c97 Date: Wed Aug 18 07:35:05 2021 +0200 Simplify Rect2Poly where tools::Polygon from tools::Rectangle ctor has special handling for an 'empty' Rectangle Change-Id: Ifb93efeee4c2c1fe1f9fe5422e0e648ad91da77a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120702 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-19tdf#143939 sw: track format changes of the actual wordLászló Németh
If there is no text selection, character formattings are applied on the word under the text cursor, now with storing the original direct character formatting in a redline "extra data" for rejection of the tracked formatting change. Follow-up to commit ee3171adb24a3d720466fa43bec869910333f892 "tdf#143918 sw: fix reject of multiple changes" (clean-up the format tracking code into the new lcl_SetRedline(), and applying that for the not handled case, too). Change-Id: Ie6bc4dc17dbf84cc61970cef66689aec8ddc4595 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120707 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-19tdf#143722 DOCX import: map using default TOC heading styleGabor Kelemen
of Writer ("Contents Heading") instead of "TOC Heading". This essentially reverts the fix to bug #83300. When that was added the TOC import was broken enough that it made no visible regression. In 6.3 the TOC import was fixed up so now it's more annoying. The unit test of bug #83300 is reused but depends on the fix to bug #143726. I checked the example file of bug #83300 and the layout problem of comment 6 that was fixed there does not come back. Follow-up to commit 5440492ff9f949ee9ed9052e8bab6f5136d78b2a "tf143726 DOCX: export default TOC Header style with correct name". Change-Id: Iaee73729ea46a0c36d08ccc6fc5fb04fdf592a1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120092 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-19vcl: move ImplReleaseFonts() to outdev/font.cxxChris Sherlock
Change-Id: I4bd54c24f415e28014690fd775a3a5136d2be433 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115371 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-19vcl: add braces to SetBackground() function to make reading easierChris Sherlock
Change-Id: Icb91c4e8aae3f6f25515ca75a3cc230d9238dd4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115370 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-19vcl: move background functions to background.cxxChris Sherlock
Change-Id: Iee2e42f3881512d2e779d16505c50f76731e398a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115369 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-19drawinglayer: split polygonprimitive2d.hxx into multiple filesTomaž Vajngerl
The header polygonprimitive2d.hxx contains multiple primitives, which should be independent in their own header files. Split them in its own file, but for now keep polygonprimitive2d.hxx with includes all the new headers so that compilation goes through with no need to change any other files. Change-Id: I5c8ea2ed0c6d38374c1b871fef562b2164b9c8fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120708 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-19tdf143726 DOCX: export default TOC Header style with correct nameGabor Kelemen
This seems to have been a typo since it was mapped to the default name of the Table of Authorities index's heading in Word which is not really supported anyways. Change-Id: I4cadce18c30c5497f27479fcc251fdf85d859145 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120091 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-19use std::optional<OutlinerParaObject> in SwPostItMgrNoel Grandin
it is a COW object, no need to allocate separately on heap Change-Id: I9388d2a850a39a8645071dfb2907a4fe7785ac21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120703 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-19tdf#143567: Distinguish bitmap vs. pattern fill styleKatarina Behrens
By the time fill style state change (SID_ATTR_FILL_STYLE) happens, the actual bitmap fill may or may not be known. If it is not known, it is impossible to tell whether it is a regular bitmap or a pattern. That's why this toolbar sometimes incorrectly reports bitmap fill instead of pattern one To solve the problem, we adjust fill style listbox selection only later, by the time we know for sure the fill IS a pattern Change-Id: I0aa95c49601d77dca29ab54ad4c056a76a90e049 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120687 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org>
2021-08-19ridljar: check that UnoClassLoader is used for NativeLibraryLoaderMichael Stahl
The native libraries are local to class loaders, so System.load("java_uno.so") will fail with any other class loader. Change-Id: Ifa3b1b8dfef07b64828943654e28ff1f0fb5a494 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120527 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
generated by cgit (git 2.34.1) at 2025-03-12 15:49:17 +0000