summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-11-19tdf#128523: drop cache directory when restart manager initiates restartMike Kaganski
This would allow to re-create cached elements that could be broken. Restarts include those after a version upgrade (with bugfixes); using safe mode dialog (after crashes/problems); some configuration changes. An example of issue fixed by this is bad cached icons from versions affected by tdf#119020, that still make troubles to users after a year after the reason of generation of bad icons had been fixed [1, 2, 3]. [1] https://ask.libreoffice.org/en/question/211759 [2] https://ask.libreoffice.org/en/question/215263 [3] https://ask.libreoffice.org/en/question/217831 Change-Id: I2362547c25f8f265915efafa4e224435eda03e20 Reviewed-on: https://gerrit.libreoffice.org/83138 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-19Improved loplugin:external, handling class typesStephan Bergmann
...renaming type as TMList to avoid ambiguity between i18npool::TMlist and i18npool::(anonymous namespace)::TMlist Change-Id: I712fca9a9a7023e5a217c019195e3aa51e858f81 Reviewed-on: https://gerrit.libreoffice.org/83132 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-19Improved loplugin:external, handling class typesStephan Bergmann
...plus follow-up loplugin:fakebool and loplugin:consttobool findings Change-Id: I4b4045439fc9b19c42f6915b158540d2daf4cafb Reviewed-on: https://gerrit.libreoffice.org/83123 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-19Improved loplugin:external, handling class typesStephan Bergmann
...plus follow-up loplugin:fakebool and loplugin:consttobool findings Change-Id: I2b19d80f7313d3d5b0e502581b39fe20147bdfcc Reviewed-on: https://gerrit.libreoffice.org/83121 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-19Rename GlyphCache to FreetypeManagerJan-Marek Glogowski
And while at it remove the unneeded getPlatformGlyphCache abstraction. Change-Id: Id5cad751eda9e6bf177dfb4816280d7c5af7066a Reviewed-on: https://gerrit.libreoffice.org/83125 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-11-19tdf#128434 correctly release fonts in destructorsJan-Marek Glogowski
This adds ReleaseFonts() calls to all destructors of SalGraphics and TextRenderImpl derivated classes, which implement SetFont. During destruction a base class can't call into derivated classes, as these are already destructed, so we have to spread these calls manually. Change-Id: Ia57db04f7df665e5205212ce512119e2f60e3379 Reviewed-on: https://gerrit.libreoffice.org/82967 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-11-19tdf#128434 try garbage collect ImplFontCache fontsJan-Marek Glogowski
Instead of changing the harfbuzz caching, for this use case it's enough to queue all per-OutputDevice fonts for garbage collection (GC), which are managed by the OutputDevices ImplFontCache. So just try to GC all the fonts in the ImplFontCache destructor. There is no point keeping these LogicalFontInstances alive, after the OutputDevice font cache is destroyed, as these fonts aren't shared and can't be accessed later. But the main problem is still some correct accounting of harfbuzz resources and eventual even the Freetype ones, so this cleanup would not really be needed. AFAI can tell, this plugs the remaining per-document leaks of the PDF generation, except for a 72 byte basic listener leak from: basic::ImplRepository::impl_createManagerForModel(...) basicmanagerrepository.cxx:480 Change-Id: I3155be59a2bdcd85e01f6f048b990db04d88c94f Reviewed-on: https://gerrit.libreoffice.org/82968 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-11-19Move static aFontFileList into GlyphCacheJan-Marek Glogowski
GlyphCache is already a global in the unix SalData class, so we can drop one more global static variable. and the FontFile map values aren't shared, so just use std::unique_ptr, like the two other maps, which form the GlyphCache class. While at it finalize the classes and hide their constructors. Change-Id: Iaac8cd9905e9b4025707a17f62d8961ccfa5d0fb Reviewed-on: https://gerrit.libreoffice.org/82966 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-11-19Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add PDF Export Security Page screenshot Change-Id: Ic5ca4f1dbb1bab68914fd015808112b42cfe4951 Reviewed-on: https://gerrit.libreoffice.org/83144 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-19Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add PDF Export Digital signature Page screenshot Change-Id: I463c27689ddc53d8c66b88c835e189956d078652 Reviewed-on: https://gerrit.libreoffice.org/83143 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-19Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add PDF Export iUser Interface Page screenshot Change-Id: I3893d6fcb514057e41446f2a179b219405b8a072 Reviewed-on: https://gerrit.libreoffice.org/83142 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-19Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add PDF Export View Page screenshot Change-Id: I76b4036e5d205a952d369d398db211545621e537 Reviewed-on: https://gerrit.libreoffice.org/83141 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-19Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add PDF Export Links Page screenshot Change-Id: I996183a122518ec18d5ffb5d60b9d30c1f328c8e Reviewed-on: https://gerrit.libreoffice.org/83140 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-19Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Add PDF Export General Page screenshot Change-Id: I1f045faa224e8b24cc67a38989209217b15abdb1 Reviewed-on: https://gerrit.libreoffice.org/83139 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-19Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Update and refactor PDF export Help pages Added Help for several new options Adjust options visibility for each module Split page into smaller pages Adjust Contents tree Change-Id: I03fd0a4cb99f36da0ea7911a1afb5d4be6648244 Reviewed-on: https://gerrit.libreoffice.org/83131 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-19Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#128808 Clarify Basic libraries containers Change-Id: Iaa85a3b0340eb88c8b81ee8070039c1e518789f6 Reviewed-on: https://gerrit.libreoffice.org/83092 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-19Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#128227 disambiguate text frame and text box in summary, on Writer, Text frame -> Frame On other modules Text Frame -> text box Change-Id: I3b218fafb03cd5ab79c8c0b902ec417bf5445ff8 Reviewed-on: https://gerrit.libreoffice.org/82976 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-18Resolves: tdf#108452 invisible all-black drawing cursors on black bgCaolán McNamara
commit c5ac80d90ebcc1c3fad18ece8784ac2b36f52045 Date: Fri Feb 8 10:00:12 2019 +0200 make cursor images part of the theme + commit 25d176ada67ada550bd4d0d08177c232cf7eeb37 Date: Mon Mar 4 15:58:18 2019 +0200 tdf#123796 Wrong cursor when inserting shape effectively resulted in the gtk version using the same curros as the mac version. Some of these icons are all black and invisible on a black background, which affects both gtk and osx. Taking a copy of LibreOffice 6-1 where the classic xbms were in use, dump all the xbm cursors and masks as loaded via cairo to png and where the mac cursors were all black take the xbm derived versions instead (if they were of the right size) Change-Id: I8a7a150caff415fa25180c1f2ed4cb8487fcd70c Reviewed-on: https://gerrit.libreoffice.org/83112 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18rhbz#1773525 wrong elements removed from saved entries when limit hitCaolán McNamara
Change-Id: Iaf8a012ffe927cbf38789e97b469d899e7cbf87b Reviewed-on: https://gerrit.libreoffice.org/83094 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18add uitest for bug tdf#126626Zdeněk Crhonek
Change-Id: Ic2ffd8f0418e208d7e17ac419a0ac7d98ffad30c Reviewed-on: https://gerrit.libreoffice.org/83118 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-11-18Extend DOCX input field export test for round-tripJan-Marek Glogowski
This expands the test from tdf#125103 to include more use cases and validate the import of the exported document (tdf#128460). Change-Id: Ifb8615b6b90931996becb8cb44d846eb30956971 Reviewed-on: https://gerrit.libreoffice.org/83038 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-11-18editeng: add doc model for semi-transparent textMiklos Vajna
tools Color can handle the alpha just fine, but add a separate member ID for transparency to be consistent with the existing border and fill color API. Change-Id: I8466da9fb40ab1d0c97b06a0594f89719ccc1959 Reviewed-on: https://gerrit.libreoffice.org/83116 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-18crashtesting fdo78617-2.odsNoel Grandin
as a consequence of commit feec8e3c34e08b621098a17f1011dccd0b4f7f4c Date: Tue Nov 12 16:00:55 2019 +0200 reduce iteration in ScViewData::GetScrPos Change-Id: Iec539c33bd80b9ad2d2a3698d443c5cec81f8f85 Reviewed-on: https://gerrit.libreoffice.org/83093 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-18use FasterParser for SvxReadXMLNoel Grandin
the SvXMLImport superclass of XMLVersionListImport already constructs a parser, so we can just use that one Change-Id: I09d946a9d0e978582fbecc67c74cd1ae5c97178e Reviewed-on: https://gerrit.libreoffice.org/83076 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-18rhbz#1773525 reducing the amount of saved search/replace entries didn't workCaolán McNamara
Change-Id: I1512ef507130718859271079e603a95cf2105c58 Reviewed-on: https://gerrit.libreoffice.org/83088 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18sw: insert image: set anchor to at-char by defaultMiklos Vajna
This changes the default set in commit 4f40bf6a79de6d60da0a5090cdfeda6242e889f0 (sw: insert image: set anchor to as-char by default, 2019-07-04), to have a better compromise, taking both Word defaults compatibility and usability into account. The problem is that users are used to just inserting an image and being able to drag it to its final location, which is broken with as-char anchoring. So default to at-char anchoring, this is still something that is fully interoperable to Word (unlike the old to-para anchoring), but allows the easier image move again. Change-Id: Ibc61ae167fc9e5cc31b04c83e854556309e27fd4 Reviewed-on: https://gerrit.libreoffice.org/83089 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-18tdf#128739 sw: don't delete bookmarks prematurely in SwUndoDeleteMichael Stahl
::RedoImpl() and SwUndoInserts::UndoImpl(). The bookmarks will be deleted again by DelContentIndex(), which also adds them to m_pHistory, but RemoveIdxFromRange() deletes them without adding them to m_pHistory so they won't be restored. There is some funny commit c50f2e0a69204b8760c2e06313a18b6194f2d109 which is a mystery: if the rPam has to be saved across the RemoveIdxFromRange() call, then either the rPam that's passed to RemoveIdxFromRange() is wrong, or the rPam that is restored after the call is wrong... just revert it and set the same values to rPam. Change-Id: I9e93ef75bcd2931594aeae07e761c48752d31d9b Reviewed-on: https://gerrit.libreoffice.org/83084 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-18tdf#128739 sw: delete fieldmarks if exactly selected ...Michael Stahl
... in SwUndoSaveContent::DelContentIndex(). The problem is that the fieldmark survives but its dummy characters are all deleted; this will eventually lead to unhappiness in Undo. Another issue is that SwHistoryBookmark doesn't know about dummy characters, so use the SwHistory*Fieldmark instead. This still doesn't work completely because SwUndoDelete::RedoImpl() is quite borked. (regression from 4dc1615c80e8e66d339dc86fa95bbc76e884d988..d9030ad6298e2f49ee63489d6158ea6ad23c0111) Change-Id: Ia98d143fa46e79348fde200be5462cc461455b58 Reviewed-on: https://gerrit.libreoffice.org/82815 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-18Missing includesStephan Bergmann
...with recent Clang trunk Change-Id: I9ea0f1692df8d269356df0d6b20ea2173f632425 Reviewed-on: https://gerrit.libreoffice.org/83086 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-18cid#1401321 Uncaught exceptionCaolán McNamara
Change-Id: I94603d614abf73881555c069f51c9c1adb5613b0 Reviewed-on: https://gerrit.libreoffice.org/83075 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18tdf#127777 fix "CrossBetween" for not imported combined chartBalazs Varga
Set the ShiftedCategoryPosition for true in case of combined chart. See also commit 111c260ab2883b7906f1a66e222dbf4dc3c58c4f 'tdf#127777 OOXML chart export: fix "CrossBetween" for not imported charts Change-Id: I52fdcdc52e75ac15c85e04c2982b25cc180d7815 Reviewed-on: https://gerrit.libreoffice.org/82617 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-11-18cid#1399260 Uncaught exceptionCaolán McNamara
Change-Id: I975716ae1f7406af57cc4141f4cbdb9e5e4c4bd2 Reviewed-on: https://gerrit.libreoffice.org/83074 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18cid#1421150 Useless callCaolán McNamara
add annotation Change-Id: I6f5eabf945f81cfb54ca3afb51231600ac30d9d2 Reviewed-on: https://gerrit.libreoffice.org/83065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18cid#1448537 silence Wrapper object use after freeCaolán McNamara
Change-Id: I896556485c441c9d0e79e75f41d0eb452f0eb21f Reviewed-on: https://gerrit.libreoffice.org/83069 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18tdf#103092 export uses MeasureUnit not FieldUnitRegina Henschel
ctor of SvXMLExport expects a util::MeasureUnit, but getMetric() from XGlobalSheetSettings returns a FieldUnit. The conversion was missing. So FieldUnit::MM (=1) was treated as MeasureUnit::MM_10TH (=1). But that one has no unit string, so the 'translate' transformation got numbers without unit, which then were wrongly interpreted. Change-Id: I433c7534be21655887863005f14836d2b733cf1f Reviewed-on: https://gerrit.libreoffice.org/83004 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-11-18compilerplugins: fix ambiguous type warningsChris Sherlock
Errors were: /home/chris/repos/libreoffice-latest/compilerplugins/clang/sharedvisitor/analyzer.cxx:80:40: error: reference to 'PointerType' is ambiguous if (auto const t = type->getAs<PointerType>()) /home/chris/repos/libreoffice-latest/compilerplugins/clang/external.cxx:61:44: error: reference to 'PointerType' is ambiguous else if (auto const t3 = t1->getAs<PointerType>()) Change-Id: Ia5b7add8f2b3160fa3198ed127785bdd61c74796 Reviewed-on: https://gerrit.libreoffice.org/83030 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-18Fix 'is' operator for comparisonJens Carl
The 'is' operator should not be used for comparison on some types of literals. In CPython this works by accident and CPython 3.8 introduced a SyntaxWarning (see https://bugs.python.org/issue34850). Change-Id: Ic4ba481579d13fd1496431ded59dd626a05fc0c6 Reviewed-on: https://gerrit.libreoffice.org/83033 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-18cid#1249470 Uninitialized scalar fieldCaolán McNamara
use comment as an annotation Change-Id: Ia8b5ba157d0d240c4a3e6beed74d66e6d34d1a32 Reviewed-on: https://gerrit.libreoffice.org/83067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18cid#1421107 Useless callCaolán McNamara
add annotation Change-Id: I97e9282cb8568378de01764802b0a6d30e71f259 Reviewed-on: https://gerrit.libreoffice.org/83064 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18sw: prefix members of SwCallLinkMiklos Vajna
See tdf#94879 for motivation. Change-Id: Ia0b6909ff037c4126e0cba1e63a672d166f6784f Reviewed-on: https://gerrit.libreoffice.org/83059 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-18cid#1421106 Useless callCaolán McNamara
add annotation Change-Id: I9e0f67fc14bc15a011faeb75264f64930a0c3065 Reviewed-on: https://gerrit.libreoffice.org/83063 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18cid#1421069 Useless callCaolán McNamara
add annotation Change-Id: Iaeebd22ccefe4a11b3ae65e3f6dc54f8fdb7e075 Reviewed-on: https://gerrit.libreoffice.org/83062 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18convert AccessibilityFlowTo to scoped enumNoel Grandin
and drop the unused FORSPELLCHECKFLOWTO Change-Id: I128e84d386c10d001aa63f93b4b6dcb7238a1242 Reviewed-on: https://gerrit.libreoffice.org/83060 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-18use FasterParser for SvxXMLXTableImport::loadNoel Grandin
the SvXMLImport superclass of XMLVersionListImport already constructs a parser, so we can just use that one Change-Id: I28402467f63e166a2c5ffc3bf0c851de81ba2108 Reviewed-on: https://gerrit.libreoffice.org/83061 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-18Fix 'is' operator for comparisonJens Carl
The 'is' operator should not be used for comparison on some types of literals. In CPython this works by accident and CPython 3.8 introduced a SyntaxWarning (see https://bugs.python.org/issue34850). Change-Id: Ifabe22e4ae3b9e1d3bfd5a663f39500e381cfa6e Reviewed-on: https://gerrit.libreoffice.org/83034 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-11-18cid#1430070 Copy-paste errorCaolán McNamara
add annotation Change-Id: I6973335b8877b48d5cf0a08f4e291585de352446 Reviewed-on: https://gerrit.libreoffice.org/83035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18cid#1430063 Copy-paste errorCaolán McNamara
add annotation Change-Id: I162b4f388baff243425d34a13c1104dfdaf92588 Reviewed-on: https://gerrit.libreoffice.org/83036 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18cid#1448469 Out-of-bounds accessCaolán McNamara
add an annotation Change-Id: I70a431fecd8a87f2167bdce53ec2397d22436a9d Reviewed-on: https://gerrit.libreoffice.org/83025 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18cid#1430094 Arguments in wrong orderCaolán McNamara
add an annotation here Change-Id: If28f6494e80df0ea38036196ed152e9dee29339f Reviewed-on: https://gerrit.libreoffice.org/83027 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18loplugin:singlevalfieldsNoel Grandin
Change-Id: I0bb32ad7351f0e4cfbdc872ed0e81b8157ecc4cb Reviewed-on: https://gerrit.libreoffice.org/83056 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-21 02:44:50 +0000