summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-05use std::unordered_map in localeNoel Grandin
instead of hand-coded hash table Change-Id: I1c52f98b5a72609f7cd8086227017a486d97520e Reviewed-on: https://gerrit.libreoffice.org/60706 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-05soltools: fix -Werror=format-overflowMichael Stahl
error: ‘sprintf’ may write a terminating nul past the end of the destination (Why does GCC8 complain about this now and not before?) Change-Id: I62cd9dec02d313b5aff1afc4cadf38ca1909ffb1 Reviewed-on: https://gerrit.libreoffice.org/61381 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-04Reformat this eye-cancer causing messEike Rathke
A mix of clang-format and manual. Change-Id: Ice3d96d1400329fc7386e2d4544c69641658600f
2018-10-04Resolves: tdf#106340 resize dialog when search/replace labels are shown/hiddenCaolán McNamara
Change-Id: I1e20807f613a73c7dbefcb8e331f99d484eb5c04 Reviewed-on: https://gerrit.libreoffice.org/61384 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04Record external/liborcus/version.patch.0 as covered upstreamStephan Bergmann
Change-Id: I006a16cfc83e5b03408a2e772e752bb210901686 Reviewed-on: https://gerrit.libreoffice.org/61380 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-04Add external/liborcus/README, containing link to upstream projectStephan Bergmann
Change-Id: Iea609a8e90d8b2bf8bcac2b537699b08073f25ae Reviewed-on: https://gerrit.libreoffice.org/61379 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-04Missing CppunitTest dependencies on new macOS/Windows vclplug backendsStephan Bergmann
...after 1698debed2993fc5f262aa3ebbdb32fc112ac556 "Implement Windows VCL backend as plugin" and 3af4e1a0825c5b11ae4ef58fc411378aab669387 "Implement MacOSX VCL backend as plugin". (On these platforms, the tests apparently call into the respective vclplug backend code regardless of whether the test is "headless" or not.) Change-Id: I6d93eacd9f94047add94ba3e866e6be1eb35c879 Reviewed-on: https://gerrit.libreoffice.org/61376 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-04-Werror,-Wdeprecated-declarations (--with-macosx-version-min-required=10.14)Stephan Bergmann
These are all the cases where the warning doesn't suggest a direct replacement, so the existing code is just wrapped in SAL_WNODEPRECATED_PUSH/POP for now. A companion commit will cover cases where there is a direct replacement that can probably be applied (even backwards-compatibly with our current baseline, hopefully). Change-Id: I899537cb36dd69e08b5442ad4af7ce69ce2ddaec Reviewed-on: https://gerrit.libreoffice.org/61354 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-04Do not let end row creep above start row, tdf#69977 tdf#119305 follow-upEike Rathke
commit 3acc5a2383f5b0458e3caf1505fe6b8ad7dc3fb0 CommitDate: Tue Mar 27 13:26:30 2018 +0200 tdf#69977 improve creation of large charts changed the loop such that it removed the stop condition for rStartRow < rEndRow, and commit aaa3c31ba79b1b3d335dcf55d72837a13411b45e CommitDate: Tue Sep 11 20:29:04 2018 +0200 tdf#119305 Chart created from fully selected sheet only targets header row still checks only for a minimum of the original end row and the last data row, which for an empty (no data) range selected may be above the start row. Change-Id: I9de08d09be62e86e7c946df701c49314fa4d682e Reviewed-on: https://gerrit.libreoffice.org/61389 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-04tdf#120301 oox: lclIsWhiteSpace should return true for a spaceJustin Luth
Change-Id: I72c79c1fed4d9a91bf02024eef23cd3b1a58632e Reviewed-on: https://gerrit.libreoffice.org/61388 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-04sw: switch XAutoTextContainer to use user-dir filesThorsten Behrens
This amends 4967d498c486800b72ba34192c82c232bc0685bd to put .bau files into user dir instead of shared config Change-Id: Ic58b2cb10a62e90deebec9cd8d7dce5ef6218b43 Reviewed-on: https://gerrit.libreoffice.org/61387 Tested-by: Jenkins Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de>
2018-10-04tdf#120291 Attaching a connector makes draw Draw busy-loopNoel Grandin
regression from commit ffe84f49270e0a8818365ca7d1fd5242abff5562 remove SdrObject::GetHdl in favour of AddToHdlList Change-Id: Idb15b976f6e1fcb6ffeda933ffbec96d59e6f155 Reviewed-on: https://gerrit.libreoffice.org/61370 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04Resolves: tdf#120238 remove wrong assert()Eike Rathke
There may be a non-empty RowMap even if nColCount == 0 || nRowCount == 0 if there was only one column or row (or cell) selected and bRowHeaders and/or bColHeaders were set, thus nColCount and/or nRowCount were decremented by 1. Regression from commit b1f9aa5f58ea322097998839e00d95fc40be8b22 CommitDate: Fri Sep 28 09:04:07 2018 +0200 loplugin:useuniqueptr in ScChartPositionMap Change-Id: I942e3fcc92449da57d708f654000387f862a4066
2018-10-04gla11y: better print paired element for visibility conflictSamuel Thibault
Change-Id: I1f3bcaf732d01c5def7b84ecbd14e0cbe3397927 Reviewed-on: https://gerrit.libreoffice.org/61300 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-04sal_False -> false in commentLionel Elie Mamane
Change-Id: I3344af4ce28bd2b94725ea9336ce1b1ab9c98554
2018-10-04weld SwCreateAddressListDialogCaolán McNamara
Change-Id: I9b8fa8ff001f82904db2478a6c88419294df2855 Reviewed-on: https://gerrit.libreoffice.org/61364 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04loplugin:redundantcastStephan Bergmann
"static_cast from 'CGContextRef' (aka 'CGContext *') prvalue to 'CGContextRef' (aka 'CGContext *') prvalue is redundant" with --with-macosx-version-min-required=10.14 at least. (Not exactly sure why this warning only starts to appear now. Presumably something changed in the system headers. Lets see whether older baseline builds are happy with the dropped casts, too.) Change-Id: Id52d1891e5e33f7c37d095440339980b4000ca4e Reviewed-on: https://gerrit.libreoffice.org/61353 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-04weld SwFindEntryDialogCaolán McNamara
Change-Id: Ia45e4ce13b92fd73fcc8ad52233aa5eccc3cfb6d Reviewed-on: https://gerrit.libreoffice.org/61365 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04weld SwAddRenameEntryDialogCaolán McNamara
Change-Id: I687486a392450fcf3b92fdc4d7a193b10f829835 Reviewed-on: https://gerrit.libreoffice.org/61363 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04weld SchLegendDlgCaolán McNamara
Change-Id: Ie57d195782d9fbfdf555205e53e733529b4c1ae8 Reviewed-on: https://gerrit.libreoffice.org/61360 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04drop SvMemoryStream::GetBufferNoel Grandin
since it does the same thing as GetData() Change-Id: I18d35aa4e67ad7775987160c021863d0de90179b Reviewed-on: https://gerrit.libreoffice.org/61350 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04Select the current format if multiple instead of first matching format codeEike Rathke
This never worked.. Change-Id: I79b8687dde4faac383121abeda70931d0192b33d Reviewed-on: https://gerrit.libreoffice.org/61290 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-04external/gpgmepp: Clash between VERSION and trunk libc++ <version>Stephan Bergmann
...on macOS with case-insensitive file systems. When compiling e.g. workdir/UnpackedTarball/gpgmepp/lang/cpp/src/parser/exception.cpp, libtool adds -I../../.. (presumably to find files like workdir/UnpackedTarball/gpgmepp/config.h), and including e.g. <string> internally includes <version> now, and workdir/UnpackedTarball/gpgmepp/VERSION happens to win. So just remove VERSION from the sources, which appears to not be needed at least in our build of gpgmepp. (An alternative approach might have been to use -iquote../../.. instead of -I../../.., but that's probably hard to shoehorn into the libtool-generated compiler invocation.) Change-Id: Ib1a30a6b825cab208238d17ff384e7900a27047d Reviewed-on: https://gerrit.libreoffice.org/61359 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-04external/liborcus: Clash between VERSION and trunk libc++ <version>Stephan Bergmann
...on macOS with case-insensitive file systems. When compiling e.g. workdir/UnpackedTarball/liborcus/src/parser/base64.cpp, libtool adds -I../.. (presumably to find files like workdir/UnpackedTarball/liborcus/config.h), and including e.g. <vector> internally includes <version> now, and workdir/UnpackedTarball/liborcus/VERSION (generated from VERSION.in) happens to win. So disable generation of VERSION from VERSION.in (Kohei confirmed in private communication that that file isn't actually used for anything, so not generating it is fine). (An alternative approach might have been to use -iquote../.. instead of -I../.., but that's probably hard to shoehorn into the libtool-generated compiler invocation.) Change-Id: Id9a6778368796dc2494df3499b5e1ca560df1e56 Reviewed-on: https://gerrit.libreoffice.org/61358 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Jenkins
2018-10-04Avoid -Werror=stringop-truncationStephan Bergmann
... "‘strncpy’ output truncated before terminating nul copying as many bytes from a string as its length", as reported at <https://lists.freedesktop.org/archives/libreoffice/2018-October/081109.html> "LO build fails -Werror=stringop-truncation in _lex.c". Not adding the terminating NUL appears to be intentional here, as the s->inp buffer is terminated (through s->inl) with EOB bytes after the if/else blocks. Change-Id: I5a8559e620b7e34ee27cbcd0f836432deb8cba90 Reviewed-on: https://gerrit.libreoffice.org/61355 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-04weld SteppedPropertiesDialogCaolán McNamara
Change-Id: I6e5a5a76f4e7d0d8b71e7d2e3dee9f7c2815f5d5 Reviewed-on: https://gerrit.libreoffice.org/61357 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04weld SchTitleDlgCaolán McNamara
Change-Id: Ie4537b9b6d856178ae378473fda4a1b27a1ed0b5 Reviewed-on: https://gerrit.libreoffice.org/61356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04tdf#120287 sw layout, TabOverMargin: imply PrinterIndependentLayout=high-resMiklos Vajna
In case an ODT document has the usual layout compat flags enabled (by the DOC/DOCX/RTF imports) to emulate Word behavior, then it's expected that Word will lay out the resulting ODT document similar to Writer. This works most of the time, but in case exact spacing matters, it's important that PrinterIndependentLayout is not disabled, as that doesn't match the Word default and will result in mismatching Writer vs Word layout. Change-Id: I0fbe110a6417ffa5d919fb81236a60bfa1fc30f5 Reviewed-on: https://gerrit.libreoffice.org/61352 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-04pass AbstractGeometryAttributes around by std::unique_ptrNoel Grandin
Change-Id: I6e06c89b5e4b77c8fc5e3e1a6bf7d76d8ebd7810 Reviewed-on: https://gerrit.libreoffice.org/61349 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04loplugin:useuniqueptr in SwInsDBColumnsNoel Grandin
Change-Id: Idd159cfd29d487773e478a0cca352fcb77f88a33 Reviewed-on: https://gerrit.libreoffice.org/61340 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04loplugin:useuniqueptr in SwWriteTableColsNoel Grandin
Change-Id: Ib4c95401c3e9e60c1c909080b3381d652c862e62 Reviewed-on: https://gerrit.libreoffice.org/61342 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04loplugin:useuniqueptr in SetGetExpFieldsNoel Grandin
and a couple more utility methods to o3tl::sorted_vector to make this easier Change-Id: Iebbbb8899b67fffa1ac98ae46b7fa70a7e35f866 Reviewed-on: https://gerrit.libreoffice.org/61344 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04loplugin:useuniqueptr in HTMLControlsNoel Grandin
Change-Id: I7301fdb1dba6f05b43b114cfb72641958322964d Reviewed-on: https://gerrit.libreoffice.org/61343 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04loplugin:useuniqueptr in SwSeqFieldListNoel Grandin
no need to store such a small structure separately on the heap Change-Id: I36b3ad5250718b7bdf526f5f67219740c69a549a Reviewed-on: https://gerrit.libreoffice.org/61298 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04loplugin:useuniqueptr in SwBlockNamesNoel Grandin
Change-Id: Ib7b0b206439b9b14cbfdf58bc8932281329e7deb Reviewed-on: https://gerrit.libreoffice.org/61346 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04loplugin:override (--enable-qt5)Stephan Bergmann
Change-Id: Id9e3127a7ac53dc9e50caa4d4c4c4d7c6e7008fb
2018-10-04loplugin:subtlezeroinit (--enable-qt5)Stephan Bergmann
Change-Id: I1a6f0a2b0de82fd0e8c30818c2ddf6e0a2d3f1b0
2018-10-04loplugin:nullptr (--enable-qt5)Stephan Bergmann
Change-Id: I85e310a4e2cf8e9f726d8d7c6ac8bbb399f0cd7c
2018-10-04loplugin:useuniqueptr in SwXMLTableColumns_ImplNoel Grandin
Change-Id: Iee894bccfc162bd97093def7eb86d54be9fde13d Reviewed-on: https://gerrit.libreoffice.org/61341 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-04Implement qt5 plain text copy to clipboardKatarina Behrens
Change-Id: I5804467c97758641718a6d6314cae015a0442d1b Reviewed-on: https://gerrit.libreoffice.org/61233 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-04Implement qt5 plain text paste from system clipboardKatarina Behrens
Change-Id: I44053d445098efc619ad9255d8f21962531a0654 Reviewed-on: https://gerrit.libreoffice.org/60674 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-04Clipboard support for qt5, first cutKatarina Behrens
this adds just enough of basic UNO ifaces to have SID_PASTE enabled. It can't actually paste anything yet. Change-Id: I82e8ef37e11e9df21d27f08d4d199f3e5924ed84 Reviewed-on: https://gerrit.libreoffice.org/60494 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-04Resolves: tdf#120175 normalize theme names to our naming schemeCaolán McNamara
So breeze-dark turns into breeze_dark Change-Id: Id5d06f73a79f099048b31fd16f9f9611236af392 Reviewed-on: https://gerrit.libreoffice.org/61321 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04color moved to slot 4Caolán McNamara
Change-Id: I965d4b042cf1510d5286c85043792a140116497f Reviewed-on: https://gerrit.libreoffice.org/61331 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04weld SbaSbAttrDlgCaolán McNamara
Change-Id: Ic1478d92fcf829bebdf8ada1051a4373d47077cf Reviewed-on: https://gerrit.libreoffice.org/61330 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04weld DlgSizeCaolán McNamara
Change-Id: I5e27d2a27810af98bd0cf59f9e9cbe1cf75d7f1b Reviewed-on: https://gerrit.libreoffice.org/61329 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04replace sclo-ScExtIButton with MenuButtonCaolán McNamara
Change-Id: I1f03bebe465e76f7e62f707937b9289e17b76605 Reviewed-on: https://gerrit.libreoffice.org/61328 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-04xmlsecurity nss: avoid deleting the dsig context manuallyMiklos Vajna
Change-Id: I0198c1b0d6ba6c27072376943895718d536a284c Reviewed-on: https://gerrit.libreoffice.org/61323 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-04elementary: sync folder color with upstream, add more 32px, etcRizal Muttaqin
Change-Id: I28f0e7b964a229320ede7accfd3a98e35ef113b3 Reviewed-on: https://gerrit.libreoffice.org/61180 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-04Fix crash when no key bindings are availableSamuel Mehrbrodt
Change-Id: I89693a01bd3e89f6d4000901c01accf88b453691 Reviewed-on: https://gerrit.libreoffice.org/61232 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
generated by cgit (git 2.34.1) at 2025-02-23 08:16:03 +0000