summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-03-13Resolves: tdf#124023 target links.txt not updatedCaolán McNamara
when source links.txt changes Change-Id: I90e9b64fdd01ff725149cc6d07d3ea6c28b50156 Reviewed-on: https://gerrit.libreoffice.org/69202 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-13add renderer for lock iconCaolán McNamara
Change-Id: I88e2a7ee44523482cf36099281c0f632fae7eac0 Reviewed-on: https://gerrit.libreoffice.org/69177 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-13tdf#123406 KDE5: Update delayed frame destructionAleksei Nikiforov
Move deleteLater() call to the different event loop. This fixes issue with frames not being disposed of deterministically, and previously opened window not reactivating. Also hide modal dialog window before unsetting modal mode. Unsetting modal mode may require to toggle window visibility. Window will be hidden soon anyway, and additional generated events might make finding correct focused window harder. Change-Id: Id7839f817075785287b09f6ac79eb3fb211726aa Reviewed-on: https://gerrit.libreoffice.org/68852 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-03-13connectivity Writer driver: use auto when initializing with new to avoid ...Miklos Vajna
... duplicating the type name Change-Id: I12b2302c4316b3ec1f22df366100c3b2a4d87454 Reviewed-on: https://gerrit.libreoffice.org/69173 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-13tdf#123293 Add testSamuel Mehrbrodt
Test for commit 0a5ca5768f56db481dd3b947b3dddaab7ed96450 Change-Id: I53b72c385d9ef4d51cefa687f07a75c9520d3e71 Reviewed-on: https://gerrit.libreoffice.org/69165 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-13tdf#124057: Do call RegisterControls() on non-DESKTOPTor Lillqvist
Otherwise the Tools > Word Count dialog doesn't show up in the iOS app. Change-Id: Ic425749cc8f3245d7a16d7784d77b02f6d47253f
2019-03-13Sifr icon theme updateandreas kainz
Change-Id: Id663ba63b361ebf5f853bdf8e9a38a6dc4ab0e36 Reviewed-on: https://gerrit.libreoffice.org/69157 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-13tdf#40966: convert last used BMPs to PNG; cleanup unusedMike Kaganski
Change-Id: Id92fcd2fd33500cc9c60645c627c2fedf2378fb9 Reviewed-on: https://gerrit.libreoffice.org/69158 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-13tdf#112411 Merge "Form controls" and "More controls" into one toolbarRoman Kuznetsov
Change-Id: I7efb107f53a12185f1bd438983e6f446ee8b6a1b Reviewed-on: https://gerrit.libreoffice.org/69079 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-03-13tdf#107593 Show the cursor after header/footer deleteJim Raykowski
Change-Id: I978f088fa700791d48a5a65392f980822ac14bd2 Reviewed-on: https://gerrit.libreoffice.org/69032 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-03-13tdf#79717 save/restore character format on selection overwritePhil Krylov
Change-Id: Ic82c50d07cf4a2208a6e2956c8b9ebc4f8630b31 Reviewed-on: https://gerrit.libreoffice.org/67597 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-13warn if sharedvisitor generator cannot find code in a source fileLuboš Luňák
Just in case there's a typo or something, without this that source would not be compiled but shared visitor would not include that functionality either. Change-Id: I5d9fad129b83f24fed2613bc071cb33e149c1db3 Reviewed-on: https://gerrit.libreoffice.org/69093 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-03-13state explicitly how ownership of ScFormulaCell::pCode worksLuboš Luňák
Change-Id: I7c2938cd731ed85dd0f96ac41d0f0a1468ee858c Reviewed-on: https://gerrit.libreoffice.org/69089 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-03-13const correctnessLuboš Luňák
Change-Id: Ifcc5cfb8d66ae77bdf54b1a5457590c92a3fe093 Reviewed-on: https://gerrit.libreoffice.org/69088 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-13weld DatabaseRegistrationDialogCaolán McNamara
Change-Id: I739785daef892ac16d2a41a98268f18670daeedb Reviewed-on: https://gerrit.libreoffice.org/69136 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-13weld DbRegistrationOptionsPageCaolán McNamara
Change-Id: I88c1129f50d9f9cbef9970f1a9453641fc87e8fd Reviewed-on: https://gerrit.libreoffice.org/69135 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-13external: update pdfium to 3730Miklos Vajna
Change-Id: Iaaac797812b2addd1e5693dbb4338fc1c506a26d Reviewed-on: https://gerrit.libreoffice.org/69134 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-13tdf#124042: There are no progress bars that vcl would handle on iOS or AndroidTor Lillqvist
Don't even bother trying to dislay such. Any progress feedback to the user will be handled through LibreOfficeKit callbacks. (Sure, the code probably thought it had created a "window" for the progress bar, but there wasn't anything real in the data structure that would actually display anything anywhere, no CG context (on iOS) etc.) Change-Id: Ie0ca18bbb22da41882bdaba4a0ce77a52112a059
2019-03-13tdf#123588 Beanshell editor to indicate whether script is savedSainal Shah
Beanshell to enable save button only upon modification of script. Save button disables after script is successfully saved. Also, save button will be disabled when there are no undoable changes. ScriptEditorForBeanShell registers listener for unsaved changes. PlainSourceView triggers listener calls upon modification of script or after a successful save, which lets to enable/ disable the save button accordingly. Change-Id: I32a2fc473924a7c85cdd6004637ab6a0b60acf38 Reviewed-on: https://gerrit.libreoffice.org/69046 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-13tdf#121092: synchronize defaults for drivers settingsMike Kaganski
See commit f33eb08a2b74e5de033af9b5f5283b220ac58ded for details TODO: reimplement defaults to be taken from the Drivers.xcu, not from ODatabaseModelImpl::getDefaultDataSourceSettings. TODO: always write settings, even if they are equal to defaults (unless they are schema defaults) - that will allow to change a default, and not break existing configurations. Change-Id: Ic0fa9a03bf801aeca3e6373eb7019f5ad7e8eb46 Reviewed-on: https://gerrit.libreoffice.org/69076 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-13tdf#124035 LibreLogo: support starting colon in variable namesLászló Németh
Regression from the commit 740b99783b5480fcd1e5fce7c1beb5967d015041 "tdf#120413 LibreLogo: handle complex Logo expressions". Change-Id: Iaae54efacf86a03a6611c154a40068ed058d43e7 Reviewed-on: https://gerrit.libreoffice.org/69138 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-03-13Revert "tdf#41202 allow decrease selection with shift-click in writer"Xisco Faulí
Reverted as suggested in https://bugs.documentfoundation.org/show_bug.cgi?id=123582#c4 This reverts commit 31ba2a6bdecb81545d9b871a1a9394e5d7a3f2c4. Change-Id: I574bacd227bdd6b0364251b060327a3e5f820965 Reviewed-on: https://gerrit.libreoffice.org/69132 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-13ActiveX: Use correct mimetypesSamuel Mehrbrodt
As registered at IANA: https://www.iana.org/assignments/media-types/media-types.xhtml Change-Id: I6d66f2cd1f96e487562a1042583e08a5beefc262 Reviewed-on: https://gerrit.libreoffice.org/69125 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-13translate some german var namesNoel Grandin
Anz -> Count Change-Id: I26f85cee2dff12377dbf0b21f8ad7b98d15b95c3 Reviewed-on: https://gerrit.libreoffice.org/69103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-13NB grouped writer: update styles commands to show icons in dropdownandreas kainz
Change-Id: Iaa16fd2c04f5168bcb58d71d48f563ae1856a901 Reviewed-on: https://gerrit.libreoffice.org/69145 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-13Sifr icon theme updateandreas kainz
Change-Id: I2ee16355545c059ad5e58c0097d8097df3eea426 Reviewed-on: https://gerrit.libreoffice.org/69139 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-13Removed duplicated includeAndrea Gelmini
Change-Id: Iea9ca5fed98f1040dd697324f9818d0014f5f79f Reviewed-on: https://gerrit.libreoffice.org/69149 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-13Fix wizards/NumberFormatter.javaJulien Nabet
Create a brand new odb file (embedded HSQLDB) Create a simple table in it Launch Query wizard, you'll see these on console: ... at com.sun.proxy.$Proxy69.addNew(Unknown Source) at com.sun.star.wizards.common.NumberFormatter.defineNumberFormat(NumberFormatter.java:96) at com.sun.star.wizards.ui.FilterComponent.addNumberFormats(FilterComponent.java:504) at com.sun.star.wizards.query.QueryWizard.buildSteps(QueryWizard.java:233) ... ... at com.sun.proxy.$Proxy69.addNew(Unknown Source) at com.sun.star.wizards.common.NumberFormatter.defineNumberFormat(NumberFormatter.java:96) at com.sun.star.wizards.ui.FilterComponent.addNumberFormats(FilterComponent.java:506) at com.sun.star.wizards.query.QueryWizard.buildSteps(QueryWizard.java:233) ... Root cause is FilterComponent.java uses "YYYY-MM-DD" and "YYYY-MM-DD HH:MM:SS" (lines 504 and 506) If it's ok for English locales, xNumberFormats.queryKey calls fail at least for French locales. Use addNewConverted instead of addNew method to take into account the difference of locales and avoid these stacktraces Change-Id: I5ef6325b8a213ae6758e378c4d3b8560c117042f Reviewed-on: https://gerrit.libreoffice.org/69131 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2019-03-13tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScTableColumnsObj. Change-Id: Icb2b61a323e69bfc5d7cef1f574bac79eaa2b220 Reviewed-on: https://gerrit.libreoffice.org/69147 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-13tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScTableColumnsObj. Change-Id: Id7128fbf5fe885045173d62eb954959e1f8aca44 Reviewed-on: https://gerrit.libreoffice.org/69146 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-13tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScTableColumnsObj. Change-Id: Id5b6296e405c108129df0bce4ed4204ede320f3c Reviewed-on: https://gerrit.libreoffice.org/69144 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-13tdf#45904 Move XNameAccess Java test to C++Jens Carl
Move XNameAccess Java test to C++ for ScTableColumnsObj. Change-Id: I3c9acde1b9e390c6a088bde567996728db855c2e Reviewed-on: https://gerrit.libreoffice.org/69143 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-13tdf#45904 Move XNameReplace Java tests to C++Jens Carl
Move XNameReplace Java tests to C++ for ScStyleFamilyObj. Fixes i#23594 by creating a new "com.sun.star.style.CellStyle" rather then using an existing one. Change-Id: Ie42e627020aff475173af5bc014bc28d7a11ec56 Reviewed-on: https://gerrit.libreoffice.org/69140 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-13“Large” LibreOffice icons are 24 × 24 pixel, as you’d expectAdolfo Jayme Barrientos
The Galaxy theme was the only odd duck to use 26 × 26 pixel icons. We’ve removed it, but the Change Icon dialog was still reporting this misleading value. Spotted by Rizal Muttaqin. Change-Id: I4f82727b93239a32f7eab5473baa3b8705abde29 Reviewed-on: https://gerrit.libreoffice.org/69148 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-03-12sw HTML export, field shadings: give text portion background priorityMiklos Vajna
If the user explicitly gives a background color to the field portion, then respect that, don't overwrite with the field shading (the UI does the same). Change-Id: I7c35618f82a37ef1dd16c03b82651268767813af Reviewed-on: https://gerrit.libreoffice.org/69127 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-12Sifr icon theme updateandreas kainz
Change-Id: I12af13094df0952326656293fa96bf3e9c82d2e7 Reviewed-on: https://gerrit.libreoffice.org/69111 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-12weld SwAddrDlgCaolán McNamara
Change-Id: I6d8b5ffa4b9db27335e771153119264216c0b8f7 Reviewed-on: https://gerrit.libreoffice.org/69084 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-12insert an intermediate class to inherit fromCaolán McNamara
Change-Id: I77cc250197658fed57175b775976a3194050c0da Reviewed-on: https://gerrit.libreoffice.org/69117 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-12prefer weld::Window variantsCaolán McNamara
Change-Id: I4938ea338a71e3c83d4d847317ba49b9c7088561 Reviewed-on: https://gerrit.libreoffice.org/69116 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-12weld extensions FormatNumberDialogCaolán McNamara
Change-Id: I34cb3f1739c6c3ee983be6ca0c70051a5fcfcb5d Reviewed-on: https://gerrit.libreoffice.org/69115 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-12select first entry initiallyCaolán McNamara
Change-Id: Ib4591197b17811a37b3a33f943fff03f1efd9550 Reviewed-on: https://gerrit.libreoffice.org/69114 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-12UNO SwTextTable: uso SvtListener instead of SwClientBjoern Michaelsen
Change-Id: I672ea969efccf660d9a23847b26535031144e3da Reviewed-on: https://gerrit.libreoffice.org/68473 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-03-12sal, android: fix -Werror,-Wreturn-typeMiklos Vajna
Change-Id: Ic37967dedb2378106db2f3f437781c8ad20cad56
2019-03-12fix a possible ScTokenArray leakLuboš Luňák
To me it looks like pArr is leaked in the bAgain = true case, or the code is rather misleading. Change-Id: I41ea26052671f127141d5421d0c446da4606da28 Reviewed-on: https://gerrit.libreoffice.org/69091 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-12don't let two unique_ptr's handle the same ScTokenArrayLuboš Luňák
The max-opencl-group-length ugly hack splits too long cell groups into smaller ones, but 60a66bd57d17a2 accidentally made the temporary group delete the array if the HW triggered this hack. Testcase: 'SC_MAX_GROUP_LENGTH=1000 make CppunitTest_sc_copypaste' Change-Id: I47ab08cd8511ad66e887c3c2d5eef25b08858c60 Reviewed-on: https://gerrit.libreoffice.org/69090 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-12weld SpellOptionsDialogCaolán McNamara
Change-Id: I813b166a8c4658e08b185a43a464b6b370b62c66 Reviewed-on: https://gerrit.libreoffice.org/69099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-12get correct frame window for SfxTabPage inside a SingleTabControllerCaolán McNamara
as opposed to the SfxTabDialogController case which already works Change-Id: If72ca14803e3ff4d716ecab56454a8e2324f460c Reviewed-on: https://gerrit.libreoffice.org/69098 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-12weld SvxLinguTabPageCaolán McNamara
Change-Id: I4bee58ab65a45d140fcb44a1def71ff505b78539 Reviewed-on: https://gerrit.libreoffice.org/69097 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-12weld OfaMiscTabPageCaolán McNamara
Change-Id: I6a363142945fc0b77e6c84649d32ffc27a5e2f04 Reviewed-on: https://gerrit.libreoffice.org/69082 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-12Simplify containers iterations in chart2, cli_ure, comphelper, configmgrArkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I7c229faa96e08b76cb4f182a1bd77c15bac4ba76 Reviewed-on: https://gerrit.libreoffice.org/69010 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>