summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-07-25loplugin:useuniqueptr in SwSrcViewNoel Grandin
Change-Id: I550d184ddd158e32abc353f8f1d458319bd4c2c5 Reviewed-on: https://gerrit.libreoffice.org/57946 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwView_ImplNoel Grandin
Change-Id: Id92590b00dbcd9b64ca90116fb6a275d66001519 Reviewed-on: https://gerrit.libreoffice.org/57945 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwModelessRedlineAcceptDlgNoel Grandin
Change-Id: I29dcfce3cc9977454f29cf21efb38dbe14f5c14f Reviewed-on: https://gerrit.libreoffice.org/57944 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwInputWindowNoel Grandin
Change-Id: If9ea84c6402269483d74a64b4b79a1f47f01c88d Reviewed-on: https://gerrit.libreoffice.org/57943 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwHHCWrapperNoel Grandin
Change-Id: Id651533b725c61f2fabd6ac51d640a42b06e6eea Reviewed-on: https://gerrit.libreoffice.org/57942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SdrHHCWrapperNoel Grandin
Change-Id: I1695dcf5af4f51e118b0286229e00896b09ec0bd Reviewed-on: https://gerrit.libreoffice.org/57941 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwSrcEditWindowNoel Grandin
Change-Id: I64d8a4ab60df95672363df7a4ac65cf4d2f9c8c2 Reviewed-on: https://gerrit.libreoffice.org/57939 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwEditWinNoel Grandin
Change-Id: I93dc00565c5ae99be774300bdde92e08546b3571 Reviewed-on: https://gerrit.libreoffice.org/57937 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwPostItMgrNoel Grandin
Change-Id: I63dd541ac975648083d75fe5ce1ef86e99016faa Reviewed-on: https://gerrit.libreoffice.org/57936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SidebarTextControlAccessibleContextNoel Grandin
Change-Id: Ie1506b90f541d3ccdc93c8234b393471fef0118d Reviewed-on: https://gerrit.libreoffice.org/57935 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwPageBreakWinNoel Grandin
and fix check in UpdatePosition, which would previously never have returned early Change-Id: Ie0d3feaf193dd3216f359a88c11ce6e504ac451c Reviewed-on: https://gerrit.libreoffice.org/57934 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwTransferableNoel Grandin
Change-Id: I857bd0416d3c093021409af18a28815eddbdb66a Reviewed-on: https://gerrit.libreoffice.org/57933 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25uitest for bug tdf#96698 , Validity-> CustomZdeněk Crhonek
Change-Id: Ia35d95c4ac6cddfb7db7a6e770b6c193baeab9fa Reviewed-on: https://gerrit.libreoffice.org/57896 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-07-24ofz#7621 tight OUString concat loop causes libfuzzer oomCaolán McNamara
it doesn't get a chance to release memory and falls over with an oom Change-Id: I20eb91223de3aa00f3e2f4131ad212f1cfde6ff3
2018-07-24GetCharWidths always returns trueCaolán McNamara
Change-Id: I4a58b203a7c18484c3405f918e77297ac764725d Reviewed-on: https://gerrit.libreoffice.org/57925 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24drop some more stuff for fuzzingCaolán McNamara
Change-Id: Ie9e1214eb2fd84f458eedb739248e06eef889385 Reviewed-on: https://gerrit.libreoffice.org/57929 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24split buffers to clarify what it doesCaolán McNamara
Change-Id: Id7888d2e2ef1cdf21af4247207c2b0dda0aa3823 Reviewed-on: https://gerrit.libreoffice.org/57926 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24forcepoint#53 restrict to expected index rangeCaolán McNamara
Change-Id: I22f01e5a3e3cf51b014ac841cd14071dce5baf0f Reviewed-on: https://gerrit.libreoffice.org/57920 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24icu: icu4c-icu11100.patch.1 presumed obsoleteMichael Stahl
According to http://bugs.icu-project.org/trac/ticket/11100 the bug was fixed upstream in a different way so hopefully this patch can be removed (but i don't know how to verify this). Change-Id: I815c17dae3de2d57d2e0e247cf5823dfc1cc7109 Reviewed-on: https://gerrit.libreoffice.org/57391 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Fix <otherwise> case for icon replacement Change-Id: Ia5db370d1e19aa2818fba7ad7b2427692ff1b80e Reviewed-on: https://gerrit.libreoffice.org/57927 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-24ofz#9431 don't check attribs of Invalid columnCaolán McNamara
Change-Id: I9c5adcadfa2a8593ff90622449d6bdfa4810f2c0 Reviewed-on: https://gerrit.libreoffice.org/57915 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24pass WrappedProperty around by std::unique_ptrNoel Grandin
Change-Id: Ifcd9606541d1157027ca49a351dbbbe0bf153b12 Reviewed-on: https://gerrit.libreoffice.org/57875 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24tdf#86619 Reintroduce Insert Caption to the table context menuXisco Fauli
This was removed in 4d0b11411d11050b13b821e847bab86f1247bcea however, the Insert Caption entry is available for images, charts and frames, thus, reintroducing in to keep it consistent across context menus Change-Id: I7dbe15ba82b8997a53eb32f8207c7ea35246b6df Reviewed-on: https://gerrit.libreoffice.org/57861 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-07-24sw,sc: Signature Line: fix VclPtr assertionMichael Stahl
Insert a Signature Line, right click, Sign..., Cancel include/vcl/vclptr.hxx:116: VclPtr<T>::~VclPtr() [with reference_type = AbstractSignSignatureLineDialog]: Assertion `(!m_rInnerRef.get() || m_rInnerRef->isDisposed() || m_rInnerRef->getRefCount() > 1) && "someone forgot to call dispose()"' failed. Change-Id: I09a1b37b917b267a84ee95fb375658974ee1b320 Reviewed-on: https://gerrit.libreoffice.org/57913 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-24forcepoint#52 flatten deep recursive delete of SwLineLayoutCaolán McNamara
Change-Id: I36d995062f4677ae900009d1eb5d48b906a4b36f Reviewed-on: https://gerrit.libreoffice.org/57910 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24valgrind: use of unit value exporting tdf107162-1.ots to xlsCaolán McNamara
Conditional jump or move depends on uninitialised value(s) at 0x4554B657: SetApiUnderline (xlstyle.cxx:487) by 0x4554B657: (anonymous namespace)::lclSetApiFontSettings(XclFontData&, rtl::OUString const&, float, float, com::sun::star::awt::FontSlant, short, short) (xlstyle.cxx:583) by 0x4554C096: XclFontPropSetHelper::ReadFontProperties(XclFontData&, ScfPropertySet const&, XclFontPropSetType, short) (xlstyle.cxx:679) by 0x4546D8BE: XclExpTbxControlObj::XclExpTbxControlObj(XclExpObjectManager&, com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&, tools::Rectangle const*) (xeescher.cxx:753) by 0x45593D99: XclEscherEx::CreateTBXCtrlObj(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&, tools::Rectangle const*) (xcl97esc.cxx:441) by 0x45594E85: XclEscherEx::StartShape(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&, tools::Rectangle const*) (xcl97esc.cxx:254) by 0x44E4FFBC: ImplEESdrWriter::ImplWriteShape(ImplEESdrObject&, EscherSolverContainer&, bool) (eschesdo.cxx:164) by 0x44E510C3: ImplEESdrWriter::ImplWriteShape(ImplEESdrObject&, EscherSolverContainer&, bool) (eschesdo.cxx:215) by 0x44E5452B: ImplEESdrWriter::ImplWritePage(EscherSolverContainer&) (eschesdo.cxx:848) by 0x44E54D27: ImplWriteCurrentPage (eschesdo.cxx:932) by 0x44E54D27: EscherEx::AddSdrPage(SdrPage const&) (eschesdo.cxx:945) by 0x454696BC: XclExpObjectManager::ProcessDrawing(SdrPage const*) (xeescher.cxx:1523) by 0x45407A35: ExcTable::FillAsTableBinary(short) (excdoc.cxx:518) by 0x454088B8: ExcDocument::ReadDoc() (excdoc.cxx:767) Change-Id: Ibefe8ea808bfbd9dfc8e773b4c13936387633507 Reviewed-on: https://gerrit.libreoffice.org/57904 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24crashtesting: tdf107162-1.xlsNoel Grandin
regression from commit 8a304fe8b1282efa2d40bdf337728e64b7532a35 loplugin:useuniqueptr in XclEscherEx Change-Id: I84c2619a1ac62cf70144b530c540a4c18b474bd1 Reviewed-on: https://gerrit.libreoffice.org/57903 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr in SwXMLTableContextNoel Grandin
Change-Id: I14dddb4ffb9ceb36ccdb902d6cbf253ccf480931 Reviewed-on: https://gerrit.libreoffice.org/57866 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24ofz#9261 catch all exceptionsCaolán McNamara
Change-Id: I535c9608bbd554a55edf9ccd58ac71032ba756fc Reviewed-on: https://gerrit.libreoffice.org/57902 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24tdf#118835 export animClr element. ( handle AnimateColor ).Mark Hung
Implement PowerPointExport::WriteAnimateColorColor to export to, from, by elements of the animClr element. Change-Id: I0fb81f8838656c127610a9a10654e3e51106bea8 Reviewed-on: https://gerrit.libreoffice.org/57820 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-24tdf#113818 convert formula of AnimContext.Mark Hung
Change-Id: I0f6f08247eaf8099d84c0e8201d22fc507b1cac4 Reviewed-on: https://gerrit.libreoffice.org/57414 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-24tdf#118835 fix missing attribute name conversion.Mark Hung
LineColor and LineStyle are missing from the switch-case. Just reuse the conversion list from oox::ppt::getAttributeConversionList(), also reoder the list so that fillcolor is prior than fillColor. Change-Id: Ia78553ad2fc908923da56bc58baf96dbb7d40863 Reviewed-on: https://gerrit.libreoffice.org/57819 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-24tdf#118890 subtract 100% from by values of animScale.Mark Hung
Despite that by values should be offset values instead of ending values, what we got from pptx seems to be the later, that we have to subtract 100% from the by values to get offset values for slideshow. Change-Id: I7eb9981210ea9998dae0de8f22c155b394e5abeb Reviewed-on: https://gerrit.libreoffice.org/57860 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-24Avoid com.sun.star.container.NoSuchElementException "Active" (2)Julien Nabet
Launch Base, use by default settings then create a form with the wizard and look at this kind of logs: warn:unotools:4125:4125:unotools/source/config/confignode.cxx:444: DBG_UNHANDLED_EXCEPTION in com::sun::star::uno::Any utl::OConfigurationNode::getNodeValue(const rtl::OUString&) const type: com.sun.star.container.NoSuchElementException message: Active context: configmgr::RootAccess Change-Id: I8a5e77ca1d51ab1a8e2b73972ad5d9a7acdce36b Reviewed-on: https://gerrit.libreoffice.org/57900 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-24loplugin:useuniqueptr in rptui::ConditionNoel Grandin
Change-Id: I1197be1f7ea8b621dedef41fdd0a664cb6d90374 Reviewed-on: https://gerrit.libreoffice.org/57879 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24uitest for bug tdf#53920Zdeněk Crhonek
Change-Id: I4e4cd572c2f2354da4f024d4bc80f56b589faab9 Reviewed-on: https://gerrit.libreoffice.org/57895 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-07-24loplugin:unusedfields,can-be-const in xmloff(1)Noel Grandin
(*) When passing a part of a global static data to XMLPropertiesOOoTContext_Impl, just store a reference to it instead of copying (*) Simplify the OOo2OasisTransformer constructor and call sites to make the const-ness work Change-Id: I012d638cfd9266ed3514164e84b381d0d577f821 Reviewed-on: https://gerrit.libreoffice.org/57853 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24crashtesting: infinite recurse with moz609361-1.svgCaolán McNamara
Change-Id: I18c2dd159dd7a64c3627abdb472d65013453b1b9 Reviewed-on: https://gerrit.libreoffice.org/57891 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24crashtesting: infinite recurse with moz384637-1.svgCaolán McNamara
Change-Id: Ia4bbc9d471c63812dc3ef490f32e8490bda72bfe Reviewed-on: https://gerrit.libreoffice.org/57888 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24Fix semantic of sentenceJens Carl
Follow up of ad7d72f0381f6a16db5c6c7bee538c475c233555. Change-Id: I188e96fd9d71dce5ebd83200b9d8212e5f13b948 Reviewed-on: https://gerrit.libreoffice.org/57894 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24tdf#118517: Use xStg before resetting itXisco Fauli
Regression from 0f166ef5240ee155bf2544e6bc3c985b1e3bf646 Change-Id: I083951700895a00be8d4407871c27804ca3e5f30 Reviewed-on: https://gerrit.libreoffice.org/57881 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24sw: Change TextPortions to std::vectorTakeshi Abe
as its usage does not require std::deque. Change-Id: I047e31972325a28f5ff92153e34893821e80fe57 Reviewed-on: https://gerrit.libreoffice.org/57898 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24use regular destructor for AnchorOverlayObject and ShadowOverlayObjectNoel Grandin
no need for static methods Change-Id: I8de3bf41183ef592f9c08d8d227834fa64d772fa Reviewed-on: https://gerrit.libreoffice.org/57849 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr in SwSpellDialogChildWindowNoel Grandin
Change-Id: Ib79e4672b7857aaacef15cd55c8633523df4d26b Reviewed-on: https://gerrit.libreoffice.org/57877 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr in SwAnnotationWinNoel Grandin
Change-Id: I0a4844898a85f0513da3e3fd7a977e35a9250f1e Reviewed-on: https://gerrit.libreoffice.org/57878 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr in SwInsertConfigNoel Grandin
Change-Id: I5f39956e529b98f4114139b8c3ba1391e45440ef Reviewed-on: https://gerrit.libreoffice.org/57876 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr in ScValidationDataListNoel Grandin
Change-Id: Icbf8eb814e7d3bd57e78d2d1a97eb44bbfd2a432 Reviewed-on: https://gerrit.libreoffice.org/57874 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr in SfxViewFrameNoel Grandin
Change-Id: I1edd00a184d8ffab4cf327aefc4e786458ccce52 Reviewed-on: https://gerrit.libreoffice.org/57873 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr in ChartControllerNoel Grandin
Change-Id: I224db5ab179bfd84125617e643441fd9a2872e67 Reviewed-on: https://gerrit.libreoffice.org/57872 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24loplugin:useuniqueptr fix check for DELETEZ inside compound stmtNoel Grandin
Change-Id: Id748b8b0c9cfe8c288dfafb5d0c2a83a8de2c91c Reviewed-on: https://gerrit.libreoffice.org/57871 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>