summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-08-29cid#1448379 silence Explicit null dereferenced false positiveCaolán McNamara
Change-Id: I5ff321520dd38f644b66bb78918035b512d5e67f Reviewed-on: https://gerrit.libreoffice.org/78090 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-29Update commentStephan Bergmann
external/liborcus/0001-Blind-fix-attempt-for-older-macOS-builds.patch has been removed with df2b4a9daa643e66b705a7b39d8988a3d97d731e "Update liborcus to 0.15.2." Change-Id: I1014e1ff847468b5b6c05ee363c1e6017722fd47 Reviewed-on: https://gerrit.libreoffice.org/78271 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-29related tdf#81345: make unit test robust - check last pageJustin Luth
On KDE Neon 18.04, something was causing page 1 to spill over onto page 2. Checking the last page instead of the second one is fine for testing the problem solved for bug 81345. Confirmed with bibisect53 that same header/page style had been used for the whole document originally. Change-Id: Id85562153d7ce1d570806a611f11d33fa5b83c87 Reviewed-on: https://gerrit.libreoffice.org/78250 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-29tdf#127211 start center: fix background of the main area with no recent docsMiklos Vajna
The background was white instead of gray, but the text color remained white, making the text unreadable. This was a problem since commit a5cafe5d7e87c0f5ecdcffbbe58c66abcb97ac8e (tdf#91843 sd sidebar: fix unexpected borders around the slide layout previews, 2019-08-27). Given that the background fix was intended to help with the slide previews in impress, move the change affecting the background handling down to ValueSet and revert the VCL changes. This preserves the impress slide preview fix, but restores the old good behavior for all non-ValueSet widgets, including the start center. Change-Id: I7efcd5b9c12e5df8e10261c992bf7a774960fa11 Reviewed-on: https://gerrit.libreoffice.org/78280 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-29tdf#126078 Autotext: fix lost space between first-/lastnamebrinzing
Change-Id: I3f8c1e25e06097cbed37fba1ca6a634704387e00 Reviewed-on: https://gerrit.libreoffice.org/76000 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-08-29Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - Insert the description of the change. Change-Id: I2dba6f76867798d59eae1e1f2d7c6c2734dd6eb4 Reviewed-on: https://gerrit.libreoffice.org/78276 Reviewed-by: LibreOfficiant <LibreOfficiant@sfr.fr> Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-08-29LOK: Proper use of isMobile() on embedded chartsMuhammet Kara
We are moving the isMobile() check to a higher layer, to avoid changing a published API method This is the follow-up of the commit feae0c186e700f6a48c3fad124fb4795ad1a8f83 Change-Id: Ia84baa36d66d5832e00e6466f5206631df0de443 Reviewed-on: https://gerrit.libreoffice.org/78277 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-29LOK: per-view support for isMobile()Muhammet Kara
embeddedobj/source/commonembedding/embedobj.cxx will have a follow-up patch, which also removes the -1 case. It is left out because it has many call-sites, and inheritance/override relations. Change-Id: Iaf00530916f3772f7aec151cbd358f255b7aab24 Reviewed-on: https://gerrit.libreoffice.org/78272 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-29lok: Disable chart editing on mobileTamás Zolnai
Disabled editing of all embedded objects. [ Miklos: motivation is that the UI is complex and the small mobile screen is not suitable to expose this functionality as-is. Disable till a more compact UI can be exposed. ] Change-Id: Id1c598c84adc12b8b52d006992d85dcae5601ad9 Reviewed-on: https://gerrit.libreoffice.org/78270 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-29Added mobile friendly ui design for ConditionalFormattingDialogmerttumer
[ Miklos: added solenv/ bits to silence the same warnings as the non-mobile layout. ] Change-Id: If2d91da45cf5eecf099f246320ffaf84f55708f1 Reviewed-on: https://gerrit.libreoffice.org/78268 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-29Make oslDirectoryImpl a bit more C++yStephan Bergmann
Change-Id: Iff5e26369889345d1f907e52d86eff6b89c63e20 Reviewed-on: https://gerrit.libreoffice.org/78260 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-29Update liborcus to 0.15.2.Kohei Yoshida
Change-Id: I1a16e7ba9a096862933536268dacf5ab49476896 Reviewed-on: https://gerrit.libreoffice.org/78246 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2019-08-29lok: Add isMobile() methodMuhammet Kara
[ Miklos: this allows core to e.g. serve tunelled dialogs with more or less compact layouts, depending on if the client is mobile or not. ] Change-Id: I3559bee84e6ef6f757809617e303aa090698ce5d Reviewed-on: https://gerrit.libreoffice.org/78261 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-29Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: Id4b7074e696507fc06c1d4c7f670f9f301b5ca54 Reviewed-on: https://gerrit.libreoffice.org/78249 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-29tdf#42949 Fix IWYU warnings in cui/source/{options,tabpages}/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9b6fda67ef7de65cc7b468dded862cd47dfd4269 Reviewed-on: https://gerrit.libreoffice.org/78078 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-29Fix typoAndrea Gelmini
Change-Id: I46650797efa70d6b416356a3e5ed57d26d8e69be Reviewed-on: https://gerrit.libreoffice.org/78252 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-29xmloff: create XMLImpressExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I44c3ac24c19f4ecd1d0d01a9a686b486f3b35c48 Reviewed-on: https://gerrit.libreoffice.org/78236 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-28loplugin:returnconstval (macOS)Stephan Bergmann
Remove the spurious "const" that dates back to a poor change in 9177329a425cf70b515d1f266132838894fe54c6 "vcl: FontCharMap to use intrusive_ptr ImplFontCharMap": > --- a/vcl/inc/quartz/salgdi.h > +++ b/vcl/inc/quartz/salgdi.h > @@ -73,7 +73,7 @@ public: > CoreTextStyle* CreateTextStyle( const FontSelectPattern& ) const; > int GetFontTable( const char pTagName[5], unsigned char* ) const; > > - const ImplFontCharMap* GetImplFontCharMap() const; > + const ImplFontCharMapPtr GetImplFontCharMap() const; > bool GetFontCapabilities(vcl::FontCapabilities &rFontCapabilities) > const; > bool HasChar( sal_uInt32 cChar ) const; > Change-Id: I6a533a917ec42513b0783332c35e0a6803504324 Reviewed-on: https://gerrit.libreoffice.org/78235 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28tdf#118169: ActiveX form control saved incorrectly with accented lettersTamás Zolnai
Write out unicode strings without any compression. Change-Id: I93cadc40bacbd679724c3404fd870cba48065650 Reviewed-on: https://gerrit.libreoffice.org/78234 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-08-28Fix typoAndrea Gelmini
Change-Id: Ic1256a994fb6813437320c29bfc73d414faf46dd Reviewed-on: https://gerrit.libreoffice.org/78232 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-28sd lok: extend language status with BCP 47 language tag info in here as wellMiklos Vajna
This brings Impress in sync with Calc, which does this since commit 47025060e4474d23e3bd97053a77b3943eeae724 (Send Bcp47 codes with region, 2019-08-28). Change-Id: I04b92c85b6627e145b5271a6f84780257e8f0d55 Reviewed-on: https://gerrit.libreoffice.org/78231 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-28INetURLObject::setFSysPath is unused nowStephan Bergmann
...after 056e1fff2ed232f2a50db933fbade1c71c0c2a65 "Simplify code removing the last segment from a URL" Change-Id: I3abe84ada119356191d8df9c0a8ee62dcf18d108 Reviewed-on: https://gerrit.libreoffice.org/78228 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28Avoid dynamic_cast in AttributeOutputBase::ConvertURLMike Kaganski
This unifies the code for any format using the function. Note: RTF code currently doesn't use the function, so an empty string is used in its ctor. Change-Id: I8776c095d4527313d06b0620059a892a48a9eaa1 Reviewed-on: https://gerrit.libreoffice.org/78229 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-28sw lok: extend language status with BCP 47 language tag info in here as wellMiklos Vajna
This brings Writer in sync with Calc, which does this since commit 47025060e4474d23e3bd97053a77b3943eeae724 (Send Bcp47 codes with region, 2019-08-28). Change-Id: I615af4a0692216f794c78955d337e6b8dbc8db5e Reviewed-on: https://gerrit.libreoffice.org/78230 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-28Send Bcp47 codes with regionSzymon Kłos
Change-Id: I816eddab3d88534bff6c1f1dba81b45107cdb372 Reviewed-on: https://gerrit.libreoffice.org/78227 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-28INetURLObject FSysStyle ctor is unused nowStephan Bergmann
...after 90e33df14a1bdff55c4759102658dba7510a733a "Always using translateToInternal should be fine in SalGtkPicker::uritounicode" Change-Id: I3712109ef875ce8961d2da904a38400e0cf97496 Reviewed-on: https://gerrit.libreoffice.org/78166 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28Handle LANGUAGE_NONE caseSzymon Kłos
Change-Id: I4dde96d488fc1e956bc2385c5e311eeadacd4be0 Reviewed-on: https://gerrit.libreoffice.org/78226 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-28Simplify code removing the last segment from a URLStephan Bergmann
This code had been introduced with 2b2f1352c72280dd25ed3bef090a3c708ee4b964 "tdf#86087 Save relative links in DOCX", but it is not clear to me what part of <https://bugs.documentfoundation.org/show_bug.cgi?id=86087> "FILESAVE FILEOPEN VIEWING: Can't open or save relative links in docx" it is meant to address. None of the tests in `make check` trigger the > else > { > // DOC > WW8Export* pWW8Export = dynamic_cast<WW8Export*>(&GetExport()); > if ( pWW8Export ) > { > SwWW8Writer& rWriter = pWW8Export->GetWriter(); > sExportedDocumentURL = rWriter.GetMedia()->GetURLObject().GetPath(); > } > } block. But what the code presumably wants to do is to create, for the DOC case, an anAbsoluteParent that is rWriter.GetMedia()->GetURLObject() with the final URL path segment removed: INetURLObject::GetPath returns the "dirname" part of a file URL's path (i.e., everything but the last path segment), and with a trailing slash removed, in the form of a filesystem pathname. That means that > INetURLObject anAbsoluteParent( sExportedDocumentURL ); creates an invalid anAbsoluteParent (because the input is not a URL), so > if ( anAbsoluteParent.GetURLPath().isEmpty() ) is true (but why not use a more obvious check of anAbsoluteParent.HasError(), or should this code also be relevant for the DOCX case?), so the following block > { > // DOC filter returns system path (without file:///) > anAbsoluteParent.setFSysPath( sExportedDocumentURL, FSysStyle::Detect ); > anAbsoluteParent.setFinalSlash(); > } recreated the URL from the filesystem pathname and added back the trailing slash. Change-Id: I9346a23680a65b6fd1ba0fa33f4565df50bd9e51 Reviewed-on: https://gerrit.libreoffice.org/78210 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28tdf#127192 Printing in main threadJuergen Funk
the wollmux has change the dialogs form swing to the LO-Dialogs, and when printig with MS-PDF then LO hang on this line. The reason is wollmux run in it own thread, but this thread has no win-message-pump, when the printer-driver would open the FileSave-Dialog then it hangs, because the message-pump is missing in this thread. The swing has made it own win-message-pump for this thread. Change-Id: Ia5131464dcc5f166133a3302d29550e945dd1026 Reviewed-on: https://gerrit.libreoffice.org/78170 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Juergen Funk (CIB) <juergen.funk_ml@cib.de> Tested-by: Juergen Funk (CIB) <juergen.funk_ml@cib.de>
2019-08-28Blind fix for ENABLE_MERGELIBSStephan Bergmann
...after 55402d82c5a81322ff7bca3c277a8813bd967a09 "tdf#42949 Fix IWYU warnings in vcl/source/[o-w]*/" had caused tb62 to fail with > C:/cygwin64/home/buildslave/source/libo-core/vcl/source/window/builder.cxx(1604): error C3861: "SVLIBRARY": Bezeichner wurde nicht gefunden. [...] > C:/cygwin64/home/buildslave/source/libo-core/vcl/source/window/builder.cxx(2294): error C3861: "SVLIBRARY": Bezeichner wurde nicht gefunden. Change-Id: I2102454bf12dc3a04d630ab09cb427471fef99d4 Reviewed-on: https://gerrit.libreoffice.org/78223 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28Send ISO language code on state changedSzymon Kłos
[ Miklos: commit 13c77cc3b34555aefd898a15c6ad898049f8aed6 (Send iso code for languages, 2019-07-19) only changed the behavior in case the LOK client asks for a list of languages explicitly. This one affects the case when the language under the cursor changes and core initiates the core -> client information sending. ] Also contains: Fix language unit test Change-Id: I45b4263026928de898fe89e25c21d97c82e1beeb Change-Id: I2f82cee1fda613636fc421449a2d8a56b0a35b7f Reviewed-on: https://gerrit.libreoffice.org/78222 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-28New loplugin:stdfunctionStephan Bergmann
...finding dubious additions to namespace std (concentrating on functions for now). C++17 [namespace.std]/1: "The behavior of a C ++ program is undefined if it adds declarations or definitions to namespace std or to a namespace within namespace std unless otherwise specified." This found ad4c7b97752b4da73808402604d6f96b39d920f5 "Avoid declaring function templates in namespace std" 042e30a3dc057aef4a02d95960e4dd4fb8d083ae "Avoid adding a function template declaration to namespace std" cae9240a76cdb0eeed92421930d3b4cbef0ac201 "Avoid adding a function declaration to namespace std" Change-Id: Ic2ba54e2a8bf931d5c58cedf499c0d1229eb2166 Reviewed-on: https://gerrit.libreoffice.org/78220 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28Add DISABLE_DYNLOADING guard for notebookbar addons builderSzymon Kłos
Change-Id: I99487a8adaa24f155eec2182899127c5bab6a21f Reviewed-on: https://gerrit.libreoffice.org/78219 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-08-28Send iso code for languagesSzymon Kłos
[ Miklos: the motivation for this change is that LOK clients may display information on their UI depending on screen size. Mobile clients may want to have a more compact display, where showing the full language name takes too much space, and showing some kind of language code is a better way. ] Change-Id: Iec93ad05d83a8ce871eab33bd12e99aee9aafa86 Reviewed-on: https://gerrit.libreoffice.org/78217 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-28Always using translateToInternal should be fine in SalGtkPicker::uritounicodeStephan Bergmann
When SalGtkPicker::uritounicode was originally introduced in 27994c3831e55174af313e74e09905003ff34440 "INTEGRATION: CWS cmcfixes4: #i46017# to and from system locale encoding when url is file:///", it only contained the g_filename_from_uri code and no translateToInternal fallback (though the SalGtkPicker::unicodetouri counterpart, already introduced then, only used INetURLObject::getExternalURL, the precursor to today's translateToExternal, from the beginning). The translateToInternal fallback was only added later with e68b4920b0a726578094013b819b1e0833929acb "INTEGRATION: CWS c07v007_SRC680: #b6465588# cope with URI encoded in non UTF8 encoding". But I see no reason to not always use just translateToInternal in uritounicode (matching the translateToExternal in unicodetouri). Trying with both LC_ALL=en_US.UTF-8 and LC_ALL=en_US.ISO-8859-1 and the gtk3 VCL plugin (on GTK 3.24.10), the only difference between using the g_filename_from_uri and the translateToInternal code is that the former produces an IURI sURL where non- ASCII Unicode characters are written as such (later on in the LO code to be encoded as %XX...), whereas the latter produces an sURL where those non-ASCII Unicode characters are already encoded as %XX... One difference is for filenames containing bytes that cannot be represented in the current LC_CTYPE encoding. g_filename_from_uri reports them as U+FFFD REPLACEMENT CHARACTER, so producing an IURI sURL containing "�" (that is later on in the LO code encoded as %EF%BF%BD), while translateToInternal keeps the single %XX representing the original byte intact. (And even though LO can't properly handle such a file URL with non--UTF-8 payload, this change is a small- step win of keeping the URL at least intact and not garbling it completely with "�" aka %EF%BF%BD). Change-Id: If27fc64c75e986dbb467e147a7e43df3a01db640 Reviewed-on: https://gerrit.libreoffice.org/78216 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28Avoid adding a function declaration to namespace stdStephan Bergmann
Change-Id: Id6839850f249f2065de05a0fd929e68ca1003ec6 Reviewed-on: https://gerrit.libreoffice.org/78213 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28Avoid adding a function template declaration to namespace stdStephan Bergmann
Change-Id: I1368276c859d3c81f4ebfbeca47bb99e781f2fed Reviewed-on: https://gerrit.libreoffice.org/78214 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28tdf#42949 Fix IWYU warnings in vcl/source/[o-w]*/Gabor Kelemen
Plus a quick recheck for files in vcl/source/[a-g]*/ Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia1ae951047be2e034da5f3b0422613ddb0a091ad Reviewed-on: https://gerrit.libreoffice.org/78065 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-28sw: prefix members of SwUndoFlyBaseMiklos Vajna
See tdf#94879 for motivation. Change-Id: I266ba820629ec6f8505d091fb6090ed8626b4742 Reviewed-on: https://gerrit.libreoffice.org/78211 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-28Fix other signature of basicide_macro_organizerStephan Bergmann
...after 97710225f015c8716c80e55ecdb78832f2edc731 "sfx2: fix DISABLE_DYNLOADING build" had changed it to 'void const *' but the concurrently submitted 036e635678aedc414e2d55217e4f7f8359ed1b9a "Fix signature of basicide_macro_organizer" fixed the underlying issue that had been introduced with df905f41a33d0d7d2cde7fad80c5b3dc3c837c10 "loplugin:constmethod in sfx2" and had caused DISABLE_DYNLOADING builds to fail Change-Id: If5d8c3289d7c77f5e6526bf7f4e0c48292dc5f71 Reviewed-on: https://gerrit.libreoffice.org/78209 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28ContentInfo::Equals uses std::equalAdrien Ollier
Change-Id: Ia99cd1cb9594d6398ff351f6ded7888a75c83dd6 Signed-off-by: Adrien Ollier <adr.ollier@hotmail.fr> Reviewed-on: https://gerrit.libreoffice.org/76504 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-28GtkWidget for the priority of extension under Extension Tab.Sumit Chauhan
The new structure : PriorityMergedHBox --OptionalBox --ToolBoxExtension --Extension1 --OptionalBox ..... Change-Id: I72760e4f0d60eb6f1f82c1e928601d41a2e4b6ce Reviewed-on: https://gerrit.libreoffice.org/76987 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-08-28Record patch as upstreamedMike Kaganski
Change-Id: Ia84db6c3d8051b872a838b530a8c44ce4a4b2821 Reviewed-on: https://gerrit.libreoffice.org/78198 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-28Typo: HAPICOLOR_WITHE->HAPICOLOR_WHITE (vbahelper)Julien Nabet
Change-Id: I51a43e190345a1e981f9bd524d8b2feaf0eb2521 Reviewed-on: https://gerrit.libreoffice.org/78207 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-28Remove unnecessary braces.Kohei Yoshida
As to the reason why they were there can be explained by the commit 48b35ed43db87d21a943e66cfa4f59213dcfe3a1. They braces did make sense before that commit. Change-Id: Ie889d9e2404436c1cc0249dcf71bf18ebfd40636 Reviewed-on: https://gerrit.libreoffice.org/78212 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2019-08-27Fix typosAndrea Gelmini
Change-Id: If2fcd9aaf920f30b49a7bb828ba174939b13a3e7 Reviewed-on: https://gerrit.libreoffice.org/78091 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-27Use lambda expression here instead of a function object.Kohei Yoshida
Change-Id: I469cc9fa0506153e6dc4ff8fe6d5bad19c02b285 Reviewed-on: https://gerrit.libreoffice.org/78208 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2019-08-27tdf#74045 Make ImageMaps in slideshow clickableSamuel Mehrbrodt
Change-Id: I151983ce34a58c0f0d4b1e912f43525de4c0ad28 Reviewed-on: https://gerrit.libreoffice.org/78157 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-27Fix signature of basicide_macro_organizerStephan Bergmann
see the function definition in basctl/source/basicide/basobj2.cxx Change-Id: If19f0a82d5498795ceef26342e0152fb12ef983d Reviewed-on: https://gerrit.libreoffice.org/78204 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-27no need to add a new virtual method (tdf#119388 related)Noel Grandin
we can re-use the existing GetObjIdentifier infrastructure Change-Id: Ie604d643186a925da41a1e67ccd5f2461ceb20f1 Reviewed-on: https://gerrit.libreoffice.org/78193 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-03-17 12:33:21 +0000