summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-07-20loplugin:constparams in accessibilityNoel Grandin
Change-Id: I9c168295dcd6d4400c0f7c0b30ec22bd018cf93b Reviewed-on: https://gerrit.libreoffice.org/40203 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-20loplugin:constparams in canvasNoel Grandin
Change-Id: Id54bb9dca606dd91e2d3ad4b63b9af7593c601e0 Reviewed-on: https://gerrit.libreoffice.org/40202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-20Avoid unnecessary calls of AdjustRowHeightTamas Bunth
Check if attribute changed during ApplyAttributes. If it did not change, it is unnecessary to recalculate cell size, repaint etc. Change-Id: Ic3a3fa24efa9ad3619b8979a67e972a7635311cc Reviewed-on: https://gerrit.libreoffice.org/40198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-07-19tdf#108824 Honor ODF default for "Mouse pointer visible" propertySamuel Mehrbrodt
Change-Id: I6b4c431d66835b6affe834a23b900fa61830d87f Reviewed-on: https://gerrit.libreoffice.org/40159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-19Removed duplicated includeAndrea Gelmini
Change-Id: Ie1eef17779e2c70215526e46813b5ab9321911f5 Reviewed-on: https://gerrit.libreoffice.org/40119 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-07-19Fix crash when saving new spreadsheet as dBase/.dbf, tdf#108789 follow-upEike Rathke
... as there is no input stream. Regression from commit 7f1465a9599e9665159dd2d823a6e9064cca5703 Date: Sun Jun 25 17:21:45 2017 +0200 Change-Id: Ib97a4878fe8cf28e5d0f1dc6cc07800ea1635e68
2017-07-19Avoid temporary Date and normalizationEike Rathke
Rather than possibly calculating Date=((Date=(Date+int))+int) with a normalization involved for each operator+() force Date=(Date+(int+int)) Change-Id: I6c4b30749d138c0b041ffc9e37796b6f64b6d461
2017-07-19Don't calculate GetDayOfWeek() thriceEike Rathke
Change-Id: Ia1f7689448f8a9ea9e5c1a6e3b1949ee2065c827
2017-07-19Change the most obvious Date+=(long)... to Date+=static_cast<sal_Int32>(...)Eike Rathke
Simple search git grep -l 'Date.*[+-].*[(<] *long *[>)]' Since commit f5b0cc2a3690ba963b3f150886e1d5ddddee9530 Date: Sat Jul 1 16:01:15 2017 +0200 Date operators +,-,+=,-= have sal_Int32 operands instead of long. Change-Id: I2387cbceadcb056831225e4111353980d50a94d4 Reviewed-on: https://gerrit.libreoffice.org/40163 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-07-19tdf#108881 : do not assume that chart objects always...Dennis Francis
...have data ranges associated with it. Empty charts do not have data ranges. Reverts the part of c55d52262ea1d5f869a9528fd051ee19e687f1cc which makes this assumption. Matching test cases (in uitest) coming up soon in another commit. Change-Id: I60f0f03a8c937ecfdff95047bdfeeb7733eff4a4 Reviewed-on: https://gerrit.libreoffice.org/40057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-07-19connectivity: merge OCalcColumns and OWriterColumnsMiklos Vajna
Turns out createObject() only needs the base class OFileTable, and then these can be shared. Change-Id: I6e8a83155dbbbc3d85794e190c2e710d01902017 Reviewed-on: https://gerrit.libreoffice.org/40183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-19connectivity: merge OCalcPreparedStatement and OWriterPreparedStatementMiklos Vajna
Into a single OComponentPreparedStatement, as both of them just provide prepared statement functionality based on a file loaded into an LO component, so they can share code. Change-Id: Ib1074871d63de83f16861081050e57442ebf0ffa Reviewed-on: https://gerrit.libreoffice.org/40182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-19connectivity: merge OCalcStatement and OWriterStatementMiklos Vajna
Into a single OComponentStatement, as both of them just provide statement functionality based on a file loaded into an LO component, so they can share code. Change-Id: Iad2852f93783ec3c4a672f4b86424b4aa0ae8eaf Reviewed-on: https://gerrit.libreoffice.org/40181 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-19connectivity: merge OCalcResultSet and OWriterResultSetMiklos Vajna
Into a single OComponentResultSet, as both of them just provide data source functionality based on a file loaded into an LO component, so they can share code. Change-Id: I19352e592a45d7a58d834e72645dec72d77ce7c9 Reviewed-on: https://gerrit.libreoffice.org/40180 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-19tdf#93328 : Assign the ScInterpreter results back to ScFormulaCell...Dennis Francis
when the formula cell type is unknown before interpreting, otherwise the cell is treated as of type string later when used by the interpreter. Added unit-test testIterations() in ucalc that tests the establishment of circular chain of references and editing of a formula cell that already belong to the circular chain. Change-Id: Ib13b05b20d17c0696fce0ac9eefd9e621bdc0c5f Reviewed-on: https://gerrit.libreoffice.org/40165 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-07-19tdf#107975: Revert "fix deleting an image anchored to last paragraphMichael Stahl
... in document" This reverts commit 2903d85d6197829633d7f96c95cd55821c2c20ff. It was a good idea, but is not complete. Change-Id: Ia0da2640889ce6e78b89b27c75fae9d6508afd40
2017-07-19oss-fuzz: fix wmffuzzerCaolán McNamara
Change-Id: Idd6a03ed46161c6d35088401ae2816edc8a69f8b
2017-07-19loplugin:constparams in cppuNoel Grandin
Change-Id: I0e772b8cf4ee281b5f3e26131df985607a569c48 Reviewed-on: https://gerrit.libreoffice.org/40156 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-19Updated coreOlivier Hallot
Project: help 96683c90c8faf8af6bcee5a149f3a7a6acefcf26 Code cleanup in XSLT remove unecessary template Change-Id: Ie7b615d75c33702e79dc052b87c2a392038964c6 Reviewed-on: https://gerrit.libreoffice.org/40186 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-07-19Updated coreOlivier Hallot
Project: help 125c3e6a3faab4062b69ab78c636192e5f3763b9 Fix a $title variable in XSLT transform Change-Id: I7463572330e2338e73266f487d88b3d1beeff741 Reviewed-on: https://gerrit.libreoffice.org/40184 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-07-19tdf#108928 Branding 6.0Heiko Tietze
Improved splash Change-Id: Ie691567fc265ebd6100029843b111be3ce97c804 Reviewed-on: https://gerrit.libreoffice.org/40120 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-07-19tdf#109188 Always load documents read-only in SwOneExampleFrameSamuel Mehrbrodt
Should be no problem since 38a3743e0c5d52f9386f74097fd512d3133fbbe3 Change-Id: I0ce47bc2bdaa900559a16baf25305066977caa6d Reviewed-on: https://gerrit.libreoffice.org/40140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-19sw mailmerge: add writer data source testcaseMiklos Vajna
Fails with commit 83b43ef2223b66484e0e90e7b614886e06f955b5 (sw mail merge: add support for the new 'writer' connectivity driver, 2017-07-18) reverted. Change-Id: I675e15bdbc655a34cca3de2b5d070167ca69cac8 Reviewed-on: https://gerrit.libreoffice.org/40174 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-19revert fix typosThorsten Behrens
This revert the part of commit d948d66509022befdb6e2c589859ca7dee9e5347 Author: Andrea Gelmini <andrea.gelmini@gelma.net> Date: Sat Mar 18 20:07:23 2017 +0100 Fix typos that changes the odf 1.2 schema Change-Id: I6307513bc1494b656c031168375cd30224914b33
2017-07-19vbaapi: File dialog produces pathTamas Bunth
instead of file url Change-Id: I6f4cab23edd1fabe93290a26adc5fb77f2a55e8b Reviewed-on: https://gerrit.libreoffice.org/40170 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-07-19CheckWebQuery: Don't use OUString::createFromAscii for user inputMike Kaganski
Change-Id: I26803984c0a9e172aa4ceb7bfc9d26abb14ca207 Reviewed-on: https://gerrit.libreoffice.org/40173 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-19tdf#108835 Fixed writer crash on adding Autocorrect Entry:Mohammed Abdul Azeem
ZipPackageStream::saveChild seeks and reads on the same stream, so it cannot be done parallely. Also, read on BufferedStream tries to aquire the same mutes, which is already aquired by the calling method resulting in deadlock. Using UnbufferedStream here should solve both. Change-Id: I25b7ca2ff3c31125cf107fe404f9af66435bec7d Reviewed-on: https://gerrit.libreoffice.org/40160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-07-19Separate SvxMenuConfigPage from cfg.cxxMuhammet Kara
Change-Id: I6e56756628bbbf3900f946715ce8b95bbe78ae03 Reviewed-on: https://gerrit.libreoffice.org/39341 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 091a7f474adac69b1808e5c812952586d253a809) Reviewed-on: https://gerrit.libreoffice.org/39956
2017-07-19gtk3: make video playback fill playback windowCaolán McNamara
Change-Id: I43f2f77889856dc6a3b0c3a3775826dbb000be7a Reviewed-on: https://gerrit.libreoffice.org/40168 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-19Missing @since tagsStephan Bergmann
...from 83535a28c57ffb59f795dd35332d6b3426071e32 "emfplus: create a wmf/emf/emf+ primitive based importer" Change-Id: Id628c834cea2ae4cb031fdd68feff5db1e887d13
2017-07-19android:Update configure.ac to support NDK 15.1.xbrainbreaker
Change-Id: I07ec4df7cb5aaf4b491fac1202d2607af9f56968 Reviewed-on: https://gerrit.libreoffice.org/39780 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-19CompilerTest_compilerplugins_clang: disable test failing with clang-3.8Miklos Vajna
10:28 <@vmiklos> noelgrandin: clang-3.8 is unhappy for the unusedfields plugin: https://pastebin.com/raw/MJ30aKcs 10:30 <@noelgrandin> vmiklos: ... probably best to just disable the unusedfields solenv testing in the .mk file Change-Id: I1873f1f76d7a7b0438002ffda9180abe582e07d7
2017-07-19Favourites feature in Special charactersAkshay Deep
Change-Id: I8273b95132d48a51e841ec3792139007b4e7b55a Reviewed-on: https://gerrit.libreoffice.org/39752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-19loplugin:constparams in connectivityNoel Grandin
Change-Id: I9b81c6227fb3c89a832640058a11444f72019694 Reviewed-on: https://gerrit.libreoffice.org/40155 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-19loplugin:constparams in desktopNoel Grandin
Change-Id: Idba3acbd1e6ad5e1ce1cae9f80f764906ab8b143 Reviewed-on: https://gerrit.libreoffice.org/40157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-19loplugin:constparams in svtoolsNoel Grandin
Change-Id: I2620419828864363af55011abe56143bb7d42f48 Reviewed-on: https://gerrit.libreoffice.org/40154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-19enhance unusedfields plugin to find readonly fieldsNoel Grandin
Change-Id: I4da97443fc7eb14fd94959a026ab45a9256c055f Reviewed-on: https://gerrit.libreoffice.org/40158 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-19[API CHANGE] offapi: remove unused css.xml.crypto.XMLEncryptionMiklos Vajna
This is mostly just the offapi/ part, more C++ code can be removed in xmlsecurity/ after this. XMLEncryption wasn't used by internal code since it was added in commit 9f34fde7a8750b856570b5e855d2ecb226bf0c23 (libxmlsec, 2004-07-12). It seems to be unlikely that this non-published service was used by 3rd-party code, since it was specific to other xmlsecurity/ code, not generic functionality that could be useful in other contexts. Change-Id: Ia0168f67d1c8ff7a019760ac436511f219eee94e Reviewed-on: https://gerrit.libreoffice.org/40162 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-19osl: fix a number of doxygen comments in unx/file_path_helper.hxxChris Sherlock
Change-Id: Icd5553505e48b650103597e40311ac11ba388259
2017-07-19osl: fix file_path_header.cxx commentChris Sherlock
Change-Id: I671ba9d48d327ccabc8851bee596831e04a6f62a
2017-07-19osl: fix header commentChris Sherlock
Change-Id: I06829e4ad0efc78244083e48bf9cd10422ff5e2e
2017-07-19osl: remove comment cruft osl/socket.hChris Sherlock
Change-Id: I785cc08e5450530f885b1bf38b50517029d6fb92
2017-07-19Followup to 56638d1a6d9ba - fValid -> bValidChris Sherlock
In 56638d1a6d9baebfe27cbf82ccf0376926c6a530 we renamed to BOOL to bool, but we also need to change from fValid to bValid. Change-Id: I6a2c2931d8872ee2cfefa43c3f06fff5d5ce0629 Reviewed-on: https://gerrit.libreoffice.org/40115 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-07-18tdf#109194 cleanse startup notification foo from envThorsten Behrens
So when the desktop environment does startup notification, this DESKTOP_STARTUP_ID gets passed on to the launched application. Problem is, XDG spec says app should read it from the env, then discard - which LibreOffice never does. When passed on to child processes, funny effects might ensue, so let's just erase this at the end of VCL init, when I'm reasonably sure every gtk/kde/whatnot backend did read it. Change-Id: I1f758c7a02455028d2b520c144ffe32538621f19 Reviewed-on: https://gerrit.libreoffice.org/40153 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-07-18remove unused CntWallpaperItemCaolán McNamara
Change-Id: I47cf9fc37bb64a80a21ed805bff2bb3ac3eb6da5 Reviewed-on: https://gerrit.libreoffice.org/40148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-18loplugin:oncevarTor Lillqvist
Change-Id: I538903412a351ba901c2b2149e450ebc7e80916a
2017-07-18loplugin:oncevarTor Lillqvist
Change-Id: Ic7c5ec9bb7cc7aff61279f2027cf5a9e1b31e36f
2017-07-18Eliminate some unnecessary temporary Date instancesEike Rathke
Change-Id: Idede71608458acf4d23504b3a6a1cba557f370d1
2017-07-18sw mail merge: add support for the new 'writer' connectivity driverMiklos Vajna
By mapping the .odt, .sxw, .doc and .docx extensions to sdbc:writer:. If we are at it, also accept xlsx next to xls. Change-Id: I8c6769b282adec1e7e8d191170e7aa9b324f2018 Reviewed-on: https://gerrit.libreoffice.org/40147 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-18dbaccess: introduce DATASOURCE_TYPE::DST_WRITERMiklos Vajna
By mostly reusing the spreadsheet code. This way the UI allows creating a data source where the backend is a Writer document (containing at least one Writer table). Change-Id: I42186d46aaa86fa96ebae0807c97306d6d00d6d4 Reviewed-on: https://gerrit.libreoffice.org/40146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>