summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-07-25warning STL4015: std::iterator is deprecated (clang-cl)Stephan Bergmann
Change-Id: I92dce067ab05cbef1b13dddd9b4de221051c9320 Reviewed-on: https://gerrit.libreoffice.org/57999 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-25Fix typoAndrea Gelmini
Change-Id: I77f793b789952d12ca07e9d218396090bb3cd427 Reviewed-on: https://gerrit.libreoffice.org/57993 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-25Fix typoAndrea Gelmini
Change-Id: I24e325e2d283c58ea58e8d227a909417e3535484 Reviewed-on: https://gerrit.libreoffice.org/57995 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-25Add missing method hasUnsignedLongDependency()Muhammet Kara
m_unsignedLongDependency was already set but never used. Behavior of Includes::Includes ctor is now in consistency with the related switch cases in Includes::add (see: m_includeSalTypesH) Change-Id: I4cca1bab014ac280b73b7532aadfd5ff2b0b9894 Reviewed-on: https://gerrit.libreoffice.org/57792 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-25tdf#118730 Correct ReportDesigner Object creationArmin Le Grand
This is a follow up problem to removing the old stuff that first a SdrPage* at the SdrObjects was set *without* the SdrObject being inserted to any SdrObjList. It works no longer - the SdrPage which you can get now is the one the SdrObject *is* inserted at. Solution is to move that stuff - plus other initializations which were done in OUnoObject::EndCreate before - to where it belongs. This gets rid of OUnoObject::EndCreate completely. It makes OUnoObject::impl_setReportComponent_nothrow no longer needed due to being used only in one place. All initializations move to OUnoObject::CreateMediator which anyways needs to be done when a OUnoObject got created. Change-Id: I86f968dc6e867c5752d3c8cee1b3b2af57e467c8 Reviewed-on: https://gerrit.libreoffice.org/57976 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-25ofz#8539 share LineInfo to save memoryCaolán McNamara
Change-Id: I6a97d82e55fb91f2c45add4d066522f36fabff6c Reviewed-on: https://gerrit.libreoffice.org/57983 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-25tdf#118777: Disable signature line slot if non-text objectKatarina Behrens
both in sw and sc Change-Id: I54f7ec336026013d09ac6262779e7fcbd17c2084 Reviewed-on: https://gerrit.libreoffice.org/57949 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-07-25Update git submodulesGabor Kelemen
* Update helpcontent2 from branch 'master' - Fix ahelps in Math; Format - Spacing page Change-Id: I96b74f871a66d7968ae268552f38d43c56bec12f Reviewed-on: https://gerrit.libreoffice.org/57928 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-25new loplugin:returnconstantNoel Grandin
look for methods that always return the same value Change-Id: I5f1c5b58a985ecf5f7765a2d4ebd464eae5ef76f Reviewed-on: https://gerrit.libreoffice.org/57973 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25tdf#50499 convert by, from, and to of AnimContext.Mark Hung
Also change testTdf104788 because the expected value is taken as a double and decimal places are omitted if there isn't any. Change-Id: I16cb363b1ce0ff09da2df361849d47819bf9ced4 Reviewed-on: https://gerrit.libreoffice.org/57413 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-25tdf#118836: fix grow-shrink animation in saved pptx.Mark Hung
Convert AnimeTransform with transform type SCALE to animScale. Change-Id: I39dfbdb814afa78ca981238bb1876f4af0995791 Reviewed-on: https://gerrit.libreoffice.org/57790 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-07-25ofz#7886 reject bogus text offsets inside fibCaolán McNamara
Change-Id: I7e81d13c199301cc4a049081476feac6e1507bd0 Reviewed-on: https://gerrit.libreoffice.org/57972 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-25convert pFontA to std::vectorCaolán McNamara
Change-Id: I8045047a963930c4a0dca2d1eaa0dcb6362b8e53 Reviewed-on: https://gerrit.libreoffice.org/57971 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-25tdf#118777 cui: use right XText in SignatureLineDialogMichael Stahl
Writer has multiple nested XText and we have to call insertTextContent on the one that corresponds to the xCursor, so use the convenient getText() instead of hard-coding the body text. Change-Id: I86bce48e97730917aa8c4b093bb74c03e3f0dd36 Reviewed-on: https://gerrit.libreoffice.org/57969 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-25Remove useless self-assignment of mxImpl->mxAccessMuhammet Kara
Change-Id: I49fe21ad4a99ea617d6698a9c9eab4daf6fed3b9 Reviewed-on: https://gerrit.libreoffice.org/57951 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-07-25ofz#7666 WritingDirectionInfos doesn't have to be a dequeCaolán McNamara
Change-Id: I67731046b1ed1ad87b78ad3981ce0b0f6d2f8415 Reviewed-on: https://gerrit.libreoffice.org/57964 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-25Adapt solenv/flatpak-manifest.in to recent download.lst changesStephan Bergmann
Change-Id: I7799abe1a6fc9cf79a751d76360ea7ad2face133
2018-07-25Resolves: tdf#118862 new instances cannot be editedCaolán McNamara
Change-Id: I9b10ff4f043949c7140852ac9ad9106ca611c98c Reviewed-on: https://gerrit.libreoffice.org/57960 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-25Resolves: tdf#118919 crash on double click ole objectCaolán McNamara
Change-Id: Id7b3df447db56f6f80d6255dabdcc7f6ab149e95 Reviewed-on: https://gerrit.libreoffice.org/57953 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-25loplugin:useuniqueptr in SwPageGridExampleNoel Grandin
Change-Id: Ie173b7ea280e922ed7aaaec6efca08ad0d95ffd0 Reviewed-on: https://gerrit.libreoffice.org/57940 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwViewNoel Grandin
Change-Id: Ifcb8320dff5e596afe1240280f64099480a6721c Reviewed-on: https://gerrit.libreoffice.org/57947 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25tdf#106174 writerfilter: bidi - prev adjust? prev bidi?Justin Luth
Four situations to handle: 1.) bidi same as previous setting: no adjust change 2.) no previous adjust: set appropriate default for this bidi 3.) previous adjust and bidi different from previous: swap adjusts 4.) previous adjust and no previous bidi: RTL swaps adjust The previous method was pretty heavy-handed, especially when clobbering the inherited ParaAdjust value. It essentially only handled situation #2. There are several commits that this one builds on or that enhance it. Look in this bug 106174 and in bug 72560. Change-Id: I07192ed93d50b07911cc8134a4ee57da87023d78 Reviewed-on: https://gerrit.libreoffice.org/57196 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-25sw: prefix members of SwGetExpField and SwGetRefFieldMiklos Vajna
Change-Id: I703357694eb2f880fa9cc5240fcc5610bd34e924 Reviewed-on: https://gerrit.libreoffice.org/57950 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-25loplugin:useuniqueptr in SwFrameSidebarWinContainerNoel Grandin
Change-Id: If802bc040f49f6a78068bbcf2b1247a98987be11 Reviewed-on: https://gerrit.libreoffice.org/57938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwXViewSettingsNoel Grandin
Change-Id: I29c70ad5b6d5e120d8dc709d279407d3100373b7 Reviewed-on: https://gerrit.libreoffice.org/57948 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwSrcViewNoel Grandin
Change-Id: I550d184ddd158e32abc353f8f1d458319bd4c2c5 Reviewed-on: https://gerrit.libreoffice.org/57946 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwView_ImplNoel Grandin
Change-Id: Id92590b00dbcd9b64ca90116fb6a275d66001519 Reviewed-on: https://gerrit.libreoffice.org/57945 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwModelessRedlineAcceptDlgNoel Grandin
Change-Id: I29dcfce3cc9977454f29cf21efb38dbe14f5c14f Reviewed-on: https://gerrit.libreoffice.org/57944 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwInputWindowNoel Grandin
Change-Id: If9ea84c6402269483d74a64b4b79a1f47f01c88d Reviewed-on: https://gerrit.libreoffice.org/57943 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwHHCWrapperNoel Grandin
Change-Id: Id651533b725c61f2fabd6ac51d640a42b06e6eea Reviewed-on: https://gerrit.libreoffice.org/57942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SdrHHCWrapperNoel Grandin
Change-Id: I1695dcf5af4f51e118b0286229e00896b09ec0bd Reviewed-on: https://gerrit.libreoffice.org/57941 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwSrcEditWindowNoel Grandin
Change-Id: I64d8a4ab60df95672363df7a4ac65cf4d2f9c8c2 Reviewed-on: https://gerrit.libreoffice.org/57939 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwEditWinNoel Grandin
Change-Id: I93dc00565c5ae99be774300bdde92e08546b3571 Reviewed-on: https://gerrit.libreoffice.org/57937 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwPostItMgrNoel Grandin
Change-Id: I63dd541ac975648083d75fe5ce1ef86e99016faa Reviewed-on: https://gerrit.libreoffice.org/57936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SidebarTextControlAccessibleContextNoel Grandin
Change-Id: Ie1506b90f541d3ccdc93c8234b393471fef0118d Reviewed-on: https://gerrit.libreoffice.org/57935 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwPageBreakWinNoel Grandin
and fix check in UpdatePosition, which would previously never have returned early Change-Id: Ie0d3feaf193dd3216f359a88c11ce6e504ac451c Reviewed-on: https://gerrit.libreoffice.org/57934 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25loplugin:useuniqueptr in SwTransferableNoel Grandin
Change-Id: I857bd0416d3c093021409af18a28815eddbdb66a Reviewed-on: https://gerrit.libreoffice.org/57933 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-25uitest for bug tdf#96698 , Validity-> CustomZdeněk Crhonek
Change-Id: Ia35d95c4ac6cddfb7db7a6e770b6c193baeab9fa Reviewed-on: https://gerrit.libreoffice.org/57896 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-07-24ofz#7621 tight OUString concat loop causes libfuzzer oomCaolán McNamara
it doesn't get a chance to release memory and falls over with an oom Change-Id: I20eb91223de3aa00f3e2f4131ad212f1cfde6ff3
2018-07-24GetCharWidths always returns trueCaolán McNamara
Change-Id: I4a58b203a7c18484c3405f918e77297ac764725d Reviewed-on: https://gerrit.libreoffice.org/57925 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24drop some more stuff for fuzzingCaolán McNamara
Change-Id: Ie9e1214eb2fd84f458eedb739248e06eef889385 Reviewed-on: https://gerrit.libreoffice.org/57929 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24split buffers to clarify what it doesCaolán McNamara
Change-Id: Id7888d2e2ef1cdf21af4247207c2b0dda0aa3823 Reviewed-on: https://gerrit.libreoffice.org/57926 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24forcepoint#53 restrict to expected index rangeCaolán McNamara
Change-Id: I22f01e5a3e3cf51b014ac841cd14071dce5baf0f Reviewed-on: https://gerrit.libreoffice.org/57920 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24icu: icu4c-icu11100.patch.1 presumed obsoleteMichael Stahl
According to http://bugs.icu-project.org/trac/ticket/11100 the bug was fixed upstream in a different way so hopefully this patch can be removed (but i don't know how to verify this). Change-Id: I815c17dae3de2d57d2e0e247cf5823dfc1cc7109 Reviewed-on: https://gerrit.libreoffice.org/57391 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Fix <otherwise> case for icon replacement Change-Id: Ia5db370d1e19aa2818fba7ad7b2427692ff1b80e Reviewed-on: https://gerrit.libreoffice.org/57927 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-07-24ofz#9431 don't check attribs of Invalid columnCaolán McNamara
Change-Id: I9c5adcadfa2a8593ff90622449d6bdfa4810f2c0 Reviewed-on: https://gerrit.libreoffice.org/57915 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24pass WrappedProperty around by std::unique_ptrNoel Grandin
Change-Id: Ifcd9606541d1157027ca49a351dbbbe0bf153b12 Reviewed-on: https://gerrit.libreoffice.org/57875 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-24tdf#86619 Reintroduce Insert Caption to the table context menuXisco Fauli
This was removed in 4d0b11411d11050b13b821e847bab86f1247bcea however, the Insert Caption entry is available for images, charts and frames, thus, reintroducing in to keep it consistent across context menus Change-Id: I7dbe15ba82b8997a53eb32f8207c7ea35246b6df Reviewed-on: https://gerrit.libreoffice.org/57861 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-07-24sw,sc: Signature Line: fix VclPtr assertionMichael Stahl
Insert a Signature Line, right click, Sign..., Cancel include/vcl/vclptr.hxx:116: VclPtr<T>::~VclPtr() [with reference_type = AbstractSignSignatureLineDialog]: Assertion `(!m_rInnerRef.get() || m_rInnerRef->isDisposed() || m_rInnerRef->getRefCount() > 1) && "someone forgot to call dispose()"' failed. Change-Id: I09a1b37b917b267a84ee95fb375658974ee1b320 Reviewed-on: https://gerrit.libreoffice.org/57913 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-24forcepoint#52 flatten deep recursive delete of SwLineLayoutCaolán McNamara
Change-Id: I36d995062f4677ae900009d1eb5d48b906a4b36f Reviewed-on: https://gerrit.libreoffice.org/57910 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>