summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-02-19loplugin:useuniqueptr in SvxClipBoardControlNoel Grandin
Change-Id: Ib9e3d20680cba684fea8b586a5ca4c5835ca6b42 Reviewed-on: https://gerrit.libreoffice.org/49932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19loplugin:useuniqueptr in AccessibleShapeNoel Grandin
Change-Id: I4c91ce6eb47f2802313fed22357e5c960cea50b2 Reviewed-on: https://gerrit.libreoffice.org/49931 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19loplugin:useuniqueptr in NavigatorTreeModelNoel Grandin
Change-Id: I53e7e4ab0a1533266ce97d5a093a1742808b6215 Reviewed-on: https://gerrit.libreoffice.org/49930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19fix windows build after 61bfc53ee710f9c79ac597888a6ee9dfee165ea4Markus Mohrhard
Change-Id: I5687d54bf2566898116c697f5a760cc0989ac0f6 Reviewed-on: https://gerrit.libreoffice.org/49955 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-19starmath: Spare unnecessary assignmentsTakeshi Abe
Change-Id: I8ddc1c04a76475d63a39dc21d36cda7a7aa26b9e Reviewed-on: https://gerrit.libreoffice.org/49921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2018-02-19fix updater on windowsMarkus Mohrhard
Change-Id: Ib6f2334a3f6f3f5c217a71e2967a69e354b0a473 Reviewed-on: https://gerrit.libreoffice.org/49956 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-19ofz#6450 use the rule name, not the rule itselfCaolán McNamara
Change-Id: I62541dc48b7e9d5a906f32791437a86a8283a7bf Reviewed-on: https://gerrit.libreoffice.org/49952 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-19ofz#6448 infinite-regressCaolán McNamara
Change-Id: Ie0c082a4b43355e935594f2dda694edfc9cdf315 Reviewed-on: https://gerrit.libreoffice.org/49950 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-19ofz#6449 Integer-overflowCaolán McNamara
Change-Id: Ia144192a1374615c50fb3574f7a229926e43d7cb Reviewed-on: https://gerrit.libreoffice.org/49951 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-18uitest: fix small race condition when launching modeless dialogsMarkus Mohrhard
Change-Id: I44f7af1b44badce6ed09eeca0bb19760b5f22aa9 Reviewed-on: https://gerrit.libreoffice.org/49942 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-18uitest: call base class Activate in modeless dialogsMarkus Mohrhard
Change-Id: I342e925a5dbc178962f720f1efc9ee001d235718 Reviewed-on: https://gerrit.libreoffice.org/49941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-18don't use the global mutex for UI stuffMarkus Mohrhard
This leads to deadlocks if one thread is using the process factory while holding the SolarMutex and another thread is calling the BackingComp::getTypes method. Change-Id: Ib4750aa1ebbfbf4f8dcd09ec2a218202450f4928 Reviewed-on: https://gerrit.libreoffice.org/49940 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-18uitest: add timeout for blocking actionsMarkus Mohrhard
Change-Id: I796d4ea0034ddae0427418f0d53a00c3dfa66871 Reviewed-on: https://gerrit.libreoffice.org/49939 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-18sw lok: assign a parent window to property dialogHenry Castro
Change-Id: Ief98b93502c3c69f84e7de47393718370a839208 Reviewed-on: https://gerrit.libreoffice.org/49926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-02-18DocumentSettingsSerializer must be SAL_DLLPUBLIC_RTTI for dynamic_castStephan Bergmann
...in SdXMLImport::SetConfigurationSettings (xmloff/source/draw/sdxmlimp.cxx) to work with instances of sd::DocumentSettings (defined in sd/source/ui/unoidl/UnoDocumentSettings.cxx, derived from DocumentSettingsSerializer), at least on platforms using the strict by-address RTTI equality check form (e.g., macOS). (Cross-casts like this are not detected by loplugin:dyncastvisibility.) Change-Id: I3f8712f9c64852cc8cb17c0c25211963360f117c Reviewed-on: https://gerrit.libreoffice.org/49884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-18Improve diagnostic outputStephan Bergmann
Change-Id: I9513f6516cd665c395f865ea204531bf8efb10b1 Reviewed-on: https://gerrit.libreoffice.org/49883 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-18tdf#113907 Remove StartModuleCommands.xcuStephan Bergmann
...now that it's empty after a1eff3100a41f592407916dd4a21d0404f1364e1 "tdf#114206 remove duplication of strings in startmodulecommands.xcu" Change-Id: I46bd0e86a274b65919a4a3f4a4036a7858520376 Reviewed-on: https://gerrit.libreoffice.org/49879 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-18Accessibility : cleanup constructors and destructors.Arnaud Versini
Change-Id: I63f94f4bb3865d0c2d211567588343e08878342c Reviewed-on: https://gerrit.libreoffice.org/49282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-18Translate German variable namesJohnny_M
m_xAktItemSet -> m_xCurrentItemSet m_bAktAND_fNumberAcross -> m_bCurrentAND_fNumberAcross in ww8par Change-Id: I1f78120008530b17d2eab508c8649798fc7bedea Note: Other occurrences of "Akt" will be done separately Reviewed-on: https://gerrit.libreoffice.org/49905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-18tdf#114817 new bitmap presets for Area Fillandreas kainz
Change-Id: Icc48efc2f6c085ccf0754620dc1cbf5132a7f824 Reviewed-on: https://gerrit.libreoffice.org/49551 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-02-18in numbering use "GraphicBitmap" property for image transportTomaž Vajngerl
Change-Id: I43abef3fe4a177f9f7867fe86e18beac812c626b Reviewed-on: https://gerrit.libreoffice.org/49923 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-18Fix typosAndrea Gelmini
Change-Id: I3225398aa3d56f76a5e8a60aecb671665d94a717 Reviewed-on: https://gerrit.libreoffice.org/49920 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-18vcl: change mbIndex from sal_uInt8 to bool in BitmapColorChris Sherlock
In 193ec57c the comment not to change this bool was kept accidentally, but memcpy was removed in that commit so this is no longer an issue. Change-Id: I772d60bb940b3327f195707524b124d034f50f64 Reviewed-on: https://gerrit.libreoffice.org/49852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-18Fix bug numbers in these commentsAdolfo Jayme Barrientos
Follow-up to 0e687595295e210e6275eda57a253ca66e8249ce. Props to Regina and Heiko. Change-Id: I4a5b71230639edf8c22d9e21c29fa31b4a561e75
2018-02-18remove use of FillBitmapURL and use FillBitmap as the alternativeTomaž Vajngerl
This is under the ongoing work to get rit of all usage of GraphicObject URLs Change-Id: I900e435ac36a4012ec36a2f0c1d909982c82660a Reviewed-on: https://gerrit.libreoffice.org/49895 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-18remove printf left in the code by accidentTomaž Vajngerl
Change-Id: Icc5742cc3b4e44ce6f7daa460af16a3c4aba82c8 Reviewed-on: https://gerrit.libreoffice.org/49894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-18GetEmbeddedXGraphicStream to read XGraphic as streamTomaž Vajngerl
This is an alternative to GetEmbeddedGraphicObjectStream which uses URL as parameter and will be removed soon. Change-Id: I3c7431bdeed0bd4ed3c7f48517a52846d0944ed2 Reviewed-on: https://gerrit.libreoffice.org/49893 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-18make WriteXGraphicBlipFill declaration same to WriteBlipFillTomaž Vajngerl
Change-Id: Ie7947abdf2e8e951c94006aae259ed1d84558b73 Reviewed-on: https://gerrit.libreoffice.org/49892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-18make it readable by adding/removing whitespace, no changeTomaž Vajngerl
Change-Id: Ice60d52c65f2e9071bb37f14a30f2eacbb9a159a Reviewed-on: https://gerrit.libreoffice.org/49891 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-18tdf#115554: Fix ownership in desktop-integration tarsMichael Weghorn
Use fakeroot to call tar when creating the tar.gz archives holding the desktop-integration parts to have root:root as owner of the files inside those. Change-Id: Idcdcb4dd398f330773671266dafb354711b0f093 Reviewed-on: https://gerrit.libreoffice.org/49827 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-18tdf#115554: Create tar archives using 'fakeroot'Michael Weghorn
'tar' must be run as root or faked to be run as root, to make sure that file ownerships and permissions inside the created tar archives are as desired (root:root). Have fakeroot take care about creating an appropriate environment rather than using the custom "libgetuid", to no longer have to care about tar internals by ourselves. This fixes the problem that file ownerships are incorrect when tar version >= 1.24 is used for * tar archives holding all the generated deb/rpm packages (created in 'download.pm') * tar archives created by using the '--with-pacakage-format=archive' autogen option (created in 'simplepackage.pm') Change-Id: Id20ccce4d002ff95c75292eda8080ca299eee3a5 Reviewed-on: https://gerrit.libreoffice.org/49682 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-18tdf#115554: Use 'fakeroot' to build Debian packagesMichael Weghorn
The command to create Debian packages must be run as root or faked to be run as root. The 'fakeroot' makes sure the command is run in an environment faking root privileges for file manipulation. This makes sure that file ownerships and permissions inside the created deb packages are correct. Using fakeroot instead of the custom "libgetuid" makes it unnecessary to care about internals of the underlying tools (like tar) and changes in those by ourselves. Change-Id: I2cbb203ab84f740377e535c1051c2b879779b164 Reviewed-on: https://gerrit.libreoffice.org/49597 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-18tdf#115602 keyboard navigation: Skip disabled toolbox itemsJim Raykowski
Change-Id: I793dd301a04435c79a97819497b9d34fa49e298b Reviewed-on: https://gerrit.libreoffice.org/49697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-18[Pardus] tdf#108446 - Shape is not changed after saveMert Tümer
This patch is sponsored by ULAKBIM/PARDUS project. Signed-off-by: Mert Tümer <merttumer7@gmail.com> Change-Id: I7ee137b2332f799e4301cc3507df4a7b86af74b9 Reviewed-on: https://gerrit.libreoffice.org/47806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-18rename non-unique id for better UI testingZdeněk Crhonek
Change-Id: Id271001411ae34269451008ca54ab5855aae7da5 Reviewed-on: https://gerrit.libreoffice.org/49305 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17Now we can remove this old checkOutput() for real.Kohei Yoshida
Change-Id: Ieff91dfd8195f1a5b8267753183e34e154a0c29a Reviewed-on: https://gerrit.libreoffice.org/49913 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-17Use the variant of checkOutput that takes nested std::vector.Kohei Yoshida
That one is *the* future. We can't remove the old one just yet... Change-Id: I3c5b1bfee3d2cb8988b68ced5a38d52d641e5881 Reviewed-on: https://gerrit.libreoffice.org/49908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-17Add a test to make sure we import docs with empty rows correctly.Kohei Yoshida
The previous XSLT-based filter failed to import this correctly. Change-Id: I6218bd2b3e5c5ac1514f84b959be27df23a0c3f8 Reviewed-on: https://gerrit.libreoffice.org/49907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-02-17tdf#114139 Don't export Plot Area shape property fot 3D chartsBartosz Kosiorek
For 2D charts Plot Area equivalent is Chart Wall. Unfortunately LibreOffice doesn't have Plot Area equivalent for 3D chart. It means that Plot Area couldn't be displayed and changed for 3D chars in LibreOffice. We cannot write Wall attributes into Plot Area for 3D charts, because Wall us used as background wall. Change-Id: I16d3b326571c1e411a094ec799e20c7aeeb2c1d4 Reviewed-on: https://gerrit.libreoffice.org/49428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17Translate German variable namesJohnny_M
m_pAktColl -> m_pCurrentColl in ww8par Change-Id: I11299bab3c294345cd32d829003b2351192f9bf9 Note: Other occurrences of "Akt" will be done separately Reviewed-on: https://gerrit.libreoffice.org/49904 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17Translate German variable namesJohnny_M
Akt -> Current in ww8par2 Change-Id: I9ef8c2def230287abe405df894f85240a338c73d Note: Other occurrences of "Akt" in the affected files will be done separately Reviewed-on: https://gerrit.libreoffice.org/49906 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17Translate German variable namesJohnny_M
Akt -> Current in svdopath Change-Id: I4482d97fcd5891c7c8137432b6defa8d52f2ca0c Reviewed-on: https://gerrit.libreoffice.org/49900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17Translate German variable namesJohnny_M
Akt -> Current in ww8 (leftovers in function names) Change-Id: I7ce1df76be01108d0e1f23522b09e20f75ae4ed3 Reviewed-on: https://gerrit.libreoffice.org/49903 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17Translate German variable namesJohnny_M
Akt -> Current in svparser Change-Id: I6c883a7690ca518ea773a08ab093d5db323122f5 Reviewed-on: https://gerrit.libreoffice.org/49901 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17Translate German variable namesJohnny_M
Akt -> Current in ascii filter Change-Id: I05637a65632b15b1ec0e0860bff15651dc25a8c4 Reviewed-on: https://gerrit.libreoffice.org/49899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17Translate German variable namesJohnny_M
Akt -> Current in txtnode Change-Id: I5f8c615c0caf96d51077aba5b27ee68bbe6f3b72 Reviewed-on: https://gerrit.libreoffice.org/49902 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17uitest for bugs #tdf114228 #tdf43078 #tdf105105Zdeněk Crhonek
Change-Id: I4fce7b1f492b6e32d48eb6f7d9c9edb6eba2c56d Reviewed-on: https://gerrit.libreoffice.org/49518 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17uitest - writer Format-Bullets and numberingZdeněk Crhonek
Change-Id: I5efeb41c13dbbaf8c5fffbb00a7503a89434c082 Reviewed-on: https://gerrit.libreoffice.org/49691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-17ofz: infinite loopCaolán McNamara
Change-Id: Ie54c22c65ccd962862cade77e3502a264164c2b2 Reviewed-on: https://gerrit.libreoffice.org/49912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-17ofz: infinite loopCaolán McNamara
Change-Id: Icbc19a6761a9972d61db45b779dab56361bf6db8 Reviewed-on: https://gerrit.libreoffice.org/49915 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>