summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-04-12remove {line,stroke}attribute.hxx from clang-format blacklistTomaž Vajngerl
Change-Id: I4826b94da3982be8807c4eba63971cb7d3df9d8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92070 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-12graphic: use UCBContentHelper to delete filesTomaž Vajngerl
Change-Id: Ibfec031daaa3b92d2286113c3ef981cfa6d09f05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92072 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-12remove unused includes in graphicfilterTomaž Vajngerl
Change-Id: I5e4ef6aadd25697beb0d3289ee22cef1e5ac433b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92071 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-12clean-up NS and pragma once for LineAttribute, StrokeAttributeTomaž Vajngerl
Change-Id: Ic914fcb9a0bf9b30feff40ec39c1002ac6eae1cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92068 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-12improve fastparser loggingNoel Grandin
so we print out the full namespace, which is quite handy when tracking down attributes that are not being parsed. Change-Id: I085d39b365d43c1a53a7c176b633ea38e6a7fb45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92064 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-11tdf#106026: Add unittestXisco Fauli
Change-Id: I9ac779a4b4a5578842a466bf5d03529ba658b6b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92066 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-11tdf#131812: fix exporting to html doesn't preserve RTL propertyJulien Nabet
Change-Id: I227e304c6868afe7a98dbd8e96487270d06ce1eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92067 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-11tdf#131931 No version history shownNoel Grandin
regression from commit 1872b44c9a2ee2bd00be54c6c310b72579d7a47f use FastParser for the XMLVersionListImport Change-Id: Ib6e9e14758c25c6ff090fe8f929984449e045c30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92063 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-11tdf#131907 Crash: reject/clear formattingNoel Grandin
regression from commit 0ef5c47547bec6319b853326603f3b807407fe78 sc: rowcol: tdf#50916 convert core/tool Change-Id: Ib8207f60d34e4257fc9a854f4e4d358951e24718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-11rename vcl::Window::Update to PaintImmediatelyNoel Grandin
To make the code easier to read. Change-Id: Iebc648150391939fba5d1cd815c72dbcf02ceec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-11Adapt loplugin:unnecessaryparen to C++20 CXXRewrittenBinaryOperatorStephan Bergmann
...as is used by GCC trunk libstdc++ std::unique_ptr since <https://gcc.gnu.org/ git/?p=gcc.git;a=commitdiff;h=5b074864f8c593fd4bccee788a023a37b446b2ed> "libstdc++: Add comparison operators to std::unique_ptr", which caused unexpected warnings like > sfx2/source/dialog/tabdlg.cxx:1057:17: error: parentheses immediately inside vardecl statement [loplugin:unnecessaryparen] > bool bSet = ( m_pSet != nullptr ); > ^~~~~~~~~~~~~~~~~~~~~ (CXXRewrittenBinaryOperator was introduced with <https://github.com/llvm/ llvm-project/commit/778dc0f1d49230f53401ae0c190fe460bda4ffd1> "[c++20] Add CXXRewrittenBinaryOperator to represent a comparison", which first appeared in LLVM 10.) Change-Id: I68024d975dc4accbfa9da855baa37bf9f990b99c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92061 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-11Sifr: Add more Korean UI icons: tdf#128689Rizal Muttaqin
Change-Id: I71a532667d4ef6b2db223fddc8afcf7384bfe7fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92057 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-04-11Resolves build error from patch I9392c0b550328fc16e1f6c30b02a6d4afbdb2ff0Tomoyuki Kubota
Change-Id: I2fa7c291c2635fb7ec15a8cc30f7a4a39a2f5b37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92054 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-11Fix typoAndrea Gelmini
Change-Id: I4ae66d3c69850fefedebcc4beeaa924de9859570 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91757 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-11Fix typoAndrea Gelmini
Change-Id: I83e3f0a75369739579b95471cfea90569bebf4ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91813 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-11Removed duplicated includeAndrea Gelmini
Change-Id: I7863aedccbf22a0958f407b8f3aefe7ed997f9b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91812 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-11Use range-based for loopMike Kaganski
Change-Id: I2ee332ffeb9004535882a7859f1821624ef5efa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92017 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-11NFC writerfilter: remove pointless assertsJustin Luth
In an age where GDB (or whatever other platform debugger you prefer) is easy to use, there is no point in asserting something that is going to crash anyway, is there? Asserting is only good in these cases if you follow it using an _if_ statement. Noel informed me that it can also be used to silence false positive coverity warnings. Change-Id: I5a5cb7a22019768ec2807f6918d4a8ebb51194de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92049 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-10tdf#55417: Add unittestXisco Fauli
Change-Id: I1cf633ea0be39c58bf38026d5ea73ad89bec72bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92052 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-10tdf#73063: Add unittestXisco Fauli
Change-Id: I69beef7f6014af1940cd89749f1712a40c74e543 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92053 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-10fix last commitLuboš Luňák
Change-Id: Ib81a7d1c3330eced1680ba0966e49dbe063fb116
2020-04-10downgrade warning to an info messageLuboš Luňák
The errors are from DirectWrite not available, but I guess may happen in some setups? But no point in spamming warnings either way. Change-Id: Ic25ddcad474ccf007925ebf7afcd784da19f4b92
2020-04-10dump info about Skia and Vulkan drivers to a log fileLuboš Luňák
Apparently it's hard for users to find out the actual Vulkan driver version (as compared to the marketing version), which is needed for blacklisting. And raster performance is noticeably better if Skia is compiled using Clang. So just dump the info to <cachedir>/skia.log (where on Windows the <cachedir> should be AppData\Roaming\LibreOffice\4\cache). Change-Id: Iafbc32637579b831275c60554f064479a326b917 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91980 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-10fix lame local variable mistakeLuboš Luňák
Change-Id: I330f8393edf61b37ae12a372e6f43ff01e204395 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92047 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-10Make BitmapPrimitive2D vcl-independentArmin Le Grand
as preparation to have drawinglayer module independent from vcl in the future Change-Id: Iaa01370f27b51cba5114a54f37d1ec73d0719918 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92048 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-04-10writerfilter: simplify ListDef::GetStyleNameJustin Luth
A simple lookup of the list's stylename has no need for a styleId. That is only used during the naming of the style, in which case both id and styletable are needed. Let's not be confusing and just create a separate function to simply return m_StyleName. Change-Id: Ib0303a45d6154988f27c37d2c1470b0529d6c762 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92035 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-04-10tdf#131948 Remove /extras/source/gallery/www-grafandreas kainz
Change-Id: I9392c0b550328fc16e1f6c30b02a6d4afbdb2ff0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91923 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-10null-deref of GetObjectShellCaolán McNamara
Change-Id: Ie0c46635d9ad01a17b5d5028ed5f983fd8c5ee74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92046 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-10Sukapura: Add DB Record icons support for RTL UIRizal Muttaqin
Change-Id: If7cc634cfc72fd61e0fb9d12d0aac682f6111ecb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92044 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-04-10Breeze,elementary,KJ,Sifr:+ DB Record support 4 RTL UIRizal Muttaqin
Change-Id: I292350c4f6cb886bb21404744a73dfd904aa9fb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92040 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-04-10Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' to 540bcbb9a74671246975ece908a8bc9c34d1da9b - 3 Basic syntax diagrams - For statement variations - On Error Change-Id: Ic4b25b9d44adeb0c80fc2e24cc60301b9325c1a3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92010 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-10Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to f4753fb3ec81fa4069a024dcd3030e740ccdfdca - Fix typo Change-Id: I0219b40a90e82c5e4cd0d0bca4e3816eb837c6cf Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92038 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-10tdf#132001 DOCX import: fix crash: redline in floating tableLászló Németh
Copying redlines to frame text was failed in tables inside frames. Skip these redlines temporarily. Regression from commit e8bae67b3dbcc90ace8264b6b1aefaf0ce459aba (tdf#125894: DOCX: import tracked changes in frames). Change-Id: I4f3ca2e95fb2e7637f8cf8dca1088a7727bcf98d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91985 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-04-10prefer DirectWrite for Skia's Windows text renderingLuboš Luňák
Change-Id: Ibfb6206751126def10905bb22effbe1a947cd6d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91968 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-10Revert "use SolarMutexReleaser in UUIInteractionHelper"Noel Grandin
This reverts commit 3705a2904d50210e3515723ad24bbbb6a72eb37f. which breaks update of extensions. SolarMutexReleaser requires that we already hold the mutex which is not always true at this spot. Thanks to Julien Nabert for debugging this. Change-Id: I6d54d4db63e8694f3dfb9d15d84f47101ded1edc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92007 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-10Resolves build error from patch I7868900d3dceb39497896bcef529fafef3bf268aHeiko Tietze
Change-Id: Idfe76b8ca6fac9d93cc16ccaec40191d96092ad1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91946 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-10fix tree view cursor leakCaolán McNamara
Change-Id: I8660db3d5eddb1596529783e13dff130bb3d0858 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91999 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-10tdf#130074 untranslated Arrow style stringsandreas kainz
Change-Id: I451082d34c236f90013749798745f01bf03d971a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91998 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-10[pt_PT] Added 11 words to autocorrectMarco A.G.Pinto
Change-Id: If3bc3ee28378c998a79155666410a6ce267685c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92006 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-04-10Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to a39ba490a12ab784a2a9d6513f8e27cbf1d9f665 - Mute l10n in bascode section Change-Id: Id510273714c15d3d5502be7550a569043a09cade Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92001 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-09Sukapura: Revert Good, Neutral and Bad Cell Styles iconsRizal Muttaqin
Change-Id: Iadcc22cacb4e188caa112fbad64a216ef220b2e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91964 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-04-09Try --disable-split-debug for distro-configs/Jenkins/linux_clang_dbgutil_64Stephan Bergmann
...in the hope that it will fix gdb backtrace generation for those Jenkins builds, as just discussed on Freenode #libreoffice-dev: > Apr 09 14:03:47 <sberg> mst___, cloph, didn't you discuss broken gdb > backtraces on some Jenkins bots the other day? > <https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/56703/console> is > another example of the bt for thread 1 missing, probably because gdb went > south or something > Apr 09 14:06:05 <llunak> sberg: that looks like gdb is too old to handle debug > info produced by that clang version > Apr 09 14:08:05 <llunak> sberg: and presumably --disable-split-debug would be > a workaround with some (not sure how big) performance cost > Apr 09 14:11:43 <mst___> yeah there were lots of complaints about > incomprehensible DWARFs in that log Change-Id: I69aa80fdd13148330d00231eefe37cbf965fe4d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91970 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-09tdf#126648 Update Arrow Style sorting after size and fill optionsandreas kainz
Change-Id: I977099f4e8cb23b5d2695ec48a5ffd43b60d260e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91966 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-09Force UITests to use internal Open/Save dialogsStephan Bergmann
At least on Windows, UITest_writer_tests UITEST_TEST_NAME=compareDocuments.compareDocuments.test_tdf130960 would otherwise open a system file-open dialog for "Compare to", which execute_dialog_through_command could apparently not handle. (The setting is changed for all tests that use qadevOOo/qa/registrymodifications.xcu, not just UITests, but that appears to have no negative consequences.) Change-Id: I004d139595c8ef04fc94fdac855a44c7c393def3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91960 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-09Error strings are not guaranteed to be ASCIIMike Kaganski
E.g., it happened to be this string with Cyrillic characters in my testing: SSL handshake failed: Удаленный хост принудительно разорвал существующее подключение. Change-Id: I4721560412ab6543206cd13c8729dc8cc851eefd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91905 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-09Resolves: tdf#131996 set_sensitive should be set_activeCaolán McNamara
search and replace went wrong in: commit b94214350e6e3d0252c09f203a3ce7807a179f90 Date: Thu Jul 25 14:09:09 2019 +0100 weld SdPublishingDlg Change-Id: I10af85633758a6e4c354f6fc957624122dd01f3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91962 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-09split out insertParent codeCaolán McNamara
Change-Id: Ideee16b57548df5f6fd1561d68729968edc42e76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91989 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-09don't animate the placeholder popoverCaolán McNamara
Change-Id: I483db377b10df0a8ced20901fde5286576ef6986 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91988 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-09tdf#104878 avoid extra deque allocations for empty Primitive2DContainerNoel Grandin
Change-Id: I9815ef38928d4c93485d69c131be6f7df32daef1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91954 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-09GetObjectShell() can return nullSamuel Mehrbrodt
Change-Id: Ie410688c124d6653fc58fa9e63bd5dd3b46bf8ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91979 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-02-22 14:57:52 +0000