summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-10-14New loplugin:getstrStephan Bergmann
...to find matches of ... << s.getStr() (for the rtl string classes) that can be written as just ... << s Some notes: * The OUStringToOString(..., RTL_TEXTENCODING_UTF8) is left explicit in desktop/source/app/crashreport.cxx (even though that would also be done internally by the "<< OUString" operator) to clarify that these values are written out as UTF-8 (and not as what that operator << happens to use, which just also happens to be UTF-8). * OUSTRING_TO_CSTR (include/oox/helper/helper.hxx) is no longer used now. * Just don't bother to use osl_getThreadTextEncoding() in the SAL_WARN in lingucomponent/source/hyphenator/hyphen/hyphenimp.cxx. * The toUtf8() in the SAL_DEBUG in pyuno/source/module/pyuno_module.cxx can just go, too. Change-Id: I4602f0379ef816bff310f1e51b57c56b7e3f0136 Reviewed-on: https://gerrit.libreoffice.org/80762 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-14assert fires after help hides find & replace dialogCaolán McNamara
Change-Id: I72db53711322de9420fdb097ac60dda35f1ec5d8 Reviewed-on: https://gerrit.libreoffice.org/80769 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-14Use default initialization instead of memset hereMike Kaganski
Change-Id: I6f4164e9c7a28e1f9d18fd6fc69dad8c48b53d9a Reviewed-on: https://gerrit.libreoffice.org/80754 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-14tdf#94117: try gswin64c if gswin32c failedMike Kaganski
Change-Id: I3c29ef72525aa25ee8606122f01b7b611ecb2091 Reviewed-on: https://gerrit.libreoffice.org/80748 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-14Resolves: tdf#128132 language page not openedCaolán McNamara
Change-Id: I1936840b89963ddc74fa8d7509855fb566e62404 Reviewed-on: https://gerrit.libreoffice.org/80761 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-14Related: tdf#124729 check for GL_EXT_texture_filter_anisotropic supportCaolán McNamara
Change-Id: I7cc7225c02e1c6688df22b237af59425fb64b79c Reviewed-on: https://gerrit.libreoffice.org/80760 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-14gtk3atk: Make sure returned values are initializedSamuel Thibault
This is the same as 8a086a97299c ("atk: Make sure returned values are initialized"), but for gtk3atk. -1 is the now-document value to be used in this case, see https://gitlab.gnome.org/GNOME/atk/merge_requests/22 Change-Id: I3cf5f78cc1db603445edfeec1bebcb2e1e48e9ed Reviewed-on: https://gerrit.libreoffice.org/80737 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-14tdf#128076: throw exception only if it's not alive and it's not a descriptionXisco Fauli
According to a comment from https://gerrit.libreoffice.org/#/c/74533/ okay... then i guess there are different kinds of callers: those who actually want to check if its a descriptor, and those who want to check that it isn't "live" so check if it's a description even if it's not alive Change-Id: I1526fdbcb006506cc67d29cbe3f65138f90843dc Reviewed-on: https://gerrit.libreoffice.org/80677 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2019-10-14fix names of enumsCaolán McNamara
as per... https://docs.microsoft.com/en-us/typography/opentype/spec/cmap encoding id 3 is PRC and 4 is Big5. We are already using RTL_TEXTENCODING_GB_2312 for 3 and RTL_TEXTENCODING_BIG5 for 4 so this just changes the names of the enum but no logic change Change-Id: Ie375cdc9c704641af21a3313128f4e97a5166ca5 Reviewed-on: https://gerrit.libreoffice.org/80755 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-14Comment out a lambda capture that isn't used, to avoid compiler warningTor Lillqvist
(The use of it is also commented out.) Change-Id: Ie015a8cbd0f7a982721a389487c2134a1aba8ed1
2019-10-14add PCHs for more external libsLuboš Luňák
I think this is all external libs where it makes sense for them to have their own PCH and be worth it. Maybe some smaller externals can also use the common system PCH, but unfortunately many externals use all kinds of defines that affect system headers, which is a problem for the common system PCH. Change-Id: I2c589ac55d93728daf3b158df110722e5f055d45 Reviewed-on: https://gerrit.libreoffice.org/80728 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-14sw: deleteFieldmarkAt() should just call getFieldmarkAt()Michael Stahl
dynamic_cast isn't a performance problem here. Change-Id: I7d90025051a428588479bb1431dd8bac292f5c49 Reviewed-on: https://gerrit.libreoffice.org/80672 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-14configure: remove sanitizer flags from default COMPILER_PLUGINS_CXXMichael Stahl
When COMPILER_PLUGINS_CXX is default initialised from $CXX, filter out sanitizer flags, because: a) linking fails with unresolved symbols currently b) typically the slowdown is unhelpful in a build c) if anybody wants a sanitized plugin they can set COMPILER_PLUGINS_CXX manually (init from CXX was added in ad5cbcf6ba0afdc1d8d7405c2641cce8de4a360b) Change-Id: I64dc48fae5f7a23f87b0eee0545add9a1ebd5672 Reviewed-on: https://gerrit.libreoffice.org/80655 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-14sw: prefix members of SwUndoInsertLabelMiklos Vajna
See tdf#94879 for motivation. Change-Id: I9d0b4ee6fc6794dc4b2e94e23c6dd83465c1191b Reviewed-on: https://gerrit.libreoffice.org/80751 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-14Related: tdf#124729 avoid GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENTCaolán McNamara
for 0 width or height Change-Id: I1452d0e6c5470d855cae96308e689e87e1d582d5 Reviewed-on: https://gerrit.libreoffice.org/80746 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-14Related: tdf#124729 check error status before continuingCaolán McNamara
Change-Id: Ic39e569121b2646995b8dec50c3941db65fdd500 Reviewed-on: https://gerrit.libreoffice.org/80745 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-14loplugin:stringadd look for unnecessary temporariesNoel Grandin
which defeat the *StringConcat optimisation. Also make StringConcat conversions treat a nullptr as an empty string, to match the O*String(char*) constructors. Change-Id: If45f5b4b6a535c97bfeeacd9ec472a7603a52e5b Reviewed-on: https://gerrit.libreoffice.org/80724 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-14Fix numbering of font tables in sft.hxx (vcl)Julien Nabet
Following kern table removal done with e3caecb5a33288dd46a80b2ffcc47a2288305052 Change-Id: Ifb42f5dc85e25faf9f1a94db7179b981abb150df Reviewed-on: https://gerrit.libreoffice.org/80742 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-14Add document-level option to lock down content extractionSamuel Mehrbrodt
Setting this option will prevent copying/dragging any content from LO to another program or even another LO window. Change-Id: Ifbc032a4fa69ac1a17d4b500f5a30f5399d84ed7 Reviewed-on: https://gerrit.libreoffice.org/80586 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-14tdf#125191: Disable Undo during pptx saveMike Kaganski
Change-Id: I07fe6895cc2ba43dfa1716e67bdbb4e697e3420c Reviewed-on: https://gerrit.libreoffice.org/80727 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-10-13Replace "static const" by "constexpr" in sft.hxx (vcl)Julien Nabet
Change-Id: I7ee86442cf822a2e866f379a98dae901f5291b8f Reviewed-on: https://gerrit.libreoffice.org/80741 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-13tdf#128096: pptx: export highlightXisco Fauli
Change-Id: If3084f7ffaceb774dba1b1f195229313a8f1d04a Reviewed-on: https://gerrit.libreoffice.org/80670 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-10-13Refactor + fix TrueTypeTableNew_post + some reading types for sft/ttcr (vcl)Julien Nabet
Move const in sft.hxx and replace define by static const Also, fix some errors with data formats + TrueTypeTableNew_post definition Following https://docs.microsoft.com/en-us/typography/opentype/spec/otff: Fixed = 32-bit signed fixed-point number (16.16) FWORD = int16 UFWORD = uint16 Change-Id: I8c460e517b9f25077f5ad81a6da656695c8e6fa1 Reviewed-on: https://gerrit.libreoffice.org/80733 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-13tdf#128111: "adsrc" doesn't exist from Postgresql 12Julien Nabet
Before Postgresql 8.0, there was only "adsrc" then it's been deprecated "The adsrc field is historical, and is best not used, because it does not track outside changes that might affect the representation of the default value. Reverse-compiling the adbin field (with pg_get_expr for example) is a better way to display the default value " and finally it's been removed with version 12 See evolution with: - https://www.postgresql.org/docs/8/catalog-pg-attrdef.html - https://www.postgresql.org/docs/11/catalog-pg-attrdef.html - https://www.postgresql.org/docs/12/catalog-pg-attrdef.html Change-Id: I57e9da423a23b5a96bbb64b0e026b160e9643ab9 Reviewed-on: https://gerrit.libreoffice.org/80722 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2019-10-13move ToolBoxButtonSize into vclenumCaolán McNamara
Change-Id: I684d192296642bc507a6f75dd52a5ce72b028157 Reviewed-on: https://gerrit.libreoffice.org/80721 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-13drop some unnecessary includesCaolán McNamara
Change-Id: I07693dd5199a1fcc08c7ba25bd986d9da76958b3 Reviewed-on: https://gerrit.libreoffice.org/80720 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-13rename FontPrevWindow back to SvxFontPrevWindowCaolán McNamara
Change-Id: Ife6f7bbc64f397e502d50c629769a8b637a591c8 Reviewed-on: https://gerrit.libreoffice.org/80718 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-13update reportdesign pchesCaolán McNamara
Change-Id: I13bf96d1c177f8f7f1141b6edcc71c2d5b3af359 Reviewed-on: https://gerrit.libreoffice.org/80717 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-13no longer need bInterimBuilderCaolán McNamara
Change-Id: Ieff1e34de9665c80ded39d605656fe7d0626aec7 Reviewed-on: https://gerrit.libreoffice.org/80716 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-13ToolBoxHelper is now unusedCaolán McNamara
Change-Id: I5e492fda0ce2b88c4e6790a6972bc36f082003a1 Reviewed-on: https://gerrit.libreoffice.org/80691 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-13SvxFontPrevWindow is now unusedCaolán McNamara
sc/uiconfig/scalc/ui/conditionalentrymobile.ui was already non-functional before this change Change-Id: I07743a8fcca4b3cf325ce3d3d0699bf68c0115f3 Reviewed-on: https://gerrit.libreoffice.org/80690 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-13weld ConditionalFormattingDialogCaolán McNamara
Change-Id: I87c03555c5555b12a1be997e368a96d9b07d2b63 Reviewed-on: https://gerrit.libreoffice.org/80689 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-13tdf#125566 Add arrangement functions to position & size sidebarTomaž Vajngerl
Adds arrangement actions to position & size sidebar so it is possible to move the object up/down in the stack. As Draw/Impress uses it's own action names for the same UNO action (Forward/Back in Draw and ObjectForwardOne and ObjectBackOne in Writer/Calc) also add the global ones to Draw/Impress and connect them to the same function as Forward/Back. This commit does not unify them however (Forward/Back are still used in menus/toolbars) but this could be done in the future. Change-Id: Ibb152f29dbe11dfb1b6a057e6ea60b21029912e2 Reviewed-on: https://gerrit.libreoffice.org/80729 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-10-13Add glyf constants + remove "offset" pattern for length var (vcl)Julien Nabet
Change-Id: I35bf0cda789cbbaa5272b78b30a58fa8c4d8c08a Reviewed-on: https://gerrit.libreoffice.org/80726 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-13Revert "tdf#127164 Don't add SdrUndoDelPage undos during pptx save"Jim Raykowski
Wont work because it will disable undo during any scripts that luck/unlock documents for their duration This reverts commit fae4f1506fc481b8dc2977d3bf9363dd8eaf4945. Change-Id: I447560c9200d381ea93e2275abd57f91c5acc819 Reviewed-on: https://gerrit.libreoffice.org/80725 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-10-13tdf#127164 Don't add SdrUndoDelPage undos during pptx saveJim Raykowski
Change-Id: I1a5e17dc056311caba3dbabfb70d21e87344eda0 Reviewed-on: https://gerrit.libreoffice.org/80429 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-10-13Put if around code for root mode multiselected outline DragFinishedJim Raykowski
Missed in commit 7ae308e5cac31c64a6bf4892aac097dac3a054b7 Change-Id: Id5001b09d36ad72841058d576ed9c976e279bb4a Reviewed-on: https://gerrit.libreoffice.org/80710 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-10-12Document and replace some magic values in sft/ttcr (vcl)Julien Nabet
Change-Id: Id9c3f96acb7b93c7ef215ae33d98ad17ef45095c Reviewed-on: https://gerrit.libreoffice.org/80719 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Jenkins
2019-10-12Get rid of 2 OUStringBuffer in comphelperJulien Nabet
Change-Id: Ib348288c729cab76ef39f6a33d173f7a20534f2f Reviewed-on: https://gerrit.libreoffice.org/80714 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-12Use size_t for string lengthsStephan Bergmann
Change-Id: I5c31197b3b61f630b41e9ee4df08aade21a71f68 Reviewed-on: https://gerrit.libreoffice.org/80708 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-12Use std::enable_ifStephan Bergmann
Change-Id: Ib9b27e2715034ef3e81d041526b705786837c491 Reviewed-on: https://gerrit.libreoffice.org/80707 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-12Remove unused ToStringHelper<char[N]>::addData sal_Unicode overloadStephan Bergmann
...that was present ever since d87f5d30879aca73fff271c254589fc41a91fdd0 "support for fast O(U)String concatenation using operator+" but was likely a typo/thinko Change-Id: I0e56166d95f447a26dba9b456255b4ed339f1e2f Reviewed-on: https://gerrit.libreoffice.org/80668 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2019-10-12rtl/stringconcat.hxx is not part of the URE interfaceStephan Bergmann
(and #include's of it in include/rtl/*.hxx are already guarded with LIBO_INTERNAL_ONLY) Change-Id: I9224f71a244a69ef69406ea3a5879b66b3cae3a3 Reviewed-on: https://gerrit.libreoffice.org/80666 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-12Missing include (for std::char_traits)Stephan Bergmann
Change-Id: I48f9e55e987b709c2cfddab87e58248b50273ee7 Reviewed-on: https://gerrit.libreoffice.org/80706 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-12Simplify some O(U)String methodsMike Kaganski
Change-Id: I020b7fef3c30cf6d5b161c33dab5bee6d2a6f91b Reviewed-on: https://gerrit.libreoffice.org/80713 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-12Adapt compilerplugins/.gitignoreStephan Bergmann
...to 0ec6797f8063a1a82dc492840351c3f0f58088a4 "generate make dependencies also for clang.pch" Change-Id: I33dcc514a7d9a80b737b56e5126dbf6a6a926ee2 Reviewed-on: https://gerrit.libreoffice.org/80709 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-12tdf#128100: add explicit service pack and build info to Windows versionMike Kaganski
Change-Id: I7cedb51f52315b006506bb37fb3562a48c7f0f3d Reviewed-on: https://gerrit.libreoffice.org/80712 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-12No need to create functions for just returning "true" or "false"Julien Nabet
Change-Id: I9c16047012675474bc2b58f33a65dd10d8aafbf6 Reviewed-on: https://gerrit.libreoffice.org/80711 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-12tdf#127129: pptx: map highlight to CharBackColorXisco Fauli
Change-Id: I033c15db6848e96ba6b6bd7a2852c9e4d1524a8e Reviewed-on: https://gerrit.libreoffice.org/80630 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-10-12fix formattingNoel Grandin
Change-Id: Iff9bf649b1abf78c7b8abfe10b4eb331714dbd6e Reviewed-on: https://gerrit.libreoffice.org/80705 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-19 10:11:58 +0000