summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-06-30Upcoming improved loplugin:staticanonymous -> redundantstatic: accessibilityStephan Bergmann
Change-Id: Ibb44e313924970319c3409323160ca7f5a6d184e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97519 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to f8d5d058a35ca8fe9b6797e45fe703a7d7486ed1 - tdf#133998 Help entries split in middle of sentence Removed <ahelp> tags from Help file, and copy contents to extended tips in dialog file as done in https://gerrit.libreoffice.org/c/core/+/97526 Change-Id: I933b1f89f8f5ea5a43dedbc25ea1de8014f3ea76 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97529 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-30check-missing-unittests: Add date to the output and...Xisco Fauli
check for writer undo and calc interpreter missing tests Change-Id: Ic891f3585eb96eda3c9c6ab4d012cd03d324df54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96436 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-30faster conversions from 1bpp mask bitmaps for Skia/GLLuboš Luňák
Tdf#134363 leads to creating a large 1bpp bitmap, and this conversion takes ages. Change-Id: If596d55829698df54f1b205a5f9a5d68cbea40fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97489 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-30tdf#134021: sw: Add unittestXisco Fauli
Change-Id: I789adaf699a857e28416132d253c04128def5984 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97481 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-30Fix typoAndrea Gelmini
Change-Id: I9562d74b5b75d6ad6f98e413410d527c7e8d502e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97510 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2020-06-30tdf#128502: Fix (haha) for a crash with multiple docs open in the iOS appTor Lillqvist
Just a band-aid to avoid a crash. The LibreOfficeKit-related code would need a thorough re-factoring to properly be prepared for multiple open documents. Change-Id: I8c31e2badd747f3086526f89638fa495f4dcf295 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97205 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97409 Tested-by: Jenkins
2020-06-30tdf#134414 Variables page doesn't need expandersCaolán McNamara
Change-Id: I5a38e1e8052c96970f9701f776f7675fda5f21c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97479 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30tdf#134404 sw: another subtlety with start/end of section (at-para flys)Michael Stahl
fix this problem by comparing the start/end of the selection instead of the anchor position, which always has an index of 0: 1. new document with image anchored to paragraph 2. insert one letter 3. press Enter 4. Backspace -> Image gone (regression from cc4b5091e739116a7ec83513fa1cd856f0130330) Change-Id: I1219a9f58ce19ea88d697c90c862fe9005318177 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97511 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-30Related: tdf#128743 fix unwanted background color of transparent wallpaperMiklos Vajna
With this, the unwanted line at the top of the background image goes away and we can consider re-adding those images again in the future. Change-Id: I36822e84ab38b0b534371f939592f6a270f2d326 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97482 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-30Related: tdf#131175 OOXML chart: import data label fill patternGülşah Köse
Change-Id: I2db64489c86e4381167eb13af4ab5118113960d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93715 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-30tdf#134243: sw: Add UItestXisco Fauli
Change-Id: I59376419048ddddff3e4fbbd6d3eb7436ee87747 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97029 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-30Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 74e0455c41e1e6b95c9e8cc34db4b4da0802f30d - Mute l10n on bookamrk hid= Change-Id: I306ece30659e9b9fe1b193f8d6fb3a5161bd8be7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97461 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-30tdf#126425 Chart: fix missing legend with exceeding textTünde Tóth
Ellipsize legend box contents, if the custom size of the chart legend is too small to contain the text. Change-Id: I91ef913f509b233912a8bfb878a1c80d577e2a88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96437 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-30tdf#134390 update spin button before processing activate signalCaolán McNamara
Change-Id: I698c789c9fe79e931547d8b230a4885393f5ff28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97476 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30Related: tdf#134390 allow entry "activate" for gen spinbuttonCaolán McNamara
Change-Id: I3c497586479a08089f167ccb890e79e7b9d1f4bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97459 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30tdf#134360 some sidebar widgets getting stuck in a disabled stateCaolán McNamara
Change-Id: I655525679dd2471e9d0c1a5af246901594b188ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97454 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30add set_alignment to EntryCaolán McNamara
Change-Id: I004fb0e19c1bb25bdb5d11ba5d5d5f39b137874c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97423 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30ofz#23783 Invalid-enum-valueCaolán McNamara
Change-Id: Ifd641a24dc8db9cb19bb41480c19ed1e3f29c43a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97455 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30tdf#134099 sw: fix textbox anchors on copy-paste and undoMiklos Vajna
Regression from commit c7307c77254557646f33017af915f6808a861e29 (fdo#82191 sw::DocumentLayoutManager: copy textbox content of draw formats, 2014-08-15), without which this problem gets hidden, as copy breaks the textbox into 2 pieces, so the textbox codepaths are no longer hit. The direct problem is that SwHistorySetFormat::SetInDoc() uses a raw node index into the nodes array, which is past the end of the nodes array. Root cause is that we have this invariant that actions and their undo has to be in sync, otherwise raw node indexes no longer work. In this case, SwUndoSaveContent::DelContentIndex() did not delete a fly frame format, because it was out of range, as it had a wrong anchor. Fix this in SwTextFlyCnt::SetAnchor(), so that whenever the anchor of a draw format is set via that function, we update its textbox as well. Also fix a related problem when fly formats were copied twice. Change-Id: I0d6c9069544c405eb20c5fed65fb40423b0adc84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97457 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-30Let's not run on hopeTor Lillqvist
Change-Id: If2fb2c55d53321ec2e5beff0ade9974c02811f7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97120 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97408 Tested-by: Jenkins
2020-06-30actually call Skia init functionLuboš Luňák
The SkGraphics::Init() docs say it's called by global variable initialization, but that doesn't seem to exist. Call it manually, as it decides e.g. which CPU features to use. Change-Id: I7e0e18290240ff2ae3298d5569c22f7dc083dde4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97415 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-30direct 8bit gray -> RGBA conversion in SkiaSalBitmapLuboš Luňák
Change-Id: Ic77f9b8f9244e7fdaca78f91686645eee421d18f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97288 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-30differentiate between 8bit and any-bit grey palette (tdf#121120)Luboš Luňák
Only the grey palette with 256 colors means that pixel values map directly to color values. Tdf#121120 has an image with 2-bit palette where color index 1 is (255,255,255), but that means the pixel value 1 cannot be just treated as color. Change-Id: Ifbd953af7f291e4fb8032ea0f4c33c0514770856 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97283 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-30tdf#130151 Fix toc pointing to wrong pageSamuel Mehrbrodt
Change-Id: I26c1027722613f751bd39fde97f1e14d3238eefa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97413 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Jenkins
2020-06-30notebookbar: don't overwrite popup heightSzymon Kłos
Change-Id: I41e0bab8f44b1d7be627e3a7e0f3293179f3977c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97215 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97418 Tested-by: Jenkins
2020-06-30Reduce code duplicationMike Kaganski
Change-Id: Ia5526e61c8dd632fbc5eae2d5c02b46b928f4fa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97430 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-06-29Avoid crash with multiple documents open in the iOS appTor Lillqvist
Also add a FIXME. Just 'hoping' is not good enough. But yeah, much of this code indeeed works mostly by accident. Change-Id: Ic6bcbc10229a0b7cdd8d696794efe152fca4faea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97117 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97407 Tested-by: Jenkins
2020-06-29Small refactorMike Kaganski
Change-Id: I14021d3e0b83dcd4fb5544239e982c8ada32d029 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97429 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-06-29Fix check whether "msi" is among --with-package-format=... tokensStephan Bergmann
Change-Id: I8979a88743926141af3b3c6f9b579b4ee34f494b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97426 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-29tdf#74424 vcl: Flush() is implemented in OutputDevice so no need for type checkChris Sherlock
Change-Id: I12f177dadf9a637ab3ef2fa7d85fe96d1d141808 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96811 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 971425d46a52037cc1bead7c0a1054d84c10e56b - refactor some database Help files Change-Id: Ia3ad2896015c335450d0970d8cf51044473e249e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97456 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-29sd: support changing position with .uno:EditAnnotationTomaž Vajngerl
Change-Id: Ie5c683c06079e4d77d42b242c60cf67257db5c16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97421 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29cui: fix context of aboutdialog's btnReleaseNotesMiklos Vajna
Change-Id: Ifab5c7b0dd007e8a318c8d89b9501f9e30cf60f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97422 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-29OOXML/ODF Support for Shadow blur radiusA_GAN
Adding export support for OOXML. Adding import/export support for ODF Changing some values in test cases as convertEMUtoHmm round the fraction. Add two test functions for OOXML and ODF export. Change-Id: Ie5d862b46b5264ead4954f407fee2837b5151cd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96907 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29curl: upgrade to release 7.71.0Michael Stahl
Fixes CVE-2020-8169, and about 3 other ones that don't affect LO/libcmis. Disable new optional dependencies "ngtcp2" and "quiche". Change-Id: I595ed909c4e792ac3244643511a338b117e7f102 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97406 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-29Call framework::Desktop::shutdown directlyStephan Bergmann
...instead of via the XJob hack introduced in a6862a26d6cd17f6b4e4f6577bcd778bf952e65b "tdf#134106: Get rid of XDesktopInternal again" Change-Id: Ic533e8faba1a3da65ead74d78f0ab9c4aab1ca6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97397 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-29tdf#134386 set m_pTemplateProvider before creating any other pagesCaolán McNamara
Change-Id: Icc501b127f92cdbfbf0987af9b0b560f1efbc056 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97404 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-29make browser rows slightly tallerCaolán McNamara
Change-Id: I6a466bfd43bb38cafa4cea0c1e68ed788922b53f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97405 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-29tdf#39593 reduce copy/paste in BitmapScaleSuperFilterMesut Çifci
Change-Id: I1f6387d3ff931b0c885e0cb8ee5b99c880a1484e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94137 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29tdf#134054 toolbox: respect drop-down arrow rectJan-Marek Glogowski
When centering the text and icon on the button, the code didn't take the drop-down arrow rect width into account, resulting in an overlapped arrow. This is especially visible, if the drop-down is shown and the button is wrongly highlighted. There is supposed to be some vertical mode, which I couldn't find in the GUI, so this just adapts the width in horizontal mode. Change-Id: I194780dc32db610041ad0ee45a425e1026c7c4e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97358 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-06-29Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to a03c8e79a278e9e17967b4978ac6667abc6d6dbc - Fix Help on borders after translator review Many thanks to Mihkel Tonnov Change-Id: Id2c97cabe779f87b6ab8ddded32e20ef276537d6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97412 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-29Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 59200481f126b3cd56ccd1eb231b8c1ee3a61a61 - Add empty colspan/rowspan cleaning Change-Id: Ibb73313768ad2252e27d6b85757338fabf0ea1d7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97414 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-29jsdialog: weld drawing areaSzymon Kłos
Change-Id: I7bc75e3de99de84c59b798e4c4dad18550157e43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96851 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97396 Tested-by: Jenkins
2020-06-29jsdialog: click action for drawing areaSzymon Kłos
Change-Id: I2434bec675559a97e5d251c6d6a958464b6db034 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96853 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97395 Tested-by: Jenkins
2020-06-29pdf: add text page object attribs, refactor ImpSdrPdfImport, testsTomaž Vajngerl
This refactors ImpSdrPdfImport to push more functions into the PDFium wrapper. The focus is on text page object attributes. Change-Id: Ie1faf5e3743eec7c77050835651533f9e227c2a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97366 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29pdf: support PDF Form object and getMatrixTomaž Vajngerl
Change-Id: I61f2004df7f9c9ac37959e0b50ea1ff83387c77a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97365 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29pdf: add PDFiumTextPage and PDFiumPageObject + testTomaž Vajngerl
Also use it in ImpSdrPdfImport. Change-Id: I6d353ef60d036c3516448e64a50b25a9befd5db8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97364 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29use PDFium wrapper in ImpSdrPdfImport (partially)Tomaž Vajngerl
Change-Id: If13bcaa6a256354aceb2e1998521644041c03b7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97363 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29We don't need merge modules if we aren't building an MSITor Lillqvist
Change-Id: Ifc14280049bdf850f43fc20554bc703961d50f86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97392 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>