summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-01-10only delete cell content for CELLTYPE_NONE, fdo#88200Markus Mohrhard
Change-Id: I43463b56cabfea4c9ee2b98445f7fb522221197d
2015-01-10fdo#87845: sw: fix crash in navigator dialog when view is closedMichael Stahl
Since we have a SwContentTree::Notify() now, might as well clear our pointers to recently deceased SwWrtShells when the obituary arrives. (regression from b5c1f352522c34a744ad0226e73904ce5af81b11) Change-Id: I44282658468f1b758038fbf1c7fc13dfe1b4b8ed
2015-01-10sc: fix use-after-free race in ScCellRangesBaseMichael Stahl
Probably 03cca068ed901d1862c440a6f414d17609785974 was not sufficient, because the ~ScCellRangesBase may access a deleted ScDocument after the early return. READ of size 8 at 0x61b000191cb0 thread T7 (cppu_threadpool) #0 0x2b3c8fd7c8b3 in ScDocument::RemoveUnoObject(SfxListener&) sc/source/core/data/documen3.cxx:863:9 #1 0x2b3c94517824 in ScCellRangesBase::~ScCellRangesBase() sc/source/ui/unoobj/cellsuno.cxx:1467:9 #2 0x2b3c9459cf98 in ScCellRangeObj::~ScCellRangeObj() sc/source/ui/unoobj/cellsuno.cxx:4786:1 #3 0x2b3c945eca28 in ScCellObj::~ScCellObj() sc/source/ui/unoobj/cellsuno.cxx:6088:1 #4 0x2b3c945ecef1 in ScCellObj::~ScCellObj() sc/source/ui/unoobj/cellsuno.cxx:6087:1 #5 0x2b3c945ed093 in non-virtual thunk to ScCellObj::~ScCellObj() sc/source/ui/unoobj/cellsuno.cxx:6088:1 #6 0x2b3c56cb35ec in cppu::OWeakObject::release() cppuhelper/source/weak.cxx:205:9 #7 0x2b3c94523d63 in ScCellRangesBase::release() sc/source/ui/unoobj/cellsuno.cxx:1772:5 #8 0x2b3c945a77ec in ScCellRangeObj::release() sc/source/ui/unoobj/cellsuno.cxx:4835:5 #9 0x2b3c945f842c in ScCellObj::release() sc/source/ui/unoobj/cellsuno.cxx:6128:5 #10 0x2b3c945fb953 in non-virtual thunk to ScCellObj::release() sc/source/ui/unoobj/cellsuno.cxx:6129:1 #11 0x2b3c7f305faa in bridges::cpp_uno::shared::freeUnoInterfaceProxy(_uno_ExtEnvironment*, void*) bridges/source/cpp_uno/shared/unointerfaceproxy.cxx:42:5 freed by thread T14 (cppu_threadpool) here: #0 0x43436b in operator delete(void*) (/data/lo/build_clang/instdir/program/soffice.bin+0x43436b) #1 0x2b3c9382462e in ScDocShell::~ScDocShell() sc/source/ui/docshell/docsh.cxx:2722:1 #2 0x2b3c93824d46 in virtual thunk to ScDocShell::~ScDocShell() sc/source/ui/docshell/docsh.cxx:2755:1 #3 0x2b3c58e2058a in SvRefBase::ReleaseRef() include/tools/ref.hxx:194:29 #4 0x2b3c58e12726 in tools::SvRef<SfxObjectShell>::~SvRef() include/tools/ref.hxx:52:24 #5 0x2b3c5a8a8f99 in IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer() sfx2/source/doc/sfxbasemodel.cxx:247:5 #6 0x2b3c5a8a9141 in IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer() sfx2/source/doc/sfxbasemodel.cxx:246:5 #7 0x2b3c5a7b1905 in SfxBaseModel::dispose() sfx2/source/doc/sfxbasemodel.cxx:795:5 #8 0x2b3c5a7c8146 in SfxBaseModel::close(unsigned char) sfx2/source/doc/sfxbasemodel.cxx:1418:5 Change-Id: Ia041dc6596d1b0b6b979a20fa93e1490c657e15b
2015-01-10vcl: CairoTextRender::nTextColor_ to mnTextColorChris Sherlock
Change-Id: Ia53dc393e4284989f6e967c4fa42e7ba6fc58183
2015-01-10vcl: cleanup cairotextrender.hxxChris Sherlock
Change-Id: Ia8471c9745b86c4137297fd9cd0a3fea712a14fa
2015-01-10vcl: cleanup textrender.hxxChris Sherlock
Change-Id: Id8524328f1bdacbc37dd6846f053e5bcfbcd782c
2015-01-09xmloff_uxmloff fails on Linux too, now -> disable it (mergelibs)Matúš Kukan
Would be nicer to fix it though. Change-Id: Ia5f49a69374e9e79a9a16542bc44f279b9e5a6f7
2015-01-09Remove extra new-line characters before regex matching in gbuild-to-ide.Ashod Nakashian
At least on some 64-bit Cygwin installations, the input gbuild-to-ide gets include \r\n EOL. Python3 regex excludes \n from .* but leaves \r in the matching group. This training cr ends up in the file paths in VS project files, breaking it as they are invalid characters. Change-Id: I481c1adbf6f6db7ab0ee0d3a768b7a397dc78ee5 Reviewed-on: https://gerrit.libreoffice.org/13803 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-01-09asan: heap-buffer-overflow on ooo8726-1.docCaolán McNamara
Change-Id: I9fd7b873b6e64a6450c1bd946cd9bb08c293290a
2015-01-09boost::scoped_ptr->std::unique_ptrCaolán McNamara
Change-Id: I844532d08123ed0c91ccec73cc806277fd821089
2015-01-09loplugin:cstylecast: warn about certain redundant reinterpret_castsStephan Bergmann
Change-Id: Iaa46849742c215798722d03d9ee59bb39d8033f7
2015-01-09Resolves: fdo#85617 always store fully encoded external document nameEike Rathke
Also OOXML calls these API functions, this is the central place to handle it.
2015-01-09do not drop entire external reference, fdo#85617 relatedEike Rathke
If there are no matching tab names for a FileId, preserve at least the known reference parts. In case of 2D references the sheet name is in the token if for example read from .xlsx, only for 3D references the second sheet name would be needed. The underlying makeExternalRefStr() and its subroutines handle the missing tabname elements gracefully. Still this situation is worth an assertion.
2015-01-09write externalLink Relationship Target IURI encoded, fdo#85617 relatedEike Rathke
Change-Id: I3df065af8e4ef44734f468fd455c3b7c93d7fbc6
2015-01-09Revert "NO_DECODE breaks non-ascii urls, fdo#85617"Eike Rathke
This reverts commit 808b0bf831d4a4fdb60c01865d0a7dd36cf9d521. This is not the right fix, it cures a symptom but probably will break other cases. See also my comment on https://gerrit.libreoffice.org/13670 Change-Id: I5bb661ba2bcbd387a69aacf08cb13b503315c5b1
2015-01-09asan: stack-buffer-overflow with fdo76216-1.docCaolán McNamara
Change-Id: Ica5ebb04ec50c6579f71d1152ae7619dd37b879e
2015-01-09include is unused againStephan Bergmann
Change-Id: I921c631545be6da66639709642e423c44e82c5af
2015-01-09One more place to work around missing std::underlying_type for GCC 4.6Stephan Bergmann
Change-Id: I46225e30f6326e0af5a8ac3bebe9847f4dbe50d0
2015-01-09Work around -fsanitize=nullStephan Bergmann
...at least in CppunitTest_sd_export_tests, the dynamic_cast in PPTWriterBase::GetStyleSheets (sd/source/filter/eppt/pptx-epptbase.cxx) can fail, but the resulting reference appears to not be accessed then. So change from reference to (potentially null) pointer. Change-Id: Ide49be7bffefa7906e84349642f7c3d0666d414e
2015-01-09type_traits for std::underlying_typeCaolán McNamara
Change-Id: Iad41da9294c9a38e501e5bcd1b3185f2e3b26ff2
2015-01-09gbuild: try to fix windows non-debug buildsMichael Stahl
The ENABLE_CRASHREP is no longer AC_SUBSTed by configure, so it is always non-empty in config_host.mk, resulting in -Zi without -FS, which breaks MSVC 2013 builds. Leave a placeholder in configure for the new crash reporter vaporware, and force the CFLAGS to be the same as in the --eanble-symbols case. (regression from 8ab4d2f29fdd2c058db23f6ee7b2200655d4c6f6) Change-Id: I476fb2e4f50de5304632628b25e3997ea6c31c27
2015-01-09java: simplify array creationNoel Grandin
and remove the need to worry about keeping indexes correct Change-Id: I9a5fc00f7e28f305279b41099274c96daebebb95
2015-01-09Apparently wants to use pData, not &pData, as sourceStephan Bergmann
Change-Id: I22a3aba3266ae8209242cf6e02ca8c66b1be863b
2015-01-09fdo#85818: rename KumZinsZ to CumIpmtLaurent Charrière
Rename OcKumZinsZ to ocCumIpmt, SC_OPCODE_KUM_ZINS_Z to SC_OPCODE_IPMT, ScInterpreter::ScKumZinsZ() to ScInterpreter::ScCumIpmt(). Change-Id: I7a062374fa0dad375c9277ca7e1c23f6d6855013 Reviewed-on: https://gerrit.libreoffice.org/13816 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-09fdo#85818: rename Kapz to PpmtLaurent Charrière
Rename OcKapz to OcPpmt, SC_OPCODE_KAPZ to SC_OPCODE_PPMT ScInterpreter::ScKapz() to ScInterpreter::ScPpmt(). Change-Id: I5bc556e086970ea487e14b4663a9b3d2aaf9bb66 Reviewed-on: https://gerrit.libreoffice.org/13815 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-09fdo#85818: rename Kombin, Kombin2, Variationen, Variationen2Laurent Charrière
Rename OcKombin to OcCombin, SC_OPCODE_KOMBIN to SC_OPCODE_COMBIN, ScInterpreter::ScKombin() to ScInterpreter::ScCombin(), OpKombin to OpCombin. Rename OcKombin2 to OcCombinA, SC_OPCODE_KOMBIN_2 to SC_OPCODE_COMBIN_A, ScInterpreter::ScKombin2() to ScInterpreter::ScCombinA(), OpKombin2 to OpCombinA. Rename OcVariationen to OcPermut, SC_OPCODE_VARIATIONEN to SC_OPCODE_PERMUT, ScInterpreter::ScVariationen() to ScInterpreter::ScPermut(), OpVariationen to OpPermut. Rename OcVariationen2 to OcPermutationA, SC_OPCODE_VARIATIONEN_2 to SC_OPCODE_PERMUTATION_A, ScInterpreter::ScVariationen2() to ScInterpreter::ScPermutationA(), OpVariationen2 to OpPermutationA. Change-Id: I2efa01e9b160e98058879d08e2e2313284a5ec91 Reviewed-on: https://gerrit.libreoffice.org/13814 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-09fdo#85818: rename ZinsZ enum name, constant, function to IpmtLaurent Charrière
Rename OcZinsZ to OcIpmt, SC_OPCODE_ZINS_Z to SC_OPCODE_IPMT, ScInterpreter::ScZinsZ() to ScInterpreter::ScIpmt() Change-Id: I6ed671aff85b7d2ec06dd66cd7ec9390776008b1 Reviewed-on: https://gerrit.libreoffice.org/13813 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-09asan: global-buffer-overflow on ooo12093-1.docCaolán McNamara
Change-Id: I5e29626fe2803d2751bdec9c6919662ea37cf64c
2015-01-09fix indexesCaolán McNamara
Change-Id: I99d3a715cce203eb2303c76da3b20e6d853a9d23
2015-01-09Resolves: #i94895# fix illegal result of Replace runtime function"Caolán McNamara
and adjust the basic test-case, which is surely wrong The syntax for REPLACE is: // Replace(expression, find, replace[, start[, count[, compare]]]) surely in the case of a start of 3 the preceeding chars should be returned unchanged in the result, not stripped off as before this change. This reverts commit 869402a58720b45e7227438b2e56e5a9532c0000. Change-Id: Ie710e4de9e7e35c84abe2770142a963532820af4
2015-01-09Work around -fsanitize=nullStephan Bergmann
(mpLayoutCache may be null, but that was harmless as Write was effectively static) Change-Id: I41b10593c5ae98de92e7b305d9db75d0c4c7b334
2015-01-09external/redland: Work around -fsanitize=nonnull-attributeStephan Bergmann
Change-Id: Ibffc44da6e9d6fb02d43d8a2b7e143ff994d76a8
2015-01-09SolarMutexClearableGuard and SolarMutexResettableGuard are never overridenNoel Grandin
so make them final and make their destructors non-virtual Change-Id: I94453786d2befb885996996040a766bc4ccbb4e3
2015-01-09Android: add share feature in the context menuJacobo Aragunde Pérez
Known issues: the mimetype returned for .odp files is null and share does not work on these files. Change-Id: I61e752763a6934657c30fff3cefc57ac0144ec71
2015-01-09Android: add context menu in document browserJacobo Aragunde Pérez
Change-Id: I234f7ddb99570498f86449cf61ceb72696995b0d
2015-01-09loplugin:cstylecastStephan Bergmann
Change-Id: I86aaad9f38ad63121805fa3dc05b3a8a33428ef7
2015-01-09Resolves: #i63614# fix strange type mismatch when Iif function is usedTsutomu Uchino
Second or later compilation uses value type returned by previous execution of code. Use the defined type as return value of the runtime function of Basic always. (cherry picked from commit 7470c682e136a4a89c1e9474bbc79b2d61f31048) Conflicts: basic/inc/basic/sbxmeth.hxx basic/inc/basic/sbxobj.hxx basic/source/runtime/stdobj.cxx basic/source/sbx/sbxobj.cxx Change-Id: I3064e8403286a9c1401ef658bf139bedeae11f17
2015-01-09external/icu: Work around -fsanitize=shiftStephan Bergmann
Change-Id: I17936ae2e37520abaa7dd31a5bb9aec6300ea021
2015-01-09Factor out XFillBmpTileItem::dumpAsXml() from swMiklos Vajna
Change-Id: I01816988eb3c47e60826ff01c1b8402f9f5130e4
2015-01-09fdo#84938: convert FRMTYPE_ #defines to 'enum class'Noel Grandin
and consequently fix bug in SwPageFrm::PreparePage where it was comparing against the wrong #define's Change-Id: I681f7e9f3f9bbe1ddf2613814ed36cfe0955825f
2015-01-09fdo#84938: replace SYSTEMWINDOW_MODE constants with 'enum class'Noel Grandin
Change-Id: I1c761482cb78efc26d3beda75381557268e1bc0d
2015-01-09enum Service is unusedNoel Grandin
Change-Id: I7aaeda37ceea080251f9d6381a78d13b8fb055d0
2015-01-09fdo#84938: convert POLY_OPTIMIZE_ #defines to 'enum class'Noel Grandin
Change-Id: I163bd3f521473c5357c23c3ce4978f984be7b6fe
2015-01-09Revert "Use SVLIBRARY instead of gb_Library_get_runtime_filename"Matúš Kukan
$(call gb_Library__get_name,foo) returns "libmerged" if library foo is merged. This reverts commit ee567a63fad9e755b11ca28696da35f00ed3b0fc. Change-Id: I6ab9b7f0b01262a6f9d5a6834a6cffdd6ffc6f8a
2015-01-09cui: SvxLinguTabPage::GetRanges() is dead, remove itMichael Stahl
That's what the comment on it said before it was translated. Change-Id: I8812f99253bd4a14cb1109abf72b11d650f56003
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-09translate all remaining abuses of "ueberladen"Michael Stahl
It is scary how many barely educated C++ programmers can't tell their inclusion polymorphism from their ad-hoc polymorphism. Change-Id: Id4df7d168ba5257eff522a7f131c841c1ddcbccd
2015-01-08asan: global-buffer-overflow on fdo55736-1.docxCaolán McNamara
Change-Id: If69a57aa9ff011cc670f868cb87b3a1c4d904435
2015-01-08Revert "Resolves: #i94895# fix illegal result of Replace runtime function"Caolán McNamara
This reverts commit 340ca294d43f2c5b9fda1afbf178609a015f71e3 as CppunitTest_basic_vba breaks, so needs revisiting to see which is right Change-Id: I10168d454a8c67d91eee5bb8939aff74bba42954
2015-01-08An odd way to say "nullptr"Stephan Bergmann
Change-Id: I6d83714b78c4d149dff5ea56483d7afa6d0eb677
generated by cgit (git 2.34.1) at 2025-03-06 16:54:33 +0000